WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#20573 closed theme (closed-newer-version-uploaded)

THEME: Storefront - 1.0.2

Reported by: woothemes Owned by: gpriday
Priority: new theme Keywords: theme-storefront
Cc: admin@…

Description

Storefront - 1.0.0

Storefront is the perfect theme for your next eCommerce project. Designed and developed by WooThemes, it features a deep integration with their market leading WooCommerce plugin, several layout & color options to personalise your shop, multiple widget regions, a responsive design and much more. Developers will love it's lean and extensible codebase making it a joy to customise and extend.

Theme URL - http://woothemes.com/storefront
Author URL - http://woothemes.com

SVN - https://themes.svn.wordpress.org/storefront/1.0.0
ZIP - https://wordpress.org/themes/download/storefront.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#10266 THEME: Storefront Paper - 1.0 closed not-approved chipbennett
#10515 THEME: Storefront Paper - 1.0.1 closed not-approved nishasingh
#15298 THEME: Storefront Paper - 1.0.5 closed live alex27
#15410 THEME: Storefront Paper - 1.0.6 closed live alex27
#17608 THEME: Storefront Paper - 1.1 closed not-approved Frank Klein
#17758 THEME: Storefront Paper - 1.1.1 closed live Frank Klein
#20573 THEME: Storefront - 1.0.2 closed closed-newer-version-uploaded gpriday

(this ticket)

#21263 THEME: Storefront - 1.0.3 closed live gpriday
#21758 THEME: Storefront - 1.1.0 closed live emiluzelac
#21788 THEME: Storefront - 1.1.1 closed live karmatosed
#21928 THEME: Storefront - 1.2.0 closed live karmatosed
#22042 THEME: Storefront - 1.2.1 closed live karmatosed
#22476 THEME: Storefront - 1.2.2 closed live karmatosed
#22533 THEME: Storefront - 1.2.3 closed live karmatosed
#22681 THEME: Storefront - 1.2.4 closed live sakinshrestha
#22810 THEME: Storefront - 1.2.5 closed live jcastaneda
#23163 THEME: Storefront - 1.3.0 closed live emiluzelac
#23347 THEME: Storefront - 1.3.1 closed live emiluzelac
#23646 THEME: Storefront – 1.4.2 closed live jcastaneda
#24170 THEME: Storefront – 1.4.3 closed live jcastaneda
#24484 THEME: Storefront – 1.4.4 closed live greenshady
#24888 THEME: Storefront – 1.4.5 closed live poena
#25322 THEME: Storefront – 1.4.6 closed live downstairsdev
#26413 THEME: Storefront – 1.5.0 closed live jcastaneda
#27103 THEME: Storefront – 1.5.1 closed live jcastaneda
#28155 THEME: Storefront – 1.5.2 closed live karmatosed
#28257 THEME: Storefront – 1.5.3 closed live jcastaneda
#29628 THEME: Storefront – 1.6.0 closed live greenshady
#29911 THEME: Storefront – 1.6.1 closed live Otto42
#32888 THEME: Storefront – 2.0.0 closed live themetracbot
#33053 THEME: Storefront – 2.0.1 closed live themetracbot
#33543 THEME: Storefront – 2.0.2 closed live themetracbot
#33580 THEME: Storefront – 2.0.3 closed live themetracbot
#33873 THEME: Storefront – 2.0.4 closed live themetracbot
#34387 THEME: Storefront – 2.0.5 closed live themetracbot
#34930 THEME: Storefront – 2.0.6 closed live themetracbot
#35093 THEME: Storefront – 2.0.7 closed live themetracbot
#35837 THEME: Storefront – 2.1.0 closed live themetracbot
#36084 THEME: Storefront – 2.1.1 closed live themetracbot
#36245 THEME: Storefront – 2.1.2 closed live themetracbot
#36641 THEME: Storefront – 2.1.3 closed live themetracbot
#37036 THEME: Storefront – 2.1.4 closed live themetracbot
#37329 THEME: Storefront – 2.1.5 closed live themetracbot
#37354 THEME: Storefront Child Theme – 1.0.0 closed not-approved poena
#37836 THEME: Storefront – 2.1.6 closed live themetracbot
#38474 THEME: Storefront Travel – 1.0 closed not-approved acosmin
#39515 THEME: Storefront – 2.1.7 closed live themetracbot
#40380 THEME: Storefront – 2.1.8 closed live themetracbot
#43062 THEME: Storefront – 2.2.0 closed live themetracbot
#43072 THEME: Storefront – 2.2.1 closed live themetracbot
#43079 THEME: Storefront – 2.2.2 closed live themetracbot
#43133 THEME: Storefront – 2.2.3 closed live themetracbot
#44245 THEME: Storefront – 2.2.4 closed live themetracbot
#45839 THEME: Storefront – 2.2.5 closed live themetracbot


https://themes.svn.wordpress.org/storefront/1.0.0/screenshot.png


Attachments (1)

storefront.zip (1.0 MB) - added by jameskoster 3 years ago.
1.0.1

Download all attachments as: .zip

Change History (17)

#1 @jameskoster
3 years ago

FYI There are a couple of links in the welcome screen that we will update before going live.

Not sure if this is possible, but once the theme has passed review, would it be possible to set a launch date to coincide with any potential marketing we might want to do?

#2 follow-up: @emiluzelac
3 years ago

You can update any time you like, newer version will just add in.

Once your theme is approved it will go for a final audit by admin where time and date is not specified sorry.

We are short people and about 6 weeks behind.


Also make sure that ticket was submitted with http://codex.wordpress.org/Theme_Review in mind, I've noticed broken link http://woothemes.com/storefront

#3 in reply to: ↑ 2 @jameskoster
3 years ago

Hey, does that mean 6 weeks until initial review? We're planning a few promotional items for when the theme does go live so it would be cool to have even a rough timescale.

I've noticed broken link http://woothemes.com/storefront

Like I mentioned in the comment previous, a couple of the links on the welcome screen will be fixed and the one you highlight in particular will go live after the theme is approved.

Cheers

#4 @emiluzelac
3 years ago

Correct, about 6 weeks +/- till reviewer assigns the ticket. We are volunteers :)

@jameskoster
3 years ago

1.0.1

#5 @themetracbot
3 years ago

  • Summary changed from THEME: Storefront - 1.0.0 to THEME: Storefront - 1.0.1

Storefront - 1.0.1

Storefront is the perfect theme for your next eCommerce project. Designed and developed by WooThemes, it features a deep integration with their market leading WooCommerce plugin, several layout & color options to personalise your shop, multiple widget regions, a responsive design and much more. Developers will love it's lean and extensible codebase making it a joy to customise and extend.

Theme URL - http://woothemes.com/storefront
Author URL - http://woothemes.com

SVN - https://themes.svn.wordpress.org/storefront/1.0.1
ZIP - https://wordpress.org/themes/download/storefront.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/storefront/1.0.0&new_path=/storefront/1.0.1

History:

Ticket Summary Status Resolution Owner
#10266 THEME: Storefront Paper - 1.0 closed not-approved chipbennett
#10515 THEME: Storefront Paper - 1.0.1 closed not-approved nishasingh
#15298 THEME: Storefront Paper - 1.0.5 closed live alex27
#15410 THEME: Storefront Paper - 1.0.6 closed live alex27
#17608 THEME: Storefront Paper - 1.1 closed not-approved Frank Klein
#17758 THEME: Storefront Paper - 1.1.1 closed live Frank Klein
#20573 THEME: Storefront - 1.0.2 closed closed-newer-version-uploaded gpriday

(this ticket)

#21263 THEME: Storefront - 1.0.3 closed live gpriday
#21758 THEME: Storefront - 1.1.0 closed live emiluzelac
#21788 THEME: Storefront - 1.1.1 closed live karmatosed
#21928 THEME: Storefront - 1.2.0 closed live karmatosed
#22042 THEME: Storefront - 1.2.1 closed live karmatosed
#22476 THEME: Storefront - 1.2.2 closed live karmatosed
#22533 THEME: Storefront - 1.2.3 closed live karmatosed
#22681 THEME: Storefront - 1.2.4 closed live sakinshrestha
#22810 THEME: Storefront - 1.2.5 closed live jcastaneda
#23163 THEME: Storefront - 1.3.0 closed live emiluzelac
#23347 THEME: Storefront - 1.3.1 closed live emiluzelac
#23646 THEME: Storefront – 1.4.2 closed live jcastaneda
#24170 THEME: Storefront – 1.4.3 closed live jcastaneda
#24484 THEME: Storefront – 1.4.4 closed live greenshady
#24888 THEME: Storefront – 1.4.5 closed live poena
#25322 THEME: Storefront – 1.4.6 closed live downstairsdev
#26413 THEME: Storefront – 1.5.0 closed live jcastaneda
#27103 THEME: Storefront – 1.5.1 closed live jcastaneda
#28155 THEME: Storefront – 1.5.2 closed live karmatosed
#28257 THEME: Storefront – 1.5.3 closed live jcastaneda
#29628 THEME: Storefront – 1.6.0 closed live greenshady
#29911 THEME: Storefront – 1.6.1 closed live Otto42
#32888 THEME: Storefront – 2.0.0 closed live themetracbot
#33053 THEME: Storefront – 2.0.1 closed live themetracbot
#33543 THEME: Storefront – 2.0.2 closed live themetracbot
#33580 THEME: Storefront – 2.0.3 closed live themetracbot
#33873 THEME: Storefront – 2.0.4 closed live themetracbot
#34387 THEME: Storefront – 2.0.5 closed live themetracbot
#34930 THEME: Storefront – 2.0.6 closed live themetracbot
#35093 THEME: Storefront – 2.0.7 closed live themetracbot
#35837 THEME: Storefront – 2.1.0 closed live themetracbot
#36084 THEME: Storefront – 2.1.1 closed live themetracbot
#36245 THEME: Storefront – 2.1.2 closed live themetracbot
#36641 THEME: Storefront – 2.1.3 closed live themetracbot
#37036 THEME: Storefront – 2.1.4 closed live themetracbot
#37329 THEME: Storefront – 2.1.5 closed live themetracbot
#37354 THEME: Storefront Child Theme – 1.0.0 closed not-approved poena
#37836 THEME: Storefront – 2.1.6 closed live themetracbot
#38474 THEME: Storefront Travel – 1.0 closed not-approved acosmin
#39515 THEME: Storefront – 2.1.7 closed live themetracbot
#40380 THEME: Storefront – 2.1.8 closed live themetracbot
#43062 THEME: Storefront – 2.2.0 closed live themetracbot
#43072 THEME: Storefront – 2.2.1 closed live themetracbot
#43079 THEME: Storefront – 2.2.2 closed live themetracbot
#43133 THEME: Storefront – 2.2.3 closed live themetracbot
#44245 THEME: Storefront – 2.2.4 closed live themetracbot
#45839 THEME: Storefront – 2.2.5 closed live themetracbot


https://themes.svn.wordpress.org/storefront/1.0.1/screenshot.png

#6 @emiluzelac
3 years ago

  • Owner set to patilswapnilv
  • Status changed from new to reviewing

#7 @themetracbot
3 years ago

  • Summary changed from THEME: Storefront - 1.0.1 to THEME: Storefront - 1.0.2

Storefront - 1.0.2

Storefront is the perfect theme for your next eCommerce project. Designed and developed by WooThemes, it features a deep integration with our market leading WooCommerce plugin, several layout & color options to personalise your shop, multiple widget regions, a responsive design and much more. Developers will love it's lean and extensible codebase making it a joy to customise and extend.

Theme URL - http://woothemes.com/storefront
Author URL - http://woothemes.com

SVN - https://themes.svn.wordpress.org/storefront/1.0.2
ZIP - https://wordpress.org/themes/download/storefront.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/storefront/1.0.1&new_path=/storefront/1.0.2

History:

Ticket Summary Status Resolution Owner
#10266 THEME: Storefront Paper - 1.0 closed not-approved chipbennett
#10515 THEME: Storefront Paper - 1.0.1 closed not-approved nishasingh
#15298 THEME: Storefront Paper - 1.0.5 closed live alex27
#15410 THEME: Storefront Paper - 1.0.6 closed live alex27
#17608 THEME: Storefront Paper - 1.1 closed not-approved Frank Klein
#17758 THEME: Storefront Paper - 1.1.1 closed live Frank Klein
#20573 THEME: Storefront - 1.0.2 closed closed-newer-version-uploaded gpriday

(this ticket)

#21263 THEME: Storefront - 1.0.3 closed live gpriday
#21758 THEME: Storefront - 1.1.0 closed live emiluzelac
#21788 THEME: Storefront - 1.1.1 closed live karmatosed
#21928 THEME: Storefront - 1.2.0 closed live karmatosed
#22042 THEME: Storefront - 1.2.1 closed live karmatosed
#22476 THEME: Storefront - 1.2.2 closed live karmatosed
#22533 THEME: Storefront - 1.2.3 closed live karmatosed
#22681 THEME: Storefront - 1.2.4 closed live sakinshrestha
#22810 THEME: Storefront - 1.2.5 closed live jcastaneda
#23163 THEME: Storefront - 1.3.0 closed live emiluzelac
#23347 THEME: Storefront - 1.3.1 closed live emiluzelac
#23646 THEME: Storefront – 1.4.2 closed live jcastaneda
#24170 THEME: Storefront – 1.4.3 closed live jcastaneda
#24484 THEME: Storefront – 1.4.4 closed live greenshady
#24888 THEME: Storefront – 1.4.5 closed live poena
#25322 THEME: Storefront – 1.4.6 closed live downstairsdev
#26413 THEME: Storefront – 1.5.0 closed live jcastaneda
#27103 THEME: Storefront – 1.5.1 closed live jcastaneda
#28155 THEME: Storefront – 1.5.2 closed live karmatosed
#28257 THEME: Storefront – 1.5.3 closed live jcastaneda
#29628 THEME: Storefront – 1.6.0 closed live greenshady
#29911 THEME: Storefront – 1.6.1 closed live Otto42
#32888 THEME: Storefront – 2.0.0 closed live themetracbot
#33053 THEME: Storefront – 2.0.1 closed live themetracbot
#33543 THEME: Storefront – 2.0.2 closed live themetracbot
#33580 THEME: Storefront – 2.0.3 closed live themetracbot
#33873 THEME: Storefront – 2.0.4 closed live themetracbot
#34387 THEME: Storefront – 2.0.5 closed live themetracbot
#34930 THEME: Storefront – 2.0.6 closed live themetracbot
#35093 THEME: Storefront – 2.0.7 closed live themetracbot
#35837 THEME: Storefront – 2.1.0 closed live themetracbot
#36084 THEME: Storefront – 2.1.1 closed live themetracbot
#36245 THEME: Storefront – 2.1.2 closed live themetracbot
#36641 THEME: Storefront – 2.1.3 closed live themetracbot
#37036 THEME: Storefront – 2.1.4 closed live themetracbot
#37329 THEME: Storefront – 2.1.5 closed live themetracbot
#37354 THEME: Storefront Child Theme – 1.0.0 closed not-approved poena
#37836 THEME: Storefront – 2.1.6 closed live themetracbot
#38474 THEME: Storefront Travel – 1.0 closed not-approved acosmin
#39515 THEME: Storefront – 2.1.7 closed live themetracbot
#40380 THEME: Storefront – 2.1.8 closed live themetracbot
#43062 THEME: Storefront – 2.2.0 closed live themetracbot
#43072 THEME: Storefront – 2.2.1 closed live themetracbot
#43079 THEME: Storefront – 2.2.2 closed live themetracbot
#43133 THEME: Storefront – 2.2.3 closed live themetracbot
#44245 THEME: Storefront – 2.2.4 closed live themetracbot
#45839 THEME: Storefront – 2.2.5 closed live themetracbot


https://themes.svn.wordpress.org/storefront/1.0.2/screenshot.png

#8 @jameskoster
3 years ago

Hey @patilswapnilv, when do you plan to perform the initial review? :-)

#9 @patilswapnilv
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

#10 @jameskoster
3 years ago

Do you have some comments explaining why it's not approved?

#11 @karmatosed
3 years ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

Hi @patilswapnilv, whilst you may have found the theme isn't able to be approved, you should give the theme developer a chance to make changes. You should say why it's not been approved and therefore give them a chance to fix things.

For now, let me reopen this as your conversation should continue.

Please do not ever mark anything as not approved, you should let the theme developer fix things that you list. It's very important that you show all your work too. We can't see what you found.

#12 @gpriday
3 years ago

  • Owner changed from patilswapnilv to gpriday
  • Status changed from reopened to reviewing

On the mailing list @patilswapnilv has said he won't be able to do the review. I'll be taking over.

@karmatosed - I've assigned this ticket to myself. If that's a problem, please let me know if this is a problem.

#13 @gpriday
3 years ago

Here are some of my initial findings.

From the latest version of the Theme Check plugin:

  • REQUIRED: Found a Customizer setting that did not have a sanitization callback function. Every call to the add_setting() method needs to have a sanitization callback function passed.

I'm not sure which settings these are, but could you double check this @jameskoster?

Everything looks well coded. I haven't been able to find anything in my initial reviews. I'll carry on checking and let you know if I find anything.

Only other thing that you'll need to fix is the activation redirect. Themes are not allowed redirecting to another page (in this case, your welcome screen) after activation.

#14 @gpriday
3 years ago

Can you also confirm the license of all the images on your welcome screen? You'll need to mention this somewhere in your theme's readme. All the images need to be GPL compatible.

#15 @jameskoster
3 years ago

Hey, I uploaded a new version but it created a new ticket here: https://themes.trac.wordpress.org/ticket/21263

Should I have just attached it to this one?

#16 @karmatosed
3 years ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from reviewing to closed

Ideally yes it should have just attached itself, so lets move everyone over there to do the review :)

Note: See TracTickets for help on using tickets.