WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20593 closed theme (live)

THEME: Shprink One - 2.4.1

Reported by: shprink Owned by: emiluzelac
Priority: theme update Keywords: theme-shprink-one
Cc: julien.renaux@…

Description

Shprink One - 2.4.0

ShprinkOne is a Bootstrap 3 responsive theme that can fit any screen (mobile phone, tablet, laptop, desktop). Features a theme picker (10 choices), a slideshow on the home page, posts as pins(masonry), infinite posts scroll, several Widget, Menu positions and multi language support. ShprinkOne is an Open Source project that can be forked on GitHub https://github.com/shprink/Shprink-One

Theme URL - http://julienrenaux.fr/shprinkone
Author URL - http://julienrenaux.fr

SVN - https://themes.svn.wordpress.org/shprink-one/2.4.0
ZIP - https://wordpress.org/themes/download/shprink-one.2.4.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/shprink-one/2.3.2&new_path=/shprink-one/2.4.0

History:

Ticket Summary Status Resolution Owner
#12104 THEME: Shprink One - 1.0.2 closed closed-newer-version-uploaded
#12259 THEME: Shprink One - 1.0.3 closed not-approved saymar90
#13071 THEME: Shprink One - 1.1.0 closed not-approved saymar90
#13640 THEME: Shprink One - 1.2.0 closed not-approved saymar90
#14757 THEME: Shprink One - 2.0.1 closed live tubiz
#15307 THEME: Shprink One - 2.1.0 closed live chipbennett
#16255 THEME: Shprink One - 2.2.0 closed live jcastaneda
#16596 THEME: Shprink One - 2.3.2 closed live robin90
#20593 THEME: Shprink One - 2.4.1 closed live emiluzelac

(this ticket)


https://themes.svn.wordpress.org/shprink-one/2.4.0/screenshot.png

Change History (7)

#1 @emiluzelac
3 years ago

  • Owner set to emiluzelac
  • Status changed from new to reviewing

#2 @emiluzelac
3 years ago

Before we can approve and mark this theme live, please address the following issues:


All images, including the screenshot must be properly licensed and GPL-Compatible.

Scripts must be properly enqueued and not hardcoded

<script type="text/javascript">
	jQuery(document).ready(function($) {
		// Add Bootstrap class to lists within the sidebar
		$('#sidebar .widget ul').addClass('nav nav-pills nav-stacked');
		$('footer .widget ul').addClass('nav nav-pills nav-stacked');
		$('.widget_recent_comments ul').removeClass('nav nav-tabs nav-pills nav-stacked').addClass('list-unstyled');
		$('[data-toggle=tooltip]').tooltip()
		$('ul.dropdown-menu [data-toggle=dropdown]').on('click', function(event) {
			// Avoid following the href location when clicking
			event.preventDefault();
			// Avoid having the menu to close when clicking
			event.stopPropagation();
			// If a menu is already open we close it
			$('#header ul.dropdown-menu [data-toggle=dropdown]').parent().removeClass('open');
			// opening the one you clicked on
			$(this).parent().addClass('open');
		});
	});
</script>

and

	<script type="text/javascript">
		jQuery(document).ready(function($) {
			var $container = $('#masonry');
			$container.infinitescroll({
				navSelector: '#page-nav', // selector for the paged navigation
				nextSelector: '#page-nav a', // selector for the NEXT link (to page 2)
				itemSelector: '.box', // selector for all items you'll retrieve,
				loading: {
					finishedMsg: '<?php echo __('No more pages to load.', 'shprinkone') ?>',
					img: '<?php echo get_stylesheet_directory_uri(); ?>/img/loading.gif',
					msgText: '<?php echo __('Loading the next set of posts...', 'shprinkone') ?>'
				}
			},
			// trigger Masonry as a callback
			function(newElements) {
				// hide new items while they are loading
				var $newElems = $(newElements).css({
					opacity: 0});
				// ensure that images load before adding to masonry layout
				$newElems.imagesLoaded(function() {
					// show elems now they're ready
					$newElems.animate({
						opacity: 1});
					$container.masonry('appended', $newElems, true);
				});
				onAfterLoaded($newElems);
			}
			);
		});
	</script>
<script type="text/javascript">
	jQuery(document).ready(function($) {
		/* Masonry */
		var $container = $('#masonry');

		// Callback on After new masonry boxes load
		window.onAfterLoaded = function(el) {
			el.find('div.post-meta li').popover({
				trigger: 'hover',
				placement: 'top',
				container: 'body'
			});

            // Disqus support
			if (typeof DISQUSWIDGETS !== 'undefined') {
                $.each(el.find('.dsq-postid'), function(i, node){
                    var $node= $(node),
                    $link = $node.parent('a'),
					url = $link.attr('href').split('#', 1);
                    $link.attr('data-disqus-identifier', $node.attr('rel'));
					$link.attr('href', ((url.length === 1)? url[0] : url[1]) + '#disqus_thread');
                });
				DISQUSWIDGETS.getCount();
			}
		};

		onAfterLoaded($container.find('.box'));

		$container.imagesLoaded(function() {
			$container.masonry({
				itemSelector: '.box'
			});

			$(window).resize(function() {
				$container.masonry('reload');
			});
		});
	});
</script>
	<script type="text/javascript">
		jQuery(document).ready(function($) {
			var loading = {
				finishedMsg: '<?php echo __('No more pages to load.', 'shprinkone') ?>',
				img: '<?php echo get_stylesheet_directory_uri(); ?>/img/loading.gif',
				msgText: '<?php echo __('Loading the next set of posts...', 'shprinkone') ?>'
			}

			var $container = $('#masonry');
			$('#page-nav a').click(function() {
				$button = $(this);
				if (typeof $button.data('href') === 'string' && $button.data('href') !== '') {
					var buttonHtml = $button.html();
					$button.attr('disabled', 'disabled');
					$button.html('<i class="icon-spinner icon-spin"></i> ' + loading.msgText);
					$.ajax($button.data('href'))
							.done(function(data, textStatus, jqXHR) {
						// Set the new page href
						$button.data('href', $(data).find('#page-nav a').data('href'));

						var $newElems = $(data).find('.box').css({
							opacity: 0});
						// ensure that images load before adding to masonry layout
						$newElems.imagesLoaded(function() {
							// show elems now they're ready
							$newElems.animate({
								opacity: 1});
							$container.prepend($newElems);
							$container.masonry('appended', $newElems, true);
						});
						onAfterLoaded($newElems);
					})
							.fail(function(jqXHR, textStatus, errorThrown) {
						$error = $('<div class="alert alert-danger">Something wrong happened :(</div>');
						$error.insertAfter($button);
						$button.remove();
						setTimeout(function() {
							$error.remove()
						}, 3000);
					})
							.always(function() {
						$button.html(buttonHtml);
						$button.removeAttr('disabled');
					});
				}
				else {
					$finish = $('<div class="alert alert-info">' + loading.finishedMsg + '</div>').hide();
					$finish.insertAfter($button);
					$finish.show(500);
					$button.remove();
					setTimeout(function() {
						$finish.hide(500, function() {
							$finish.remove()
						});
					}, 3000)
				}

			});
		});
	</script>

and also:

<script type="text/javascript">
    var $ = jQuery;
</script>

All needs to be in example.js and included via wp_enqueue_

In functions.php you have third-party link, please delete:

echo '<span class="description alignright">Themes by <a href="http://bootswatch.com" target="_blank">Bootswatch</a></span>';

and all related such as:

$templateList['united'] = array(
		'name' => 'United',
		'value' => 'united',
		'author' => 'http://bootswatch.com/',
		'path' => '/css/united.bootswatch.min.css',
		'colors' => array('#DD4814', '#FFFFFF', '#DD4814', '#333333'),
		'description' => __('Ubuntu orange and unique font.', 'shprinkone')
	);

Recommended:

Theme uses $_COOKIE please see and use http://codex.wordpress.org/WordPress_Cookies instead, also see: http://hitchhackerguide.com/2011/02/12/wp_set_auth_cookie/


Correct the issues and resubmit, once everything is fixed I will approve your theme.

Thanks!

#3 @shprink
3 years ago

Thanks for your feedback :)

Working on it,
Julien

#4 @themetracbot
3 years ago

  • Summary changed from THEME: Shprink One - 2.4.0 to THEME: Shprink One - 2.4.1

Shprink One - 2.4.1

ShprinkOne is a Bootstrap 3 responsive theme that can fit any screen (mobile phone, tablet, laptop, desktop). Features a theme picker (10 choices), a slideshow on the home page, posts as pins(masonry), infinite posts scroll, several Widget, Menu positions and multi language support. ShprinkOne is an Open Source project that can be forked on GitHub https://github.com/shprink/Shprink-One

Theme URL - http://julienrenaux.fr/shprinkone
Author URL - http://julienrenaux.fr

SVN - https://themes.svn.wordpress.org/shprink-one/2.4.1
ZIP - https://wordpress.org/themes/download/shprink-one.2.4.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/shprink-one/2.4.0&new_path=/shprink-one/2.4.1

History:

Ticket Summary Status Resolution Owner
#12104 THEME: Shprink One - 1.0.2 closed closed-newer-version-uploaded
#12259 THEME: Shprink One - 1.0.3 closed not-approved saymar90
#13071 THEME: Shprink One - 1.1.0 closed not-approved saymar90
#13640 THEME: Shprink One - 1.2.0 closed not-approved saymar90
#14757 THEME: Shprink One - 2.0.1 closed live tubiz
#15307 THEME: Shprink One - 2.1.0 closed live chipbennett
#16255 THEME: Shprink One - 2.2.0 closed live jcastaneda
#16596 THEME: Shprink One - 2.3.2 closed live robin90
#20593 THEME: Shprink One - 2.4.1 closed live emiluzelac

(this ticket)


https://themes.svn.wordpress.org/shprink-one/2.4.1/screenshot.png

#5 @shprink
3 years ago

There you go :) You are right using wp_enqueue_ is way better.

CHeers,
Julien

#6 @emiluzelac
3 years ago

  • Resolution set to live
  • Status changed from reviewing to closed

Julien you rock buddy! Thanks :)

#7 @shprink
3 years ago

Thank you man :)

Cheers

Note: See TracTickets for help on using tickets.