WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 2 years ago

#20740 closed theme (not-approved)

THEME: Adapter - 1.0.6

Reported by: ryankienstra Owned by: irenem
Priority: new theme Keywords: theme-adapter
Cc: ryankienstra@…

Description

Adapter - 1.0.0

Adapts to any screen size. Made for developers, with 16 filters and 3 hooks. Load your own Bootstrap css and javascript if you want. Using the admin menu, add an opt-in form to the top and bottom navbars. Select a header image and background color. Page templates include full-width, a page with a sidebar, and a landing page without a header or footer.

Theme URL - http://ryankienstra.com/adapter
Author URL - http://ryankienstra.com

SVN - https://themes.svn.wordpress.org/adapter/1.0.0
ZIP - https://wordpress.org/themes/download/adapter.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#20740 THEME: Adapter - 1.0.6 closed not-approved irenem

(this ticket)


https://themes.svn.wordpress.org/adapter/1.0.0/screenshot.png


Attachments (2)

adapter-1.0.2.zip (520.0 KB) - added by ryankienstra 3 years ago.
Adapter Theme, version 1.0.2
adapter.zip (519.0 KB) - added by ryankienstra 3 years ago.
Version 1.0.3, Adapter Theme

Download all attachments as: .zip

Change History (41)

@ryankienstra
3 years ago

Adapter Theme, version 1.0.2

#1 @ryankienstra
3 years ago

Please see version 1.0.2 of "Adapter." Diffs include new dependency files and some styling changes.

#2 @karmatosed
3 years ago

  • Owner set to jfelient
  • Status changed from new to reviewing

#3 follow-up: @jfelient
3 years ago

Hi ryankienstra,

I'm sorry that this is taking so long, I will go over this now.

#4 in reply to: ↑ 3 @ryankienstra
3 years ago

Replying to jfelient:
Dear jfelient,
That's fine, thank you for reviewing the theme.

#5 @emiluzelac
3 years ago

  • Owner changed from jfelient to bappi.d.great

@ryankienstra
3 years ago

Version 1.0.3, Adapter Theme

#6 @ryankienstra
3 years ago

Please see Version 1.0.3 of "Adapter."
I removed ?> tags at the end of files, escaped in the echo statement instead of earlier, and improved formatting.

#7 @bappi.d.great
3 years ago

Hello @ryankienstra

Please update your svn url with the latest version of the theme.

Cheers
Ash

#8 @ryankienstra
3 years ago

Dear Ash,
Thanks for reviewing my theme.

How should I update the svn url? Sorry, I can't see how to do that. The panel with the url has a reply, but not an edit button.

I assume you mean the url that is currently https://themes.svn.wordpress.org/adapter/1.0.0

My best,
Ryan

#9 @bappi.d.great
3 years ago

Hello Ryan

Yes, it is the same way as you did first time. Go to there: https://themes.svn.wordpress.org/adapter/ and upload 1.0.3 in there :)

Cheers
Ash

#10 @themetracbot
3 years ago

  • Summary changed from THEME: Adapter - 1.0.0 to THEME: Adapter - 1.0.3

Adapter - 1.0.3

Adapts to any screen size. Made for developers, with 17 filters and 7 hooks. Load your own Bootstrap css and javascript if you want. Using the admin menu, add an opt-in form to the top and bottom navbars. Select a header image and background color. Page templates include full-width, a page with a sidebar, and a landing page without a header or footer.

Theme URL - http://ryankienstra.com/adapter
Author URL - http://ryankienstra.com

SVN - https://themes.svn.wordpress.org/adapter/1.0.3
ZIP - https://wordpress.org/themes/download/adapter.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/adapter/1.0.0&new_path=/adapter/1.0.3

History:

Ticket Summary Status Resolution Owner
#20740 THEME: Adapter - 1.0.6 closed not-approved irenem

(this ticket)


https://themes.svn.wordpress.org/adapter/1.0.3/screenshot.png

#11 @ryankienstra
3 years ago

Dear Ash,
Thanks for your help. Let me know if you could use anything else.

My best,
Ryan

#12 @bappi.d.great
3 years ago

Hello @ryankienstra

I have found some issues.

  1. The theme URI is redirecting, maybe use the final URI?
  2. The site title is not shown at all in home page
  3. The third level menu is not shown
  4. The following should be moved to setup function:
    if ( ! isset( $content_width ) ) {
    	 $content_width = 600;
    }
    
  5. Remove the space before DOCTYPE in header.php
  6. Need some padding: http://screencast.com/t/t3snTZwUy25w
  7. Cropping doesn't work in customizer when uploading a top banner
  8. Maybe this is not the best place to show the header markup? http://screencast.com/t/9THV1CZKY7B3 but it's up to you.

Please fix these and I will continue reviewing again :)

Cheers
Ash

#13 @ryankienstra
3 years ago

Dear Ash,
Thanks for listing those issues and going through my whole theme. I will work on them today.

My best,
Ryan

#14 @themetracbot
3 years ago

  • Summary changed from THEME: Adapter - 1.0.3 to THEME: Adapter - 1.0.4

Adapter - 1.0.4

Adapts to any screen size. Made for developers, with 17 filters and 7 hooks. Load your own Bootstrap css and javascript if you want. Using the admin menu, add an opt-in form to the top and bottom navbars. Select a header image and background color. Page templates include full-width, a page with a sidebar, and a landing page without a header or footer.

Theme URL - http://ryankienstra.com/themes/adapter
Author URL - http://ryankienstra.com

SVN - https://themes.svn.wordpress.org/adapter/1.0.4
ZIP - https://wordpress.org/themes/download/adapter.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/adapter/1.0.3&new_path=/adapter/1.0.4

History:

Ticket Summary Status Resolution Owner
#20740 THEME: Adapter - 1.0.6 closed not-approved irenem

(this ticket)


https://themes.svn.wordpress.org/adapter/1.0.4/screenshot.png

#15 @ryankienstra
3 years ago

Dear Ash,
Thanks for going through my theme. I fixed the issues above, except for #2 and #8.

I couldn't replicate issue #2, where the site title isn't showing on the front page. Could you give me more details about when it isn't showing?

Here is a static front page: http://ryankienstra.com/wp-content/uploads/2014/11/site_title_static_front_page.png
Here is a "blog post" front page: http://ryankienstra.com/wp-content/uploads/2014/11/site_title_blog_post.png

Thanks for raising these points. The theme is much better now that the header can be cropped.

My best,
Ryan

Last edited 3 years ago by ryankienstra (previous) (diff)

#16 @bappi.d.great
3 years ago

Hello @ryankienstra

  1. About 2: Please check the title bar: http://monosnap.com/image/XcYIj5k5ehHtGJMi9rWk4p5s53cv9d and http://monosnap.com/image/nGWmcWl72oZvVrPd07BsM03Y922gRc
  1. The menu is still not fixed: http://take.ms/QdVPM (3rd level menu is not shown)

Check my menu structure: http://take.ms/pMntW

  1. The version number should be changed in functions.php line no 7 when you update the version.
  1. Function should_page_have_top_and_bottom_navs should have prefix awp_ :)
  1. add_theme_page( __( 'Header & Footer' , 'adapter-wp' ) , __( 'Header & Footer' , 'adapter-wp' ) , 'unfiltered_html' , 'awp_options' , 'awp_options_output_callback' ); - capability should be edit_theme_options not unfiltered_html
  1. Nonce is not checked in theme option page (awp-admin-menu.php) THIS IS IMPORTANT!
  1. update_option( $name_header_extra_markup , $value_header_extra_markup ); and update_option( $name_footer_extra_markup , $value_footer_extra_markup );

Those should be added as an single array, not separated. Same for get_options()

  1. Please include briefly the use of page template file in readme file

That's it what I can see now. If any confusion, please feel free to let me know :)

Cheers
Ash

Last edited 3 years ago by bappi.d.great (previous) (diff)

#17 @themetracbot
3 years ago

  • Summary changed from THEME: Adapter - 1.0.4 to THEME: Adapter - 1.0.5

Adapter - 1.0.5

Adapts to any screen size. Made for developers, with 17 filters and 7 hooks. Load your own Bootstrap css and javascript if you want. Using the admin menu, add an opt-in form to the top and bottom navbars. Select a header image and background color. Page templates include full-width, a page with a sidebar, and a landing page without a header or footer.

Theme URL - http://ryankienstra.com/themes/adapter
Author URL - http://ryankienstra.com

SVN - https://themes.svn.wordpress.org/adapter/1.0.5
ZIP - https://wordpress.org/themes/download/adapter.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/adapter/1.0.4&new_path=/adapter/1.0.5

History:

Ticket Summary Status Resolution Owner
#20740 THEME: Adapter - 1.0.6 closed not-approved irenem

(this ticket)


https://themes.svn.wordpress.org/adapter/1.0.5/screenshot.png

#18 @ryankienstra
3 years ago

Dear Ash,
Thanks for your notes. I worked on all of them.

For point #7, I changed update_option to set_theme_mod. I also changed get_option to get_theme_mod. This keeps the theme options in one array.

I also moved the header markup to the top of the page.

Thanks for your advice.
Ryan

#19 @karmatosed
3 years ago

bappi.d.great are you able to take a look at this?

#20 @bappi.d.great
3 years ago

Hello @karmatosed and @ryankienstra

I am sorry, I should have mentioned, I am out of my workplace right now and will be back in this Friday. So I can take another look in this Saturday. I will really appreciate if that is possible.

Otherwise, you can assign another person.

Sorry for inconvenience.

Cheers
Ash

#21 @bappi.d.great
3 years ago

Hello Ryan

I am sorry for the delay, was quite busy with something else.

Issues:

  1. The menu is still not fixed. Please check screenshots:

http://take.ms/UFrUM
http://take.ms/0ajzf

Level 3, 3a, 3b should be shown on hover of Level 2
Level 2a, 2b is missing.

  1. Markup doesn't work in post/page title

https://cloudup.com/cOy52JYG4EX
https://cloudup.com/cUQ1c1GxYV4

Recommendation:

  1. As you have not shown featured image in single post, maybe keep an option if the user wants to show in front end or not?
  2. There is no space between cells: https://cloudup.com/cA1kUMiv8Wt

I think everything else is good :)

Cheers
Ash

#22 @themetracbot
3 years ago

  • Summary changed from THEME: Adapter - 1.0.5 to THEME: Adapter - 1.0.6

Adapter - 1.0.6

Adapts to any screen size. Made for developers, with filters and hooks. Load your own Bootstrap css and JavaScript if you want. Using the admin menu, add an opt-in form to the top and bottom navbars. Select a header image and background color. Page templates include full-width, a page with a sidebar, and a landing page without a header or footer.

Theme URL - http://ryankienstra.com/themes/adapter
Author URL - http://ryankienstra.com

SVN - https://themes.svn.wordpress.org/adapter/1.0.6
ZIP - https://wordpress.org/themes/download/adapter.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/adapter/1.0.5&new_path=/adapter/1.0.6

History:

Ticket Summary Status Resolution Owner
#20740 THEME: Adapter - 1.0.6 closed not-approved irenem

(this ticket)


https://themes.svn.wordpress.org/adapter/1.0.6/screenshot.png

#23 @ryankienstra
3 years ago

Ash,
Thanks for your help with this theme.

I fixed the third-level menu with the new script awp-third-level-menu.js.

Also, the markup should now work in the page/post title.

Your suggestions about the featured image and space between cells are good. But I think I'll have to wait until the next version if that's alright.

Thanks for all of your guidance.

My best,
Ryan

This ticket was mentioned in Slack in #themereview by jcastaneda. View the logs.


3 years ago

#25 @ryankienstra
3 years ago

Dear Ash,
Thanks a lot for your help with this theme.

Your suggestions really helped, especially fixing the header image.

Have you had a chance to look at my work on your latest points?

My best,
Ryan

#26 @ryankienstra
3 years ago

Dear Ash,
Thanks for reviewing my theme, and helping me make it more usable and secure.

Do you have time to take a look at the final two changes?

My best,
Ryan Kienstra

#27 @bappi.d.great
3 years ago

Hello Ryan

I am really really sorry, I am currently busy with something, so not getting time :(

I should have informed earlier but I totally forgot, I apologize.

@karmatosed, Can this be assigned to someone else please? This guy is waiting for a long time.

Cheers
Ash

Last edited 3 years ago by bappi.d.great (previous) (diff)

#28 @ryankienstra
3 years ago

Dear Ash,
That's fine, thanks for all of your advice for my theme.

Your suggestions for the header image and the nonce were especially helpful.

My best,
Ryan

#29 @ryankienstra
3 years ago

@karmatosed, is there any way someone could be assigned to review my theme? It seems that Ash is too busy now. I know it's hard to find someone, with all the themes to be reviewed.

@bappi.d.great, thank you for all of your suggestions for my theme. Your input really helped, especially with the menu and the nonces.

#30 @grapplerulrich
3 years ago

  • Owner changed from bappi.d.great to irenem

Thank you @irenem for taking this ticket over.

#31 @irenem
3 years ago

Hi @ryankienstra,

Please fix/modify the comments below.

@ Layout

  • Check the page & sidebar layout. Images, menus, text or any contents should not overflow.
  • Check the bottom of your page & sidebar, the rest of the contents are cut.
  • Check your responsive layouts, especially the mobile dimension.

@ Menu

  • All levels (sub-menu) must be visible. You only show up to the 2nd level.

@ Customizer

  • DO NOT remove the core features like colors, nav etc.

@ Theme Options (Header & Footer)

  • Change or remove this page. There's no boundaries as to how much data will the user add to this page, cases like this is already categorized as plugin territory.
  • You can use Settings API to implement your theme options (if you have other than above). Refer to this link https://codex.wordpress.org/Settings_API for adding your theme options.

@ Scripts

  • Include the unminified version of html5shiv and respond

@ comments.php

  • Do not hard code the comment form. Use comment_form instead.

@ Others

Irene

#32 @ryankienstra
3 years ago

Hi @irenem,
Thanks for your points above about my theme. I really appreciate you working on it.

I'll work on correcting these issues.

My best,
Ryan

#33 @irenem
3 years ago

Hi Ryan,

When do you think you can upload the new version of your theme? Haven't heard from you for more than a week.

Irene

#34 @irenem
2 years ago

Hi @ryankienstra,

Any progress with your new version?

Irene

#35 @ryankienstra
2 years ago

Hi @irenem,
Sorry, I haven't made any progress with my new theme version. I've been really busy with a new job.

I'm sorry for not replying to your last message.

Is there a date that you'd like this done by? The earliest I could do would be one or two weeks.

Thanks a lot for reviewing my theme.

Ryan

#36 @irenem
2 years ago

Hi @ryankienstra,

I will leave this ticket open. Do let me know when you are able to upload the new version so that this ticket will not be considered abandoned.

Irene

#37 @irenem
2 years ago

Hi @ryankienstra,

Any update on your theme?

#38 @ryankienstra
2 years ago

Hi Irene,
Sorry, I don't have any updates on my theme. Sorry to keep you waiting. It'll be at least a few weeks until it's ready.

Is there an option of re-submitting the theme at some later point? Maybe that would keep me from holding up your theme queue.

#39 @irenem
2 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi Ryan,

I believe you can resubmit your theme any time. And no it's not holding anything (from me) really but if there's no activity then it is considered abandoned.

I'll close this ticket and then you can resubmit your theme when you are ready. I don't want to rush you either especially if you're busy. You can cc me by then if you want me to review your theme again. If I am not around then I'm sure there are other reviewers who will be ready to review your theme.

Have a great day!
Irene

Note: See TracTickets for help on using tickets.