WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#20751 closed theme (live)

THEME: HopScotch - 2.1.5

Reported by: briansahagun Owned by: a2lau
Priority: new theme Keywords: theme-hopscotch
Cc: briansahagun@…

Description

HopScotch - 1.0

A WordPress base template upholding the importance of semantic HTML and content structure.

Theme URL - http://briansahagun.com/hopscotch
Author URL - http://briansahagun.com

SVN - https://themes.svn.wordpress.org/hopscotch/1.0
ZIP - https://wordpress.org/themes/download/hopscotch.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#20751 THEME: HopScotch - 2.1.5 closed live a2lau

(this ticket)

#25304 THEME: HopScotch 3 – 3.0 closed not-approved Xtraboy
#45244 THEME: HopScotch – 2.1.6 closed live themetracbot
#45245 THEME: HopScotch – 2.1.7 closed live Otto42


https://themes.svn.wordpress.org/hopscotch/1.0/screenshot.png


Change History (30)

#1 follow-up: @alex27
3 years ago

  • Keywords changed from theme-hopscotch, accessibility-ready to theme-hopscotch accessibility-ready

Hello!

Please note, that screenshot should be a "reasonable facsimile" of the Theme after it is initially activated with default options. Please update your screenshot and upload new version of the theme.

#2 @themetracbot
3 years ago

  • Summary changed from THEME: HopScotch - 1.0 to THEME: HopScotch - 2.0

HopScotch - 2.0

A WordPress base template upholding the importance of semantic HTML and content structure.

Theme URL - http://briansahagun.com/hopscotch
Author URL - http://briansahagun.com

SVN - https://themes.svn.wordpress.org/hopscotch/2.0
ZIP - https://wordpress.org/themes/download/hopscotch.2.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/hopscotch/1.0&new_path=/hopscotch/2.0

History:

Ticket Summary Status Resolution Owner
#20751 THEME: HopScotch - 2.1.5 closed live a2lau

(this ticket)

#25304 THEME: HopScotch 3 – 3.0 closed not-approved Xtraboy
#45244 THEME: HopScotch – 2.1.6 closed live themetracbot
#45245 THEME: HopScotch – 2.1.7 closed live Otto42


https://themes.svn.wordpress.org/hopscotch/2.0/screenshot.png

#3 in reply to: ↑ 1 @briansahagun
3 years ago

Replying to alex27:

Hello!

Please note, that screenshot should be a "reasonable facsimile" of the Theme after it is initially activated with default options. Please update your screenshot and upload new version of the theme.

Will change it, thanks!

#4 @themetracbot
3 years ago

  • Summary changed from THEME: HopScotch - 2.0 to THEME: HopScotch - 2.1

HopScotch - 2.1

A WordPress base template upholding the importance of semantic HTML and content structure.

Theme URL - http://briansahagun.com/hopscotch
Author URL - http://briansahagun.com

SVN - https://themes.svn.wordpress.org/hopscotch/2.1
ZIP - https://wordpress.org/themes/download/hopscotch.2.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/hopscotch/2.0&new_path=/hopscotch/2.1

History:

Ticket Summary Status Resolution Owner
#20751 THEME: HopScotch - 2.1.5 closed live a2lau

(this ticket)

#25304 THEME: HopScotch 3 – 3.0 closed not-approved Xtraboy
#45244 THEME: HopScotch – 2.1.6 closed live themetracbot
#45245 THEME: HopScotch – 2.1.7 closed live Otto42


https://themes.svn.wordpress.org/hopscotch/2.1/screenshot.png

#5 @themetracbot
3 years ago

  • Summary changed from THEME: HopScotch - 2.1 to THEME: HopScotch - 2.1.1

HopScotch - 2.1.1

A WordPress base template upholding the importance of semantic HTML and content structure.

Theme URL - http://briansahagun.com/hopscotch
Author URL - http://briansahagun.com

SVN - https://themes.svn.wordpress.org/hopscotch/2.1.1
ZIP - https://wordpress.org/themes/download/hopscotch.2.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/hopscotch/2.1&new_path=/hopscotch/2.1.1

History:

Ticket Summary Status Resolution Owner
#20751 THEME: HopScotch - 2.1.5 closed live a2lau

(this ticket)

#25304 THEME: HopScotch 3 – 3.0 closed not-approved Xtraboy
#45244 THEME: HopScotch – 2.1.6 closed live themetracbot
#45245 THEME: HopScotch – 2.1.7 closed live Otto42


https://themes.svn.wordpress.org/hopscotch/2.1.1/screenshot.png

#6 @briansahagun
3 years ago

Good day, may I ask how long does the approval process take?

Thanks.

#7 @alex27
3 years ago

Hello!

As you can see, there are themes 5 weeks old in the queue in front of you, so couple of weeks is my best guess.

#8 @joedolson
3 years ago

Note: will require accessibility-ready review before it can be approved.

#9 @emiluzelac
3 years ago

  • Owner set to a2lau
  • Status changed from new to reviewing

#10 follow-up: @a2lau
3 years ago

Hi Brian,

Thank you for your patience while I was reviewing your theme. There are a some items that need to be fixed before your theme can be approved. These are listed under "Required." If you want to keep the accessibility-ready tag, you'll also need to address a few issues that are listed under "Accessibility-Ready." I do want to see your theme approved (and approved as accessibility-ready!), so please feel free to voice any questions or concerns about my review here.


Required

  1. re-enable the admin toolbar (see lines 50-51 in functions/setup.php)
  2. favicon (and app icons), if kept, must be opt-in and user-definable
  3. hopscotch_customize_main[max_content_width] add_setting call in functions/customizer-structure.php needs to have a sanitization callback
  4. The following items fall into plugin territory and must be removed:
    1. Google Analytics
    2. custom shortcodes hopscotch and display
    3. page excerpts (functions/page-excerpt.php)
    4. custom fields entry-thumbnail, entry-subtitle, and entry-class
    5. allow_all_tinymce_elements_attributes in functions/allow-html-attributes.php
    6. enabling SVG uploads in functions/svg-enable.php
  5. custom-header support must be implemented using header_image() or removed
  6. to facilitate the use of child themes, the child theme's style.css file should be enqueued instead of css/app.css in functions/stylesheet.php
  7. do not remove core-bundled scripts in functions/javascript.php
  8. do not link to anything other than Theme or Author URI in credits (remove link to Wikipedia page)

Accessibility-Ready

  1. "Continue reading" links should be filtered to add context (example)
  2. dropdown navigation menu items should be visible on keyboard focus
  3. skip links should be visible on focus

Notes
You don't need to address these for your theme to be approved. These are just things I wanted to bring to your attention.

  1. The Tagline and Header Text Color settings in the customizer do not work.
  2. Header Sidebar seems to be only good for the search widget. Some documentation (in the description) to that effect would be helpful.
  3. Videos stick out into the Secondary Sidebar area.
  4. add_editor_style argument is not a path to a stylesheet.
  5. There's an unused and unnecessary jQuery file under js/vendor.
  6. functions/customizer-theme.php and functions/home-link.php are not used (commented out).
  7. There's a lot of commented-out code in functions/breadcrumbs.php.
  8. get_the_content_formatted() in functions/get-the-content-formatted.php is never used.
  9. Many of your custom action hooks aren't used (e.g. hopscotch_content_header, hopscotch_body_content, hopscotch_entry_content, hopscotch_hook_extra_content, hopscotch_hook_pre_content, hopscotch_hook_content_title, hopscotch_hook_above_entry, hopscotch_hook_pre_the_content).

#11 in reply to: ↑ 10 @briansahagun
3 years ago

Hi a2lau, thanks for reviewing my theme. I will review and resolve each item.

Replying to a2lau:

Hi Brian,

Thank you for your patience while I was reviewing your theme. There are a some items that need to be fixed before your theme can be approved. These are listed under "Required." If you want to keep the accessibility-ready tag, you'll also need to address a few issues that are listed under "Accessibility-Ready." I do want to see your theme approved (and approved as accessibility-ready!), so please feel free to voice any questions or concerns about my review here.


Required

  1. re-enable the admin toolbar (see lines 50-51 in functions/setup.php)
  2. favicon (and app icons), if kept, must be opt-in and user-definable
  3. hopscotch_customize_main[max_content_width] add_setting call in functions/customizer-structure.php needs to have a sanitization callback
  4. The following items fall into plugin territory and must be removed:
    1. Google Analytics
    2. custom shortcodes hopscotch and display
    3. page excerpts (functions/page-excerpt.php)
    4. custom fields entry-thumbnail, entry-subtitle, and entry-class
    5. allow_all_tinymce_elements_attributes in functions/allow-html-attributes.php
    6. enabling SVG uploads in functions/svg-enable.php
  5. custom-header support must be implemented using header_image() or removed
  6. to facilitate the use of child themes, the child theme's style.css file should be enqueued instead of css/app.css in functions/stylesheet.php
  7. do not remove core-bundled scripts in functions/javascript.php
  8. do not link to anything other than Theme or Author URI in credits (remove link to Wikipedia page)

Accessibility-Ready

  1. "Continue reading" links should be filtered to add context (example)
  2. dropdown navigation menu items should be visible on keyboard focus
  3. skip links should be visible on focus

Notes
You don't need to address these for your theme to be approved. These are just things I wanted to bring to your attention.

  1. The Tagline and Header Text Color settings in the customizer do not work.
  2. Header Sidebar seems to be only good for the search widget. Some documentation (in the description) to that effect would be helpful.
  3. Videos stick out into the Secondary Sidebar area.
  4. add_editor_style argument is not a path to a stylesheet.
  5. There's an unused and unnecessary jQuery file under js/vendor.
  6. functions/customizer-theme.php and functions/home-link.php are not used (commented out).
  7. There's a lot of commented-out code in functions/breadcrumbs.php.
  8. get_the_content_formatted() in functions/get-the-content-formatted.php is never used.
  9. Many of your custom action hooks aren't used (e.g. hopscotch_content_header, hopscotch_body_content, hopscotch_entry_content, hopscotch_hook_extra_content, hopscotch_hook_pre_content, hopscotch_hook_content_title, hopscotch_hook_above_entry, hopscotch_hook_pre_the_content).

#12 follow-up: @briansahagun
3 years ago

Questions:
Which filter can I use to sanitize CSS property values? I revised to use wp_filter_nohtml_kses
What do you suggest for favicon to be user-definable or opt-in?

#13 in reply to: ↑ 12 ; follow-up: @a2lau
3 years ago

Replying to briansahagun:

Questions:
Which filter can I use to sanitize CSS property values? I revised to use wp_filter_nohtml_kses

I don't know of a filter that sanitizes CSS property values. For hopscotch_customize_main[max_content_width] I would check against a regex (number followed by optional unit, any of px, em, rem, %, etc.). Here's an example of how they sanitize hex colors.

What do you suggest for favicon to be user-definable or opt-in?

I'm not sure about this, since I personally would leave this to a plugin or to the user to add in via child theme. I'm thinking a separate section in the customizer with image uploaders. Just remember that the favicon and mobile icons should be disabled by default. Depending on how WP Customize Image Control works you may need to have controls for disabling.

#14 @themetracbot
3 years ago

  • Summary changed from THEME: HopScotch - 2.1.1 to THEME: HopScotch - 2.1.3

HopScotch - 2.1.3

A WordPress Theme upholding the importance of semantic HTML and content structure. Features a Header Sidebar for adding Search functionality at the header.

Theme URL - http://designdrive.co/hopscotch/
Author URL - http://briansahagun.com

SVN - https://themes.svn.wordpress.org/hopscotch/2.1.3
ZIP - https://wordpress.org/themes/download/hopscotch.2.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/hopscotch/2.1.1&new_path=/hopscotch/2.1.3

History:

Ticket Summary Status Resolution Owner
#20751 THEME: HopScotch - 2.1.5 closed live a2lau

(this ticket)

#25304 THEME: HopScotch 3 – 3.0 closed not-approved Xtraboy
#45244 THEME: HopScotch – 2.1.6 closed live themetracbot
#45245 THEME: HopScotch – 2.1.7 closed live Otto42


https://themes.svn.wordpress.org/hopscotch/2.1.3/screenshot.png

#15 in reply to: ↑ 13 ; follow-up: @briansahagun
3 years ago

Replying to a2lau:

Hi I simply removed other items that I could not resolve. I uploaded a new version for review.

Thanks.

Replying to briansahagun:

Questions:
Which filter can I use to sanitize CSS property values? I revised to use wp_filter_nohtml_kses

I don't know of a filter that sanitizes CSS property values. For hopscotch_customize_main[max_content_width] I would check against a regex (number followed by optional unit, any of px, em, rem, %, etc.). Here's an example of how they sanitize hex colors.

What do you suggest for favicon to be user-definable or opt-in?

I'm not sure about this, since I personally would leave this to a plugin or to the user to add in via child theme. I'm thinking a separate section in the customizer with image uploaders. Just remember that the favicon and mobile icons should be disabled by default. Depending on how WP Customize Image Control works you may need to have controls for disabling.

#16 in reply to: ↑ 15 ; follow-up: @a2lau
3 years ago

Replying to briansahagun:

Hi I simply removed other items that I could not resolve. I uploaded a new version for review.

Thanks.

I will take a look within the next several days.

#17 @themetracbot
3 years ago

  • Summary changed from THEME: HopScotch - 2.1.3 to THEME: HopScotch - 2.1.4

HopScotch - 2.1.4

A WordPress Theme upholding the importance of semantic HTML and content structure. Features a Header Sidebar for adding Search functionality at the header.

Theme URL - http://designdrive.co/hopscotch/
Author URL - http://briansahagun.com

SVN - https://themes.svn.wordpress.org/hopscotch/2.1.4
ZIP - https://wordpress.org/themes/download/hopscotch.2.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/hopscotch/2.1.3&new_path=/hopscotch/2.1.4

History:

Ticket Summary Status Resolution Owner
#20751 THEME: HopScotch - 2.1.5 closed live a2lau

(this ticket)

#25304 THEME: HopScotch 3 – 3.0 closed not-approved Xtraboy
#45244 THEME: HopScotch – 2.1.6 closed live themetracbot
#45245 THEME: HopScotch – 2.1.7 closed live Otto42


https://themes.svn.wordpress.org/hopscotch/2.1.4/screenshot.png

#18 in reply to: ↑ 16 @briansahagun
3 years ago

Replying to a2lau:

Hi a2lau, I uploaded a new version.

Replying to briansahagun:

Hi I simply removed other items that I could not resolve. I uploaded a new version for review.

Thanks.

I will take a look within the next several days.

#19 @a2lau
3 years ago

Hi Brian,

Just a few items to fix before your newest version can be approved.

Required

  1. Make sure the admin bar is not blocking header#masthead. You can use the .admin-bar body class to position it below the admin bar.
  2. When comments are set to be broken into pages, there is an undefined function error from calling hopscotch_components_directory() in comments.php, line 31.
  3. functions/svg.php is plugin territory and should be removed. I should have been clearer the first time around.

Recommended

  1. app.css gives 25 errors when checked with the W3C CSS validator (some of them are the result of typos).
  2. The post counts in category and archive widgets look odd (the number of posts followed by a closing parenthesis but no open parenthesis). Like this: category 2)
  3. Videos still stick out into (and covers) the Secondary Sidebar area.
  4. Remove __MACOSX folder.

#20 @themetracbot
3 years ago

  • Summary changed from THEME: HopScotch - 2.1.4 to THEME: HopScotch - 2.1.5

HopScotch - 2.1.5

A WordPress Theme upholding the importance of semantic HTML and content structure. Features a Header Sidebar for adding Search functionality at the header.

Theme URL - http://designdrive.co/hopscotch/
Author URL - http://briansahagun.com

SVN - https://themes.svn.wordpress.org/hopscotch/2.1.5
ZIP - https://wordpress.org/themes/download/hopscotch.2.1.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/hopscotch/2.1.4&new_path=/hopscotch/2.1.5

History:

Ticket Summary Status Resolution Owner
#20751 THEME: HopScotch - 2.1.5 closed live a2lau

(this ticket)

#25304 THEME: HopScotch 3 – 3.0 closed not-approved Xtraboy
#45244 THEME: HopScotch – 2.1.6 closed live themetracbot
#45245 THEME: HopScotch – 2.1.7 closed live Otto42


https://themes.svn.wordpress.org/hopscotch/2.1.5/screenshot.png

#21 follow-up: @briansahagun
3 years ago

Hi a2lau, thanks for reviewing my theme. I have corrected the following:

  • Admin bar not interfering with theme's header
  • Comment navigation corrected
  • Removed svg.php
  • Corrected CSS typo
  • Corrected parenthesis in Widget post counts
  • I tested the videos and they fit the container
  • I removed MACOSX folders from the zip

Thanks!

#22 @joedolson
3 years ago

  • Keywords accessibility-ready removed

Hey, it looks like you've removed the accessibility-ready tag, so I'm removing that workflow keyword. If you decide you do want to pursue making this theme accessibility-ready, I'd be glad to help!

#23 @briansahagun
3 years ago

Hi joedolson, yeah - I need help regarding these items:

  • dropdown navigation menu items should be visible on keyboard focus
  • skip links should be visible on focus

Could you show me an example?

Thank you.

#24 @joedolson
3 years ago

Sure. With the way your menus are modeled, you should look at what was done for Twenty Fifteen, which uses a similar concept of buttons to trigger dropdowns. The problem with yours is that the trigger is attached to the list item and specifically to generated content on that item. What that means is that if you're navigating with the keyboard (use your tab key to navigate forward and tab+shift to navigate backwards), then you can't reach the control; a list item isn't focusable. You should use a <button> element to trigger the dropdown, instead. Twenty Fifteen uses a filter to inject the button into the navigation menu.

With the skip links, it's simply that you need to be able to see the skip link when you tab to it. This is true of anything that you access with the keyboard: you need to be able see that you've moved focus to that item. Many people who are dependent on keyboard navigation are not blind, and without a visual indicator that they've arrived at a particular location at the page, they'll be totally lost when navigating. So, you need to add a :focus state to your skip link (and other links/inputs), so that it's obvious that the user has arrived at them.

WordPress core and Twenty Fifteen have skip links that become visible on :focus; just place your cursor in your browser's address bar, then tab forward to see what happens.

Hope that helps!

#25 in reply to: ↑ 21 @a2lau
3 years ago

Replying to briansahagun:

Great, this theme now looks good to go.

Unless you are working on the accessibility items, my proposed resolution for this theme is approved.

Hi a2lau, thanks for reviewing my theme. I have corrected the following:

  • Admin bar not interfering with theme's header
  • Comment navigation corrected
  • Removed svg.php
  • Corrected CSS typo
  • Corrected parenthesis in Widget post counts
  • I tested the videos and they fit the container
  • I removed MACOSX folders from the zip

Thanks!

#26 follow-up: @briansahagun
3 years ago

Wow, thanks! How long will it take to have a URL in the theme directory?

Regarding the accessibility, it will be just an update to the theme in the future.

#27 in reply to: ↑ 26 @a2lau
3 years ago

Replying to briansahagun:

Wow, thanks! How long will it take to have a URL in the theme directory?

I am not sure. I am actually a new theme reviewer. As I understand it, a more experienced theme reviewer will review my comments and then resolve the ticket. After that, there might still be a waiting period before your theme appears in the theme directory.

Regarding the accessibility, it will be just an update to the theme in the future.

That works too!

#28 @emiluzelac
3 years ago

  • Resolution set to live
  • Status changed from reviewing to closed

Approving based on a2lau's review only.

#29 @briansahagun
3 years ago

Hi theme reviewers, may I know how am I going to update my theme?

#30 @joedolson
3 years ago

Go to https://wordpress.org/themes/getting-started/ and upload the updated .zip file.

Note: See TracTickets for help on using tickets.