WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#20894 closed theme (live)

THEME: Tally Framework - 0.8.5.1

Reported by: tallythemes Owned by: catchthemes
Priority: theme update Keywords: theme-tally-framework
Cc: admin@…

Change History (12)

#1 @catchthemes
3 years ago

  • Owner set to catchthemes
  • Status changed from new to reviewing

#2 @catchthemes
3 years ago

  • Status changed from reviewing to approved

Diff Review Only:
No Previous Issue. Marking Theme as Approved.


Need to fix this in next update:

  • Enqueue <?php if ( is_singular() && get_option( 'thread_comments' ) ) wp_enqueue_script( 'comment-reply' ); ?> in header.php line 10 via wp_enqueue_script (preferably in theme setup function) hook rather than hard-coding it in header.php.

#3 @emiluzelac
3 years ago

  • Status changed from approved to reopened

#4 @emiluzelac
3 years ago

  • Status changed from reopened to reviewing

#5 @emiluzelac
3 years ago

Sorry to that I had to reopen.


We do not accept Google hosted JS such as:

<!--[if lt IE 9]>
<script src="https://html5shim.googlecode.com/svn/trunk/html5.js"></script>
<![endif]-->

please bundle the script with your theme.


Themes should use WordPress image features and not https://themes.svn.wordpress.org/tally-framework/0.8.4/core/vandors/mr-image-resize.php


There is no need to do this wp_enqueue_script('jquery'); when jQuery is called in array like this: wp_enqueue_script('tinynav', tally_assets_file('js/tinynav.min.js'), array('jquery'), '', true);

#6 @catchthemes
3 years ago

Sorry for reopen.

Issue about image resize was mentioned in #20296, as it uses core functionality, it was allowed.

#7 @emiluzelac
3 years ago

disregard that part than :)

#8 @themetracbot
3 years ago

  • Summary changed from THEME: Tally Framework - 0.8.4 to THEME: Tally Framework - 0.8.5

#9 @themetracbot
3 years ago

  • Summary changed from THEME: Tally Framework - 0.8.5 to THEME: Tally Framework - 0.8.5.1

#10 @tallythemes
3 years ago

Sorry for the two update. I did a mistake of a JavaScript file name.

The require changes are here comment:8

#11 @catchthemes
3 years ago

  • Status changed from reviewing to approved

Previous issues

<!--[if lt IE 9]>
<script src="https://html5shim.googlecode.com/svn/trunk/html5.js"></script>
<![endif]-->

Script bundled with theme and licence added.

Themes should use WordPress image features and not https://themes.svn.wordpress.org/tally-framework/0.8.4/core/vandors/mr-image-resize.php

Issue disregarded based on ticket #20296

There is no need to do this wp_enqueue_script('jquery'); when jQuery is called in array like this: wp_enqueue_script('tinynav', tally_assets_file('js/tinynav.min.js'), array('jquery'), '', true);

Issue fixed.

All mentioned issues fixed. Marking theme as approved.

Last edited 3 years ago by catchthemes (previous) (diff)

#12 @jcastaneda
3 years ago

  • Resolution set to live
  • Status changed from approved to closed

Setting live per @catchthemes review


ps, you may want to consider renaming page-blog to template-* or even a folder structure. The reason to avoid this template naming convention for publicly released Themes is to avoid surprising users that create a page with the “-foobar” slug and expect the default template. See Template Hierarchy Page display.

Note: See TracTickets for help on using tickets.