WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 2 years ago

#20936 closed theme (not-approved)

THEME: Mace - 1.1

Reported by: thehosts Owned by: jameskoster
Priority: previously reviewed Keywords: theme-mace
Cc: admin@…

Description

Mace - 1.1

Mace is a fully responsive WordPress theme designed for restaurants, cafes and food bloggers. It has a warm color scheme consisting of a brown background and an elegant orange navigation bar. It comes with a built-in slider, two sidebar positions, social icons and tons of customization options. If you want to setup a food related website quickly and effortlessly then Mace is the theme that you have been looking for.

Theme URL - http://the-hosts.com/mace-wordpress-theme/
Author URL - http://the-hosts.com/

SVN - https://themes.svn.wordpress.org/mace/1.1
ZIP - https://wordpress.org/themes/download/mace.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/mace/1.0&new_path=/mace/1.1

History:

Ticket Summary Status Resolution Owner
#20225 THEME: Mace - 1.0 closed not-approved jameskoster
#20936 THEME: Mace - 1.1 closed not-approved jameskoster

(this ticket)

#21008 THEME: Mace - 1.23 closed live jameskoster


https://themes.svn.wordpress.org/mace/1.1/screenshot.png

Change History (12)

#1 @jameskoster
3 years ago

@Emil Uzelac can this be assigned to me as I did the initial review?

#2 @emiluzelac
3 years ago

  • Owner set to jameskoster
  • Status changed from new to reviewing

#3 @thehosts
3 years ago

Hi. Here are the changes that I have made in this version:

  • I have made sure that there is no HTML in any localisation functions.
  • html5.js has been enqueued properly with the help of $is_IE.
  • All the theme settings have been combined into a single option. Also, I checked the option panel file and all the output is already being escaped prior to output.
  • The Warnings that you received have been taken care of.
  • The show excerpt function has no effect on the excerpts manually generated with the <!-- more --> tag. The description of this setting has been updated accordingly.
  • The credit link is only visible on the first page of the homepage now.
  • When no menu is assigned to the Mobile Menu, nothing shows up now which is the behavior that I want to create.

I couldn't implement some of the optional changes though. I can always take care of them in a latter version. I hope that is okay.

Thanks a lot.

#4 @jameskoster
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hey, almost there!

The screenshot still needs updating to the appropriate size (880 x 660) :-)

Still getting some notices when saving your settings page with wp_debug enabled:

Notice: Undefined index: color_scheme in wp-content/themes/mace/inc/options-panel.php on line 244

Notice: Undefined index: slides in wp-content/themes/mace/inc/options-panel.php on line 251

Notice: Undefined index: slides in wp-content/themes/mace/inc/options-panel.php on line 261

I'm also seeing all of the settings printed on save, I think you left a var_dump($input); in your mace_validator() function.

Thanks.

#5 @khaxan
2 years ago

Hi. Thanks for the feedback. I see that you have closed the thread again. Now a new thread will get opened for the next version :(

Also, I have a couple of questions:

  • Is the large screenshot a requirement? Its just that it took me quite some time to make it look the way it does right now and I no longer have the demo data and the images that I used the last time.
  • I can't see the errors that you have described, even with WP_DEBUG set to true. Maybe they are being generated off-screen? Am I missing something?

Thanks for all your help.

#6 @jameskoster
2 years ago

Hey,

I see that you have closed the thread again. Now a new thread will get opened for the next version :(

That's how it works I'm afraid.

The large screenshot is not a requirement but I would recommend it.

The errors are definitely there. Do you have PHP error logging turned on? You should be able to fix it relatively simply given the errors that I pasted in before. You just need to define that slides var.

The color_scheme var probably shouldn't even be there seeing as the theme doesn't have preset color schemes?

Finally, remove that unnecessary var_dump. It's inside the mace_validator() function.

#7 @khaxan
2 years ago

Thanks for the quick response.

I am pretty sure it is not necessary to close the thread every time. If a thread is open and a new version is uploaded, it gets added automatically. I have made the changes but before I upload the new version, could you try reopening this thread? Otherwise we'll both have to wait for someone to assign the new thread to you. It can't do any harm right?

#8 @jameskoster
2 years ago

I don't have the same privileges as a full member of the review team so I cannot re-open the thread. I'll ask for the new one to be assigned to me once you create it. Shouldn't take long.

#9 @khaxan
2 years ago

Got it.

I would really appreciate it if you could confirm whether closing the threads is necessary. I'm sure it will be helpful for you in the future as well.

#10 @jameskoster
2 years ago

Well the options are;

  • 'leave as reviewing'
  • 'close - not approved'
  • 'mark as approved'

So it's not exactly clear which to use. Closing seems most appropriate .

#11 @emiluzelac
2 years ago

@jameskoster yes that is it, however you can also leave the ticket open, wait for next submission and continue with your review. If that is what you are willing to do. Just Cc me and I will handle the rest :)

Thanks for helping!

#12 @thehosts
2 years ago

Thanks for clarifying that. However I have already uploaded the new version. You can find it here: https://themes.trac.wordpress.org/ticket/21008

Note: See TracTickets for help on using tickets.