WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#21165 closed theme (live)

THEME: Corsa - 1.0.2

Reported by: woorockets Owned by: jugname
Priority: new theme Keywords: theme-corsa
Cc: woorockets@…, grapplerulrich

Description

Corsa - 1.0.0

Corsa focuses on simple shapes with the combination of bright colors and exotic typography to emphasize clarity and usability. You can use Corsa for your business website or personal blog, it will complete all of your demands.

Theme URL - http://demo.woorockets.com/corsa
Author URL - http://www.woorockets.com/

SVN - https://themes.svn.wordpress.org/corsa/1.0.0
ZIP - https://wordpress.org/themes/download/corsa.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#21165 THEME: Corsa - 1.0.2 closed live jugname

(this ticket)

#22359 THEME: Corsa - 1.1 closed live karmatosed
#22781 THEME: Corsa - 1.2 closed live karmatosed
#24169 THEME: Corsa – 1.3 closed live jcastaneda
#25402 THEME: Corsa – 1.4.1 closed not-approved poena
#26144 THEME: Corsa – 1.5 closed live kafleg


https://themes.svn.wordpress.org/corsa/1.0.0/screenshot.png


Attachments (1)

corsa_1.0.1.zip (181.1 KB) - added by woorockets 3 years ago.
Re submit Corsa

Download all attachments as: .zip

Change History (21)

#1 @woorockets
3 years ago

Hello, any reviewer please?

#2 @metallicarosetail
3 years ago

Just wait for the queue. You theme is still on the queue. Please be patience this may also take some several weeks
Just view this link to view your queue
https://themes.trac.wordpress.org/query?priority=new+theme&status=new&keywords=!~buddypress&page=2&col=id&col=summary&col=status&col=time&col=changetime&col=reporter&report=4&order=time

This ticket was mentioned in Slack in #themereview by quang2o12. View the logs.


3 years ago

#4 @karmatosed
3 years ago

  • Cc grapplerulrich added
  • Owner set to jugname
  • Status changed from new to reviewing

#5 @karmatosed
3 years ago

grapplerulrich is going to be your mentor through this process. Thanks grapplerulrich!

#6 @jugname
3 years ago

Thanks @karmatosed,
I am going to review the theme and will be more than happy to work with @grapplerulrich.

#7 @jugname
3 years ago

Review Summary:

  • This is a complete review.

Theme Plugin Test:

Plugin "Theme Check": Pass
Plugin "Debogger": Pass
Plugin "Log Deprecated Notices": None

Required Issues:

  • Screenshot should be a "reasonable facsimile" of the Theme after it is initially activated with default options.
    • Theme requires WR PageBuilder plugin for front page design shown in screenshot.
  • Theme URI, Theme URI must be more than merely a demo.
  • Documentation URI: Documentation URI returns a 404. Appearance > Customize > Getting Started
  • Social content sharing links are plugin territory. Appearance > Customize > Social Networks
  • Favicon, Google Analytics are plugin territory. Appearance > Customize > Extras
  • Meta boxes are plugin territory
  • Theme Customizer sanitization callback must actually sanitize $input, rather than merely return $input unmodified.
  • Footer credit link goes to home_url() with the label WooRockets. I think it should go to http://www.woorockets.com/

Theme Recommendation:

Thank you for your submission.

@woorockets
3 years ago

Re submit Corsa

#8 @woorockets
3 years ago

Hi @jugname,
We are resolved all issue reported by you and resubmited version 1.0.1 . Please review for us again
Thank you so much

#9 @grapplerulrich
3 years ago

@woorockets - Please use the upload page to upload the next version. https://wordpress.org/themes/upload

#10 @themetracbot
3 years ago

  • Summary changed from THEME: Corsa - 1.0.0 to THEME: Corsa - 1.0.1

Corsa - 1.0.1

Corsa focuses on simple shapes with the combination of bright colors and exotic typography to emphasize clarity and usability. You can use Corsa for your business website or personal blog, it will complete all of your demands.

Theme URL - http://www.woorockets.com/themes/corsa/
Author URL - http://www.woorockets.com/

SVN - https://themes.svn.wordpress.org/corsa/1.0.1
ZIP - https://wordpress.org/themes/download/corsa.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/corsa/1.0.0&new_path=/corsa/1.0.1

History:

Ticket Summary Status Resolution Owner
#21165 THEME: Corsa - 1.0.2 closed live jugname

(this ticket)

#22359 THEME: Corsa - 1.1 closed live karmatosed
#22781 THEME: Corsa - 1.2 closed live karmatosed
#24169 THEME: Corsa – 1.3 closed live jcastaneda
#25402 THEME: Corsa – 1.4.1 closed not-approved poena
#26144 THEME: Corsa – 1.5 closed live kafleg


https://themes.svn.wordpress.org/corsa/1.0.1/screenshot.png

#11 follow-up: @jugname
3 years ago

Review Summary:

  • This is a complete review.
  • Previous version of Theme not-approved.
  • Required issues from previous ticket.

Issues from Previous Ticket:

  • Fixed: Screenshot should be a "reasonable facsimile" of the Theme after it is initially activated with default options.
  • Fixed: Theme URI, must be more than merely a demo.
  • Fixed: Documentation URI: Documentation URI returns a 404.
  • Fixed: Social content sharing links are plugin territory.
  • Fixed: Favicon, Google Analytics are plugin territory.
  • Fixed: Meta boxes are plugin territory.
  • Fixed: Theme Customizer sanitization callback must actually sanitize $input, rather than merely return $input unmodified.
  • Fixed: Footer credit link goes to home_url() with the label WooRockets. I think it should go to http://www.woorockets.com/

Theme Plugin Test:

Plugin "Theme Check": Pass
Plugin "Debogger": Pass
Plugin "Log Deprecated Notices": None

Required Issues:

  • Themes are required to be 100% GPL-licensed, or use a GPL-compatible license. This includes all PHP, HTML, CSS, images, fonts, icons, and everything else. All of the theme must be GPL-Compatible.

The PHP code portions of product that interacts via linking with the WordPress CMS are released under the GNU/GPL v2 license. Unless otherwise stated, all images, flash files and cascading style sheets (css) files are released under a WooRockets.com Proprietary License and may not be redistributed or repackaged for use other than those allowed by this “Terms of Use”.

Theme Recommendation:

Thank you for your submission.

#12 in reply to: ↑ 11 @woorockets
3 years ago

Replying to jugname:

Required Issues:

  • Themes are required to be 100% GPL-licensed, or use a GPL-compatible license. This includes all PHP, HTML, CSS, images, fonts, icons, and everything else. All of the theme must be GPL-Compatible.

The PHP code portions of product that interacts via linking with the WordPress CMS are released under the GNU/GPL v2 license. Unless otherwise stated, all images, flash files and cascading style sheets (css) files are released under a WooRockets.com Proprietary License and may not be redistributed or repackaged for use other than those allowed by this “Terms of Use”.

I just edited the term on our main site, all products are now under GPL license. Please check Our Term of Service.

Thank you very much!

#13 @jugname
3 years ago

  • Status changed from reviewing to approved

Review Summary:

  • This is a complete review.
  • Previous version of Theme not-approved.
  • Required issues from previous ticket.

Issues from Previous Ticket:

  • Fixed: Themes are required to be 100% GPL-licensed,

Theme Plugin Test:

Plugin "Theme Check": Pass
Plugin "Debogger": Pass
Plugin "Log Deprecated Notices": None

Theme Recommendation:

  • Approved.
  • Looks good and without apparent issues.

Thank you for your submission.

This ticket was mentioned in Slack in #themereview by quang2o12. View the logs.


3 years ago

#15 @karmatosed
3 years ago

  • Status changed from approved to reopened

Hi, unfortunately the following needs sorting before the theme can be approved:


Required

  • There is no need to enqueue jQuery. You can load it into the array of an enqueue to ensure dependency.
  • No minification of scripts or files unless provide original files.

If you can please do that changes, we can progress with your review. Once you’ve done the revisions, just re-upload through wordpress.org and it will append to this ticket.

#16 @grapplerulrich
3 years ago

@karmatosed

There is no need to enqueue jQuery. You can load it into the array of an enqueue to ensure dependency.

Can you point me to the requirement? Personally I agree with it.

#17 @themetracbot
3 years ago

  • Summary changed from THEME: Corsa - 1.0.1 to THEME: Corsa - 1.0.2

Corsa - 1.0.2

Corsa focuses on simple shapes with the combination of bright colors and exotic typography to emphasize clarity and usability. You can use Corsa for your business website or personal blog, it will complete all of your demands.

Theme URL - http://www.woorockets.com/themes/corsa/
Author URL - http://www.woorockets.com/

SVN - https://themes.svn.wordpress.org/corsa/1.0.2
ZIP - https://wordpress.org/themes/download/corsa.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/corsa/1.0.1&new_path=/corsa/1.0.2

History:

Ticket Summary Status Resolution Owner
#21165 THEME: Corsa - 1.0.2 closed live jugname

(this ticket)

#22359 THEME: Corsa - 1.1 closed live karmatosed
#22781 THEME: Corsa - 1.2 closed live karmatosed
#24169 THEME: Corsa – 1.3 closed live jcastaneda
#25402 THEME: Corsa – 1.4.1 closed not-approved poena
#26144 THEME: Corsa – 1.5 closed live kafleg


https://themes.svn.wordpress.org/corsa/1.0.2/screenshot.png

This ticket was mentioned in Slack in #themereview by quang2o12. View the logs.


3 years ago

#19 @emiluzelac
3 years ago

  • Status changed from reopened to reviewing

@grapplerulrich there is none, but as @karmatosed noted there is no need to:

wp_enqueue_script( 'textdomain-navigation', get_template_directory_uri() . '/js/script.js', array( 'jquery' ), '1.0', true );

that would be how we call the jQuery in array.


Requirements are now fixed, approving and making live.

Thanks :)

#20 @emiluzelac
3 years ago

  • Resolution set to live
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.