WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21175 closed theme (not-approved)

THEME: Business from Henri van de Munt - 1.0

Reported by: HenrivdMunt Owned by: racase
Priority: new theme Keywords: theme-business-from-henri-van-de-munt
Cc: henrivandemunt@…, catchthemes

Description

Change History (8)

#1 @sakinshrestha
3 years ago

  • Owner set to sakinshrestha
  • Status changed from new to reviewing

#2 @karmatosed
3 years ago

  • Cc catchthemes added
  • Owner changed from sakinshrestha to racase

#3 @racase
3 years ago

Hello,
This theme seems to have nice layout (on screenshot) and useful for the WooCommerce based sites.
I had installed this theme in my server I found following issues in the theme:

  • Theme License is not under GNU General Public License. Currently given “test”
  • No proper license URI. Currently given “test”
  • Theme URI is not given
  • Readme.txt file is empty
  • The layout of the site is not in proper order. The styling of the theme is broken.
  • Found following JavaScript error on the theme:
TypeError: $ is not a function
$('.example1').wmuSlider();
  • Googling “wmuSlider”, found that “wmuSlider” is under MIT License. GPL based scripts are recommended.
  • “add_shortcode” function has been used which falls under the plugin-territory functionality.
  • The <title> tags can only contain a call to wp_title(). Use the wp_title filter to modify the output.
  • Found a Customizer setting that did not have a sanitization callback function. Every call to the add_setting() method needs to have a sanitization callback function passed.
  • screen_icon() found in the files theme-settings.php, class-tgm-plugin-activation.php. Deprecated since version 3.8.
  • get_bloginfo( 'text_direction' ) was found in the file context.php. Use is_rtl() instead.
  • The theme appears to use include or require. If these are being used to include separate sections of a template from independent files, then get_template_part() should be used instead.
  • “wp_head” is used before “title” tag. It should have been placed immediately before </head> tag. Please check http://codex.wordpress.org/Function_Reference/wp_head
  • Css and script files are directly coded in header.php file. Those files should have been enqueued from functions.php file.
  • Unnecessary code commenting has been done. Like on header.php file.
  • Tagline are not displayed in front-end
  • No menu has been displayed on front-end
  • “Read More” links are not displayed on the post listing.
  • No links on post date
  • $content_width is not properly defined in functions.php file
  • Comment disabled notice is not shown on posts in which comments are disabled.
  • Search query is not displayed in the search result page
  • Custom widget is not displayed properly as other widget.
  • Screenshot image do not show the real theme design. Screenshot shows the customized header and logo is shown in header which should be removed.
  • Author url is blank. It should be linked to proper theme url.
  • _e() is not used to display the translated text. Text are typed directly in the template files which cannot be translated.
  • Text Domain do not match the theme folder name
  • Adding table of content in css files is a good practice.

Template files not included on theme:

  • Single.php (Used when a single post is queried.)
  • Page.php (Used when an individual Page is queried.)
  • Archive.php (Used when a category, author, or date is queried)
  • Sidebar.php (Used to display widgets)

Note:
Please check http://codex.wordpress.org/Theme_Unit_Test for the help.

Thanks!

#4 @catchthemes
3 years ago

@racase: A few notes:

  • MIT License is GPL Compatible.
  • Author url is blank.
    • Author URI and Theme URI are optional. Themes are recommended to provide at least one of these two links, in order to ensure Theme users have a point of contact for the Theme developer. However, this is not required.
  • Screenshot dimensions are wrong. Screenshot size should be 880x660, to account for HiDPI displays. Any 4:3 image size is acceptable, but 880x660 is preferred.
  • Proper copyright and attribution not found. Go through this link Here.
Last edited 3 years ago by catchthemes (previous) (diff)

#5 @HenrivdMunt
3 years ago

Hi,

I was just testing how it works...
How can I remove this theme?

#6 @catchthemes
3 years ago

@racase: Hi racase, you can close this ticket by selecting resolve as not-approved and you can ask for new one here. Also mention catchthemes as your mentor.

@HenrivdMunt: Hi HenrivMunt, please make sure that you mention the test thing before a review was done. Reviewing takes a lot of time and resource of the Theme Review Team. Please make sure this doesn't happen in the future.

Last edited 3 years ago by catchthemes (previous) (diff)

#7 @racase
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

@catchthemes thanks for the help.

@HenrivdMunt Hope u create better standard theme next time :).

#8 @HenrivdMunt
3 years ago

Last edited 3 years ago by HenrivdMunt (previous) (diff)
Note: See TracTickets for help on using tickets.