WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#21212 closed theme (not-approved)

THEME: myREALConcept - 2.3

Reported by: martin_ziegert Owned by: pokhsujan
Priority: new theme Keywords: theme-myrealconcept
Cc: ziegertmartin@…

Description

myREALConcept - 2.3

Theme is fully custmizable

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/myrealconcept/2.3
ZIP - https://wordpress.org/themes/download/myrealconcept.2.3.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#21212 THEME: myREALConcept - 2.3 closed not-approved pokhsujan

(this ticket)


https://themes.svn.wordpress.org/myrealconcept/2.3/screenshot.png


Change History (6)

#1 @sakinshrestha
3 years ago

  • Owner set to sakinshrestha
  • Status changed from new to reviewing

#2 @emiluzelac
3 years ago

  • Owner changed from sakinshrestha to pokhsujan

#3 @martin_ziegert
3 years ago

Hi,
Aha – you change the person in charge for the review and how long will that now take before we get something like a feedback / approval or whatever?

#4 @sakinshrestha
3 years ago

Looks like no update from @pokhsujan. So, I have done the review. So, when you have free time. Please look at this ticket and update if necessary.

Last edited 3 years ago by sakinshrestha (previous) (diff)

#5 @sakinshrestha
3 years ago

Required

  • Please fix the following error I got in theme options.
    Undefined index: desc on line 979 of /wp-content/themes/myrealconcept/functions/be/fw-options.php
    
  • Please fix the following error I got on saving theme options.
    Notice: Undefined index: myREALConcept_header_image_size in wp-content/themes/myrealconcept/functions/be/fw-options.php on line 854
    
    Warning: Cannot modify header information - headers already sent by (output started at wp-content/themes/myrealconcept/functions/be/fw-options.php:854) in wp-content/themes/myrealconcept/functions/be/fw-options.php on line 878
    
  • Got following error on Theme Options -> General Settings -> Display Breadcrumb Navigation.
    NOTICE: wp-content/themes/myrealconcept/functions/be/fw-options.php:979 - Undefined index: desc
    require_once('wp-admin/admin.php'), do_action('appearance_page_fw-options'), call_user_func_array, myREALConcept_admin
    
  • Text domain is defined as twentytwelve in style.css. Please provide a unique text domain or theme slug.
  • There are two screenshots. You can remove any one.
  • Need to add proper Copyright/License Attribution for bundled resources in readme.txt. E.g: PIE: CSS3, header images, html5shiv, Placeholders.js, SelectNav.js. Read this article
  • Unless otherwise specified, all the theme files, scripts and images are licensed under GNU General Public License version 2, see file license.txt. is not enough. Any resources included such as fonts or images should have all license information declared explicitly. If they are not, the readme file should atleast point the user where to look for the license of the bundled resources.
    • For images, if you have taken the images from somewhere, you need to mention their proper attributions with links. If they were made/captured by you, you will need to mention this explicitly. This goes for the images for screenshot as well.
  • Theme looks to be derived from twentytwelve theme. Please add proper attribution to twentytwelve theme.
  • The languages folder is empty. You will be required to add a pot/po file.
  • In footer.php line 25 and 26, text needs to be localized/internationalized. Also it looks like there is false text(Lorem Ipsum) used. You will need to add something relevant here.
  • No minification of scripts or files unless provide original files. This goes for html5shiv and placeholders.js
  • No hard coding of scripts, styles and Favicons unless a browser workaround script.
    • You have hardcoded google font in header.php. You will need to remove this and add it to myREALConcept_scripts_styles function in functions.php. To avoid ssl issues use following code: wp_enqueue_style('myREALconcept-googleFontsAlike','//fonts.googleapis.com/css?family=Alike');

Recommendation

  • Anything you add to the theme that WordPress doesn’t do such as template files, should be documented.

Note

  • Because of the errors on the theme options page, it has been difficult to proceed further with this review that is based on saving the options. Please fix the mentioned issue and I will proceed with the review that is based on the theme options.

#6 @karmatosed
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

I am closing this ticket as you've not responded to the review. In future please respond, even to say you need more time within 7 days.

Note: See TracTickets for help on using tickets.