WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#21284 closed theme (live)

THEME: Aventurine - 0.1.4

Reported by: ryelle Owned by: davidakennedy
Priority: new theme Keywords: theme-aventurine
Cc: fantastic.fall@…, karmatosed

Description

Aventurine - 0.1.0

Aventurine puts the focus back on your content, with large type and bright colors. Responsive and accessibility-ready, your content can be easily available to your entire audience.

Theme URL - http://themes.redradar.net/introducing-aventurine
Author URL - http://themes.redradar.net/

SVN - https://themes.svn.wordpress.org/aventurine/0.1.0
ZIP - https://wordpress.org/themes/download/aventurine.0.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#21284 THEME: Aventurine - 0.1.4 closed live davidakennedy

(this ticket)


https://themes.svn.wordpress.org/aventurine/0.1.0/screenshot.png


Change History (24)

#1 @karmatosed
3 years ago

  • Cc karmatosed added
  • Keywords changed from theme-aventurine, accessibility-ready to theme-aventurine accessibility-ready
  • Owner set to davidakennedy
  • Status changed from new to reviewing

Assigning this to davidakennedy as it's an accessibility-ready theme and he can do both an accessibility and normal review.

#2 @davidakennedy
3 years ago

Hi there!

I just wanted to note that I started this review last week and will finish it this week. Coming soon! :)

#3 @melchoyce
3 years ago

Thanks David!

#4 follow-up: @davidakennedy
3 years ago

Hi there!

Sorry I didn't finish this last week, but I have both the main review and accessibility review completed. Great work overall! Both the main review and accessibility review have areas that need addressed before the theme can be approved and receive the accessibility-ready tag.

Details are below:

Required

  • customizer.php: There is a new setting here for header_color with callback functions for:
'sanitize_callback'    => 'sanitize_hex_color_no_hash',
'sanitize_js_callback' => 'maybe_hash_hex_color',

But I don't see those functions anywhere. Am I missing them? Those functions would need to be sanitized.

  • content.php: The read more link is not translatable and should use the theme's text domain.
  • _s.pot: This can be removed as it's not needed.
  • In the style.css, the license URL is license.txt, but that isn't present. It should be http://www.gnu.org/licenses/gpl-2.0.html, like in the README.md file.
  • Please list the license for the Google fonts.
  • Remove the tag, "featured-image-header", as there is no support for it that I can see. Did I miss something? Tag info is: "Outputs a featured image, via add_theme_support( 'post-thumbnails' ), in place of the custom header image via add_theme_support( 'custom-header' ), on single-post view."

Recommended

  • Use .txt files in addition to .md files.
  • When I was testing the theme, it wasn't obvious why the widgets didn't appear on archive pages but did on pages and single posts. I'd suggest adding a description for the widgets in the Admin area, saying where they will appear.
  • The archive post navigation looks different on search pages. It's not styled like others, and may be broken.

Notes

  • There is some text near the top of style.css: /* Text meant only for screen readers */ that looks oout of place.

Accessibility

Anything without a "Pass" needs to be addressed.

Headings: Pass: We aren't very strict here, and as it stands this structure would pass, but I see some spots for improvement.

Make your Widget area titles, comment section title and any hidden h1 meant for screen readers h2 headings. This will clean up the organization some and improve navigation in the theme pages for screen reader users.

For more on headings, see: https://www.joedolson.com/2014/11/headings-hierarchy-problem/

Link Text: Pass.

Keyboard Navigation: textarea and inputs need to have visiable :focus styles that don't rely on color alone. It looks like most do already in the theme, done via boder. But border: none; cancels the styles in a number of places.

Controls: Pass.

Contrasts: These color contrasts are not high enough:

21759b on f1f1f1 in <a> on .screen-reader-text.
16a387 on ffffff in <a> in footer.
ffffff on 16a387 in .site-description in footer. The .site-title passes because it's a larger font size.
16a387 on ffffff in <a> in .entry-meta.
16a387 on whitesmoke keyword in <a> in .logged-in-as
e74c3c on whitesmoke keyword in <a> in .widget-title
ffffff text with opacity in .site-info
7c94ac on ffffff in .read-more

The accessibility guidelines have some links on tools for testing contrasts: https://make.wordpress.org/themes/handbook/review/accesibility/

Skip Links: Pass.

Forms: Pass: This passes, but I'd recommend a change with your removing of the * for required. You've removed it, but it's still referenced in the .comment-notes as "Required fields are marked *" This could be confusing to users.

Images: Pass.

Media: Pass.

Disallowed: None found.

Recommended:

ARIA is good.
Zoomable text is good.
title attribute use is minimal but seen in footer.php, image.php, template-tags.php.

You can make changes and submit them via the theme upload form, and we'll go from there. Let me know if you have any questions. I'm happy to clarify anything. Happy theming! :)

Cheers!
Dave

#5 in reply to: ↑ 4 ; follow-up: @ryelle
3 years ago

Replying to davidakennedy:

customizer.php: There is a new setting here for header_color with callback functions for:
But I don't see those functions anywhere. Am I missing them? Those functions would need to be sanitized.

They're core functions: maybe_hash_hex_color & sanitize_hex_color_no_hash.

_s.pot: This can be removed as it's not needed.

Whoops, yes it can :)

Remove the tag, "featured-image-header", as there is no support for it that I can see. Did I miss something? Tag info is: "Outputs a featured image, via add_theme_support( 'post-thumbnails' ), in place of the custom header image via add_theme_support( 'custom-header' ), on single-post view."

Oh, OK- I misunderstood the tag, then (was assuming it meant "uses a featured image as a header").

The archive post navigation looks different on search pages. It's not styled like others, and may be broken.

It is, I guess I only tested that with infinite scroll on.

Regarding color contrasts, what ratio were you testing against? I was aiming for the large/bold text ratio, since the font is so bold. If that's not OK I can adjust the colors :)

#6 in reply to: ↑ 5 @davidakennedy
3 years ago

Replying to ryelle:

Replying to davidakennedy:

customizer.php: There is a new setting here for header_color with callback functions for:
But I don't see those functions anywhere. Am I missing them? Those functions would need to be sanitized.

They're core functions: maybe_hash_hex_color & sanitize_hex_color_no_hash.

Opps! Not sure how I missed that. Thanks for setting me straight! :)

Regarding color contrasts, what ratio were you testing against? I was aiming for the large/bold text ratio, since the font is so bold. If that's not OK I can adjust the colors :)

I'm using the information/ratios outlined here: https://make.wordpress.org/themes/handbook/review/accesibility/#contrasts

The tricky part here is that you have to watch small and large text. WCAG 2.0 considers small anything less than 24px and anything large 24px or greater. So that's why a lot of the trouble spots here are for the green at smaller font sizes.

Here's most of the colors pulled out in a tool you can experiment with: http://accessibility.oit.ncsu.edu/tools/color-contrast/accessible-color-palette.php?&colors=222222,233140,333333,555555,556677,888888,999999,000000,ffffff,16a387,2c3e50,1d2936,1f2c39,ce4435,aabdd1,e74c3c,f4f6f9,5f7a96,7c94ac,cccccc,eeeeee,4b4b4b,45bbe6,f1f1f1,aaaaaa,bbbbbb,f0f0f0,e8e8e8,15191e,21759b,fcfcfc&main=ffffff&level=AA

Greens can be difficult because the darker they go, the more like Christmas it becomes. :)

NC State has some nice color tools that might help: http://accessibility.oit.ncsu.edu/index.php (in the Tools menu).

Let me know if you have any other questions. Happy to retest, of course.

#7 follow-up: @melchoyce
3 years ago

Hey David, we're going to take another stab at fixing up the colors to be compliant, but we might need a couple days. Is that okay?

#8 in reply to: ↑ 7 @davidakennedy
3 years ago

Replying to melchoyce:

Hey David, we're going to take another stab at fixing up the colors to be compliant, but we might need a couple days. Is that okay?

No problem, we only close tickets that have had no response for more than seven days – I believe. :)

So just keep in touch here, and I'll jump on the review when the revisions are made.

#9 @themetracbot
3 years ago

  • Summary changed from THEME: Aventurine - 0.1.0 to THEME: Aventurine - 0.1.1

Aventurine - 0.1.1

Aventurine puts the focus back on your content, with large type and bright colors. Responsive and accessibility-ready, your content can be easily available to your entire audience.

Theme URL - http://themes.redradar.net/introducing-aventurine
Author URL - http://themes.redradar.net/

SVN - https://themes.svn.wordpress.org/aventurine/0.1.1
ZIP - https://wordpress.org/themes/download/aventurine.0.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/aventurine/0.1.0&new_path=/aventurine/0.1.1

History:

Ticket Summary Status Resolution Owner
#21284 THEME: Aventurine - 0.1.4 closed live davidakennedy

(this ticket)


https://themes.svn.wordpress.org/aventurine/0.1.1/screenshot.png

#10 @ryelle
3 years ago

0.1.1 handles everything but the color contrasts, still working with melchoyce on that.

#11 @davidakennedy
3 years ago

Thanks for the update! I hope to get to re-checking the theme this week, but it will likely be after the holidays. :)

#12 @melchoyce
3 years ago

Hey David,

I've played around a bit and determined that there really isn't a way to make this particular color palette accessible, so we're going to drop the accessibility-ready tag and submit it as a regular theme. We'll upload a new version with updated copy (and some updated colors, to restore my original color palette) in the next day or two.

#13 @davidakennedy
3 years ago

Sounds good, @melchoyce! Finding a good, accessible green is rather hard. :(

I'm going to review 0.1.1 this week for the changes suggested because I assume the next diff will probably be small. That way, we'll be closer to getting this one out there for folks to download.

#14 @davidakennedy
3 years ago

@melchoyce and @ryelle, I reviewed 0.1.1 and all the changes address the needed requirements, plus some of the recommendations. Thanks for that! Even though, you're not going for the accessibility-ready tag, you've still created a lovely theme that's very accessibility-friendly. Great work!

I will hold off on approving this until the next revised version comes through.

Let me know if you need anything else in the meantime.

Cheers,
Dave

#15 @melchoyce
3 years ago

Thanks David! Hopefully one of the next ones we make will cover color as well as keyboard/focus. :) We'll upload another version soon.

#16 @themetracbot
3 years ago

  • Summary changed from THEME: Aventurine - 0.1.1 to THEME: Aventurine - 0.1.2

Aventurine - 0.1.2

Aventurine puts the focus back on your content, with large type and bright colors. Responsive and accessibility-ready, your content can be easily available to your entire audience.

Theme URL - http://themes.redradar.net/introducing-aventurine
Author URL - http://themes.redradar.net/

SVN - https://themes.svn.wordpress.org/aventurine/0.1.2
ZIP - https://wordpress.org/themes/download/aventurine.0.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/aventurine/0.1.1&new_path=/aventurine/0.1.2

History:

Ticket Summary Status Resolution Owner
#21284 THEME: Aventurine - 0.1.4 closed live davidakennedy

(this ticket)


https://themes.svn.wordpress.org/aventurine/0.1.2/screenshot.png

#17 @ryelle
3 years ago

Forgot to remove the accessibility-ready tag, will upload a new one in a minute.

#18 @themetracbot
3 years ago

  • Summary changed from THEME: Aventurine - 0.1.2 to THEME: Aventurine - 0.1.3

Aventurine - 0.1.3

Aventurine puts the focus back on your content, with large type and bright colors. Responsive and built with accessibility in mind, your content can be easily available to your entire audience.

Theme URL - http://themes.redradar.net/introducing-aventurine
Author URL - http://themes.redradar.net/

SVN - https://themes.svn.wordpress.org/aventurine/0.1.3
ZIP - https://wordpress.org/themes/download/aventurine.0.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/aventurine/0.1.2&new_path=/aventurine/0.1.3

History:

Ticket Summary Status Resolution Owner
#21284 THEME: Aventurine - 0.1.4 closed live davidakennedy

(this ticket)


https://themes.svn.wordpress.org/aventurine/0.1.3/screenshot.png

#19 @themetracbot
3 years ago

  • Summary changed from THEME: Aventurine - 0.1.3 to THEME: Aventurine - 0.1.4

Aventurine - 0.1.4

Aventurine puts the focus back on your content, with large type and bright colors. Responsive and built with accessibility in mind, your content can be easily available to your entire audience.

Theme URL - http://themes.redradar.net/introducing-aventurine
Author URL - http://themes.redradar.net/

SVN - https://themes.svn.wordpress.org/aventurine/0.1.4
ZIP - https://wordpress.org/themes/download/aventurine.0.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/aventurine/0.1.3&new_path=/aventurine/0.1.4

History:

Ticket Summary Status Resolution Owner
#21284 THEME: Aventurine - 0.1.4 closed live davidakennedy

(this ticket)


https://themes.svn.wordpress.org/aventurine/0.1.4/screenshot.png

#20 @ryelle
3 years ago

OK, I think I'm done :)

From 0.1.1 to 0.1.4: updated the colors, removed accessibility-ready, and updated the screenshot.

#21 @davidakennedy
3 years ago

  • Keywords accessibility-ready removed
  • Status changed from reviewing to approved

#22 @davidakennedy
3 years ago

I approved the changes based on the diffs. Congrats @ryelle and @melchoyce! This should be live soon, whenever someone pushes the button. :)

#23 @melchoyce
3 years ago

Thanks for the review, David!

#24 @karmatosed
3 years ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations, this theme is now live!

Note: See TracTickets for help on using tickets.