WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#21366 closed theme (live)

THEME: WikiWP - 1.4.7

Reported by: LifeIsSimple Owned by: downstairsdev
Priority: theme update Keywords: theme-wikiwp
Cc: info@…, karmatosed, emiluzelac

Description

WikiWP - 1.4

Powerful Wiki-style theme for WordPress. WikiWP is best suited for an encyclopedic website. The theme gives you the opportunity to turn your blog into an encyclopedia! Now you can build our own Wikipedia using the advantages of WordPress. Easy to use and modify, clean and understandable code. WikiWP focuses on the content and is also SEO-friendly.

Theme URL - http://wikiwp.com
Author URL -

SVN - https://themes.svn.wordpress.org/wikiwp/1.4
ZIP - https://wordpress.org/themes/download/wikiwp.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/wikiwp/1.3&new_path=/wikiwp/1.4

History:

Ticket Summary Status Resolution Owner
#21224 THEME: WikiWP - 1.3 closed not-approved karmatosed
#21366 THEME: WikiWP - 1.4.7 closed live downstairsdev

(this ticket)

#23600 THEME: WikiWP – 1.5.06 closed live jcastaneda
#23998 THEME: WikiWP Latest – 1.6.06 closed not-approved emiluzelac
#24024 THEME: WikiWP – 1.6 closed not-approved jcastaneda
#24340 THEME: WikiWP – 1.6.2 closed live nishasingh
#26001 THEME: WikiWP – 1.7 closed live jcastaneda
#29021 THEME: WikiWP – 1.8 closed live Otto42
#29808 THEME: WikiWP – 1.8.1 closed live Otto42
#29972 THEME: WikiWP – 1.8.2 closed live emiluzelac


https://themes.svn.wordpress.org/wikiwp/1.4/screenshot.png

Change History (65)

#1 @LifeIsSimple
3 years ago

This is the second try, to update the WikiWP theme. If there are any issues, please let us know in detail. For the last upload, we didn't get any feedback ... "Closing as clone of existing design" (see #21224) is not helpfull.

Thanks!

#2 follow-up: @catchthemes
3 years ago

  • Cc karmatosed added

Hi LifeIsSimple,

What @karmatosed meant was following:

  • Themes must not clone the design of past or present web site. Themes that clone non-website designs will be considered on a case-by-case basis.
    • This site is very identical to wikipedia design. More info Here

#3 in reply to: ↑ 2 @LifeIsSimple
3 years ago

Replying to catchthemes:

Hi LifeIsSimple,

What @karmatosed meant was following:

  • Themes must not clone the design of past or present web site. Themes that clone non-website designs will be considered on a case-by-case basis.
    • This site is very identical to wikipedia design. More info Here

Thank you for your answer!

This is sad, because the wiki team said to me, I could make it look close to the Wikipedia stile, if there is no Wikipedia logo or any kind of suggest, the Wikipedia foundation would support this theme ... anyway:

Would this be better?

http://wikiwp.com/wp-content/uploads/wikiwpv1.4.1-preview.png

#4 @downstairsdev
3 years ago

Looks like your ticket has gotten stuck here. Sorry about that.

Do any admins have an opinion? @EmilUzelac @karmatosed.

I believe the design of wikipedia is actually very close to the original mediawiki theme which has a permissive license.

@LifeIsSimple This new design you posted makes a number of improvements on the original design. Based on the screenshot I'd feel comfortable approving it. Let's have an admin weigh in though.

Thanks for your patience!

Last edited 3 years ago by downstairsdev (previous) (diff)

#5 @downstairsdev
3 years ago

  • Cc EmilUzelac added

#6 @emiluzelac
3 years ago

Our guidelines are changing and so called "clones" are no longer a concern. As long as there are no trademark infringement we can accept @LifeIsSimple's theme.

#7 @emiluzelac
3 years ago

P.S. usernames are case sensitive emiluzelac -vs EmilUzelac.

#8 @LifeIsSimple
3 years ago

Thank you guys! The new style is almost ready, so I could upload a new version if it helps ...

#9 @downstairsdev
3 years ago

I like the new design you've been working on. It's also better for users if they don't get two updates back-to-back.

Why don't you upload the new version when it's ready and ping me in the ticket (downstairsdev)? I'll review it and make sure you keep your place in the queue.

#10 @themetracbot
3 years ago

  • Summary changed from THEME: WikiWP - 1.4 to THEME: WikiWP - 1.4.1

WikiWP - 1.4.1

Powerful Wiki-style theme for WordPress. WikiWP is best suited for an encyclopedic website. The theme gives you the opportunity to turn your blog into an encyclopedia! Now you can build our own Wikipedia using the advantages of WordPress. Easy to use and modify, clean and understandable code. WikiWP focuses on the content and is also SEO-friendly.

Theme URL - http://wikiwp.com
Author URL -

SVN - https://themes.svn.wordpress.org/wikiwp/1.4.1
ZIP - https://wordpress.org/themes/download/wikiwp.1.4.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/wikiwp/1.4&new_path=/wikiwp/1.4.1

History:

Ticket Summary Status Resolution Owner
#21224 THEME: WikiWP - 1.3 closed not-approved karmatosed
#21366 THEME: WikiWP - 1.4.7 closed live downstairsdev

(this ticket)

#23600 THEME: WikiWP – 1.5.06 closed live jcastaneda
#23998 THEME: WikiWP Latest – 1.6.06 closed not-approved emiluzelac
#24024 THEME: WikiWP – 1.6 closed not-approved jcastaneda
#24340 THEME: WikiWP – 1.6.2 closed live nishasingh
#26001 THEME: WikiWP – 1.7 closed live jcastaneda
#29021 THEME: WikiWP – 1.8 closed live Otto42
#29808 THEME: WikiWP – 1.8.1 closed live Otto42
#29972 THEME: WikiWP – 1.8.2 closed live emiluzelac


https://themes.svn.wordpress.org/wikiwp/1.4.1/screenshot.png

#11 @themetracbot
3 years ago

  • Summary changed from THEME: WikiWP - 1.4.1 to THEME: WikiWP - 1.4.2

WikiWP - 1.4.2

Powerful Wiki-style theme for WordPress. WikiWP is best suited for an encyclopedic website. The theme gives you the opportunity to turn your blog into an encyclopedia! Now you can build our own Wikipedia using the advantages of WordPress. Easy to use and modify, clean and understandable code. WikiWP focuses on the content and is also SEO-friendly.

Theme URL - http://wikiwp.com
Author URL -

SVN - https://themes.svn.wordpress.org/wikiwp/1.4.2
ZIP - https://wordpress.org/themes/download/wikiwp.1.4.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/wikiwp/1.4.1&new_path=/wikiwp/1.4.2

History:

Ticket Summary Status Resolution Owner
#21224 THEME: WikiWP - 1.3 closed not-approved karmatosed
#21366 THEME: WikiWP - 1.4.7 closed live downstairsdev

(this ticket)

#23600 THEME: WikiWP – 1.5.06 closed live jcastaneda
#23998 THEME: WikiWP Latest – 1.6.06 closed not-approved emiluzelac
#24024 THEME: WikiWP – 1.6 closed not-approved jcastaneda
#24340 THEME: WikiWP – 1.6.2 closed live nishasingh
#26001 THEME: WikiWP – 1.7 closed live jcastaneda
#29021 THEME: WikiWP – 1.8 closed live Otto42
#29808 THEME: WikiWP – 1.8.1 closed live Otto42
#29972 THEME: WikiWP – 1.8.2 closed live emiluzelac


https://themes.svn.wordpress.org/wikiwp/1.4.2/screenshot.png

#12 @LifeIsSimple
3 years ago

Sorry, for version 1.4.1 I've forgot to update the thumbnail ...

@downstairsdev this is the new theme style. ;)

#13 @downstairsdev
3 years ago

  • Owner set to downstairsdev
  • Status changed from new to reviewing

#14 follow-up: @downstairsdev
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

This is by no means an exhaustive list, but it seems clear this theme was not run through the Theme Unit Tests. Make sure to go through that and all the theme review requirements before submitting again.

Theme Unit Tests: http://codex.wordpress.org/Theme_Unit_Test
Theme Review Guidelines: https://make.wordpress.org/themes/handbook/guidelines/

Let me know if you have any questions.

Required:

  • <title> not displaying correctly
  • Pagination not working
  • Please run this through the theme unit tests (http://codex.wordpress.org/Theme_Unit_Test)
  • Long title test failed
  • pre tags overflow container
  • Wide image not sized properly, overflow container
  • Post pagination is now working

Suggested:

  • Logo is partially obscured when wp menu is visible
  • h6 tags are incredibly small
  • tables could use some styling
  • Why aren't you supporting WordPress menus?

You shouldn't need a custom SQL query to list all authors, try:
wp_list_authors

get_related_tag_posts_ids is not performant. This will crush a site will thousands of posts. Please refactor or remove.

I suggest putting your add_theme_support calls inside and after_theme_setup hook. See how _s does it:
https://github.com/Automattic/_s/blob/master/functions.php

#15 @karmatosed
3 years ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

Please leave the ticket open for the developer to respond.

#16 @LifeIsSimple
3 years ago

OMG, seems I've got some things to do the next days ... :/

Ok, the Theme Check Plugin said, WikiWP would have passed the tests (with some issues RECOMMENDED). I will update the theme - @karmatosed: thank you for leaving this ticket open.

This ticket was mentioned in Slack in #themereview by downstairsdev. View the logs.


3 years ago

#18 in reply to: ↑ 14 @LifeIsSimple
3 years ago

Replying to downstairsdev:

This is by no means an exhaustive list, but it seems clear this theme was not run through the Theme Unit Tests. Make sure to go through that and all the theme review requirements before submitting again.

Theme Unit Tests: http://codex.wordpress.org/Theme_Unit_Test
Theme Review Guidelines: https://make.wordpress.org/themes/handbook/guidelines/

Let me know if you have any questions.

Required:

  • <title> not displaying correctly
  • Pagination not working
  • Please run this through the theme unit tests (http://codex.wordpress.org/Theme_Unit_Test)
  • Long title test failed
  • pre tags overflow container
  • Wide image not sized properly, overflow container
  • Post pagination is now working

Suggested:

  • Logo is partially obscured when wp menu is visible
  • h6 tags are incredibly small
  • tables could use some styling
  • Why aren't you supporting WordPress menus?

You shouldn't need a custom SQL query to list all authors, try:
wp_list_authors

get_related_tag_posts_ids is not performant. This will crush a site will thousands of posts. Please refactor or remove.

I suggest putting your add_theme_support calls inside and after_theme_setup hook. See how _s does it:
https://github.com/Automattic/_s/blob/master/functions.php

@downstairsdev: How can I display the authors avatar using wp_list_authors() funktion?

#19 @downstairsdev
3 years ago

Sorry if I pointed you in the wrong direction with that specific function. My main point was to try to use one of WordPress wrappers if you can rather than a direct SQL query as this will be safer for long term compatibility.

This might work: http://codex.wordpress.org/Class_Reference/WP_User_Query. (http://wordpress.stackexchange.com/questions/76622/wp-user-query-to-exclude-users-with-no-posts)

It's not a requirement, just a strong suggestion. If you can make the argument that the direct SQL query is necessary and explain reasons why it might be better/more performant I'm all ears. You could also ask someone in the Theme Review Team Slack channel for a second opinion.

Cheers.

#20 @LifeIsSimple
3 years ago

@downstairsdev: I think, I will use the wp_list_authors() function and maybe change it in an future release ... but a thing I would really like to keep is the related post list. Do you got an solution for this problem? (I know it is not required, but a crashing site is not what I want :( )

#21 @LifeIsSimple
3 years ago

@downstairsdev: is this a better solution?

// get 5 related posts
		echo '<div class="related-posts">';
		$tags = wp_get_post_tags($post->ID);
		if ($tags) {
			$tag_ids = array();
			foreach($tags as $individual_tag) $tag_ids[] = $individual_tag->term_id;
			echo '<strong>'.__('Related Posts', 'wikiwp').'</strong>';
			$args=array(
				'tag__in' => $tag_ids,
				'post__not_in' => array($post->ID),
				'showposts'=>5,
				'ignore_sticky_posts'=>1
			);
			$my_query = new WP_Query($args);
			if( $my_query->have_posts() ) {
				while ($my_query->have_posts()) : $my_query->the_post();
				echo '<p><a href="'.get_the_permalink().'" rel="bookmark" title="';
				the_title_attribute();
				echo '">';
				the_post_thumbnail('mini');
				the_title();
				echo '</a></p>';
				endwhile;
			}
		}
		echo '</div>', // end of .related-posts

#22 @downstairsdev
3 years ago

Hi @LifeIsSimple. Yes, that is a much better solution.

But I think the best option is to integrate with an existing quality plugin that provides similar functionality.

For instance JetPack (http://jetpack.me/support/related-posts/) takes the site post data and does all of the intensive data processing on WordPress.com servers. It also probably does much more relevant matching since they have an entire team working on this.

You could recommend the JetPack plugin for related posts and make have your theme include styling so they display how you like. Would that work?

#23 @LifeIsSimple
3 years ago

I know JetPack can do many things, but I try to avoid plugins if possible ... so keeping this would be very nice :)

#24 @downstairsdev
3 years ago

This post from WP Engine has some information on why related queries are difficult: http://wpengine.com/support/disallowed-plugins/ (scroll down a bit).

I think the above code you posted is okay performance-wise (just one additional query), but it's not a very robust solution. It only works for posts that are tagged and in cases where there are additional posts with the same tag. It wouldn't work on my personal site (for example) because I only use categories. I think it's important to consider a wide range of sites and use cases.

If you still want to include the feature as-is, go ahead and submit in the next version and I'll ask another reviewer to give additional feedback. I don't mean to dissuade you from building the theme as you see fit, I just want to make sure the solution has been well considered.

Last edited 3 years ago by downstairsdev (previous) (diff)

#25 @LifeIsSimple
3 years ago

OK, last try (I don't want to give up ... ;P ): Related posts by tags with category fallback, if the post has no tags ... so it should work on your blog, too :D

<?php 
echo '<div class="postmeta-section tags">';
		// get 5 related posts
		echo '<strong>'.__('Related Posts', 'wikiwp').'</strong>';
		echo '<ul class="related-posts">';
		// if post has tags show related posts by tags
		if( has_tag() ) {
			$tags = wp_get_post_tags($post->ID);
			if ($tags) {
				$tag_ids = array();
				foreach($tags as $individual_tag) $tag_ids[] = $individual_tag->term_id;
				$args=array(
					'tag__in' => $tag_ids,
					'post__not_in' => array($post->ID),
					'showposts'=>5,
					'ignore_sticky_posts'=>1
				);
				$my_query = new WP_Query($args);
				if( $my_query->have_posts() ) {
					while ($my_query->have_posts()) : $my_query->the_post();
					echo '<li><a href="'.get_the_permalink().'" rel="bookmark" title="';
					the_title_attribute();
					echo '"><div class="related-post-thumb">'.get_the_post_thumbnail($page->ID, 'mini').'</div>',
						 '<span>'.get_the_title().'</span>',
					 	 '</a></li>';
					endwhile;
				}
			}
		}
		// if post has no tags show related posts by category
		else {
			$related = get_posts( array( 'category__in' => wp_get_post_categories($post->ID), 'numberposts' => 5, 'post__not_in' => array($post->ID) ) );
			if( $related ) foreach( $related as $post ) {
				setup_postdata($post); 
        		echo '<li><a href="'.get_the_permalink().'" rel="bookmark" title="';
				the_title_attribute();
				echo '"><div class="related-post-thumb">'.get_the_post_thumbnail($page->ID, 'mini').'</div>',
					 '<span>'.get_the_title().'</span>',
					 '</a></li>';
       		}
			wp_reset_postdata(); 
		}
		echo '</ul>', 
			 '</div>', // end of .related-posts
			 '</div>'; // end of .postmeta
?>

#26 @themetracbot
3 years ago

  • Summary changed from THEME: WikiWP - 1.4.2 to THEME: WikiWP - 1.4.3

WikiWP - 1.4.3

Powerful Wiki-style theme for WordPress. WikiWP is best suited for an encyclopedic website. The theme gives you the opportunity to turn your blog into an encyclopedia! Now you can build our own Wikipedia using the advantages of WordPress. Easy to use and modify, clean and understandable code. WikiWP focuses on the content and is also SEO-friendly.

Theme URL - http://wikiwp.com
Author URL -

SVN - https://themes.svn.wordpress.org/wikiwp/1.4.3
ZIP - https://wordpress.org/themes/download/wikiwp.1.4.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/wikiwp/1.4.2&new_path=/wikiwp/1.4.3

History:

Ticket Summary Status Resolution Owner
#21224 THEME: WikiWP - 1.3 closed not-approved karmatosed
#21366 THEME: WikiWP - 1.4.7 closed live downstairsdev

(this ticket)

#23600 THEME: WikiWP – 1.5.06 closed live jcastaneda
#23998 THEME: WikiWP Latest – 1.6.06 closed not-approved emiluzelac
#24024 THEME: WikiWP – 1.6 closed not-approved jcastaneda
#24340 THEME: WikiWP – 1.6.2 closed live nishasingh
#26001 THEME: WikiWP – 1.7 closed live jcastaneda
#29021 THEME: WikiWP – 1.8 closed live Otto42
#29808 THEME: WikiWP – 1.8.1 closed live Otto42
#29972 THEME: WikiWP – 1.8.2 closed live emiluzelac


https://themes.svn.wordpress.org/wikiwp/1.4.3/screenshot.png

#27 @LifeIsSimple
3 years ago

Changelog for version 1.4.3:

  • Optimised title
  • New styles for numeric and unordered lists
  • Numeric list with nested counters
  • New styles for heading 4 to 6
  • New styles for numeric lists
  • New styles for non floating images
  • New stylings for blockquotes
  • New styles for tables
  • New styles for links - using #rebeccapurple for visited links as tribute to Rebecca Alison Meyer, Eric Meyer's daughter who recently passed away ... (http://lists.w3.org/Archives/Public/www-style/2014Jun/0316.html)
  • Displaying all authors on author page with number of written posts
  • Supporting custom menus - first is the main menu in the sidebar under the logo
  • Removed blog description from sidebar and set smaller size for the blog title because of long title problems
  • Added blog description to front page
  • Using after_theme_setup hook
  • Added post and page pargination
  • New words for translation dummy file:
    • "Search" (Located in header > main search form)
    • "Sections" (Located in pargination for posts and pages)
    • Updated german translation
  • Bugfix: Text in pre tags (code) is now wrapping
  • Bugfix: Headings had different negative text indent
  • Bugfix: Headings 4 to 6 had no negative text indent
  • Bugfix: Image with align center was behaving like an non floating image
  • Bugfix: Wide image not sized properly
  • Bugfix: Logo was partially obscured when wp menu is visible (while user is logged in)
  • Bugfix: Added Comments styling for comments reply level tree deeper than 2
  • Bugfix: Added translation for date ("on") in postinfo
Last edited 3 years ago by LifeIsSimple (previous) (diff)

#28 @downstairsdev
3 years ago

  • Status changed from reopened to reviewing

Okay, I'll ask another theme reviewer to look at your related posts code.

Thanks for the updates and fixes you made.

Here's some issues I see with the latest update:

  • function "_s_setup" should be prefixed with the theme slug "wikiwp_setup"
  • load_theme_textdomain should use the theme slug
  • function "new_excerpt_more" should be prefixed with the theme slug
  • "?>" should be removed from the end of functions.php (whitespace after can cause issues)
  • Any instances of "theme_name" should changed to your theme slug (i.e. "wikiwp")
  • Pagination still doesn't work
  • Long title test failed again (please check theme unit tests)

Some new things I noticed:

In the right side of a post, there is no output after "Published" or "Author".

---

Please run your theme through the unit tests and do a thorough code check before uploading the next version. Let me know if you have any questions about my feedback.

This ticket was mentioned in Slack in #themereview by downstairsdev. View the logs.


3 years ago

#30 @karmatosed
3 years ago

Regarding related posts, so long as they are are done within the guidelines in other areas such as code, the have historically been allowed. Personally, I always suggest people keep these as plugin territory, but that is up to the theme author.

#31 @downstairsdev
3 years ago

Okay, thanks for the second opinion @karmatosed. I'll give the code another thorough look-over, though I also believe this is plugin territory and does not provide the best experience for users.

#32 @LifeIsSimple
3 years ago

@downstairsdev: What should I do fixing this long title problem? In Twenty Fourteen the Title acts nearly the same ... CSS hypens???

http://guesmo.com/stuff/wikiwp-long-title-issue.png

#33 @LifeIsSimple
3 years ago

@downstairsdev: The pargination works fine for me (<--!nextpage-->)with both, posts and pages ... or have I missed something?

http://guesmo.com/stuff/wikiwp-pargination.png

And the output of second page title, author, published, and related posts is shown only for posts with the category "Wiki" on the post meta section :)

This is because there should be a difference between posts for news and posts for wiki. It will be documented on our website, if the theme passes your tests ;)

#34 @greenshady
3 years ago

I just had a couple of things that I wanted to point out that are recommendations rather than requirements. We should make sure these are clear to the theme author.

"?>" should be removed from the end of functions.php (whitespace after can cause issues)

This is a coding preference rather than a guideline. If the theme actually had whitespace after the closing ?>, it'd be a problem though.

Long title test failed again (please check theme unit tests)

Theme unit tests are no longer a requirement. The long title test is one of the main reasons why.

#35 @LifeIsSimple
3 years ago

@greenhandy: thanks, I will change the things in functions.php :)

#36 @downstairsdev
3 years ago

Hi @LifeIsSimple. Post pagination was indeed fixed in the latest update. I should have been more specific. Archive pagination is what is not working. (Main posts page, category pages, etc.).

Thanks for the clarifications @greenshady. I was not aware that theme unit tests were no longer required (https://make.wordpress.org/themes/2013/11/12/theme-unit-tests-recommended/).

#37 @LifeIsSimple
3 years ago

@downstairsdev: but the archive.php is not jet created. These Templates are using the index.php that only displays an excerpt of posts like the category.php. There is no need for pargination isn't it - od do you mean a thing like "see all/older posts"? :/

#38 @downstairsdev
3 years ago

Yes, you need to provide a way to view older/newer posts. Let's say there are 100 posts on a site. How would someone be able to view those without an "older posts" link or some sort of pagination.

You can see how _s implements this here:

https://github.com/Automattic/_s/blob/master/inc/template-tags.php#L10

#39 @themetracbot
3 years ago

  • Summary changed from THEME: WikiWP - 1.4.3 to THEME: WikiWP - 1.4.4

WikiWP - 1.4.4

Powerful Wiki-style theme for WordPress. WikiWP is best suited for an encyclopedic website. The theme gives you the opportunity to turn your blog into an encyclopedia! Now you can build our own Wikipedia using the advantages of WordPress. Easy to use and modify, clean and understandable code. WikiWP focuses on the content and is also SEO-friendly.

Theme URL - http://wikiwp.com
Author URL -

SVN - https://themes.svn.wordpress.org/wikiwp/1.4.4
ZIP - https://wordpress.org/themes/download/wikiwp.1.4.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/wikiwp/1.4.3&new_path=/wikiwp/1.4.4

History:

Ticket Summary Status Resolution Owner
#21224 THEME: WikiWP - 1.3 closed not-approved karmatosed
#21366 THEME: WikiWP - 1.4.7 closed live downstairsdev

(this ticket)

#23600 THEME: WikiWP – 1.5.06 closed live jcastaneda
#23998 THEME: WikiWP Latest – 1.6.06 closed not-approved emiluzelac
#24024 THEME: WikiWP – 1.6 closed not-approved jcastaneda
#24340 THEME: WikiWP – 1.6.2 closed live nishasingh
#26001 THEME: WikiWP – 1.7 closed live jcastaneda
#29021 THEME: WikiWP – 1.8 closed live Otto42
#29808 THEME: WikiWP – 1.8.1 closed live Otto42
#29972 THEME: WikiWP – 1.8.2 closed live emiluzelac


https://themes.svn.wordpress.org/wikiwp/1.4.4/screenshot.png

#40 @LifeIsSimple
3 years ago

next try :)

functions.php is modified and the posts pargination works now!

http://wikiwp.com/wp-content/uploads/wikiwp-posts-pargination.png

#41 follow-up: @downstairsdev
3 years ago

Editing comments. May have been looking at older version- hang on.

Last edited 3 years ago by downstairsdev (previous) (diff)

#42 in reply to: ↑ 41 @LifeIsSimple
3 years ago

Replying to downstairsdev:

Editing comments. May have been looking at older version- hang on.

No problem ... I have also read your original comment and made some bugfixes:

  • Bugfix: Removed Whitespace at the end of comments.php
  • Bugfix: Removed text domain from header.php (dublicate of text domain in functions.php)
  • Bugfix: Using get_serch_form in header.php instead of custom form and added custom searchform.php (for localisation)
  • Bugfix: Removed SEO meta elements in head

Would it be OK for you if I keep this changes for the next version?

I know the code is not easy to read, but having multiple opening end ending php functions in one PHP template seems not the right way of coding for me ... :/

I'm now following the _s template on Guithub and will make this one of my references ... thanks ;)

#43 @downstairsdev
3 years ago

Did you upload the newest version? The latest I see is 1.4.4 which still has the header meta:
https://themes.svn.wordpress.org/wikiwp/

You are not required to remove all the echo statements, that was just a suggestion. If you look at all the default WordPress themes and most themes that get submitted to the repo though, that is how it is done.

#44 @themetracbot
3 years ago

  • Summary changed from THEME: WikiWP - 1.4.4 to THEME: WikiWP - 1.4.5

WikiWP - 1.4.5

Powerful Wiki-style theme for WordPress. WikiWP is best suited for an encyclopedic website. The theme gives you the opportunity to turn your blog into an encyclopedia! Now you can build our own Wikipedia using the advantages of WordPress. Easy to use and modify, clean and understandable code. WikiWP focuses on the content and is also SEO-friendly.

Theme URL - http://wikiwp.com
Author URL -

SVN - https://themes.svn.wordpress.org/wikiwp/1.4.5
ZIP - https://wordpress.org/themes/download/wikiwp.1.4.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/wikiwp/1.4.4&new_path=/wikiwp/1.4.5

History:

Ticket Summary Status Resolution Owner
#21224 THEME: WikiWP - 1.3 closed not-approved karmatosed
#21366 THEME: WikiWP - 1.4.7 closed live downstairsdev

(this ticket)

#23600 THEME: WikiWP – 1.5.06 closed live jcastaneda
#23998 THEME: WikiWP Latest – 1.6.06 closed not-approved emiluzelac
#24024 THEME: WikiWP – 1.6 closed not-approved jcastaneda
#24340 THEME: WikiWP – 1.6.2 closed live nishasingh
#26001 THEME: WikiWP – 1.7 closed live jcastaneda
#29021 THEME: WikiWP – 1.8 closed live Otto42
#29808 THEME: WikiWP – 1.8.1 closed live Otto42
#29972 THEME: WikiWP – 1.8.2 closed live emiluzelac


https://themes.svn.wordpress.org/wikiwp/1.4.5/screenshot.png

#45 @downstairsdev
3 years ago

Hi. Thanks for the update.

All the OG tags and the meta description also need to be removed from header.php:
https://make.wordpress.org/themes/handbook/guidelines/plugin-territory/

#46 @downstairsdev
3 years ago

Questions:

I am not seeing post comments. Have you tested these?

Published/Author information is not showing up in the right sidebar of posts. Have you tested this?

Requires update:

  • Remove meta and OG tags from header (plugin territory)
  • "Search-for" text is cut-off in header search field
  • Functions should not be nested within wikiwp_s_setup
  • Comments and comment pagination

Fixed:

  • Page pagination
  • excerpt_more properly prefixed
  • load_theme_textdomain
  • Search updated in header to use get_search_form

#47 @emiluzelac
3 years ago

  • Cc emiluzelac added; EmilUzelac removed

#48 follow-up: @emiluzelac
3 years ago

If there is anything I can help to speed up the process please ping me :)

Thanks!

#49 in reply to: ↑ 48 @LifeIsSimple
3 years ago

Replying to emiluzelac:

If there is anything I can help to speed up the process please ping me :)

Thanks!

Hi emiluzelac :)

@downstairsdev & @emiluzelac: OK, I'm working on version 1.4.6 and the following things are allready done:

  • Supporting comments for pages
  • Added Styling for comments pargination
  • Removed meta and OG tags from header (plugin territory)
  • New words for translation dummy file:
    • "Page not found" (Located in 404 error template)
  • Bugfix: 404 page title had to much padding to the top
  • Bugfix: heading 4 was smaller than heading 5
  • Bugfix: Functions should not be nested within wikiwp_s_setup
  • Bugfix: Date and author not shown in post meta box
  • Bugfix: Title attr. of related post link in post meta & post info has shown the excerpt

My Question: the required "Search-for text is cut-off in header search field" ... why is this text required? This is just set to display none because of the design for this form and maybe will be displayed in other serch forms?!

#50 follow-up: @downstairsdev
3 years ago

This is what the text looks like in Chrome:
http://i0.wp.com/wptheming.com/wp-content/uploads/2014/11/screenshot.png

#51 in reply to: ↑ 50 @LifeIsSimple
3 years ago

Replying to downstairsdev:

This is what the text looks like in Chrome:
http://i0.wp.com/wptheming.com/wp-content/uploads/2014/11/screenshot.png

OK, must spend more time on cross browser testing :)

#52 @themetracbot
3 years ago

  • Summary changed from THEME: WikiWP - 1.4.5 to THEME: WikiWP - 1.4.6

WikiWP - 1.4.6

Powerful Wiki-style theme for WordPress. WikiWP is best suited for an encyclopedic website. The theme gives you the opportunity to turn your blog into an encyclopedia! Now you can build our own Wikipedia using the advantages of WordPress. Easy to use and modify, clean and understandable code. WikiWP focuses on the content and is also SEO-friendly.

Theme URL - http://wikiwp.com
Author URL -

SVN - https://themes.svn.wordpress.org/wikiwp/1.4.6
ZIP - https://wordpress.org/themes/download/wikiwp.1.4.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/wikiwp/1.4.5&new_path=/wikiwp/1.4.6

History:

Ticket Summary Status Resolution Owner
#21224 THEME: WikiWP - 1.3 closed not-approved karmatosed
#21366 THEME: WikiWP - 1.4.7 closed live downstairsdev

(this ticket)

#23600 THEME: WikiWP – 1.5.06 closed live jcastaneda
#23998 THEME: WikiWP Latest – 1.6.06 closed not-approved emiluzelac
#24024 THEME: WikiWP – 1.6 closed not-approved jcastaneda
#24340 THEME: WikiWP – 1.6.2 closed live nishasingh
#26001 THEME: WikiWP – 1.7 closed live jcastaneda
#29021 THEME: WikiWP – 1.8 closed live Otto42
#29808 THEME: WikiWP – 1.8.1 closed live Otto42
#29972 THEME: WikiWP – 1.8.2 closed live emiluzelac


https://themes.svn.wordpress.org/wikiwp/1.4.6/screenshot.png

#53 @downstairsdev
3 years ago

Hi.

Required:

  • Can you add credits for all the images used so that I can verify they have a GPL compatible licensed.

Suggested:

  • I see you added a default logo. I would give the user the ability to the image if they choose and display the site title and tagline as text. Not everyone has an image to use.

#54 @LifeIsSimple
3 years ago

Hi @downstairsdev,

I can replace the default logo with text.

How should I add credits to the images? The theme has a GPL_License.txt file, isn't this enough? I can put it in the images folder too ...

#55 @downstairsdev
3 years ago

Hi. You can add any credits at the top of your readme file (https://themes.trac.wordpress.org/browser/wikiwp/1.4.6/readme.txt?rev=40509).

I just need to verify that the image is GPL compatible. If you got it from a source, please link to that source and list the license for the image.

I do think displaying the title/tagline as text (as in previous versions) with an option to upload a logo provides a better experience for most users.

#56 @themetracbot
3 years ago

  • Summary changed from THEME: WikiWP - 1.4.6 to THEME: WikiWP - 1.4.7

WikiWP - 1.4.7

Powerful Wiki-style theme for WordPress. WikiWP is best suited for an encyclopedic website. The theme gives you the opportunity to turn your blog into an encyclopedia! Now you can build our own Wikipedia using the advantages of WordPress. Easy to use and modify, clean and understandable code. WikiWP focuses on the content and is also SEO-friendly. For more information see the documentation on wikiwp.com.

Theme URL - http://wikiwp.com
Author URL -

SVN - https://themes.svn.wordpress.org/wikiwp/1.4.7
ZIP - https://wordpress.org/themes/download/wikiwp.1.4.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/wikiwp/1.4.6&new_path=/wikiwp/1.4.7

History:

Ticket Summary Status Resolution Owner
#21224 THEME: WikiWP - 1.3 closed not-approved karmatosed
#21366 THEME: WikiWP - 1.4.7 closed live downstairsdev

(this ticket)

#23600 THEME: WikiWP – 1.5.06 closed live jcastaneda
#23998 THEME: WikiWP Latest – 1.6.06 closed not-approved emiluzelac
#24024 THEME: WikiWP – 1.6 closed not-approved jcastaneda
#24340 THEME: WikiWP – 1.6.2 closed live nishasingh
#26001 THEME: WikiWP – 1.7 closed live jcastaneda
#29021 THEME: WikiWP – 1.8 closed live Otto42
#29808 THEME: WikiWP – 1.8.1 closed live Otto42
#29972 THEME: WikiWP – 1.8.2 closed live emiluzelac


https://themes.svn.wordpress.org/wikiwp/1.4.7/screenshot.png

#57 @LifeIsSimple
3 years ago

Hi, @downstairsdev, is there anything left to do?

#58 @downstairsdev
3 years ago

I haven't had a chance to look at this most recent version yet (it's the Thanksgiving Holiday here in the United States). I'll let you know as soon as I can.

#59 @downstairsdev
3 years ago

Required:

  • The screenshot doesn't match the default display now that the logo has been removed.

Recommended:

  • The tagline is not displayed.
  • There is no hover state for any of the links in post content.
  • Typo "pargination" > "pagination"?

Question:

Default logo image is no longer displayed, but the image is still in the images directory. Just to confirm, wikiwp-logo.png was created by Florian Steller?

#60 @greenshady
3 years ago

The screenshot doesn't match the default display now that the logo has been removed.

Can the user choose the logo via the theme options? If so, this is probably fine to show it in the screenshot. It's not a major problem if it's meant to show that a user can utilize a logo there. Our goal with screenshot guidelines is to make sure you don't see all the marketing crap like on sites such as ThemeForest. It's OK to show some theme options in use, even if they're not enabled by default.

Last edited 3 years ago by greenshady (previous) (diff)

#61 @downstairsdev
3 years ago

  • Status changed from reviewing to approved

@greenshady Alright, thanks for jumping in. I'll mark as approved.

@LifeIsSimple A theme review admin will take a final look at this before pushing it live- but otherwise you should be good to go.

#62 @LifeIsSimple
3 years ago

@downstairsdev:

  • Florian Steller is my real name :)
  • Tagline: I'm not sure about the right way of displaying the logo, because some people have the company name in the logo and some don't. What do you think, should I display blog name + tagline and only remove the blog name while displaying the logo image or should I keep both and show the image in addition?
  • The other things will be fixt in the next version ;)

@downstairsdev, @greenshady, @emiluzelac, @catchthemes, @karmatosed
Thank you, guys!

#63 @downstairsdev
3 years ago

Hi @LifeIsSimple. I'm not sure there is a standardized way of doing it. I personally hide the site title if a logo has been uploaded. I always show the tagline unless someone has set the tagline to blank, i.e. if ( get_bloginfo( 'description' ) != ).

#64 @LifeIsSimple
3 years ago

Seems to be a good way, I will think about it, thanks! :)

#65 @karmatosed
3 years ago

  • Resolution set to live
  • Status changed from approved to closed
Note: See TracTickets for help on using tickets.