WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#21450 closed theme (not-approved)

THEME: Worthy - 1.2

Reported by: biplobmurb Owned by: stubgo
Priority: new theme Keywords: theme-worthy accessibility-ready
Cc: biplobmurb@…

Change History (5)

#2 @karmatosed
3 years ago

  • Keywords changed from theme-worthy, accessibility-ready to theme-worthy accessibility-ready
  • Owner set to stubgo
  • Status changed from new to reviewing

#3 @stubgo
3 years ago

Hey,

Here are the first notes:

I Licence:
# Icon’s bundle is not declared anywhere;

II Author and theme URI:
# Theme URI is not working;
# Theme and author URI both point to a landing page template which doesn’t seem to be related nor GLP-compatible.
# The theme seems to be partly copied from a theme named “brightpage” by Effi (https://themes.trac.wordpress.org/ticket/5283). There are still some text domains from that theme (‘brightpage’) + the readme.txt file the author’s name Effi is the one thanking for using the plugin, recommendation given are the same as by Effi etc - these shouldn't be in the theme, the theme should use 'worthy' text domain and author's information only.

III TAGS
The following tags aren’t implemented to the theme: green, three-columns, left-sidebar, fixed-layout, custom-background, custom-header, editor-style, theme-options, rtl-language-support, accessibility-ready

IV Other
# Footer has hardcoded text in case the user is not using footer widget. Also, it includes many incorrect words in English, I would recommend taking the hardcoded text out + checking over the language.
# Look over the comments’ design. It’s not very understandable.
# Some files (for example includes/pagination.php and includes/widgets-worthy.php) have an empty row as the first row. The files must start with <?php without any space/empty row before. Also, the files shouldn’t have empty rows in the ending. Please check all the files. I would recommend removing empty rows from the middle of the code as well, there are many of unnecessary empty rows.
# Recommended screenshot image size is 880*660 (or some other size in ratio 4:3)
# Text domain is missing for sidebar names, pagination next/previous
# The footer.php line 52 has duplicate class attribute.

Let me know if you have any questions.
I'll continue the review after the first fixes!

Regards,
M.

#4 @stubgo
3 years ago

Hi again @biplobmurb,

Let me know if you are working on the fixes. Then I'll know if I'll wait some more or will change the status of the ticket.

Thanks!

Regards,
M.

#5 @stubgo
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hey,

I'm resolving the theme as not-approved due to inactivity and unfixed issues.

Regards,
M.

Note: See TracTickets for help on using tickets.