WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21488 closed theme (live)

THEME: Geekery - 1.1.2

Reported by: Magnigenie Owned by: gregrickaby
Priority: previously reviewed Keywords: theme-geekery
Cc: info@…, karmatosed

Description

Geekery - 1.1

Geekery is a clean elegant flat theme specialized for Blog, News, Magazine websites.It's 100% responsive theme which adapts to any device.It comes with 10 predefined color schemes to choose from which would change the complete look and feel of your website in just one click.It has a powerful admin theme options to manage different aspects of the sites. The theme supports all post formats and has its own custom fields to make the blog posting much more easier. It is also optimized for SEO, has localization support, social links widget and much more. Check the theme demo @ http://magnigenie.com/geekery-clean-responsive-wordpress-blog-theme and for support check our support forum @ http://magnigenie.com/support.

Theme URL - http://magnigenie.com/themes/geekery/
Author URL - http://magnigenie.com/

SVN - https://themes.svn.wordpress.org/geekery/1.1
ZIP - https://wordpress.org/themes/download/geekery.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/geekery/1.0.1&new_path=/geekery/1.1

History:

Ticket Summary Status Resolution Owner
#20361 THEME: Geekery - 1.0.1 closed not-approved basantakumar
#21488 THEME: Geekery - 1.1.2 closed live gregrickaby

(this ticket)

#30370 THEME: Geekery115 – 1.1.5 closed not-approved emiluzelac


https://themes.svn.wordpress.org/geekery/1.1/screenshot.png

Change History (15)

#1 @karmatosed
3 years ago

  • Cc karmatosed added
  • Owner set to gregrickaby
  • Status changed from new to reviewing

#2 follow-up: @gregrickaby
3 years ago

Hi! Thanks for submitting a theme. My name is Greg and I'll be handling the review.

I've noticed a few things that I'll outline here. Anything that is "required" will be have to be fixed before we can proceed. Anything "recommended" should be fixed before proceeding. Let's begin...

REQUIRED ITEMS


In header.php following condition requires braces:

if (!empty($sticky))
rsort($sticky);

Incorrect use of "alternate if/else syntax" throughout header.php. For example:

<?php if( $logo !='' ) { ?>
<img src="<?php echo $logo; ?>">
<?php } else bloginfo('name'); ?>

Contains HTML in between, therefore should use a :, not a brace. Please read: https://make.wordpress.org/core/handbook/coding-standards/php/#brace-style to learn more.

RECOMMENDED


  • breatheout_filter_pre_get_posts() should be moved to extras.php

This

$geekery_user_agent = strtolower($_SERVER['HTTP_USER_AGENT']);
if(preg_match('/(?i)msie [1-8]/',$geekery_user_agent)) {
wp_enqueue_script( 'html5', get_template_directory_uri() . '/js/html5shiv.min.js', true ); 
}

should be written like:

global $is_IE;

if ( $is_IE ) {
    wp_enqueue_script( 'html5', get_template_directory_uri() . '/js/html5shiv.min.js', true ); 
}

Read more about the available global variables http://codex.wordpress.org/Global_Variables#Browser_Detection_Booleans

Thanks and if you have any questions, just leave a comment and I'll respond soon!

Last edited 3 years ago by gregrickaby (previous) (diff)

#3 @Magnigenie
3 years ago

Hi Greg,

Thank you for reviewing our theme. Will will do the necessary and upload the new version .

Regards
Magnigenie

#4 in reply to: ↑ 2 @Magnigenie
3 years ago

HI Gerg,

I am not sure if genereicons is already there with wordpress core as far as I know its not genereicons its dashicons. Please let me know if I am wrong and when I tried to enqueue genereicons then also it didn't work with wp 4.0.1.

Replying to gregrickaby:

Hi! Thanks for submitting a theme. My name is Greg and I'll be handling the review.

I've noticed a few things that I'll outline here. Anything that is "required" will be have to be fixed before we can proceed. Anything "recommended" should be fixed before proceeding. Let's begin...

REQUIRED ITEMS


In header.php following condition requires braces:

if (!empty($sticky))
rsort($sticky);

Incorrect use of "alternate if/else syntax" throughout header.php. For example:

<?php if( $logo !='' ) { ?>
<img src="<?php echo $logo; ?>">
<?php } else bloginfo('name'); ?>

Contains HTML in between, therefore should use a :, not a brace. Please read: https://make.wordpress.org/core/handbook/coding-standards/php/#brace-style to learn more.

RECOMMENDED


  • breatheout_filter_pre_get_posts() should be moved to extras.php

This

$geekery_user_agent = strtolower($_SERVER['HTTP_USER_AGENT']);
if(preg_match('/(?i)msie [1-8]/',$geekery_user_agent)) {
wp_enqueue_script( 'html5', get_template_directory_uri() . '/js/html5shiv.min.js', true ); 
}

should be written like:

global $is_IE;

if ( $is_IE ) {
    wp_enqueue_script( 'html5', get_template_directory_uri() . '/js/html5shiv.min.js', true ); 
}

Read more about the available global variables http://codex.wordpress.org/Global_Variables#Browser_Detection_Booleans

Thanks and if you have any questions, just leave a comment and I'll respond soon!

#5 follow-up: @gregrickaby
3 years ago

My mistake! Genericons are part of Jetpack and Dashicons are included with core.

Disregard that requirement!

#6 @themetracbot
3 years ago

  • Summary changed from THEME: Geekery - 1.1 to THEME: Geekery - 1.1.1

Geekery - 1.1.1

Geekery is a clean elegant flat theme specialized for Blog, News, Magazine websites.It's 100% responsive theme which adapts to any device.It comes with 10 predefined color schemes to choose from which would change the complete look and feel of your website in just one click.It has a powerful admin theme options to manage different aspects of the sites. The theme supports all post formats and has its own custom fields to make the blog posting much more easier. It is also optimized for SEO, has localization support, social links widget and much more. Check the theme demo @ http://magnigenie.com/geekery-clean-responsive-wordpress-blog-theme and for support check our support forum @ http://magnigenie.com/support.

Theme URL - http://magnigenie.com/product/geekery/
Author URL - http://magnigenie.com/

SVN - https://themes.svn.wordpress.org/geekery/1.1.1
ZIP - https://wordpress.org/themes/download/geekery.1.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/geekery/1.1&new_path=/geekery/1.1.1

History:

Ticket Summary Status Resolution Owner
#20361 THEME: Geekery - 1.0.1 closed not-approved basantakumar
#21488 THEME: Geekery - 1.1.2 closed live gregrickaby

(this ticket)

#30370 THEME: Geekery115 – 1.1.5 closed not-approved emiluzelac


https://themes.svn.wordpress.org/geekery/1.1.1/screenshot.png

#7 in reply to: ↑ 5 @Magnigenie
3 years ago

Hi Gerg,

I have done the necessary modifications as per your last review.

Regards

Replying to gregrickaby:

My mistake! Genericons are part of Jetpack and Dashicons are included with core.

Disregard that requirement!

#8 follow-up: @gregrickaby
3 years ago

Thank you for making those adjustments. They look good. Couple more things:

In header.php, this

if(is_front_page() && get_theme_mod('geekery_slider') == 1&& count( $sticky ) > 0 ) :

needs to be a yoda condition per https://make.wordpress.org/core/handbook/coding-standards/php/#yoda-conditions

if ( is_front_page() && 1 == get_theme_mod( 'geekery_slider' ) && 0 < count( $sticky ) ) :

I'm unable to view the slider. I have a sticky post, but nothing displays. When using the theme customizer, there is still a PHP error. What am I doing wrong?

#9 @themetracbot
3 years ago

  • Summary changed from THEME: Geekery - 1.1.1 to THEME: Geekery - 1.1.2

Geekery - 1.1.2

Geekery is a clean elegant flat theme specialized for Blog, News, Magazine websites.It's 100% responsive theme which adapts to any device.It comes with 10 predefined color schemes to choose from which would change the complete look and feel of your website in just one click.It has a powerful admin theme options to manage different aspects of the sites. The theme supports all post formats and has its own custom fields to make the blog posting much more easier. It is also optimized for SEO, has localization support, social links widget and much more. Check the theme demo @ http://magnigenie.com/geekery-clean-responsive-wordpress-blog-theme and for support check our support forum @ http://magnigenie.com/support.

Theme URL - http://magnigenie.com/product/geekery/
Author URL - http://magnigenie.com/

SVN - https://themes.svn.wordpress.org/geekery/1.1.2
ZIP - https://wordpress.org/themes/download/geekery.1.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/geekery/1.1.1&new_path=/geekery/1.1.2

History:

Ticket Summary Status Resolution Owner
#20361 THEME: Geekery - 1.0.1 closed not-approved basantakumar
#21488 THEME: Geekery - 1.1.2 closed live gregrickaby

(this ticket)

#30370 THEME: Geekery115 – 1.1.5 closed not-approved emiluzelac


https://themes.svn.wordpress.org/geekery/1.1.2/screenshot.png

#10 in reply to: ↑ 8 @Magnigenie
3 years ago

Hi Gerg,

I have changed the required codes and everything should be fine now. Regarding the slider, It automatically drives the sticky posts and displays them on the slider. I have set it up on http://demo.magnigenie.com/geekery and its working pretty well.

Regards

Replying to gregrickaby:

Thank you for making those adjustments. They look good. Couple more things:

In header.php, this

if(is_front_page() && get_theme_mod('geekery_slider') == 1&& count( $sticky ) > 0 ) :

needs to be a yoda condition per https://make.wordpress.org/core/handbook/coding-standards/php/#yoda-conditions

if ( is_front_page() && 1 == get_theme_mod( 'geekery_slider' ) && 0 < count( $sticky ) ) :

I'm unable to view the slider. I have a sticky post, but nothing displays. When using the theme customizer, there is still a PHP error. What am I doing wrong?

#11 @gregrickaby
3 years ago

Thank you for updating. I was able to get the slider working.

@karmatosed Can you give this a glance? Everything looks OK to me.

This ticket was mentioned in Slack in #themereview by gregrickaby. View the logs.


3 years ago

#13 @gregrickaby
3 years ago

  • Status changed from reviewing to approved

#14 follow-up: @karmatosed
3 years ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations, this theme is now live!

#15 in reply to: ↑ 14 @Magnigenie
3 years ago

Thanks a lot. Can you please let me know why can't I see it listed under themes? Will it take some time to be listed there?

Replying to karmatosed:

Congratulations, this theme is now live!

Note: See TracTickets for help on using tickets.