WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21730 closed theme (not-approved)

THEME: Adirondack - 0.1.1

Reported by: ryelle Owned by: rabmalin
Priority: new theme Keywords: theme-adirondack
Cc: fantastic.fall@…, catchthemes

Description

Adirondack - 0.1.0

Adirondack has a bright, clean layout designed to give your content the full attention it deserves. With large images and neat typography, this theme is crafted for longform writers and photographers alike.

Theme URL - http://themes.redradar.net/adirondack/documentation/
Author URL - http://themes.redradar.net

SVN - https://themes.svn.wordpress.org/adirondack/0.1.0
ZIP - https://wordpress.org/themes/download/adirondack.0.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#21730 THEME: Adirondack - 0.1.1 closed not-approved rabmalin

(this ticket)

#22639 THEME: Adirondack - 0.1.3 closed live iCaleb


https://themes.svn.wordpress.org/adirondack/0.1.0/screenshot.png


Change History (10)

#1 @themetracbot
3 years ago

  • Summary changed from THEME: Adirondack - 0.1.0 to THEME: Adirondack - 0.1.1

Adirondack - 0.1.1

Adirondack has a bright, clean layout designed to give your content the full attention it deserves. With large images and neat typography, this theme is crafted for longform writers and photographers alike.

Theme URL - http://themes.redradar.net/adirondack/documentation/
Author URL - http://themes.redradar.net

SVN - https://themes.svn.wordpress.org/adirondack/0.1.1
ZIP - https://wordpress.org/themes/download/adirondack.0.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/adirondack/0.1.0&new_path=/adirondack/0.1.1

History:

Ticket Summary Status Resolution Owner
#21730 THEME: Adirondack - 0.1.1 closed not-approved rabmalin

(this ticket)

#22639 THEME: Adirondack - 0.1.3 closed live iCaleb


https://themes.svn.wordpress.org/adirondack/0.1.1/screenshot.png

#2 @themetracbot
3 years ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#3 @rabmalin
3 years ago

Hello,
You have developed simple but nice theme. I am really impressed with unique design. Here are some points which needs to be resolved.


Theme Check

  • RECOMMENDED: No reference to add_theme_support( "title-tag" ) was found in the theme. It is recommended that the theme implement this functionality for WordPress 4.1 and above.
  • RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

Licensing

  • REQUIRED: Put license information regarding Google Fonts.
  • REQUIRED: Can you please put link of images used in your screenshot along with license information in your readme file.
  • REQUIRED: Please rename your readme file to readme.txt

style.css

  • You have kept tag microformats in the file. Can you exaplain how it is implemented in the theme?

Functionality:
REQUIRED:


Code:
REQUIRED:

  • Move
        if ( ! isset( $content_width ) ) {
    	$content_width = 850; /* pixels */
        }
    

inside adirondack_setup function and make $content_width variable global.

  • RECOMMENDED: You can style the sticky little differently to make it distinguishable.

#4 @ryelle
3 years ago

REQUIRED: Please rename your readme file to readme.txt

Is this a new requirement? .md files have be accepted before, and I'd prefer to stick to that format.

You have kept tag microformats in the file. Can you exaplain how it is implemented in the theme?

No, that was probably a mistake :)

Move $content_width [...]

This is fine where it is, since it's meant to be global. Since there's if ( ! isset( $content_width ) ) { check, a child theme can override it by just defining it in their functions.php. If there's been a requirements update, can you link me?

Thanks for the review!

#5 @rabmalin
3 years ago

Hello,
Thanks for quick reply. I have always seen mention of readme.txt in the guideline. So, I kept that point. I believe it is only RECOMMENDED then.
Also it is highly recommended to have changelog.txt in the theme.

#6 @karmatosed
3 years ago

  • Cc catchthemes added

#7 follow-up: @rabmalin
3 years ago

@catchthemes Theme developer has not responded since 7 days. Should I close this ticket?

#8 in reply to: ↑ 7 @catchthemes
3 years ago

Replying to rabmalin:

@catchthemes Theme developer has not responded since 7 days. Should I close this ticket?

Yes, generally if there in no reply from Theme author for 7 days then you can close the ticket.

#9 @rabmalin
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Ticket closed. Reason: No response from theme developer.

#10 @ryelle
3 years ago

For what it's worth, I've made updated the theme and uploaded my new version here: https://themes.trac.wordpress.org/ticket/22639

Thanks for the review, rabmalin, and sorry I lost track of my emails :)

Note: See TracTickets for help on using tickets.