WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#21892 closed theme (closed-newer-version-uploaded)

THEME: Just Clean Shop - 1.3.1

Reported by: JustPX Owned by: KalenJohnson
Priority: new theme Keywords: theme-just-clean-shop
Cc: mail@…, karmatosed

Description

Just Clean Shop - 1.0

Just Clean Shop – theme comes with the support of WooCommerce Plugin, Jetpack (logo and favicon), Contact Form 7 and Subscribe2. Template suitable for any kind of Shop. Translation ready. Available in English, French, German, Italian, Russian.

Theme URL - http://justpx.com/product/just-clean-shop-free/
Author URL - http://justpx.com/

SVN - https://themes.svn.wordpress.org/just-clean-shop/1.0
ZIP - https://wordpress.org/themes/download/just-clean-shop.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#21892 THEME: Just Clean Shop - 1.3.1 closed closed-newer-version-uploaded KalenJohnson

(this ticket)

#23029 THEME: Just Clean Shop – 1.3.9 closed live KalenJohnson
#24287 THEME: Just Clean Shop – 1.4 closed live jacenty3590
#24377 THEME: Just Clean Shop – 1.5.5 closed live nishasingh
#24625 THEME: Just Clean Shop – 1.5.8 closed live poena
#24827 THEME: Just Clean Shop – 1.6 closed live jcastaneda
#25908 THEME: Just Clean Shop – 1.6.1 closed live jcastaneda
#26213 THEME: Just Clean Shop – 1.6.6 closed live jcastaneda
#26371 THEME: Just Clean Shop – 1.6.7 closed live rabmalin
#26755 THEME: Just Clean Shop – 1.7.1 closed live imon Hasan
#27496 THEME: Just Clean Shop – 1.7.2 closed live rabmalin
#28111 THEME: Just Clean Shop – 1.7.3 closed live karmatosed
#28690 THEME: Just Clean Shop – 1.7.4 closed live karmatosed
#28991 THEME: Just Clean Shop – 1.7.5 closed live karmatosed
#29305 THEME: Just Clean Shop – 1.7.6 closed live karmatosed
#29502 THEME: Just Clean Shop – 1.7.7 closed live Otto42
#29834 THEME: Just Clean Shop – 1.7.8 closed live Otto42


https://themes.svn.wordpress.org/just-clean-shop/1.0/screenshot.png


Change History (15)

#1 @themetracbot
3 years ago

  • Owner set to KalenJohnson
  • Status changed from new to reviewing

#2 @themetracbot
3 years ago

  • Summary changed from THEME: Just Clean Shop - 1.0 to THEME: Just Clean Shop - 1.3

Just Clean Shop - 1.3

Just Clean Shop – theme comes with the support of WooCommerce Plugin, Jetpack (logo and favicon), Contact Form 7 and Subscribe2. Template suitable for any kind of Shop. Translation ready. Available in English, French, German, Italian, Russian.

Theme URL - http://justpx.com/product/just-clean-shop-free/
Author URL - http://justpx.com/

SVN - https://themes.svn.wordpress.org/just-clean-shop/1.3
ZIP - https://wordpress.org/themes/download/just-clean-shop.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/just-clean-shop/1.0&new_path=/just-clean-shop/1.3

History:

Ticket Summary Status Resolution Owner
#21892 THEME: Just Clean Shop - 1.3.1 closed closed-newer-version-uploaded KalenJohnson

(this ticket)

#23029 THEME: Just Clean Shop – 1.3.9 closed live KalenJohnson
#24287 THEME: Just Clean Shop – 1.4 closed live jacenty3590
#24377 THEME: Just Clean Shop – 1.5.5 closed live nishasingh
#24625 THEME: Just Clean Shop – 1.5.8 closed live poena
#24827 THEME: Just Clean Shop – 1.6 closed live jcastaneda
#25908 THEME: Just Clean Shop – 1.6.1 closed live jcastaneda
#26213 THEME: Just Clean Shop – 1.6.6 closed live jcastaneda
#26371 THEME: Just Clean Shop – 1.6.7 closed live rabmalin
#26755 THEME: Just Clean Shop – 1.7.1 closed live imon Hasan
#27496 THEME: Just Clean Shop – 1.7.2 closed live rabmalin
#28111 THEME: Just Clean Shop – 1.7.3 closed live karmatosed
#28690 THEME: Just Clean Shop – 1.7.4 closed live karmatosed
#28991 THEME: Just Clean Shop – 1.7.5 closed live karmatosed
#29305 THEME: Just Clean Shop – 1.7.6 closed live karmatosed
#29502 THEME: Just Clean Shop – 1.7.7 closed live Otto42
#29834 THEME: Just Clean Shop – 1.7.8 closed live Otto42


https://themes.svn.wordpress.org/just-clean-shop/1.3/screenshot.png

#3 @themetracbot
3 years ago

  • Summary changed from THEME: Just Clean Shop - 1.3 to THEME: Just Clean Shop - 1.3.1

Just Clean Shop - 1.3.1

Just Clean Shop – theme comes with the support of WooCommerce Plugin, Jetpack (logo and favicon), Contact Form 7 and Subscribe2. Template suitable for any kind of Shop. Translation ready. Available in English, French, German, Italian, Russian.

Theme URL - http://justpx.com/product/just-clean-shop-free/
Author URL - http://justpx.com/

SVN - https://themes.svn.wordpress.org/just-clean-shop/1.3.1
ZIP - https://wordpress.org/themes/download/just-clean-shop.1.3.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/just-clean-shop/1.3&new_path=/just-clean-shop/1.3.1

History:

Ticket Summary Status Resolution Owner
#21892 THEME: Just Clean Shop - 1.3.1 closed closed-newer-version-uploaded KalenJohnson

(this ticket)

#23029 THEME: Just Clean Shop – 1.3.9 closed live KalenJohnson
#24287 THEME: Just Clean Shop – 1.4 closed live jacenty3590
#24377 THEME: Just Clean Shop – 1.5.5 closed live nishasingh
#24625 THEME: Just Clean Shop – 1.5.8 closed live poena
#24827 THEME: Just Clean Shop – 1.6 closed live jcastaneda
#25908 THEME: Just Clean Shop – 1.6.1 closed live jcastaneda
#26213 THEME: Just Clean Shop – 1.6.6 closed live jcastaneda
#26371 THEME: Just Clean Shop – 1.6.7 closed live rabmalin
#26755 THEME: Just Clean Shop – 1.7.1 closed live imon Hasan
#27496 THEME: Just Clean Shop – 1.7.2 closed live rabmalin
#28111 THEME: Just Clean Shop – 1.7.3 closed live karmatosed
#28690 THEME: Just Clean Shop – 1.7.4 closed live karmatosed
#28991 THEME: Just Clean Shop – 1.7.5 closed live karmatosed
#29305 THEME: Just Clean Shop – 1.7.6 closed live karmatosed
#29502 THEME: Just Clean Shop – 1.7.7 closed live Otto42
#29834 THEME: Just Clean Shop – 1.7.8 closed live Otto42


https://themes.svn.wordpress.org/just-clean-shop/1.3.1/screenshot.png

#4 @JustPX
3 years ago

Hello Kalen Johnson,
I can help you?

#5 @karmatosed
3 years ago

  • Cc karmatosed added

Hi, you've got me as your mentor! I'm really looking forward to mentoring you and helping you become a theme reviewer. Most communication we can do in trac right here. I am available though on Slack in #themereview if you need me.

#6 follow-up: @KalenJohnson
3 years ago

Hey guys,

Sorry I've been busy the last couple weeks. I'll try and get this theme reviewed this week.

#7 in reply to: ↑ 6 @JustPX
3 years ago

Replying to KalenJohnson:

Hey guys,

Sorry I've been busy the last couple weeks. I'll try and get this theme reviewed this week.

Hello, I can help you?

#8 @KalenJohnson
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi JustPX,

Good work on the theme, it's pretty clean and simple, I'm always happy to see that :)

Not too many issues, but here are a couple:

header.php
Line 10 - Please do not link directly to a jQuery CDN file. jQuery should be enqueued using WordPress:
https://make.wordpress.org/themes/handbook/review/required/#stylesheets-and-scripts
"No hard coding of scripts, styles and Favicons unless a browser workaround script. Everything should be enqueued."

Line 11-25 - what does this script do? And why is it saved within a //<![CDATA[ ]]> tag? If you're not using this code, it should be removed. It should also go into a .js file if it is in use.

functions.php
Line 133 - Closing center tag is is a typo: </ceter>
Also, as a strong suggestion, the Wordpress Admin area is loaded as HTML5, so tags like <center> and <font> are deprecated in HTML5. Suggest using either inline styles, or ideally, load your own CSS file for your theme's pages.


Suggestions

These are not requirements to be accepted, but other things that could improve the quality of your theme.

header.php
May consider using HTML5 Doctype

functions.php
Line 79 - Unused variable $args, this could be removed.
Line 108 - Unused variable $defaults, this could be removed.

Let me know if you have any questions!

#9 follow-up: @KalenJohnson
3 years ago

Whoops, @karmatosed, I think I should have set to "still reviewing" rather than "not approved". JustPX can still make the updates and have it approved.

This ticket was mentioned in Slack in #themereview by kalenjohnson. View the logs.


3 years ago

#11 @emiluzelac
3 years ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#12 @emiluzelac
3 years ago

  • Status changed from reopened to reviewing

Done

#13 in reply to: ↑ 9 @JustPX
3 years ago

Replying to KalenJohnson:
Add new version Just Clean Shop - 1.3.2 https://themes.trac.wordpress.org/ticket/23029
Suggestions - I can update in the next version?
KalenJohnson, thank you.

This ticket was mentioned in Slack in #themereview by kalenjohnson. View the logs.


3 years ago

#15 @emiluzelac
3 years ago

  • Resolution set to closed-newer-version-uploaded
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.