WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#21954 closed theme (not-approved)

THEME: HappenStance - 1.0.1

Reported by: tomastoman Owned by: chellycat
Priority: new theme Keywords: theme-happenstance
Cc: webdesign@…

Description

HappenStance - 1.0.0

HappenStance is an easily customizable theme which can be used for your Blog, Magazine, Business, eCommerce or Events website. It is a fully responsive and Retina ready theme that allows for easy viewing on any device. HappenStance theme offers 4 pre-defined color schemes, 220 Google fonts, Theme Options panel for easy adaptation to your needs, selection between Boxed or Wide layout, 2 blog layouts (One Column and Grid - Masonry), contact information in header, ability to set your header logo and favicon, sidebar and footer widget areas, theme documentation and much more. Supports the popular plugins WooCommerce, The Events Calendar and Breadcrumb NavXT. Available in Czech, English, French, German, Russian, Slovak and Spanish.

Theme URL - http://www.tomastoman.cz/happenstance/
Author URL - http://www.tomastoman.cz/

SVN - https://themes.svn.wordpress.org/happenstance/1.0.0
ZIP - https://wordpress.org/themes/download/happenstance.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#21954 THEME: HappenStance - 1.0.1 closed not-approved chellycat

(this ticket)

#22691 THEME: HappenStance - 1.0.2 closed not-approved chellycat
#22779 THEME: HappenStance - 1.0.3 closed live chellycat
#23106 THEME: HappenStance - 1.1.0 closed live jcastaneda
#23661 THEME: HappenStance – 1.1.1 closed live jcastaneda
#24228 THEME: HappenStance – 1.1.2 closed live jacenty3590
#25276 THEME: HappenStance – 1.1.3 closed live karmatosed
#26386 THEME: HappenStance – 1.1.4 closed live rabmalin
#27683 THEME: HappenStance – 1.1.5 closed live emiluzelac
#28584 THEME: HappenStance – 2.0.0 closed live karmatosed
#29288 THEME: HappenStance – 2.0.1 closed live karmatosed
#29847 THEME: HappenStance – 2.0.2 closed live Otto42
#30757 THEME: HappenStance – 2.0.3 closed live jcastaneda
#31695 THEME: HappenStance – 2.0.4 closed live themetracbot
#32638 THEME: HappenStance – 2.0.5 closed live themetracbot
#33323 THEME: HappenStance – 2.0.6 closed live themetracbot
#34340 THEME: HappenStance – 2.0.7 closed live themetracbot
#36192 THEME: HappenStance – 2.0.8 closed live themetracbot
#36804 THEME: HappenStance – 2.0.9 closed live themetracbot
#43389 THEME: HappenStance – 3.0.0 closed live themetracbot
#43987 THEME: HappenStance – 3.0.1 closed live themetracbot


https://themes.svn.wordpress.org/happenstance/1.0.0/screenshot.png


Change History (8)

#1 @themetracbot
3 years ago

  • Summary changed from THEME: HappenStance - 1.0.0 to THEME: HappenStance - 1.0.1

HappenStance - 1.0.1

HappenStance is an easily customizable theme which can be used for your Blog, Magazine, Business, eCommerce or Events website. It is a fully responsive and Retina ready theme that allows for easy viewing on any device. HappenStance theme offers 4 pre-defined color schemes, 220 Google fonts, Theme Options panel for easy adaptation to your needs, selection between Boxed or Wide layout, 2 blog layouts (One Column and Grid - Masonry), contact information in header, ability to set your header logo and favicon, sidebar and footer widget areas, theme documentation and much more. Supports the popular plugins WooCommerce, The Events Calendar and Breadcrumb NavXT. Available in Czech, English, French, German, Russian, Slovak and Spanish.

Theme URL - http://www.tomastoman.cz/happenstance/
Author URL - http://www.tomastoman.cz/

SVN - https://themes.svn.wordpress.org/happenstance/1.0.1
ZIP - https://wordpress.org/themes/download/happenstance.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/happenstance/1.0.0&new_path=/happenstance/1.0.1

History:

Ticket Summary Status Resolution Owner
#21954 THEME: HappenStance - 1.0.1 closed not-approved chellycat

(this ticket)

#22691 THEME: HappenStance - 1.0.2 closed not-approved chellycat
#22779 THEME: HappenStance - 1.0.3 closed live chellycat
#23106 THEME: HappenStance - 1.1.0 closed live jcastaneda
#23661 THEME: HappenStance – 1.1.1 closed live jcastaneda
#24228 THEME: HappenStance – 1.1.2 closed live jacenty3590
#25276 THEME: HappenStance – 1.1.3 closed live karmatosed
#26386 THEME: HappenStance – 1.1.4 closed live rabmalin
#27683 THEME: HappenStance – 1.1.5 closed live emiluzelac
#28584 THEME: HappenStance – 2.0.0 closed live karmatosed
#29288 THEME: HappenStance – 2.0.1 closed live karmatosed
#29847 THEME: HappenStance – 2.0.2 closed live Otto42
#30757 THEME: HappenStance – 2.0.3 closed live jcastaneda
#31695 THEME: HappenStance – 2.0.4 closed live themetracbot
#32638 THEME: HappenStance – 2.0.5 closed live themetracbot
#33323 THEME: HappenStance – 2.0.6 closed live themetracbot
#34340 THEME: HappenStance – 2.0.7 closed live themetracbot
#36192 THEME: HappenStance – 2.0.8 closed live themetracbot
#36804 THEME: HappenStance – 2.0.9 closed live themetracbot
#43389 THEME: HappenStance – 3.0.0 closed live themetracbot
#43987 THEME: HappenStance – 3.0.1 closed live themetracbot


https://themes.svn.wordpress.org/happenstance/1.0.1/screenshot.png

#2 @themetracbot
3 years ago

  • Owner set to chellycat
  • Status changed from new to reviewing

#3 @chellycat
3 years ago

Howdy! My name is Michelle and I'll be reviewing your theme. :) Expect initial notes from me within the next few days.

#4 @tomastoman
3 years ago

Dear Michelle,

thank you for reviewing this theme! I am looking forward to your notes, hopefully there won't be too much issues in the theme. :-)

Best regards,
Tomas Toman

#5 @chellycat
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi @tomastoman,

I did a quick initial review, and it's looking good so far. I didn't see too many issues. Here are my notes:

BLOCKER:

  • Please remove Appearance > Install Plugins, as well as the “Begin Installing Plugins” link from the plugins admin notice. This is not allowed.

UNIT TEST / VISUAL (These are all suggestions)

  • Add padding to the footer so that the footer notices widget area doesn’t bump against the top of the container (https://cloudup.com/cJPXEN6J4bX). Checking “automatically add paragraphs” in the widget moves the text down, but IMO it should look “right” even if the box isn’t checked.
  • 404 page mentions “perhaps searching will help you find a related page” — what do you think about adding a search box below this? This is only a suggestion.

NEXT:

After you fix the one blocker above and upload a new version, I'll do a more in-depth review of the theme's options, code and settings. So far I'm not seeing major issues. :)

#6 @tomastoman
3 years ago

Dear Michelle,

thank you for your initial review! I would have one question about your blocker note. There are many themes in the repository which recommend installing some plugins (for example the Responsive theme). So far I thought that it only isn't allowed to install plugins which are directly bundled into the theme, but if they are installed from the wordpress.org plugins repository, it is allowed to attach them using the TGM-Plugin-Activation (like I did). Have the guidelines been recently changed please? I see no problem in removing the "Install Plugins" panel, I just wanted to make sure. :-)

Best regards,
Tomas Toman

Last edited 3 years ago by tomastoman (previous) (diff)

#7 @chellycat
3 years ago

It's fine to have the admin notice for recommended plugins, but the separate "Install Plugins" page and menu item are not allowed as per the guidelines. Themes aren't allowed to install or add anything to the Dashboard except for a Theme Options page.

Just linking to the plugins on the .org repository inside the admin notice is sufficient.

I hope this helps!

Cheers,
Michelle

#8 @tomastoman
3 years ago

Thank you! Here is the new ticket with the updated version. I also have improved the output of additional CSS based on the Theme Options custom settings in functions/fe/headerdata.php.

Best regards,
Tomas Toman

Note: See TracTickets for help on using tickets.