WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#22072 closed theme (not-approved)

THEME: Codon - 1.1

Reported by: cardiganmedia Owned by: antsanchez
Priority: new theme Keywords: theme-codon
Cc: erjenkins1@…

Description

Codon - 1.0.1

A responsive, flexible framework built on Underscores and Foundation 5. Features a full customizer experience, with options for column posts, multiple headers, and much more. Use a child theme for advanced customization, or fork Codon for a custom project.

Theme URL - https://www.edwardrjenkins.com/themes/codon
Author URL - https://www.edwardrjenkins.com/

SVN - https://themes.svn.wordpress.org/codon/1.0.1
ZIP - https://wordpress.org/themes/download/codon.1.0.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#22072 THEME: Codon - 1.1 closed not-approved antsanchez

(this ticket)

#24075 THEME: Codon – 1.1.5 closed live poena


https://themes.svn.wordpress.org/codon/1.0.1/screenshot.png


Change History (28)

#1 @themetracbot
3 years ago

  • Summary changed from THEME: Codon - 1.0.1 to THEME: Codon - 1.0.2

Codon - 1.0.2

A responsive, flexible framework built on Underscores and Foundation 5. Features a full customizer experience, with options for column posts, multiple headers, and much more. Use a child theme for advanced customization, or fork Codon for a custom project.

Theme URL - https://www.edwardrjenkins.com/themes/codon
Author URL - https://www.edwardrjenkins.com/

SVN - https://themes.svn.wordpress.org/codon/1.0.2
ZIP - https://wordpress.org/themes/download/codon.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/codon/1.0.1&new_path=/codon/1.0.2

History:

Ticket Summary Status Resolution Owner
#22072 THEME: Codon - 1.1 closed not-approved antsanchez

(this ticket)

#24075 THEME: Codon – 1.1.5 closed live poena


https://themes.svn.wordpress.org/codon/1.0.2/screenshot.png

#2 @themetracbot
3 years ago

  • Summary changed from THEME: Codon - 1.0.2 to THEME: Codon - 1.0.3

Codon - 1.0.3

A responsive, flexible framework built on Underscores and Foundation 5. Features a full customizer experience, with options for column posts, multiple headers, and much more. Use a child theme for advanced customization, or fork Codon for a custom project.

Theme URL - https://www.edwardrjenkins.com/themes/codon
Author URL - https://www.edwardrjenkins.com/

SVN - https://themes.svn.wordpress.org/codon/1.0.3
ZIP - https://wordpress.org/themes/download/codon.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/codon/1.0.2&new_path=/codon/1.0.3

History:

Ticket Summary Status Resolution Owner
#22072 THEME: Codon - 1.1 closed not-approved antsanchez

(this ticket)

#24075 THEME: Codon – 1.1.5 closed live poena


https://themes.svn.wordpress.org/codon/1.0.3/screenshot.png

#3 @themetracbot
3 years ago

  • Summary changed from THEME: Codon - 1.0.3 to THEME: Codon - 1.0.4

Codon - 1.0.4

A responsive, flexible framework built on Underscores and Foundation 5. Features a full customizer experience, with options for column posts, multiple headers, and much more. Use a child theme for advanced customization, or fork Codon for a custom project.

Theme URL - https://www.edwardrjenkins.com/themes/codon
Author URL - https://www.edwardrjenkins.com/

SVN - https://themes.svn.wordpress.org/codon/1.0.4
ZIP - https://wordpress.org/themes/download/codon.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/codon/1.0.3&new_path=/codon/1.0.4

History:

Ticket Summary Status Resolution Owner
#22072 THEME: Codon - 1.1 closed not-approved antsanchez

(this ticket)

#24075 THEME: Codon – 1.1.5 closed live poena


https://themes.svn.wordpress.org/codon/1.0.4/screenshot.png

#4 @antsanchez
3 years ago

  • Owner set to antsanchez
  • Status changed from new to reviewing

#5 @antsanchez
3 years ago

Hello cardiganmedia, you have created a good theme. There are however a few issues which need to be fixed:

  • Validate and sanitze untrusted data before entering into the database. All untrusted data should be escaped before output.
    • For instance, you dind't escape that "echo get_theme_mod (codon-topbar-logo)" in header, line 37.
    • What is the codon_mod_validation() supposed to do? It is empty!
  • All theme strings are to be translatable
    • For instance, the "MENU" word in header.php, line 42
  • Remove code for creating custom boxes from functions.php, that is plugin territory
  • Remove empty/non-used files
    • For instance, rtl.css
  • Declare licenses of any resources included such as fonts or images.

#6 @antsanchez
3 years ago

I will close the ticket tomorrow due to inactivity if there is no answer. It has been 7 days without answer.

#7 @cardiganmedia
3 years ago

Hi, sorry, I will work these changes tonight.

#8 @themetracbot
3 years ago

  • Summary changed from THEME: Codon - 1.0.4 to THEME: Codon - 1.0.5

Codon - 1.0.5

A responsive, flexible framework built on Underscores and Foundation 5. Features a full customizer experience, with options for column posts, multiple headers, and much more. Use a child theme for advanced customization, or fork Codon for a custom project.

Theme URL - https://www.edwardrjenkins.com/themes/codon
Author URL - https://www.edwardrjenkins.com/

SVN - https://themes.svn.wordpress.org/codon/1.0.5
ZIP - https://wordpress.org/themes/download/codon.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/codon/1.0.4&new_path=/codon/1.0.5

History:

Ticket Summary Status Resolution Owner
#22072 THEME: Codon - 1.1 closed not-approved antsanchez

(this ticket)

#24075 THEME: Codon – 1.1.5 closed live poena


https://themes.svn.wordpress.org/codon/1.0.5/screenshot.png

#9 @themetracbot
3 years ago

  • Summary changed from THEME: Codon - 1.0.5 to THEME: Codon - 1.0.6

Codon - 1.0.6

A responsive, flexible framework built on Underscores and Foundation 5. Features a full customizer experience, with options for column posts, multiple headers, and much more. Use a child theme for advanced customization, or fork Codon for a custom project.

Theme URL - https://www.edwardrjenkins.com/themes/codon
Author URL - https://www.edwardrjenkins.com/

SVN - https://themes.svn.wordpress.org/codon/1.0.6
ZIP - https://wordpress.org/themes/download/codon.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/codon/1.0.5&new_path=/codon/1.0.6

History:

Ticket Summary Status Resolution Owner
#22072 THEME: Codon - 1.1 closed not-approved antsanchez

(this ticket)

#24075 THEME: Codon – 1.1.5 closed live poena


https://themes.svn.wordpress.org/codon/1.0.6/screenshot.png

#10 @cardiganmedia
3 years ago

Good evening.

I have removed the meta_box and associated post_extras theme mod as requested.

The rtl.css is useful for RTL folks, and since the theme includes some RTL language packs, I feel it's necessary to keep. I did un-comment the CSS, so it's not an empty file.

All bundled elements are accounted for in license.html.

I just noticed that I forgot to handle the theme mod options sanitize callback. I will take care of that tomorrow.

#11 @themetracbot
3 years ago

  • Summary changed from THEME: Codon - 1.0.6 to THEME: Codon - 1.0.7

Codon - 1.0.7

A responsive, flexible framework built on Underscores and Foundation 5. Features a full customizer experience, with options for column posts, multiple headers, and much more. Use a child theme for advanced customization, or fork Codon for a custom project.

Theme URL - https://www.edwardrjenkins.com/themes/codon
Author URL - https://www.edwardrjenkins.com/

SVN - https://themes.svn.wordpress.org/codon/1.0.7
ZIP - https://wordpress.org/themes/download/codon.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/codon/1.0.6&new_path=/codon/1.0.7

History:

Ticket Summary Status Resolution Owner
#22072 THEME: Codon - 1.1 closed not-approved antsanchez

(this ticket)

#24075 THEME: Codon – 1.1.5 closed live poena


https://themes.svn.wordpress.org/codon/1.0.7/screenshot.png

#12 @cardiganmedia
3 years ago

Hi, my apologies for the delay. I've created sanitization callbacks for each theme mod in the latest version.

#13 @antsanchez
3 years ago

  • You forgot to escape untrusted data before output. I know that this data is sanitized, but it must also be escaped in output. Here are some examples where I found non escaped data:
    • Function codon_social_links()
    • logo.php, line 12
  • There are some minified scripts, what it is ok, as long as you include the non minified version too.
    • Modernizer.js
    • jquery.infinitescroll.js
    • Fastclick.js
    • jquery.cookie.js
  • Remove rtl.css, it is not being used.


#14 @themetracbot
3 years ago

  • Summary changed from THEME: Codon - 1.0.7 to THEME: Codon - 1.0.8

Codon - 1.0.8

A responsive, flexible framework built on Underscores and Foundation 5. Features a full customizer experience, with options for column posts, multiple headers, and much more. Use a child theme for advanced customization, or fork Codon for a custom project.

Theme URL - https://www.edwardrjenkins.com/themes/codon
Author URL - https://www.edwardrjenkins.com/

SVN - https://themes.svn.wordpress.org/codon/1.0.8
ZIP - https://wordpress.org/themes/download/codon.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/codon/1.0.7&new_path=/codon/1.0.8

History:

Ticket Summary Status Resolution Owner
#22072 THEME: Codon - 1.1 closed not-approved antsanchez

(this ticket)

#24075 THEME: Codon – 1.1.5 closed live poena


https://themes.svn.wordpress.org/codon/1.0.8/screenshot.png

#15 @cardiganmedia
3 years ago

Ok, I believe I took care of all instances of user-input ouput. Also, the only minified script left is the main Foundation JS file, but I added a non-minified version as well.

#16 @themetracbot
3 years ago

  • Summary changed from THEME: Codon - 1.0.8 to THEME: Codon - 1.0.9

Codon - 1.0.9

A responsive, flexible framework built on Underscores and Foundation 5. Features a full customizer experience, with options for column posts, multiple headers, and much more. Use a child theme for advanced customization, or fork Codon for a custom project.

Theme URL - https://www.edwardrjenkins.com/themes/codon
Author URL - https://www.edwardrjenkins.com/

SVN - https://themes.svn.wordpress.org/codon/1.0.9
ZIP - https://wordpress.org/themes/download/codon.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/codon/1.0.8&new_path=/codon/1.0.9

History:

Ticket Summary Status Resolution Owner
#22072 THEME: Codon - 1.1 closed not-approved antsanchez

(this ticket)

#24075 THEME: Codon – 1.1.5 closed live poena


https://themes.svn.wordpress.org/codon/1.0.9/screenshot.png

#17 @cardiganmedia
3 years ago

This latest version fixes a function typo in inc/template-tags.php

#18 @antsanchez
3 years ago

Remove the rtl-language-support tag from style.css and I will mark the theme as approved. There is only that issue.

#19 @themetracbot
3 years ago

  • Summary changed from THEME: Codon - 1.0.9 to THEME: Codon - 1.1

Codon - 1.1

A responsive, flexible framework built on Underscores and Foundation 5. Features a full customizer experience, with options for column posts, multiple headers, and much more. Use a child theme for advanced customization, or fork Codon for a custom project.

Theme URL - https://www.edwardrjenkins.com/themes/codon
Author URL - https://www.edwardrjenkins.com/

SVN - https://themes.svn.wordpress.org/codon/1.1
ZIP - https://wordpress.org/themes/download/codon.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/codon/1.0.9&new_path=/codon/1.1

History:

Ticket Summary Status Resolution Owner
#22072 THEME: Codon - 1.1 closed not-approved antsanchez

(this ticket)

#24075 THEME: Codon – 1.1.5 closed live poena


https://themes.svn.wordpress.org/codon/1.1/screenshot.png

#20 @cardiganmedia
3 years ago

The latest version removes the rtl tag. I also made a minor tweak to the main nav menu to make the sub-menus easier to navigate.

#21 @cardiganmedia
3 years ago

Are we good to go here?

#22 @antsanchez
3 years ago

  • Status changed from reviewing to approved

Hello @cardiganmedia,

Sorry for the delay, I was pretty busy and didn't see the update.

Everything is OK now, I will mark the ticket as approved.

#23 @cardiganmedia
3 years ago

Cool. Thanks.

#24 @cardiganmedia
3 years ago

This theme has been approved for a couple of weeks. When will it be live?

#25 @poena
3 years ago

Hi!
Here are a few things you need to update before your theme can go live:

The admin notice is not allowed and needs to be removed.

-Missing copyright for the theme itself (You need to include both copyright and license).

In customizer.php, the On and Off texts needs to be translatable.


Recommended:
You don't need to register your scripts before you enqueue them.

It looks like the path to images/loader.gif is not working, I'm seeing a broken image.


#26 @cardiganmedia
3 years ago

@poena, I made these changes, fixed a couple of other things, and uploaded the new version. For some reason, it seems to have created a new ticket. Can you check on that?

Also, I could not replicate an issue with the loader graphic -- I tried on two different dev spaces.

#27 @poena
3 years ago

  • Status changed from approved to reopened

closing this ticket since the theme is already live

#28 @poena
3 years ago

  • Resolution set to not-approved
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.