WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#22142 closed theme (not-approved)

THEME: Midway - 1.1.3

Reported by: tytus-tytus Owned by: ryelle
Priority: previously reviewed Keywords: theme-midway
Cc: tytus@…

Description

Midway - 1.1.3

Midway Template - A page template designed to meet the needs of even the most demanding users, full support for SEO, clean and clear code, beautiful form, made using the Responsive Web Design technique, and that's not all. It has been designed to enable adapting it to any need - with full Wordpress support, creating new pages is very simple, and the support for popular plugins makes adding new functionalities dead easy.

Theme URL - http://midway.tidio.net/
Author URL - http://www.tidioelements.com/

SVN - https://themes.svn.wordpress.org/midway/1.1.3
ZIP - https://wordpress.org/themes/download/midway.1.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/midway/1.1.2&new_path=/midway/1.1.3

History:

Ticket Summary Status Resolution Owner
#19035 THEME: Midway - Onepage | Responsive Multi-Purpose Theme - 1.1.0 closed not-approved emiluzelac
#19065 THEME: Midway - 1.1.0 closed not-approved karmatosed
#19643 THEME: Midway - 1.1.1 closed not-approved crondeau
#21434 THEME: Midway - 1.1.2 closed not-approved couturefreak
#22142 THEME: Midway - 1.1.3 closed not-approved ryelle

(this ticket)


https://themes.svn.wordpress.org/midway/1.1.3/screenshot.png

Change History (4)

#1 @ryelle
3 years ago

  • Owner set to ryelle
  • Status changed from new to reviewing

#2 @ryelle
3 years ago

Hi there! I'll get a full review to you in the next few days, but here are some things I've seen already:

REQUIRED

  • All theme text strings are to be translatable.
  • Use a single unique text domain, which should be your theme slug (midway).
  • Spell “WordPress” correctly in all public facing text: all one word, with both an uppercase W and P.
  • Include all scripts rather than hot-linking - you'll need to download and bundle Modernizr if you want to use it.

#3 @ryelle
3 years ago

Here's your full review. In addition to the 4 items in the previous comment, I've also found these issues:

REQUIRED

  • Attribute & declare licensing for all 3rd party resources in readme.txt: Modernizr, Bootstrap, Glyphicons, FontAwesome, your images (unless you created them), the HTML5 Shiv
  • Don't remove Open Sans, that is required for the admin bar, and shouldn't be loaded if you're logged out.
  • You're bypassing core filters by using echo do_shortcode(get_the_content());, just use the_content(); instead. Same with echo get_the_excerpt();, you should use the_excerpt(); instead.
  • You can use the_permalink(); instead of echo get_permalink(get_the_ID());. Shorter version of the same thing :) Check out this page for a full list of functions available, you're going the long way in a few places.
  • Comments should be available on pages too, it should be up to the user to disable them.
  • There are a lot of problems in comments.php:
    • modify_comment_form_fields required should have a unique prefix
    • modify_comment_form_fields recommended move into functions.php
    • Use your midway text domain, instead of vision.
    • Don't hide the Website field with CSS.
    • I recommend going over the defaults for comment_form(), and seeing what you can remove from $comments_args - I think you're over-engineering this part.

ISSUES

These are things that seem like bugs, and are recommended to fix - or at least respond to by commenting.

  • If a large header image is added, the alignment is thrown off, example. I was expecting this image to become the background image for the header -- replacing the green. If you don't want people uploading large images, then set a height & width when you add support.
  • Dropdowns don't seem to work. If that's by design, you can add 'depth' => -1 to wp_nav_menu, which flattens any menu used.
  • Is it intentional that the navigation is bold on single pages? example
  • You should probably change this footer text "© 2014 Neue. All Rights Reserved. Wordpress theme that would knock you out. Created by SPNOY." Are you Neue, or SPNOY? The content isn't copyright to you. I'd recommend just "Theme: Midway by Tidio", and you can link to http://www.tidioelements.com/.

I'd recommend checking out this how to make a theme tutorial. Another resource, if you'd rather dive straight into code, is the _s starter theme. Both of these links will have more resources & explanation about most of the points I brought up.

Let me know if you have any questions, and also let me know as you're working on this - the review will be closed if we don't hear from you for 7 days. Even just a quick "I'm still working" is enough to keep this ticket open.

#4 @ryelle
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Closing due to inactivity.

Note: See TracTickets for help on using tickets.