WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#22240 closed theme (live)

THEME: e.nigma 2015 – 1.0.14

Reported by: chemiker Owned by: poena
Priority: new theme Keywords: theme-e-nigma-2015 accessibility-ready
Cc:

Description

e.nigma 2015 - 1.0

e.nigma 2015 is a WordPress theme that was developed for the blog e.nigma. It is thought to be used with WordPress posts formats.

Theme URL - http://e.nigma.de/portfolio/enigma2015
Author URL - http://e.nigma.de

SVN - https://themes.svn.wordpress.org/e-nigma-2015/1.0
ZIP - https://wordpress.org/themes/download/e-nigma-2015.1.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/e-nigma-2015/1.0/screenshot.png


Change History (59)

#1 @chemiker
3 years ago

The update to Version 1.0.3 brings enhanced support for better customization.

Last edited 2 years ago by chemiker (previous) (diff)

#2 @themetracbot
2 years ago

  • Summary changed from THEME: e.nigma 2015 - 1.0 to THEME: e.nigma 2015 - 1.0.3

e.nigma 2015 - 1.0.3

e.nigma 2015 is a WordPress theme that was developed for the blog e.nigma. It is thought to be used with WordPress posts formats.

Theme URL - http://e.nigma.de/portfolio/enigma2015
Author URL - http://e.nigma.de

SVN - https://themes.svn.wordpress.org/e-nigma-2015/1.0.3
ZIP - https://wordpress.org/themes/download/e-nigma-2015.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/e-nigma-2015/1.0&new_path=/e-nigma-2015/1.0.3

History:


https://themes.svn.wordpress.org/e-nigma-2015/1.0.3/screenshot.png

#3 @themetracbot
2 years ago

  • Summary changed from THEME: e.nigma 2015 - 1.0.3 to THEME: e.nigma 2015 - 1.0.4

e.nigma 2015 - 1.0.4

e.nigma 2015 is a WordPress theme that was developed for the blog e.nigma. It is thought to be used with WordPress posts formats.

Theme URL - http://e.nigma.de/portfolio/enigma2015
Author URL - http://e.nigma.de

SVN - https://themes.svn.wordpress.org/e-nigma-2015/1.0.4
ZIP - https://wordpress.org/themes/download/e-nigma-2015.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/e-nigma-2015/1.0.3&new_path=/e-nigma-2015/1.0.4

History:


https://themes.svn.wordpress.org/e-nigma-2015/1.0.4/screenshot.png

#4 @themetracbot
2 years ago

  • Summary changed from THEME: e.nigma 2015 - 1.0.4 to THEME: e.nigma 2015 - 1.0.7

e.nigma 2015 - 1.0.7

e.nigma 2015 is a light-weight, modern and simple WordPress theme. It is thought to be used with WordPress posts formats.

Theme URL - http://e.nigma.de/portfolio/enigma2015
Author URL - http://e.nigma.de

SVN - https://themes.svn.wordpress.org/e-nigma-2015/1.0.7
ZIP - https://wordpress.org/themes/download/e-nigma-2015.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/e-nigma-2015/1.0.4&new_path=/e-nigma-2015/1.0.7

History:


https://themes.svn.wordpress.org/e-nigma-2015/1.0.7/screenshot.png

#5 @themetracbot
2 years ago

  • Summary changed from THEME: e.nigma 2015 - 1.0.7 to THEME: e.nigma 2015 - 1.0.8

e.nigma 2015 - 1.0.8

e.nigma 2015 is a light-weight, modern and simple WordPress theme. It is thought to be used with WordPress posts formats.

Theme URL - http://e.nigma.de/portfolio/enigma2015
Author URL - http://e.nigma.de

SVN - https://themes.svn.wordpress.org/e-nigma-2015/1.0.8
ZIP - https://wordpress.org/themes/download/e-nigma-2015.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/e-nigma-2015/1.0.7&new_path=/e-nigma-2015/1.0.8

History:


https://themes.svn.wordpress.org/e-nigma-2015/1.0.8/screenshot.png

#6 @themetracbot
2 years ago

  • Summary changed from THEME: e.nigma 2015 - 1.0.8 to THEME: e.nigma 2015 - 1.0.8.1

e.nigma 2015 - 1.0.8.1

e.nigma 2015 is a light-weight, modern and simple WordPress theme. It is thought to be used with WordPress posts formats.

Theme URL - http://e.nigma.de/portfolio/enigma2015
Author URL - http://e.nigma.de

SVN - https://themes.svn.wordpress.org/e-nigma-2015/1.0.8.1
ZIP - https://wordpress.org/themes/download/e-nigma-2015.1.0.8.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/e-nigma-2015/1.0.8&new_path=/e-nigma-2015/1.0.8.1

History:


https://themes.svn.wordpress.org/e-nigma-2015/1.0.8.1/screenshot.png

#7 @themetracbot
2 years ago

  • Summary changed from THEME: e.nigma 2015 - 1.0.8.1 to THEME: e.nigma 2015 - 1.0.9

e.nigma 2015 - 1.0.9

e.nigma 2015 is a light-weight, modern and simple WordPress theme. It is thought to be used with WordPress posts formats.

Theme URL - http://e.nigma.de/portfolio/enigma2015
Author URL - http://e.nigma.de

SVN - https://themes.svn.wordpress.org/e-nigma-2015/1.0.9
ZIP - https://wordpress.org/themes/download/e-nigma-2015.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/e-nigma-2015/1.0.8.1&new_path=/e-nigma-2015/1.0.9

History:


https://themes.svn.wordpress.org/e-nigma-2015/1.0.9/screenshot.png

#8 @themetracbot
2 years ago

  • Owner set to imranaliweb
  • Status changed from new to reviewing

#9 @chemiker
2 years ago

  • Keywords changed from theme-e-nigma-2015, accessibility-ready to theme-e-nigma-2015 accessibility-ready

Dear imranaliweb,

are you still reviewing the theme? Do you found any issues?

This ticket was mentioned in Slack in #themereview by chemiker. View the logs.


2 years ago

This ticket was mentioned in Slack in #themereview by chemiker. View the logs.


2 years ago

#12 @karmatosed
2 years ago

  • Cc gpriday added

This is just a note for the reviewer, you have been assigned a mentor to take you through your first reviews. Congratulations, you get gpriday as your mentor!

#13 @gpriday
2 years ago

Looking forward to mentoring you. You can catch me on WordPress Slack - I'm gpriday there too.

This ticket was mentioned in Slack in #themereview by chemiker. View the logs.


2 years ago

#15 @karmatosed
2 years ago

  • Owner changed from imranaliweb to limestreet

#16 @limestreet
2 years ago

  • Cc edward@… gpriday removed

Hi, this is my initial review.
When you address those issues and upload new version I'll check one more time.
I belive we make this theme live asap :)

REQUIRED

- licenses:

in style css is mentioned MIT license, but no link or license file...
nothing about fonts license / image license
license.txt is not gpl compatible
why apache license is bundled ?
Info:
https://make.wordpress.org/themes/handbook/review/required/#licensing

- functions.php

Add page class to Post pages
add_filter('wp_link_pages_link', function ($link) {

if ( strrpos($link, 'href') )

return str_replace("href", "class='page' href", $link);

return "<a href='".$_SERVERHTTP_HOST? . $_SERVERREQUEST_URI?."' class=\"active page\">" . $link . "</a>";

});

You should use body_class() instead:
http://codex.wordpress.org/Function_Reference/body_class

Prefixes - all custom functions should be prefixed with the theme_slug
Look here:
https://github.com/Automattic/_s/blob/master/functions.php

- header.php

Favicons - more:
https://make.wordpress.org/themes/handbook/review/required/#favicons

Fonts
Please enqueue Google fonts - can be like here:
https://themes.svn.wordpress.org/twentyfifteen/1.0/functions.php

- translation

Text domain is not defined and not used.
More info:
http://codex.wordpress.org/I18n_for_WordPress_Developers

OTHER:

  • style.css

why are you importing screen.css??
better solution is to enqueue stylesheet.

Best

Patryk

#17 @limestreet
2 years ago

Nearly all my yesterday mentioned issues are still valid :)
Additionally:

Required:

  • translation

Instead of po/mo files you should add .pot file
More info:
http://codex.wordpress.org/I18n_for_WordPress_Developers

in footer.php
string "and" is not translation ready :)

  • header.php

home_url should be escaped:
<?php echo esc_url( home_url( '/' ) ); ?>

  • functions.php

If you enqueue google fonts please don't use protocol - new browsers are smart enough:
wp_enqueue_style( 'google-fonts', 'fonts.googleapis.com/css?family=Raleway:100%7CRoboto+Slab:400,700%7COpen+Sans:400italic,400,700' );

-functions.php and /functions

all custom functions should be properly prefixed
Example:
Add actions for customizer
add_action('customize_register', '\enigma\Customizer::register');
should be:
Add actions for customizer
add_action('customize_register', 'enigma_2015_custom_function');

and in customizer.php function definition:
enigma_2015_custom_function()

you can read more about:
http://nacin.com/2010/05/11/in-wordpress-prefix-everything/

So I'm waiting for news from you

#18 @limestreet
2 years ago

one more thing - before google fonts url should be slashes but formating is eating them

#19 @limestreet
2 years ago

I got it: //fonts.googleapis.com/css?family=Raleway:100%7CRoboto+Slab:400,700%7COpen+Sans:400italic,400,700

#20 @chemiker
2 years ago

Dear Patryk,

thanks for your new review :) I have some questions regarding your feedback:

1) "all custom functions should be properly prefixed":

To do so I'm using namespaces. As you can see in my sourcecode I'm using a custom namespace "enigma". In the end this is the same as if I would have prefixed the functions. To the best of my knowledge the idea of prefixing the functions is that it prevents the WordPress instance to crash if a plugin provides a function with the same slug. This is exactly the purpose of namespaces.

2) "licenses":

I'm not sure what you mean by "not GPL compatible". To the best of my knowledge both the license of the theme (MIT) and the licenses of the libraries (CC, Apache) are GPL compatible. Btw: The copy of the Apache license is shipped because it is required to do so. In the license it is stated that a copy of the Apache license has to be shipped if any library or similar is used which is released under the Apache license.

All other issues are clear and I will address them in the next update.

#21 follow-up: @limestreet
2 years ago

Ad. 1. I'll check this with admins because it's first time when I see using namespace in WP repository :)

Ad. 2 licenses:

In style.css header is:
License: MIT
License URI: license.txt

But in license.txt is nothing about MIT license / enigma font license / image license.
I suppose that your theme is released under MIT but there is even no link to license.
Licenses should be very clear.

#22 in reply to: ↑ 21 @chemiker
2 years ago

Replying to limestreet:

Ad. 1. I'll check this with admins because it's first time when I see using namespace in WP repository :)

Ok, I see :)

Ad. 2 licenses:

In style.css header is:
License: MIT
License URI: license.txt

But in license.txt is nothing about MIT license / enigma font license / image license.

Well. The text in license.txt IS the MIT license text (see http://opensource.org/licenses/MIT).

Regarding the copyright for the fonts, etc. all copyright remarks (e.g. Icomoon (which is the "enigma icon font")) are listed below the MIT license text except for the google fonts. In an other ticket (https://themes.trac.wordpress.org/ticket/19283) I found that as the Google Fonts are not bundled with the theme I do not have to provide any copyright information for them.

Please tell me if I this must be seperated or something similar.

I suppose that your theme is released under MIT but there is even no link to license.
Licenses should be very clear.

#23 @limestreet
2 years ago

  • Cc greenshady added

OK @chemiker - so licenses should be ok.

Hi @greenshady - I need your expertise :)
Can you look at:
https://themes.svn.wordpress.org/e-nigma-2015/1.0.9/functions.php

I think it is not acceptable using namespace instead of prefixes like in this example:
add_action('customize_register', '\enigma\Customizer::register');

#24 @greenshady
2 years ago

Namespaces are fine and are acceptable in place of a prefix.

#25 @themetracbot
2 years ago

  • Summary changed from THEME: e.nigma 2015 - 1.0.9 to THEME: e.nigma 2015 - 1.0.10

e.nigma 2015 - 1.0.10

e.nigma 2015 is a light-weight, modern and simple WordPress theme. It is thought to be used with WordPress posts formats.

Theme URL - http://e.nigma.de/portfolio/enigma2015
Author URL - http://e.nigma.de

SVN - https://themes.svn.wordpress.org/e-nigma-2015/1.0.10
ZIP - https://wordpress.org/themes/download/e-nigma-2015.1.0.10.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/e-nigma-2015/1.0.9&new_path=/e-nigma-2015/1.0.10

History:


https://themes.svn.wordpress.org/e-nigma-2015/1.0.10/screenshot.png

#26 @chemiker
2 years ago

Dear Patryk,

I uploaded a new version of e.nigma 2015 which fixes all the issues that you found :)

Last edited 2 years ago by chemiker (previous) (diff)

#27 follow-up: @limestreet
2 years ago

  • Cc greenshady removed

Thanks @greenshady
Thanks @chemiker

Good job :)

From my side theme is ready for approving, but we must wait for accessibility-ready check

#28 in reply to: ↑ 27 @chemiker
2 years ago

Replying to limestreet:

Thanks @greenshady
Thanks @chemiker

Good job :)

From my side theme is ready for approving, but we must wait for accessibility-ready check

Thanks for the kind review :)

Is their anything I must do to get the accessibility-ready check started or will somebody join the ticket to do so?

#29 @limestreet
2 years ago

  • Cc joedolson added

I'll just ping some accessibility expert :)

@joedolson can you check this theme for accessibility?

Thanks
Patryk

#30 @joedolson
2 years ago

Will do. Probably on Monday. Thanks!

#31 follow-up: @joedolson
2 years ago

Accessibility Review:

1) Headings - Looks good!

2) ARIA Landmark Roles: Also looking good.

3) Link text: Looks good.

4) Controls: Look good.

5) Keyboard Navigation: A couple problems here. 1) Next page links have no keyboard focus state 2) If the search widget is enabled, it behaves *very* strangely - hard to describe 3) The main menu submenus are not keyboard accessible. Although there's a focusin/focusout event attached to the top level items, all it does is make the menus visible; you can't actually reach them with the keyboard.

6) Color Contrast: The search field is #494949 against #494949 when it's used as a widget in the footer. This is because the header search styles are being applied, but you shouldn't assume that a user won't want a search field in both locations.

7) Skip Links: Look good. Given this theme's menu location, the addition of a skip to navigation link was a good idea.

8) Forms: The search form has no label. Comment form looks fine.

9) Images: Some of the ornamental images in use (such as the enigma-icon "Information", the hamburger ornament in the footer, etc.) would benefit from the use of aria-hidden='true', so that they aren't read. Otherwise, fine.

10) Media: None observed.

11) Disallowed code: None found.

Recommend Accessibility features:

1) Zoomable: Most things are fine, but the site description is pushed into the content at large text sizes or with long site titles and the next page links start to lose their visible page numbers. Otherwise fine.

2) Generally looks good.

Thanks! I can see that a lot of conscientious attention has been paid to accessibility - there are still a few issues, but overall this has great potential.

#32 @themetracbot
2 years ago

  • Summary changed from THEME: e.nigma 2015 - 1.0.10 to THEME: e.nigma 2015 - 1.0.11

e.nigma 2015 - 1.0.11

e.nigma 2015 is a light-weight, modern and simple WordPress theme. It is thought to be used with WordPress posts formats.

Theme URL - http://e.nigma.de/portfolio/enigma2015
Author URL - http://e.nigma.de

SVN - https://themes.svn.wordpress.org/e-nigma-2015/1.0.11
ZIP - https://wordpress.org/themes/download/e-nigma-2015.1.0.11.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/e-nigma-2015/1.0.10&new_path=/e-nigma-2015/1.0.11

History:


https://themes.svn.wordpress.org/e-nigma-2015/1.0.11/screenshot.png

#33 in reply to: ↑ 31 @chemiker
2 years ago

First of all: @joedolson Thank you very much for your detailed feedback!

Replying to joedolson:

Accessibility Review:

1) Headings - Looks good!

2) ARIA Landmark Roles: Also looking good.

3) Link text: Looks good.

4) Controls: Look good.

5) Keyboard Navigation: A couple problems here. 1) Next page links have no keyboard focus state 2) If the search widget is enabled, it behaves *very* strangely - hard to describe 3) The main menu submenus are not keyboard accessible. Although there's a focusin/focusout event attached to the top level items, all it does is make the menus visible; you can't actually reach them with the keyboard.

I fixed the menu and focus issues. I'm not sure what you mean by "behaves strangely". I rechecked everything and cannot find any "strange" behavior. Can you describe what is exactly strange?

6) Color Contrast: The search field is #494949 against #494949 when it's used as a widget in the footer. This is because the header search styles are being applied, but you shouldn't assume that a user won't want a search field in both locations.

Fixed in 1.0.11.

7) Skip Links: Look good. Given this theme's menu location, the addition of a skip to navigation link was a good idea.

8) Forms: The search form has no label. Comment form looks fine.

Fixed in 1.0.11.

9) Images: Some of the ornamental images in use (such as the enigma-icon "Information", the hamburger ornament in the footer, etc.) would benefit from the use of aria-hidden='true', so that they aren't read. Otherwise, fine.

Added this attribute in 1.0.11. Thanks for pointing this out!

10) Media: None observed.

11) Disallowed code: None found.

Recommend Accessibility features:

1) Zoomable: Most things are fine, but the site description is pushed into the content at large text sizes or with long site titles and the next page links start to lose their visible page numbers. Otherwise fine.

I added some CSS tweaks which should improve the user experience with large text sizes.

2) Generally looks good.

Thanks! I can see that a lot of conscientious attention has been paid to accessibility - there are still a few issues, but overall this has great potential.

Again, thanks for your review. It would be very cool if you could review the recent version (1.0.11) again to check if all issues are fixed :)

Last edited 2 years ago by chemiker (previous) (diff)

#34 follow-up: @joedolson
2 years ago

The search widget thing was very strange - I was getting multiple tab stops for the search, but it wasn't clear why, since there wasn't anything to focus on. Odd :focus states, but that was largely because the field itself was only visible when focused, due to the CSS.

I'll re-review shortly. Thanks!

#35 in reply to: ↑ 34 @chemiker
2 years ago

Replying to joedolson:

The search widget thing was very strange - I was getting multiple tab stops for the search, but it wasn't clear why, since there wasn't anything to focus on. Odd :focus states, but that was largely because the field itself was only visible when focused, due to the CSS.

I just checked that again. I think there is a minor bug? that focuses the <li> parent to the input field. To be honest I do not have any idea what causes this behavior. In the top "menu-bar" a similar behavior is not observable - even if it is a similar html markup…

I'll re-review shortly. Thanks!

Cool! :)

#36 @joedolson
2 years ago

So, the only remaining issues are:

1) The search forms have the same ID, which is an HTML validation error and can cause problems for accessibility. You should either use an wrapping label or write some code to modify the ID/for values for the search form. The best thing to do there is probably to fetch the widget ID if in use in a widget and append that to the ID and for value; the easiest thing would probably just be to use mt_rand().

2) That weird bug with the focus around the search form. If you can't find it, I wouldn't worry about it - I looked, but I couldn't see anything that would cause it, either.

Also, and this is just a recommendation, but I'd advise you to change your screen reader class to 'screen-reader-text' -- this is what WordPress is using in core, and will begin introducing into front-end produced code in WP 4.2. If you're using a different class name, your styles won't apply; although you can always declare both classes, if you need.

#37 @chemiker
2 years ago

@joedolson thanks for you rereview. I will correct the remaining issues in the next update. So from your remarks I conclude that from the accessibility-ready point of view the theme is ok (I think 1) is a general issue) and @limestreet can approve the theme once I fixed that last issue?

#38 @joedolson
2 years ago

#1 is a general issue that can impact accessibility; with that fixed, I'd consider the theme approved for accessibility-ready. Thank you!

#39 @themetracbot
2 years ago

  • Summary changed from THEME: e.nigma 2015 - 1.0.11 to THEME: e.nigma 2015 - 1.0.12

e.nigma 2015 - 1.0.12

e.nigma 2015 is a light-weight, modern and simple WordPress theme. It is thought to be used with WordPress posts formats.

Theme URL - http://e.nigma.de/portfolio/enigma2015
Author URL - http://e.nigma.de

SVN - https://themes.svn.wordpress.org/e-nigma-2015/1.0.12
ZIP - https://wordpress.org/themes/download/e-nigma-2015.1.0.12.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/e-nigma-2015/1.0.11&new_path=/e-nigma-2015/1.0.12

History:


https://themes.svn.wordpress.org/e-nigma-2015/1.0.12/screenshot.png

#40 @chemiker
2 years ago

@limestreet In version 1.0.12 you will find the last fixes that were required in order to make the theme accessibility-ready. As there should be no more issues please consider this theme to be approved :)

@joedolson Once again thanks for your review :)

#41 @joedolson
2 years ago

Approved for accessibility-ready based on diff. Thank you!

#42 @limestreet
2 years ago

  • Status changed from reviewing to approved

Thanks guys :)

#43 follow-up: @karmatosed
2 years ago

  • Status changed from approved to reopened

There is no need to enqueue jQuery can you remove that as soon as possible please?

#44 in reply to: ↑ 43 @chemiker
2 years ago

Replying to karmatosed:

There is no need to enqueue jQuery can you remove that as soon as possible please?

Actually I need jQuery for those two scripts: 'jquery-scrollupformenu' and 'jquery-enigma' (line 76/77, functions.php).

#45 follow-up: @limestreet
2 years ago

  • Cc karmatosed added

I think @karmatosed means doing it this way (use dependency):
http://codex.wordpress.org/Function_Reference/wp_enqueue_script#Link_a_Theme_Script_Which_Depends_on_jQuery

So in your theme:

function enigma_2015_scripts_init() {
wp_enqueue_script( 'bootstrap', get_template_directory_uri() . '/js/bootstrap.min.js', array('jquery') );
wp_enqueue_script( 'jquery-scrollupformenu', get_template_directory_uri().'/js/jquery.scrollupformenu.js', array('jquery') );
wp_enqueue_script( 'jquery-enigma', get_template_directory_uri() . '/js/jquery.enigma.js' , array('jquery'));
}

AFAIK bootstrap.js needs jquery too.

#46 @themetracbot
2 years ago

  • Summary changed from THEME: e.nigma 2015 - 1.0.12 to THEME: e.nigma 2015 – 1.0.13

e.nigma 2015 - 1.0.13

e.nigma 2015 is a light-weight, modern and simple WordPress theme. It is thought to be used with WordPress posts formats.

Theme URL - http://e.nigma.de/portfolio/enigma2015
Author URL - http://e.nigma.de

SVN - https://themes.svn.wordpress.org/e-nigma-2015/1.0.13
ZIP - https://wordpress.org/themes/download/e-nigma-2015.1.0.13.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=e-nigma-2015/1.0.12&new_path=e-nigma-2015/1.0.13

History:


https://themes.svn.wordpress.org/e-nigma-2015/1.0.13/screenshot.png

#47 in reply to: ↑ 45 @chemiker
2 years ago

Replying to limestreet:

I think @karmatosed means doing it this way (use dependency):
http://codex.wordpress.org/Function_Reference/wp_enqueue_script#Link_a_Theme_Script_Which_Depends_on_jQuery

So in your theme:

function enigma_2015_scripts_init() {
wp_enqueue_script( 'bootstrap', get_template_directory_uri() . '/js/bootstrap.min.js', array('jquery') );
wp_enqueue_script( 'jquery-scrollupformenu', get_template_directory_uri().'/js/jquery.scrollupformenu.js', array('jquery') );
wp_enqueue_script( 'jquery-enigma', get_template_directory_uri() . '/js/jquery.enigma.js' , array('jquery'));
}

AFAIK bootstrap.js needs jquery too.

Ah, I see. Good point! Thanks for pointing this out.

@karmatosed The new version fixes this issue.

#48 @limestreet
2 years ago

  • Status changed from reopened to approved

So I'm approving this theme again :)

This ticket was mentioned in Slack in #themereview by chemiker. View the logs.


2 years ago

This ticket was mentioned in Slack in #themereview by chemiker. View the logs.


2 years ago

This ticket was mentioned in Slack in #themereview by chemiker. View the logs.


2 years ago

This ticket was mentioned in Slack in #themereview by chemiker. View the logs.


2 years ago

#53 @poena
2 years ago

  • Status changed from approved to reopened

#54 @poena
2 years ago

  • Owner changed from limestreet to poena
  • Status changed from reopened to reviewing

#55 @poena
2 years ago

  • Cc joedolson karmatosed removed

Themes are required to use WordPress functionality and features first, if available.
Header.php: Search forms must be called using get_search_form().
(You can still use the class to edit your form)

Functions.php:
This is not allowed: remove_action('wp_head', 'wp_generator');

add_theme_support needs to be initiated with after_setup_theme. Create a new function that holds all the add_theme_support as well as load_theme_textdomain and register_nav_menus.

example:

function custom_theme_setup() {
	add_theme_support( $feature, $arguments );
}
add_action( 'after_setup_theme', 'custom_theme_setup' );

See https://codex.wordpress.org/Function_Reference/add_theme_support
https://codex.wordpress.org/Function_Reference/load_theme_textdomain

These licenses below are not GPL compatible. The only creative commons license that is compatible is CC0.

IcoMoon (Free) - (C) keyamoon.com
is released under Creative Commons 4.0 (http://creativecommons.org/licenses/by/4.0/)

Linecons - (C) Sergey Shmidt
is released under Creative Commons Attribution-ShareAlike 3.0 United States (http://creativecommons.org/licenses/by-sa/3.0/us/)

Entypo - (C) Daniel Bruce
is released under Creative Commons Attribution-ShareAlike 3.0 United States (http://creativecommons.org/licenses/by-sa/3.0/us/)


RECOMMENDED: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

You have added a editor-style.css file but you are not loading it?

#56 @themetracbot
2 years ago

  • Summary changed from THEME: e.nigma 2015 – 1.0.13 to THEME: e.nigma 2015 – 1.0.14

e.nigma 2015 - 1.0.14

e.nigma 2015 is a light-weight, modern and simple WordPress theme. It is thought to be used with WordPress posts formats.

Theme URL - http://e.nigma.de/portfolio/enigma2015
Author URL - http://e.nigma.de

SVN - https://themes.svn.wordpress.org/e-nigma-2015/1.0.14
ZIP - https://wordpress.org/themes/download/e-nigma-2015.1.0.14.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=e-nigma-2015/1.0.13&new_path=e-nigma-2015/1.0.14

History:


https://themes.svn.wordpress.org/e-nigma-2015/1.0.14/screenshot.png

#57 @chemiker
2 years ago

Dear poena,

thanks again for your feedback.

The current version addresses all issues that were found during your review.

I decided to not include an editor style as my theme does not style the content of the editor much differently compared to the default style. Maybe I decide to include editor styling in a future update but for know the theme does not support this feature.

#58 @poena
2 years ago

  • Resolution set to live
  • Status changed from reviewing to closed

I've found no more issues.

Note: I did not test accessibility since Joe has reviewed and approved that part, but I think the footer menu could use some more contrast. The text color that is used when you hover over the links (and there are no sub menus) is very close to the background color.

#59 @chemiker
2 years ago

Dear Poena,

thank you very much for your fast feedback!

The contrast in the Footer is technically high enough. I tested it with the Juicy Studio Accessibility Toolbar which is the one which is recommended to test the contrast ratio. As Joe already approved the theme for accessibility it will be alright I think.

Thanks again for your feedback :)

Note: See TracTickets for help on using tickets.