WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#22516 closed theme (live)

THEME: Tally Framework - 0.8.8.1

Reported by: tallythemes Owned by: karmatosed
Priority: theme update Keywords: theme-tally-framework
Cc: admin@…

Change History (14)

#1 @themetracbot
3 years ago

  • Summary changed from THEME: Tally Framework - 0.8.8.0 to THEME: Tally Framework - 0.8.8.1

#2 @karmatosed
3 years ago

  • Owner set to karmatosed
  • Status changed from new to reviewing

Thanks for the update. Based on the diff, I am going to approve this version.

#3 @karmatosed
3 years ago

  • Resolution set to live
  • Status changed from reviewing to closed

#4 @emiluzelac
3 years ago

@tallythemes please remove this https://themes.svn.wordpress.org/tally-framework/0.8.8.1/demo/theme-options.php from your theme as soon as possible to avoid theme suspension! We do not allow any type of code encryption.

#5 @emiluzelac
3 years ago

Also, note to future reviewer, full review is required.

#6 @emiluzelac
3 years ago

Since the same was used in 8 more themes by the same author, I am going to suspend the theme till issues are resolved.

#7 @tallythemes
3 years ago

@emiluzelac is php array serialize unserialize allowed.

#8 @emiluzelac
3 years ago

No it's not. All themes hosted here must be clear and readable, no code obstruction of any kind is allowed.

#9 @tallythemes
3 years ago

okay, so what is the best way to create a default option data. The file will supply an array. See the image below. This is the default option data. For example logo URL, font color etc.

http://i.imgur.com/xE7g5E9.png

OR will I have to create a full PHP array?

#10 @emiluzelac
3 years ago

Correct full PHP. Also see http://codex.wordpress.org/Theme_Customization_API

All must be validated and sanitized and with sanity in mind.

#11 @tallythemes
3 years ago

@emiluzelac I have updated the theme here https://themes.trac.wordpress.org/ticket/23037 with the changes you asked.

#12 @emiluzelac
3 years ago

There are few tickets before yours and as soon as #23037 reaches the top, a reviewer will go over the update.

#13 @emiluzelac
3 years ago

P.S. When #23037 is approved, please ping me so that I can manually unsuspend as well.

#14 @tallythemes
3 years ago

@emiluzelac #23037 is approved and live can you please unsuspected the theme.

Note: See TracTickets for help on using tickets.