WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

Last modified 23 months ago

#22632 closed theme (not-approved)

THEME: Kicoe – 1.4

Reported by: kicoe Owned by: poena
Priority: new theme Keywords: theme-kicoe
Cc: mr.kicoe@…

Attachments (1)

kicoe.zip (890.4 KB) - added by kicoe 2 years ago.
Update version of the theme with some corrections in it, among which the adress of the demo website

Download all attachments as: .zip

Change History (27)

#1 @kicoe
2 years ago

The theme has a built-in widget for displaying the profile you can see on the sidebar.
besides, it has a "resume" page template optimised to display the result of the use of the plugin Wordpress Resume Shortcode.

#2 @kicoe
2 years ago

Hi,
Appologies, this theme was not quite ready to be submitted... Please ignore this !

@kicoe
2 years ago

Update version of the theme with some corrections in it, among which the adress of the demo website

#3 in reply to: ↑ description @kicoe
2 years ago

Replying to kicoe:

Kicoe - 1.0

Description

Theme URL - http://www.patrickroux.fr

Theme URL is updated to http://patrickroux.fr/wpthemes/kicoe/

#4 follow-up: @ZGani
2 years ago

Please upload a revised version via: https://wordpress.org/themes/upload/ as we can not work attacments.

Plus theme url can not be a mere demo site - the content must be relevant to the theme.

In addition, the readme file shoul reflect the theme under review. You must also declare the theme copyright either in the readme file or in the head of style.css.

This not a review! Just a heads up before the theme is picked up for review.

#5 @themetracbot
2 years ago

  • Summary changed from THEME: Kicoe - 1.0 to THEME: Kicoe - 1.1

Kicoe - 1.1

Kicoe is a fully responsive personal template : Colorful blog, curriculum vitae, simple content pages and personnal branding. It just keeps it simple and efficient.

Theme URL - http://wpthemes.patrickroux.fr/kicoe
Author URL - http://www.patrickoux.fr

SVN - https://themes.svn.wordpress.org/kicoe/1.1
ZIP - https://wordpress.org/themes/download/kicoe.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/kicoe/1.0&new_path=/kicoe/1.1

History:

Ticket Summary Status Resolution Owner
#22632 THEME: Kicoe – 1.4 closed not-approved poena

(this ticket)

#26301 THEME: Kicoe – 1.8 closed live kevinhaig


https://themes.svn.wordpress.org/kicoe/1.1/screenshot.png

#6 in reply to: ↑ 4 @kicoe
2 years ago

Replying to ZGani:

Please upload a revised version via: https://wordpress.org/themes/upload/ as we can not work attacments.

Plus theme url can not be a mere demo site - the content must be relevant to the theme.

In addition, the readme file shoul reflect the theme under review. You must also declare the theme copyright either in the readme file or in the head of style.css.

This not a review! Just a heads up before the theme is picked up for review.

Thanks a lot for your heads up, I did not know it was possible to upload a new version like this, it's done ! I alos corrected the readme file and the style.css one. It should be all good now.

#7 @themetracbot
2 years ago

  • Owner set to Anibesh
  • Status changed from new to reviewing

#8 follow-up: @Anibesh
2 years ago

Hello @kicoe,

Still can't find readme.txt and license.txt. Please fix below issues and resubmit new version of the theme.

readme.txt - you're missing your readme.txt which should include information about your theme, and guidelines on how to use all of your theme specific options.

license.txt - you need to add licensing information to a license.txt file or to your readme.txt file. This file needs to include licensing info for any scripts being used by your theme (can't see any) and the images in your screenshot.

Thanks,
Anibesh

Last edited 2 years ago by Anibesh (previous) (diff)

#9 @themetracbot
2 years ago

  • Summary changed from THEME: Kicoe - 1.1 to THEME: Kicoe - 1.2

Kicoe - 1.2

Kicoe is a fully responsive personal template : Colorful blog, curriculum vitae, simple content pages and personnal branding. It just keeps it simple and efficient.

Theme URL - http://wpthemes.patrickroux.fr/kicoe
Author URL - http://www.patrickoux.fr

SVN - https://themes.svn.wordpress.org/kicoe/1.2
ZIP - https://wordpress.org/themes/download/kicoe.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/kicoe/1.1&new_path=/kicoe/1.2

History:

Ticket Summary Status Resolution Owner
#22632 THEME: Kicoe – 1.4 closed not-approved poena

(this ticket)

#26301 THEME: Kicoe – 1.8 closed live kevinhaig


https://themes.svn.wordpress.org/kicoe/1.2/screenshot.png

#10 in reply to: ↑ 8 @kicoe
2 years ago

Replying to Anibesh:

Hello @kicoe,

Still can't find readme.txt and license.txt. Please fix below issues and resubmit new version of the theme.

readme.txt - you're missing your readme.txt which should include information about your theme, and guidelines on how to use all of your theme specific options.

license.txt - you need to add licensing information to a license.txt file or to your readme.txt file. This file needs to include licensing info for any scripts being used by your theme (can't see any) and the images in your screenshot.

Thanks,
Anibesh

Thank you,

I understood that I was able to put all these informations in the readme.md and style.css. I created the files you requested and uploaded it.

Regards,

Patrick

#11 follow-up: @Anibesh
2 years ago

Hello kicoe,
readme.txt file missing licenses brief. Please fix below issues and resubmit new version of the theme.

license.txt - you need to add licensing information to a license.txt file or to your readme.txt file. This file needs to include licensing info for any scripts being used by your theme (can't see any) and the images in your screenshot.

Please find the attached image as example:

http://content.screencast.com/users/Anibesht/folders/Jing/media/9ad6a0e2-5c5f-44d0-817c-0f1577691288/2015-02-19_0346.png

changelog.txt - Themes are recommended to include a changelog, indicating version-to-version Theme changes.

Thanks,
Anibesh

#12 @themetracbot
2 years ago

  • Summary changed from THEME: Kicoe - 1.2 to THEME: Kicoe - 1.3

Kicoe - 1.3

Kicoe is a fully responsive personal template : Colorful blog, curriculum vitae, simple content pages and personnal branding. It just keeps it simple and efficient.

Theme URL - http://wpthemes.patrickroux.fr/kicoe
Author URL - http://www.patrickoux.fr

SVN - https://themes.svn.wordpress.org/kicoe/1.3
ZIP - https://wordpress.org/themes/download/kicoe.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/kicoe/1.2&new_path=/kicoe/1.3

History:

Ticket Summary Status Resolution Owner
#22632 THEME: Kicoe – 1.4 closed not-approved poena

(this ticket)

#26301 THEME: Kicoe – 1.8 closed live kevinhaig


https://themes.svn.wordpress.org/kicoe/1.3/screenshot.png

#13 in reply to: ↑ 11 @kicoe
2 years ago

Replying to Anibesh:

Hello kicoe,
readme.txt file missing licenses brief. Please fix below issues and resubmit new version of the theme.

license.txt - you need to add licensing information to a license.txt file or to your readme.txt file. This file needs to include licensing info for any scripts being used by your theme (can't see any) and the images in your screenshot.

Please find the attached image as example:

http://content.screencast.com/users/Anibesht/folders/Jing/media/9ad6a0e2-5c5f-44d0-817c-0f1577691288/2015-02-19_0346.png

changelog.txt - Themes are recommended to include a changelog, indicating version-to-version Theme changes.

Thanks,
Anibesh

Hi anibesh,

Thanks for your advices. I fixed the readme.txt file by adding the information you requested. Also added the changelog.txt.

Patrick

Last edited 2 years ago by kicoe (previous) (diff)

#14 follow-ups: @Anibesh
2 years ago

@kicoe,
Sorry for delay.
Please fix below issues and resubmit new version of the theme.

Required
==============
Change “text-domain” to the slug of your theme.
License of Images used on Screenshot. For example above comment attached image last line.
function.php - No need to enqueue_script "kicoe-jquery"
function.php - Remove unused code and comments.

Screenshot of site when theme is installed.

http://content.screencast.com/users/Anibesht/folders/Jing/media/0ffc8831-46a8-4f62-909f-4da6b13c3af1/front-page-screenshot.png
http://content.screencast.com/users/Anibesht/folders/Jing/media/e38cac61-8d75-47d0-a6b4-d8afb1127acc/sidebar-image-scroll.png
http://content.screencast.com/users/Anibesht/folders/Jing/media/e589cabd-fe65-434f-9155-c0f60694ff4b/theme-check-plugin.png

Thanks,
Anibesh

#15 in reply to: ↑ 14 @kicoe
2 years ago

Thank you Anibesh for your review.

I don't however understand the problem with the screenshots. Countless featured theme on wordpress.org do not show a screenshot even close to the freshly installed theme. See for yourself : https://wordpress.org/themes/. Why should it be different here ?

I modified it for the purpose of the validation, but I don't understand the reasons.

As for the rest of the points :
Change "text-domain" to the slug of your theme
=> It was already done. The only difference was the case. Is it case sensitive ? I changed Kicoe to kicoe.

License of Images used on Screenshot. For example above comment attached image last line.
=> No license needed, since no image is used now, but the few icons or the background I created myself. But let's say there is, where should I put this info ?

function.php - No need to enqueue_script "kicoe-jquery"
=> The default jquery which comes with wordpress is outdated. I modified the call using wp_deregister_script('jquery') first.

function.php - Remove unused code and comments.
=> If we are talking about commented code, done.

Thank you again,

Patrick

Replying to Anibesh:

@kicoe,
Sorry for delay.
Please fix below issues and resubmit new version of the theme.

Required
==============
Change “text-domain” to the slug of your theme.
License of Images used on Screenshot. For example above comment attached image last line.
function.php - No need to enqueue_script "kicoe-jquery"
function.php - Remove unused code and comments.

Screenshot of site when theme is installed.

http://content.screencast.com/users/Anibesht/folders/Jing/media/0ffc8831-46a8-4f62-909f-4da6b13c3af1/front-page-screenshot.png
http://content.screencast.com/users/Anibesht/folders/Jing/media/e38cac61-8d75-47d0-a6b4-d8afb1127acc/sidebar-image-scroll.png
http://content.screencast.com/users/Anibesht/folders/Jing/media/e589cabd-fe65-434f-9155-c0f60694ff4b/theme-check-plugin.png

Thanks,
Anibesh

#16 @themetracbot
2 years ago

  • Summary changed from THEME: Kicoe - 1.3 to THEME: Kicoe – 1.4

Kicoe - 1.4

Kicoe is a fully responsive personal template : Colorful blog, curriculum vitae, simple content pages and personnal branding. It just keeps it simple and efficient.

Theme URL - http://wpthemes.patrickroux.fr/kicoe
Author URL - http://www.patrickoux.fr

SVN - https://themes.svn.wordpress.org/kicoe/1.4
ZIP - https://wordpress.org/themes/download/kicoe.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=kicoe/1.3&new_path=kicoe/1.4

History:

Ticket Summary Status Resolution Owner
#22632 THEME: Kicoe – 1.4 closed not-approved poena

(this ticket)

#26301 THEME: Kicoe – 1.8 closed live kevinhaig


https://themes.svn.wordpress.org/kicoe/1.4/screenshot.png

#17 in reply to: ↑ 14 @kicoe
2 years ago

Replying to Anibesh:

Hi Anibesh,

Did you get a chance to have a look on the changes I have made ?

Thanks,

Patrick

#18 in reply to: ↑ 14 @kicoe
2 years ago

Replying to Anibesh:

Hello Anibesh,

Did you get a chance to look at the several modifications ?

Thank you for your feedback.

Patrick

#19 @kicoe
2 years ago

Hello there?

#20 @kicoe
2 years ago

Knock knock :)

#21 @poena
2 years ago

I can continue this review.

#22 @poena
2 years ago

Hi!
Your theme has been checked against the following guidelines:
https://make.wordpress.org/themes/handbook/review/

This is not a complete review. Please fix the required issues below and I will continue.


REQUIRED

Please remove the rtl stylesheet and the commented code in functions.php.

Please remove the MACOSX folder

Licence:
You are stating that you are using GPL v3, but GPl v2 is included in license.txt. Please pick one.

As the previous reviewer has tried to explain, you also need to included a source and license for the images used in the screenshot. The entire theme needs to be GPL compatible.
Celebrity photos are not likely to be GPL compatible or suitable, since GPL allows users to use the theme commercially.

Prefixing:
Please prefix your thumbnail sizes.
There are also several functions that needs to be prefixed with your theme slug.

Escaping:
You must escape the options in your custom widget.

Links need to be escaped with esc_url(), including:

home_url( '/' ); 
<a href="<?php echo $instance['profilegoogleplus'];

Attributes should be escaped with esc_attr().

See https://codex.wordpress.org/Validating_Sanitizing_and_Escaping_User_Data

Scripts:
You are not allowed to deregeister jquery and include your own version. Don't forget to delete the jquery files that are in the assests/js folder.
When minified scripts are used, the original, unminified script needs to be included aswell.

This is not allowed and needs to be removed:
remove_filter( 'the_content', 'wpautop' );

Plugin territory:
parse_shortcode_content() needs to be removed.
Themes are for presenting content, not for functionality.
Social sharing. The theme can include links to the users social pages, but not social sharing, this is plugin territory.

Language and translation:
Your language file is still referring to underscores, please update it.
ALL theme text strings need to be translatable.
-Your theme needs to be in one language. It doesn't matter if the langauge is french or english, but please choose one.

#23 @grapplerulrich
2 years ago

  • Owner changed from Anibesh to poena

#24 @poena
2 years ago

Hi, do you want to post an update? Otherwise I will need to close the ticket as not approved.

#25 follow-up: @poena
2 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Submit an update when you are ready.

#26 in reply to: ↑ 25 @kicoe
23 months ago

Replying to poena:

Submit an update when you are ready.

Thank you, I have uplaoded a new version on the ticket #26301

Note: See TracTickets for help on using tickets.