WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#22649 closed theme (not-approved)

THEME: Shelby - 1.0

Reported by: 65_Falcon Owned by: selenastrain
Priority: new theme Keywords: theme-shelby
Cc: cmaraglio@…

Description

Change History (4)

#1 @themetracbot
3 years ago

  • Owner set to selenastrain
  • Status changed from new to reviewing

#2 @selenastrain
3 years ago

You can look through http://underscores.me/ and http://codex.wordpress.org/Theme_Unit_Test to see what should be added and updated to this theme. Below are the changes needed that are required and some additional notes.

Required:

  • The Theme URI but the link is not a working link
  • There are two different theme slugs being used for translatable strings - Shelby and wppthemecustomizer - need to use one, also if the theme is going to be translatable then all text strings need to be properly formatted and a text domain should be included in style.css
  • The screenshot should be of the actual theme as it appears with default options - the current screenshot only shows the top portion of the header
  • No minification of scripts or files unless original files are provided - /css/style.css is minified and no original is provided - please include the original file preferably in style.css
  • Documentation is required for custom features and limitations
    • In functions.php: There is strip_shortcode_gallery which needs documenting
    • The page template files that were included need to be documented
    • The nav menus should have documentation explaining that drop down menus are not supported since using them breaks the layout, you can also set the depth to -1 in the options when calling wp_nav_menu - see http://codex.wordpress.org/Function_Reference/wp_nav_menu

Notes:

  • The readme.txt needs more information specifically for any custom functionality and any special set up requirements
  • A proper theme setup function should be used and hooked into the after_setup_theme action
  • In header.php, wp_title can be removed since theme support for the title_tag has been added in the functions file - again you can look through the _s theme mentioned above

There are a lot of styling and functionality issues with this theme, please start with what's stated above and then thoroughly test the theme to make sure everything works and looks as its intended to. Then you can upload the theme again to continue your review.

#3 @65_Falcon
3 years ago

You can close this ticket. I am going to take a step back and ensure the theme's I submit are of better quality. Thanks.

#4 @selenastrain
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Closing ticket as requested.

Note: See TracTickets for help on using tickets.