WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#23024 closed theme (not-approved)

THEME: Hercules - 1.0

Reported by: wiloke Owned by: irenem
Priority: new theme Keywords: theme-hercules
Cc: piratesmorefun@…

Change History (5)

#1 @themetracbot
3 years ago

  • Owner set to pramodpandey
  • Status changed from new to reviewing

#2 @jcastaneda
3 years ago

  • Owner changed from pramodpandey to irenem

This ticket was mentioned in Slack in #themereview by jcastaneda. View the logs.


3 years ago

#4 @irenem
3 years ago

Hi @wiloke,

Please read and fix/change the comments below.

@ General

  • Change your screenshot, it should be what your theme looks like.
  • DO NOT use outside image source. If you want to use an image as default background etc, include them in your theme.
  • Remove Header metabox.
  • Remove Avatar at user profile.
  • Remove Flickr Feed widget.
  • Do not CREATE/ADD anything to the database, especially adding Blog page. Use sane defaults if you need to set default settings/options.
  • Check your layouts on mobile devices, especially posts which have long title, it is cut.

@ Theme Options Appearance -> Hercules

  • Use Settings API when implementing your theme options. Refer to https://codex.wordpress.org/Settings_API
  • Remove sections About Us, Skills, Team, Clients, Portfolio, Blog, Services, Contact and any code relating/associated to these sections, especially Google Map.
  • Remove option Text Slider at section Header
  • Remove Header Code and Footer Code at Custom Code option page
  • Remove Section Builder
  • Remove Sharing box codes & options. This is plugin territory
  • Make all your text translation ready. Always use __() or _e() when rendering text.
  • Set your theme's textdomain/slug to all translated text.

@ functions.php

  • Remove any conditional statement that check WordPress CORE functions. Ex. if( function_exists( 'add_theme_support' ) )
  • Use proper hooked when declaring functions like add_theme_support, load_theme_support. These type of functions should be inside after_setup_theme callback.

@ Header

  • Remove google-analytics.com link
  • DO NOT hard code the search form. Use get_search_form instead.

@ Menu

  • Check your menu when using tons of menus, it crashes the server and browser. This is so NOT good.

@ Scripts

Include unminified versions of:

  • css3-mediaqueries
  • jquery-1.10.2.min
  • jquery.easing
  • jquery.mb.YTPlayer
  • jquery.owl.carousel
  • jquery.parallax
  • jquery.superslides
  • jquery.wow
  • retina
  • soundcloud (Where do you use this script? I don't see any options or area that enable the use of this script, if it's not part of the theme do remove this. better to include this to your plugin)
  • isotope

Are you the author of the scripts below, if not do not remove author's copyrights/attribution.

  • jquery.wow.carousel
  • css3-mediaqueries
  • jquery-parallax
  • retina
  • soundcloud

@ Customizer

  • Do check the different settings as most of which doesn't work.
  • Also remove the sections mention above.

-:) Irene

#5 @irenem
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed
Note: See TracTickets for help on using tickets.