WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#23056 closed theme (not-approved)

THEME: Seos Business – 1.01

Reported by: seosbg Owned by: LittleBigThing
Priority: new theme Keywords:
Cc: seosbg@…

Description

Seos Business - 1.0

Seos Business is the 2015 theme, dark multi-purpose theme with a responsive 2 column layout.We designed it using a mobile-first approach, meaning your content takes center-stage, regardless of whether your visitors arrive by smartphone, tablet, laptop, or desktop computer. Customizer - background color, header color, nav color, hover color, header image, background image, social media buttons, upload logo.

Theme URL - http://seosthemes.com/seos-business-free-wp-theme/
Author URL - http://seosthemes.com/

SVN - https://themes.svn.wordpress.org/seos-business/1.0
ZIP - https://wordpress.org/themes/download/seos-business.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#23610 THEME: Seos Business – 1.04 closed not-approved mattrad
#27745 THEME: Seos Business – 1.12 closed live poena
#29608 THEME: Seos Business – 1.13 closed live greenshady
#30399 THEME: Seos Business – 1.14 closed live poena
#30495 THEME: Seos Business – 1.16 closed live jcastaneda
#37647 THEME: Seos Business – 1.17 closed live themetracbot
#37649 THEME: Seos Business – 1.18 closed live themetracbot
#37752 THEME: Seos Business – 1.19 closed live themetracbot
#37753 THEME: Seos Business – 1.20 closed live themetracbot
#37754 THEME: Seos Business – 1.21 closed live Otto42
#39869 THEME: Seos Business – 1.22 closed live themetracbot
#41811 THEME: Seos Business – 1.23 closed live themetracbot
#42508 THEME: Seos Business – 1.24 closed live themetracbot


https://themes.svn.wordpress.org/seos-business/1.0/screenshot.png


Attachments (2)

screenshot.png (68.1 KB) - added by seosbg 3 years ago.
seos-business.zip (145.2 KB) - added by seosbg 3 years ago.

Download all attachments as: .zip

Change History (10)

@seosbg
3 years ago

#1 @themetracbot
3 years ago

  • Owner set to LittleBigThing
  • Status changed from new to reviewing

#2 @seosbg
3 years ago

Hi LittleBigThing,

Thank you so much for your review. I found errors and I suggested a new file.

@seosbg
3 years ago

#3 @LittleBigThing
3 years ago

  • Keywords changed from theme-seos-business, accessibility-ready to theme-seos-business accessibility-ready

Hi,

Could you please upload a new version of the theme?

Thanks!
Cheers.

#4 @seosbg
3 years ago

Last edited 3 years ago by seosbg (previous) (diff)

#5 @themetracbot
3 years ago

  • Summary changed from THEME: Seos Business - 1.0 to THEME: Seos Business – 1.01

Seos Business - 1.01

Seos Business is the 2015 theme, dark multi-purpose theme with a responsive 2 column layout. We designed it using a mobile-first approach, meaning your content takes center-stage, regardless of whether your visitors arrive by smartphone, tablet, laptop, or desktop computer. Customizer – background color, header color, nav color, hover color, header image, background image, social media buttons, upload logo.

Theme URL - http://seosthemes.com/seos-business-free-wp-theme/
Author URL - http://seosthemes.com/

SVN - https://themes.svn.wordpress.org/seos-business/1.01
ZIP - https://wordpress.org/themes/download/seos-business.1.01.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=seos-business/1.0&new_path=seos-business/1.01

History:

Ticket Summary Status Resolution Owner
#23610 THEME: Seos Business – 1.04 closed not-approved mattrad
#27745 THEME: Seos Business – 1.12 closed live poena
#29608 THEME: Seos Business – 1.13 closed live greenshady
#30399 THEME: Seos Business – 1.14 closed live poena
#30495 THEME: Seos Business – 1.16 closed live jcastaneda
#37647 THEME: Seos Business – 1.17 closed live themetracbot
#37649 THEME: Seos Business – 1.18 closed live themetracbot
#37752 THEME: Seos Business – 1.19 closed live themetracbot
#37753 THEME: Seos Business – 1.20 closed live themetracbot
#37754 THEME: Seos Business – 1.21 closed live Otto42
#39869 THEME: Seos Business – 1.22 closed live themetracbot
#41811 THEME: Seos Business – 1.23 closed live themetracbot
#42508 THEME: Seos Business – 1.24 closed live themetracbot


https://themes.svn.wordpress.org/seos-business/1.01/screenshot.png

#6 @LittleBigThing
3 years ago

Yes, like this, thanks. :-)

I'll try to look at it in detail later today. But I can tell you this already:

REQUESTED:

  • there should only be one text domain: seos_business or seosbusiness; (different versions are used like seosbusiness and wp-seosbusiness)
  • all function names should be prepended with the unique text domain

GENERAL COMMENT:

  • I find the theme name confusing since the theme does not seem typically suitable for a (small) business to me. Most of the 'business themes' have, for example, a distinct front page (see here: https://wordpress.org/themes/search/business/). This theme may not meet the expectations of someone who is looking for such a theme. This is not beneficial for you or for the potential user. Please react on this.

Please wait with uploading a new version until further comments.

Cheers.

#7 @LittleBigThing
3 years ago

  • Keywords theme-seos-business accessibility-ready removed
  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi seosbg,

Please find my review below.

The theme has passed the theme check (plugin). However, there are a lot of other points missing that are required. Therefore, I have to change the status of the theme to not-approved.

Required:

  • there should only be one text domain: seosbusiness (as in the stylesheet) or seos_business; (different versions are used now like seosbusiness and wp-seosbusiness)
  • the theme URI in the stylesheet should be 'http://seosthemes.com/seos-business/'
  • all function names should be prepended with the unique text domain (see functions.php)
  • you should use '#' for the hex color code when defining default colors for the Customizer
  • there is a php error in the category.php template file:

Notice: Undefined variable: ID in C:\xampp\htdocs\themereview\wp-content\themes\seos-business-1.01\category.php on line 19. You should simply use the_title() instead of echoing 'get_the_title( $ID )'.

  • check how to properly link scripts in WordPress (mac.js) (http://themeshaper.com/2012/10/31/the-wordpress-theme-header-template/)
  • always use esc_url() to escape urls (see footer, line 13)
  • there is a JS syntax error: Uncaught SyntaxError: Unexpected token <
  • licensing information is missing for the font DebasNeue Regular
  • there is no possibility to navigate between posts pages (or between posts)
  • ...

Accessibility-ready:

  • the tag is used but the theme is not accessibility ready (for example no 'role' attribute is used)

Recommended:

  • while it is possible to categorize and tag posts, only tags are displayed.
  • use the post_class() function to display the proper classes for each post and also display the id of each post. You should add them to your <article> tag: <article id="post-<?php the_ID(); ?>" <?php post_class(); ?>>. This allows specific styling of certain or specific posts.
  • the form field have white text on a white background (except for the textarea): unreadable

Notes:

  • no central aligned text in mobile?
  • there is no archive template or an option to display the archive title in the index.php template
  • if logo added, no site-title: this is not a good SEO practice
  • there is no need to check whether there are posts (if ( have-posts() )) when in another template than index.php. Templates files such as page.php, category.php will only be used if proper posts are present.

Good luck further!
Cheers.

#8 @seosbg
3 years ago

Thank you for your review. I found errors and I upload a new version :).

Last edited 3 years ago by seosbg (previous) (diff)
Note: See TracTickets for help on using tickets.