WordPress.org

Make WordPress Themes

Opened 6 years ago

Closed 6 years ago

#2319 closed theme (live)

THEME: Suffusion - 3.7.3

Reported by: sayontan Owned by: furciferrising
Priority: Keywords: theme-suffusion,
Cc: sayontan@…

Description

Suffusion - 3.7.3

An elegant, versatile and browser-safe theme with a power-packed set of options. It has 19 widget areas, one-column, two-column and three-column fixed-width and flexible-width formats, 10 pre-defined templates, 17 pre-defined color schemes, two customizable multi-level drop-down menus, featured posts, a magazine layout, tabbed sidebars, widgets for Twitter, Social Networks and Google Translator, translations in many languages and RTL language support. WP 3.0 Menus, Custom Post Types and Custom Taxonomies are integrated. A BuddyPress support pack is available on the theme page. Support forum at http://www.aquoid.com/forum.

Theme URL - http://www.aquoid.com/news/themes/suffusion/
Author URL - http://mynethome.net/blog

SVN - http://themes.svn.wordpress.org/suffusion/3.7.3
ZIP - http://wordpress.org/extend/themes/download/suffusion.3.7.3.zip?nostats=1

Diff with previous version: http://themes.trac.wordpress.org/changeset?old_path=/suffusion/3.7.2&new_path=/suffusion/3.7.3

All previous tickets for this theme: http://themes.trac.wordpress.org/query?col=id&col=summary&col=keywords&col=owner&col=status&col=resolution&keywords=~theme-suffusion&order=priority

Change History (4)

#1 @cais
6 years ago

  • Owner set to furciferrising
  • Status changed from new to assigned

#2 @furciferrising
6 years ago

Suggested:

One depricated function:

  • Deprecated: automatic_feed_links found in the file actions.php. Use add_theme_support( 'automatic-feed-links' ) instead.

Line 1565: In version 3.7.0 Removing the call to automatic_feed_links() because the theme uploader will fail the

Line 1568: echo automatic_feed_links();


Recommended:

  • Recommended: get_option("home") was found in the file functions.php. Use home_url() instead.

Line 525: $home_link = function_exists('home_url') ? home_url() : get_option("home");

  • Recommended: bloginfo('url') was found in the file searchform.php. Use echo home_url() instead.

Line 10: <form method="get" class="searchform" action="<?php bloginfo('url'); ?>/">

  • Recommended: get_bloginfo('template_directory') was found in the file actions.php. Use get_template_directory_uri() instead.

Line 1045: $img = get_bloginfo('template_directory')."/timthumb.php?src=$img&amp;w

  • Recommended: bloginfo('url') was found in the file actions.php. Use echo home_url() instead.

Line 1291: <form method="get" action="<?php bloginfo('url'); ?>/" class='search-info' id='search-info'>

  • Recommended: get_option("home") was found in the file actions.php. Use home_url() instead.

Line 440: $home_link = get_option("home");

  • Recommended: the_time('M') was found in the file actions.php. Use the_time( get_option( 'date_format' ) ) instead.

Line 1379: <div class="date"><span class="month"><?php the_time('M'); ?></span> <span class="day"><?php the_time('d');

  • Recommended: get_bloginfo('url') was found in the file theme-options-visual-effects.php. Use home_url() instead.

Line 1015: "std" => "&#169; " . date('Y') . " <a href='" . get_bloginfo('url') . "'>" . get_bloginfo('name') . "</a>"),

  • Recommended: get_bloginfo('wpurl') was found in the file suffusion-options-page.php. Use site_url() instead.

Line 837: <td><a class='edit-post-type' id='edit-post-type-<?php echo $id; ?>' href='<?php echo get_bloginfo('wpurl'); ?>/wp-admin/admin-ajax.php'>Edit</a> | <a

Line 899: <!-- <td><a class='edit-post-type' id='edit-post-type-<?php echo $id; ?>' href='<?php echo get_bloginfo('wpurl'); ?>/wp-admin/admin-ajax.php'>Edit</a> | <a

Line 1142: <td><a class='edit-taxonomy' id='edit-taxonomy-<?php echo $id; ?>' href='<?php echo get_bloginfo('wpurl'); ?>/wp-admin/admin-ajax.php'>Edit</a> | <a

  • Recommended: get_bloginfo('template_url') was found in the file suffusion-options-page.php. Use get_template_directory_uri() instead.

Line 165: add_menu_page("Suffusion", "Suffusion", 'manage_options', $suffusion_options_intro_page, 'suffusion_render_options', get_bloginfo('template_url').'/admin/images/aquoid.png');

  • Recommended: No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.
  • Recommended: No reference to add_custom_image_header() was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • Recommended: No reference to add_custom_background() was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.

Overall:

Suggest: approved


Notes:

The deprecated function should be replaced in the next revision of the theme, I see no reason to hold this theme up.


A Theme will be held for approval until items listed as Required are addressed. Once these issues have been resolved, please re-submit your Theme using the uploader tool. A new Trac ticket will be generated. Also note, re-submitted Themes are given priority over newly submitted Themes to help speed up the process and to ensure timely updates are available to end-users.

Theme developer questions, comments, and feedback are always welcome … and encouraged!
Please use one of the following methods:

  • Leave a comment on the appropriate Trac ticket(s) related to the Theme;
  • Email the theme-reviewers email list (you may need to join first); or,
  • Use the #wordpress-themes channel on irc.freenode.net where you can find the Theme Review team.

#3 @sayontan
6 years ago

Hi,
The deprecated function call is actually commented out in the code - so it is not being invoked. Here is the code:

			// In version 3.7.0 Removing the call to automatic_feed_links() because the theme uploader will fail the check.
			// Instead if users are on 2.9 or older, the link will be printed directly.
//			if (function_exists('automatic_feed_links')) {
//				echo automatic_feed_links();
//			}

Please note the comment in front of the "echo" statement.

#4 @Frumph
6 years ago

  • Resolution set to approved
  • Status changed from assigned to closed

Approved with recommendations by furciferrising (beyond sayontan's replies)

Heya Sayontan, those messages are probably from the theme-check plugin, it's a good plugin to add to your test environment, give it a try if you haven't yet.

Note: See TracTickets for help on using tickets.