WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 2 years ago

#23208 closed theme (live)

THEME: Ample - 1.0

Reported by: ThemeGrill Owned by: nitkr
Priority: previously reviewed Keywords: theme-ample
Cc: themegrill@…

Description

Ample - 0.2

Ample is a multipurpose responsive WordPress theme made to help you create a beautiful professional looking site in no time. It has numerous built-in options to give your site the look that you want. Get free support at http://themegrill.com/support-forum/ and check the demo at http://demo.themegrill.com/ample/

Theme URL - http://themegrill.com/themes/ample/
Author URL - http://themegrill.com

SVN - https://themes.svn.wordpress.org/ample/0.2
ZIP - https://wordpress.org/themes/download/ample.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/ample/0.1&new_path=/ample/0.2

History:

Ticket Summary Status Resolution Owner
#22775 THEME: Ample - 0.1 closed not-approved nitkr
#23208 THEME: Ample - 1.0 closed live nitkr

(this ticket)

#24005 THEME: Ample – 1.0.1 closed live jcastaneda
#24396 THEME: Ample – 1.0.2 closed live emiluzelac
#25300 THEME: Ample – 1.0.3 closed live poena
#25850 THEME: Ample – 1.0.4 closed live jcastaneda
#26332 THEME: Ample – 1.0.5 closed live rabmalin
#26441 THEME: Ample – 1.0.6 closed live jcastaneda
#27010 THEME: Ample – 1.0.7 closed live jcastaneda
#27558 THEME: Ample – 1.0.8 closed live jcastaneda
#28179 THEME: Ample – 1.0.9 closed live karmatosed
#28921 THEME: Ample – 1.1.0 closed live karmatosed
#30537 THEME: Ample – 1.1.1 closed live jcastaneda
#31981 THEME: Ample – 1.1.2 closed live themetracbot
#32549 THEME: Ample – 1.1.3 closed live themetracbot
#35003 THEME: Amplest – 1.1.4 closed not-approved poena
#36090 THEME: Ample – 1.1.4 closed live themetracbot
#38928 THEME: Ample – 1.1.5 closed live themetracbot
#42455 THEME: Ample – 1.1.6 closed live themetracbot
#42780 THEME: Ample – 1.1.7 closed live themetracbot


https://themes.svn.wordpress.org/ample/0.2/screenshot.png

Change History (10)

#1 @nishasingh
3 years ago

Theme URI if used, it is required to link to a page with information about the Theme.

#2 @ThemeGrill
3 years ago

Hi @nishasingh

Theme URI -> http://themegrill.com/themes/ample/ and it is the page with the information about the theme. Please do inform if we are missing anything. Thanks.

#3 @nitkr
3 years ago

  • Owner set to nitkr
  • Status changed from new to reviewing

#4 @nitkr
3 years ago

Policy Requirements

License

  • REQUIRED: The Apache 2.0 license for the fonts used is only compatible with GPLv3.0, you will have to either replace the fonts used or change the theme license from GPLv2.0 to GPLv3.0.
  • NOTE: Found WordPress favicon used in your theme shop.

Code Quality

  • REQUIRED: For security, themes should escape all user entered data. More Info
    • Found in line 35 header.php
    • <img src="<?php echo of_get_option( 'ample_header_logo_image', '' ); ?>
  • REQUIRED: admin_print_scripts should not be used to enqueue styles or scripts on the admin pages.More Info
    • Use admin_enqueue_scripts
    • Found in line 62 inc/functions.php .
  • REQUIRED: Use admin_enqueue_scripts hook to enqueue scripts/styles.
    • Found add_action( 'load-widgets.php', 'ample_custom_load' ); .
    • Prefix color_picker with theme-slug.
    • Use array handle instead of wp_enqueue_script( 'wp-color-picker' );
    • Eg:
      wp_enqueue_script('awple-color_picker', get_template_directory_uri() . '/js/color-picker.js', array( 'wp-color-picker' ), false);
      
  • REQUIRED: Prefix all options, custom functions, custom global variables and custom constants with the theme-slug.More Info
    • function exclude_category( $query ) , found in line 90 inc/functions.php
    • wp_enqueue_style( 'google_fonts' ); found in Line 19 in functions.php
    • Found in function.php
      add_image_size( 'featured-blog-large', 710, 300, true );
      add_image_size( 'featured-blog-small', 230, 230, true );
      add_image_size( 'portfolio-image', 330, 330, true );
      
      
  • REQUIRED: Custom css used in theme options should be properly sanitized. More Info
    • Use wp_filter_nohtml_kses() instead of wp_kses
    • For options framework just override the sanitation for textarea
      • Use of_sanitize_textarea filter hook.
  • NOTE: No need to bundle anything that's not needed/used.
    • Found empty css and images folder.

  • RECOMMENDED: If you are providing support for plugins, please refer that in your readme file.
    • Found support for NavXT and wp_pagenavi plugins.
  • RECOMMENDED: No need to register and enqueue at the same time, unless its used in more than one places to enqueue.
    • wp_register_style( 'google_fonts', '//fonts.googleapis.com/css?family=Roboto:400,300' );
      wp_enqueue_style( 'google_fonts' );
      
  • RECOMMENDED: Add prefix for custom template files.
    • Eg: business.php to template-business.php

Review Summary

This is a full review.

Please address all issues in the next theme revision, see review handbook for guidelines and references. If you have any questions please feel free to ask.

Keeping this ticket open for few more days, for your revision.

#5 @ThemeGrill
3 years ago

Hi,

Thanks for your review and time. We will fix the issues and submit the new version.

ThemeGrill

#6 @themetracbot
3 years ago

  • Summary changed from THEME: Ample - 0.2 to THEME: Ample - 1.0

Ample - 1.0

Ample is a multipurpose responsive WordPress theme made to help you create a beautiful professional looking site in no time. It has numerous built-in options to give your site the look that you want. Get free support at http://themegrill.com/support-forum/ and check the demo at http://demo.themegrill.com/ample/

Theme URL - http://themegrill.com/themes/ample/
Author URL - http://themegrill.com

SVN - https://themes.svn.wordpress.org/ample/1.0
ZIP - https://wordpress.org/themes/download/ample.1.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/ample/0.2&new_path=/ample/1.0

History:

Ticket Summary Status Resolution Owner
#22775 THEME: Ample - 0.1 closed not-approved nitkr
#23208 THEME: Ample - 1.0 closed live nitkr

(this ticket)

#24005 THEME: Ample – 1.0.1 closed live jcastaneda
#24396 THEME: Ample – 1.0.2 closed live emiluzelac
#25300 THEME: Ample – 1.0.3 closed live poena
#25850 THEME: Ample – 1.0.4 closed live jcastaneda
#26332 THEME: Ample – 1.0.5 closed live rabmalin
#26441 THEME: Ample – 1.0.6 closed live jcastaneda
#27010 THEME: Ample – 1.0.7 closed live jcastaneda
#27558 THEME: Ample – 1.0.8 closed live jcastaneda
#28179 THEME: Ample – 1.0.9 closed live karmatosed
#28921 THEME: Ample – 1.1.0 closed live karmatosed
#30537 THEME: Ample – 1.1.1 closed live jcastaneda
#31981 THEME: Ample – 1.1.2 closed live themetracbot
#32549 THEME: Ample – 1.1.3 closed live themetracbot
#35003 THEME: Amplest – 1.1.4 closed not-approved poena
#36090 THEME: Ample – 1.1.4 closed live themetracbot
#38928 THEME: Ample – 1.1.5 closed live themetracbot
#42455 THEME: Ample – 1.1.6 closed live themetracbot
#42780 THEME: Ample – 1.1.7 closed live themetracbot


https://themes.svn.wordpress.org/ample/1.0/screenshot.png

#7 @nitkr
3 years ago

  • I failed to notice that the fonts used are external links, the license change wasn't required, sorry about that. Just letting you know, no need to revert, GPLv3 is good :)

Review Summary

Found all required issues as FIXED.

Marking it as APPROVED.

Last edited 3 years ago by nitkr (previous) (diff)

#8 @nitkr
3 years ago

  • Status changed from reviewing to approved

#9 @ThemeGrill
3 years ago

Thanks for your time and theme approval. :)

ThemeGrill

#10 @karmatosed
2 years ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations, this theme is now live!

Note: See TracTickets for help on using tickets.