WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#23252 closed theme (not-approved)

THEME: Magnificient – 1.3.4

Reported by: krazzeniru20 Owned by: optimistic_shekhar
Priority: new theme Keywords: theme-magnificient
Cc: nirmalya.email@…

Description

Magnificient - 1.0

The 2015 theme from Infismash - Creativity that inspires you!

Theme URL -
Author URL - http://infismash.com/

SVN - https://themes.svn.wordpress.org/magnificient/1.0
ZIP - https://wordpress.org/themes/download/magnificient.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#23252 THEME: Magnificient – 1.3.4 closed not-approved optimistic_shekhar

(this ticket)

#32029 THEME: Magnificient – 1.3.8 closed not-approved yudleethemes


https://themes.svn.wordpress.org/magnificient/1.0/screenshot.png


Change History (40)

#1 @themetracbot
3 years ago

  • Summary changed from THEME: Magnificient - 1.0 to THEME: Magnificient - 1.1

Magnificient - 1.1

The 2015 theme from Infismash - Creativity that inspires you!

Theme URL -
Author URL - http://infismash.com/

SVN - https://themes.svn.wordpress.org/magnificient/1.1
ZIP - https://wordpress.org/themes/download/magnificient.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/magnificient/1.0&new_path=/magnificient/1.1

History:

Ticket Summary Status Resolution Owner
#23252 THEME: Magnificient – 1.3.4 closed not-approved optimistic_shekhar

(this ticket)

#32029 THEME: Magnificient – 1.3.8 closed not-approved yudleethemes


https://themes.svn.wordpress.org/magnificient/1.1/screenshot.png

#2 @themetracbot
3 years ago

  • Summary changed from THEME: Magnificient - 1.1 to THEME: Magnificient - 1.2

Magnificient - 1.2

The 2015 theme from Infismash - Creativity that inspires you!

Theme URL -
Author URL - http://infismash.com/

SVN - https://themes.svn.wordpress.org/magnificient/1.2
ZIP - https://wordpress.org/themes/download/magnificient.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=/magnificient/1.1&new_path=/magnificient/1.2

History:

Ticket Summary Status Resolution Owner
#23252 THEME: Magnificient – 1.3.4 closed not-approved optimistic_shekhar

(this ticket)

#32029 THEME: Magnificient – 1.3.8 closed not-approved yudleethemes


https://themes.svn.wordpress.org/magnificient/1.2/screenshot.png

#3 @krazzeniru20
3 years ago

Please provide an update.

#4 @themetracbot
3 years ago

  • Owner set to johnbriangan
  • Status changed from new to reviewing

#5 @krazzeniru20
3 years ago

Please provide an update.

#6 @krazzeniru20
3 years ago

Any updates please.

#7 @irenem
3 years ago

@grapplerulrich I can review this theme -:)

#8 @grapplerulrich
3 years ago

  • Owner changed from johnbriangan to irenem

Thank you @irenem for taking on this review.

#9 @irenem
3 years ago

Hi @krazzeniru20,

Please read and fix the comments belows.

General

  • Intertionalize all text. Check your templates.
  • Add your textdomain/themeslug at _e('SOME TEXT', 'YOUR_TEXT_DOMAIN' ). Check your templates.
  • Prefix wp_enqueue_script() and wp_enqueue_style id with your textdomain/themeslug
  • Use proper hook when declaring your theme support etc. Put add_theme_support, add_editor_style to your callback hook
  • Specify id at register_sidebar arguments.
  • Use if( is_active_sidebar( 'SIDEBAR_ID' ) ) instead of is_dynamic_sidebar. Do this to all your templates where you add your sidebar. Proper usage is below:

if( is_active_sidebar( 'SIDEBAR_ID' ) ){
dynamic_sidebar( 'SIDEBAR_ID' );
}

  • Use proper hook when declaring your theme support. Put add_theme_support, add_editor_style,if ( ! isset( $content_width ) ).... inside it's callback function.

Example:

function infi_setup(){

add_theme_support( .... )
add_editor_style()
......................

}
add_action( 'after_setup_theme', 'infi_setup' );

  • Remove this statement if( function_exists( 'register_sidebar' ) ) put register_sidebar inside infi_widgets_init

@ functions.php

  • Please check and fix your codes. Your using too much <?php that triggers an error. If your copy/pasting the codes from other themes or plugin, make sure you write proper author attribution.

@ style.css

  • Remove Theme URI if you don't have theme uri

@ header.php

@ searchform.php

  • Escape value= get_search_query()

@ Scripts

  • Add unminified version of bootstrap, html5shiv
  • Remove wp_enqueue_script( 'customjs', get_template_directory_uri() . '/assets/js/custom.js', array( 'jquery' ) ). You don't have custom.js file.
  • Remove jquery.min.js. This file isn't in use.
  • Remove scripts.js. This is an empty file.

@ Layout

  • Check your layout both main content and sidebar widgets.
  • Check your menu, It is hidden when admin toolbar is enabled.
  • Posts/Page navigation at home page/archive is missing.
  • Check your HTML blocks and form fields. Using bootstrap alone does not style all HTML blocks or form fields.

Irene

#10 @krazzeniru20
3 years ago

Thank you for your detailed reply. Much appreciate your help. Will provide an update in a few days.

#11 @irenem
3 years ago

Still no update?

#12 @krazzeniru20
3 years ago

Hello!

I had updated the theme but had used Option Tree framework for custom theme options. But at present, WordPress supports theme options only through the customizer. So, I've to build all the options from scratch. Hence, it's taking a lot of time.

Hope you understand and keep this ticket open.

#13 @irenem
3 years ago

No Problem. Just write a note here to let us know your status so that this ticket will remain open. We have 7 days inactivity rule so do keep us updated. Thanks.

#14 @krazzeniru20
3 years ago

Will post a new version soon with basic functions.

#15 @themetracbot
3 years ago

  • Summary changed from THEME: Magnificient - 1.2 to THEME: Magnificient – 1.3.0

Magnificient - 1.3.0

Magnifient is a versatile HTML5 responsive WordPress theme based on ZURB&#8217;s Foundation.

Theme URL - http://infismash.com/demos/wordpress/magnificient
Author URL - http://infismash.com/

SVN - https://themes.svn.wordpress.org/magnificient/1.3.0
ZIP - https://wordpress.org/themes/download/magnificient.1.3.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=magnificient/1.2&new_path=magnificient/1.3.0

History:

Ticket Summary Status Resolution Owner
#23252 THEME: Magnificient – 1.3.4 closed not-approved optimistic_shekhar

(this ticket)

#32029 THEME: Magnificient – 1.3.8 closed not-approved yudleethemes


https://themes.svn.wordpress.org/magnificient/1.3.0/screenshot.png

#16 @krazzeniru20
2 years ago

Any updates please.

#17 @krazzeniru20
2 years ago

Can I get an update on this theme please?

#18 @grapplerulrich
2 years ago

It seems like @irenem is unable to continue with the review. I marked your theme to be reassigned. https://themes.trac.wordpress.org/report/30

#19 @grapplerulrich
2 years ago

  • Owner changed from irenem to optimistic_shekhar

Thank you @optimistic_shekhar for continuing this review.

#20 @optimistic_shekhar
2 years ago

Hi There,

I will be reviewing your theme today, will post my reviews shortly.

Thanks

#21 @krazzeniru20
2 years ago

Hello,

Sure.

Thanks

#22 @optimistic_shekhar
2 years ago

Hi there,

Sorry it taked me some time to post the review.

The Reviews are divided into "Required" and "Recommended" part, in order to get the theme approved you need to fix all the required parts, but it will be worth to have a look at the recommendations too.

Required

  • Text domain should be slug of theme name that will be magnificient
  • home_url should be escaped on searchform.php line no.1
  • prefixing of the functions used in the theme should be magnificient_, please change this in all area.
  • All Strings should be translatable for example page-left-dual-sidebar.php line no.37 <?php edit_post_link('Edit this Post'); ?>
  • home_url() in the header.php line no.19 should be home('/ ')
  • Please provide all licensing details of used fonts, css with appropriate links for example wow.js
  • Language file should be magnificient.pot not foundationbuddy.pot

Please fix the following issues and submit again.

Thanks

#23 @themetracbot
2 years ago

  • Summary changed from THEME: Magnificient – 1.3.0 to THEME: Magnificient – 1.3.1

Magnificient - 1.3.1

Magnifient is a versatile HTML5 responsive WordPress theme based on ZURB&#8217;s Foundation.

Theme URL - http://infismash.com/demos/wordpress/magnificient
Author URL - http://infismash.com/

SVN - https://themes.svn.wordpress.org/magnificient/1.3.1
ZIP - https://wordpress.org/themes/download/magnificient.1.3.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=magnificient/1.3.0&new_path=magnificient/1.3.1

History:

Ticket Summary Status Resolution Owner
#23252 THEME: Magnificient – 1.3.4 closed not-approved optimistic_shekhar

(this ticket)

#32029 THEME: Magnificient – 1.3.8 closed not-approved yudleethemes


https://themes.svn.wordpress.org/magnificient/1.3.1/screenshot.png

#24 @themetracbot
2 years ago

  • Summary changed from THEME: Magnificient – 1.3.1 to THEME: Magnificient – 1.3.2

Magnificient - 1.3.2

Magnificient is a versatile HTML5 responsive WordPress theme based on ZURB&#8217;s Foundation. Magnificient is a WordPress theme which you can use for your personal blogging website or a story website. Magnificient gives you a clean layout with minimal interface.

Theme URL - http://infismash.com/demos/wordpress/magnificient
Author URL - http://infismash.com/

SVN - https://themes.svn.wordpress.org/magnificient/1.3.2
ZIP - https://wordpress.org/themes/download/magnificient.1.3.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=magnificient/1.3.1&new_path=magnificient/1.3.2

History:

Ticket Summary Status Resolution Owner
#23252 THEME: Magnificient – 1.3.4 closed not-approved optimistic_shekhar

(this ticket)

#32029 THEME: Magnificient – 1.3.8 closed not-approved yudleethemes


https://themes.svn.wordpress.org/magnificient/1.3.2/screenshot.png

#25 @optimistic_shekhar
2 years ago

Hi there,

Required

  • Screenshot should be the default preview of the theme, not mockup
  • Language .pot file should contain project id of same theme not "Project-Id-Version: reverie-master-libsass-template 5.4.0\n"
  • You can directly enqueue the stylesheet without registering it, like the following wp_enqueue_style('magnificient-open-sans-font', '//fonts.googleapis.com/css?family=Open+Sans:600italic,700italic,800italic,400,300,700'); and don't forget to remove the {{{http:}} to avoid errors.
  • {{load_theme_textdomain('magnificient-master', get_template_directory() . '/languages');}} Magificient-master should be theme slug. https://make.wordpress.org/themes/handbook/review/required/explanations-and-examples/#language
  • Prefix the add_image_size name
  • Why are you using foreach loop to register a widget?

Please fix the following file and submit again.

Thanks

#26 @themetracbot
2 years ago

  • Summary changed from THEME: Magnificient – 1.3.2 to THEME: Magnificient – 1.3.3

Magnificient - 1.3.3

Magnificient is a versatile HTML5 responsive WordPress theme based on ZURB&#8217;s Foundation. Magnificient is a WordPress theme which you can use for your personal blogging website or a story website. Magnificient gives you a clean layout with minimal interface.

Theme URL - http://www.infismash.com/magnificient-wordpress-theme/
Author URL - http://infismash.com/

SVN - https://themes.svn.wordpress.org/magnificient/1.3.3
ZIP - https://wordpress.org/themes/download/magnificient.1.3.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=magnificient/1.3.2&new_path=magnificient/1.3.3

History:

Ticket Summary Status Resolution Owner
#23252 THEME: Magnificient – 1.3.4 closed not-approved optimistic_shekhar

(this ticket)

#32029 THEME: Magnificient – 1.3.8 closed not-approved yudleethemes


https://themes.svn.wordpress.org/magnificient/1.3.3/screenshot.png

#27 @optimistic_shekhar
2 years ago

Hi There,

Required

  • Text-domain should be the theme_slug, in your case magnificient, please replace all the text-domains and prefix all the function as theme_slug_function_name
  • Language file is not included load_theme_textdomain() is not found, All theme strings should be transtable
  • Previous Issues Not Fixed You can directly enqueue the stylesheet without registering it, like the following wp_enqueue_style('magnificient-open-sans-font', 'fonts.googleapis.com/css?family=Open+Sans:600italic,700italic,800italic,400,300,700'); and don't forget to remove the {{{http:}} to avoid errors.

Please fix the following issues and submit again.

Thanks

#28 @krazzeniru20
2 years ago

Fixing the issues asap.

#29 @krazzeniru20
2 years ago

Can you please elaborate on this issue?

Previous Issues Not Fixed You can directly enqueue the stylesheet without registering it, like the following wp_enqueue_style('magnificient-open-sans-font', 'fonts.googleapis.com/css?family=Open+Sans:600italic,700italic,800italic,400,300,700'); and don't forget to remove the {{{http:}} to avoid errors.

I'm not registering it. I'm only enqueuing it:
https://themes.trac.wordpress.org/browser/magnificient/1.3.3/library/custom-fonts.php?rev=49581#L11

#31 @themetracbot
2 years ago

  • Summary changed from THEME: Magnificient – 1.3.3 to THEME: Magnificient – 1.3.4

Magnificient - 1.3.4

Magnificient is a versatile HTML5 responsive WordPress theme based on ZURB&#8217;s Foundation. Magnificient is a WordPress theme which you can use for your personal blogging website or a story website. Magnificient gives you a clean layout with minimal interface.

Theme URL - http://www.infismash.com/magnificient-wordpress-theme/
Author URL - http://infismash.com/

SVN - https://themes.svn.wordpress.org/magnificient/1.3.4
ZIP - https://wordpress.org/themes/download/magnificient.1.3.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=magnificient/1.3.3&new_path=magnificient/1.3.4

History:

Ticket Summary Status Resolution Owner
#23252 THEME: Magnificient – 1.3.4 closed not-approved optimistic_shekhar

(this ticket)

#32029 THEME: Magnificient – 1.3.8 closed not-approved yudleethemes


https://themes.svn.wordpress.org/magnificient/1.3.4/screenshot.png

#32 @optimistic_shekhar
2 years ago

Hi There,

I will be reviewing your theme today. Will post my reviews soon.

Thanks

#33 @krazzeniru20
2 years ago

Hi,

Can I get an update on this theme please?

Thanks.

#34 @optimistic_shekhar
2 years ago

  • Status changed from reviewing to approved

All Previous issues has been fixed and no any issues remaining, marking theme as approved.

#35 @krazzeniru20
2 years ago

Any updates on this theme!

#36 @jcastaneda
2 years ago

  • Status changed from approved to reopened

Was looking a little closer and noticed this uses a lot of the code from:
https://wordpress.org/themes/infiword/

Is this correct?

If this is so, have you considered the route of a child theme?

#37 @krazzeniru20
2 years ago

Thanks for the reply.

Yes, it has a lot of codes common to Infiword since both of them are developed by me. I didn't consider the route of a child theme since I was considering to make some changes on this theme in the future.

So, I decided to make a separate theme.

I hope that it won't cause any problem in the approval process! :)

Thanks again.

#38 @jcastaneda
2 years ago

Okay, thanks for clarifying that.

I think what threw me off what the images were also transferred over. Not sure if that was intentional or not. As for what does need to be fixed:

  • cannot remove generator ( non-presentational hook )
  • cannot remove version on styles/scripts ( non-presentational hook )
  • commented code, be sure to remove
  • license/copyright information for all bundled resources ( images )
  • use core bundled scripts ( noticed jquery 1.11.3 )
  • provide unminified versions

You don't have to post the entire license terms for all, something like:

=== resources
* fastclick.js MIT copyright ( year )
* icons.png Public Domain ( year )

#39 @karmatosed
2 years ago

  • Resolution set to not-approved
  • Status changed from reopened to closed

I am closing this ticket as you've not responded to the review. In future please respond, even to say you need more time within 7 days.

#40 @krazzeniru20
2 years ago

Sorry for the late reply. Will modify and upload a new version soon.

Note: See TracTickets for help on using tickets.