WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 2 years ago

#23294 closed theme (live)

THEME: Creative Focus – 1.0.9

Reported by: Mladjo Owned by: poena
Priority: new theme Keywords: theme-creative-focus
Cc: mladenmilentijevic@…, joedolson

Description

Creative Focus - 1.0.0

Creative Focus - Minimal, Responsive, Developer Friendly WordPress Theme with Clean and Modern Layout

Theme URL - http://creativefocus.se/
Author URL - http://milentijevic.com

SVN - https://themes.svn.wordpress.org/creative-focus/1.0.0
ZIP - https://wordpress.org/themes/download/creative-focus.1.0.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/creative-focus/1.0.0/screenshot.png


Change History (36)

#2 @themetracbot
3 years ago

  • Owner set to txbredred
  • Status changed from new to reviewing

#3 @themetracbot
3 years ago

  • Summary changed from THEME: Creative Focus – 1.0.1 to THEME: Creative Focus – 1.0.2

Creative Focus - 1.0.2

Creative Focus is Minimal, Responsive, Developer Friendly WordPress Theme with Clean and Modern Layout

Theme URL - https://github.com/mladjom/creativefocus
Author URL - http://milentijevic.com

SVN - https://themes.svn.wordpress.org/creative-focus/1.0.2
ZIP - https://wordpress.org/themes/download/creative-focus.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=creative-focus/1.0.1&new_path=creative-focus/1.0.2

History:


https://themes.svn.wordpress.org/creative-focus/1.0.2/screenshot.png

#4 @jcastaneda
2 years ago

  • Keywords changed from theme-creative-focus, accessibility-ready to theme-creative-focus accessibility-ready
  • Owner changed from txbredred to antsanchez

#5 @antsanchez
2 years ago

Hi Mladjo,

You have created a nice theme. Thanks for submitting it to WordPress.org.

Here is my complete review based on these requirements: https://make.wordpress.org/themes/handbook/review/required/

Required:

  • Prefix with your theme slug the function is_creativefocus_customizer_enabled()
  • I don't understand why you use add_action to require the sidebars. You should use get_sidebar() for that.
  • Declare licenses of any resources included such as fonts or images. You could use readme.txt for that


Recommended:

  • You can add translation-ready tag in your style.css

If you have any questions, do not hesitate to ask me.

#6 @antsanchez
2 years ago

I forgot to say, that in the mobile version I can't see the menu button since it is behind the wp menu bar (tested in Chrome). Please fix it.

Last edited 2 years ago by antsanchez (previous) (diff)

#7 @themetracbot
2 years ago

  • Summary changed from THEME: Creative Focus – 1.0.2 to THEME: Creative Focus – 1.0.3

Creative Focus - 1.0.3

Creative Focus is Minimal, Responsive, Developer Friendly WordPress Theme with Clean and Modern Layout

Theme URL - https://github.com/mladjom/creativefocus
Author URL - http://milentijevic.com

SVN - https://themes.svn.wordpress.org/creative-focus/1.0.3
ZIP - https://wordpress.org/themes/download/creative-focus.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=creative-focus/1.0.2&new_path=creative-focus/1.0.3

History:


https://themes.svn.wordpress.org/creative-focus/1.0.3/screenshot.png

#8 @Mladjo
2 years ago

Hi,
I made required and recommended changes.
Explanation why I use add_action to require the sidebar - Because I remove sidebar if theme_mod creativefocus_layout is without. Check function creativefocus_layout_class.

#9 @antsanchez
2 years ago

Hi @Mladjo,

Sorry, I missed something in my first review:

  • Please, remove rtl.css since it is empty

I understand now the sidebar issue, but I still can't understand why you make it so complicate. You could just do that code:

if(get_theme_mod('creativefocus_layout') != "without"){
   get_sidebar();
}

That's not a requirement, but a recommendation: If used in theme, standard template files are required to be called using the correct template tag. https://make.wordpress.org/themes/handbook/review/recommended/templates/ Anyway, you would save a lot of lines of code.

Last edited 2 years ago by antsanchez (previous) (diff)

#10 @Mladjo
2 years ago

Hi @antsanchez,

I removed rtl.css

Regarding

do_action('creativefocus_sidebar');

I have it in index.php, archive.php, page.php, search.php and single.php So I register this action with:

add_action('creativefocus_sidebar', 'creativefocus_get_sidebar', 10);

and remove it with:

if ('without' == $layout) {
        remove_action('creativefocus_sidebar', 'creativefocus_get_sidebar', 10);
    }

And that is much less code. Now if I decide to extend theme to support woocommerce it can be handy. If you do not insist I would like to keep this as it is.

Thanks and Regards

#11 @themetracbot
2 years ago

  • Summary changed from THEME: Creative Focus – 1.0.3 to THEME: Creative Focus – 1.0.4

Creative Focus - 1.0.4

Creative Focus is Minimal, Responsive, Developer Friendly WordPress Theme with Clean and Modern Layout

Theme URL - https://github.com/mladjom/creativefocus
Author URL - http://milentijevic.com

SVN - https://themes.svn.wordpress.org/creative-focus/1.0.4
ZIP - https://wordpress.org/themes/download/creative-focus.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=creative-focus/1.0.3&new_path=creative-focus/1.0.4

History:


https://themes.svn.wordpress.org/creative-focus/1.0.4/screenshot.png

#12 @antsanchez
2 years ago

Hello @Mladjo,

The sidebar-code was just a recommendation, not a requirement.

Everything seems to be OK now. The normal review is therefore approved.

Since you have the "accessibility-ready" tag in your style.css, I will have to do now an accessibility review. I'll try to finish it today.

#13 @antsanchez
2 years ago

Here is my Accessibility Review:

Please, note that that's my very first accessibility-review. One of the admins will double-check everything.

The requirements for the Accessibility-review are here: https://make.wordpress.org/themes/handbook/review/accessibility/required/

Keyboard Navigation
Theme authors MUST provide visual keyboard focus highlighting in navigation menus and for form fields, submit buttons and text links. Navigation by keyboard should also be intuitive and effective.

  • There is no focus highlighting when navigating with the TAB key
  • I can't open the sub-menus with the TAB key

Controls
All theme features that behave as buttons or links must use <button>, <input>, or <a> elements, to ensure native keyboard accessibility and interaction with screen reader accessibility APIs.
All controls must also have machine-readable text to indicate the nature of the control.

  • There is no machine-readable text for the menu button in mobile version

Contrast
Theme authors MUST ensure that all background/foreground color contrasts for plain content text are within the level AA contrast ratio (4.5:1) specified in the Web Content Accessibility Guidelines (WCAG) 2.0 for color luminosity.

  • Most of the elements pass with a AAA level, but :
    • Post in index
      • (Background-color: RGBA 0, 0, 0, 0.12
      • Text color: 0, 0, 0, 0.87
      • Luminosity Contrast Ratio: 1:1
    • Links
      • Background: fff
      • Color: 4dafff
      • Luminosity Contras Ratio: 2.36:1

Images
Font Icons supplementing text (like the icons for "Leave a comment" or "Edit") should be hidden from screen readers using aria-hidden. Scince your icons are added with the :before CSS attribute, I don't know if that rule applies to you.

Last edited 2 years ago by antsanchez (previous) (diff)

This ticket was mentioned in Slack in #themereview by antsanchez. View the logs.


2 years ago

#15 @joedolson
2 years ago

Follow-up accessibility review:

1) Headings: are fine.
2) ARIA Landmark Roles: are fine.
3) Link text: No 'continue reading' links found.
4) Controls: While technically allowable, it could be confusing to users that your search toggle is a different type of control from the menu-toggle. <a> and <button> are activated differently from the keyboard, so it would be preferable to use the same type of control for both, since they're right next to each other. It's also very confusing that while the menu-toggle doesn't actually hide the menu (it only makes it visibly disappear), the search-toggle actually does hide the search box (using display: none.)

You should make both those controls behave the same way: they should both be buttons, and when hidden, the content should be hidden using display: none, so that it's not available to users if it's supposed to be hidden. Right now, the menu has to be browsed through by screen reader users whether it's hidden or not.

5) Keyboard Navigation:

As Antonio pointed out, you need to have visual :focus states on every focusable control (links, buttons, inputs, etc.).

6) Contrast: The base link color is a problem, but the black/black contrast is a false positive; it doesn't actually occur on the site. The link color is a problem both against the white and the home page gray; and the reversed color of the sticky post is also a problem.

7) Skip Links - Good to go.

8) Forms: Don't use display: none for submit buttons; instead hide them using off-screen styles for screen readers. Otherwise good.

9) Images: Right now, we aren't requiring authors to change generated content; however, this could change in the future, so that those ornamental icons can be hidden. Otherwise, good.

10) Media: none found.

Not allowed:

  • Tabindex: Not found.
  • Accesskey: not found.
  • New windows: Not found.

#16 @themetracbot
2 years ago

  • Summary changed from THEME: Creative Focus – 1.0.4 to THEME: Creative Focus – 1.0.5

Creative Focus - 1.0.5

Creative Focus is Minimal, Responsive, Developer Friendly WordPress Theme with Clean and Modern Layout

Theme URL - https://github.com/mladjom/creativefocus
Author URL - http://milentijevic.com

SVN - https://themes.svn.wordpress.org/creative-focus/1.0.5
ZIP - https://wordpress.org/themes/download/creative-focus.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=creative-focus/1.0.4&new_path=creative-focus/1.0.5

History:


https://themes.svn.wordpress.org/creative-focus/1.0.5/screenshot.png

#17 @Mladjo
2 years ago

Thanks for feedback. I made all the changes but please check 5) Keyboard Navigation again.

#18 @antsanchez
2 years ago

  • Cc joedolson added

Any updates here @joedolson ?

#19 @joedolson
2 years ago

Will get this checked soon; today, if possible.

#20 @Mladjo
2 years ago

That would be very nice as all this reviewing process took already too much time. Thanks

#21 @joedolson
2 years ago

5) Keyboard navigation: Still none.

The essence of keyboard navigation is that users need to be able to 1) access all controls from the keyboard and 2) be able to see which control they're currently on. You've got #1; that's fine. However, nothing is visible. You need to define the :focus state for all controls (links, inputs, etc.) so that a user can tell when they've arrived on that control.

6) Contrast: The link color is still a problem when it's over the gray background - over white, it's good to go, but on the gray backgrounds it's too low.

8) Forms: You've still got inputs that are hidden using display: none;. They can be hidden off-screen like screen-reader-text, but don't hide them using display: none.

#22 @themetracbot
2 years ago

  • Summary changed from THEME: Creative Focus – 1.0.5 to THEME: Creative Focus – 1.0.6

Creative Focus - 1.0.6

Creative Focus is Minimal, Responsive, Developer Friendly WordPress Theme with Clean and Modern Layout. Theme is widget ready, SEO optimized, fast loading, and easy to customize. It features 1, 2 or 3 colinms and supports Schema.org microdata format.

Theme URL - https://github.com/mladjom/creativefocus
Author URL - http://milentijevic.com

SVN - https://themes.svn.wordpress.org/creative-focus/1.0.6
ZIP - https://wordpress.org/themes/download/creative-focus.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=creative-focus/1.0.5&new_path=creative-focus/1.0.6

History:


https://themes.svn.wordpress.org/creative-focus/1.0.6/screenshot.png

#23 @themetracbot
2 years ago

  • Summary changed from THEME: Creative Focus – 1.0.6 to THEME: Creative Focus – 1.0.7

Creative Focus - 1.0.7

Creative Focus is Minimal, Responsive, Developer Friendly WordPress Theme with Clean and Modern Layout. Theme is widget ready, SEO optimized, fast loading, and easy to customize. It features 1, 2 or 3 colinms and supports Schema.org microdata format.

Theme URL - https://github.com/mladjom/creativefocus
Author URL - http://milentijevic.com

SVN - https://themes.svn.wordpress.org/creative-focus/1.0.7
ZIP - https://wordpress.org/themes/download/creative-focus.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=creative-focus/1.0.6&new_path=creative-focus/1.0.7

History:


https://themes.svn.wordpress.org/creative-focus/1.0.7/screenshot.png

#24 @Mladjo
2 years ago

I decided to remove accessibility-ready tag as I will need more to make main navigation fully keyboard accessible.

#25 @joedolson
2 years ago

  • Keywords accessibility-ready removed

Thank you for your efforts to this point; I look forward to seeing the theme again when you're ready!

#26 @Mladjo
2 years ago

Thank you @joedolson because I certainly made my theme better and learned a lot along the way.

#27 @themetracbot
2 years ago

  • Summary changed from THEME: Creative Focus – 1.0.7 to THEME: Creative Focus – 1.0.8

Creative Focus - 1.0.8

Creative Focus is Minimal, Responsive, Developer Friendly WordPress Theme with Clean and Modern Layout. Theme is widget ready, SEO optimized, fast loading, and easy to customize. It features 1, 2 or 3 columns and supports Schema.org microdata format.

Theme URL - https://github.com/mladjom/creativefocus
Author URL - http://milentijevic.com

SVN - https://themes.svn.wordpress.org/creative-focus/1.0.8
ZIP - https://wordpress.org/themes/download/creative-focus.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=creative-focus/1.0.7&new_path=creative-focus/1.0.8

History:


https://themes.svn.wordpress.org/creative-focus/1.0.8/screenshot.png

#28 @antsanchez
2 years ago

  • Status changed from reviewing to approved

hi! sorry for the delay, I thought it was still under accesibility-review. Since that tag is removed, I will mark your ticket as approved.
Once a theme is approved to go live one of the committers will review the ticket and make it live. https://make.wordpress.org/themes/handbook/review/

#29 @poena
2 years ago

Hi!
Please add a copyright for the theme itself, and declare the license of any included resources -like Font Awesome. See https://make.wordpress.org/themes/handbook/review/required/#licensing

#30 @Mladjo
2 years ago

Hej @poena,

The theme already has licenses declared. GPLv3 for the theme, SIL Open Font License for FontAwesome. This is style.css Please help me understand what do you mean?

/*
Theme Name: Creative Focus
Theme URI: https://github.com/mladjom/creativefocus
Author: Mladjo
Author URI: http://milentijevic.com
Description: Creative Focus is Minimal, Responsive, Developer Friendly WordPress Theme with Clean and Modern Layout. Theme is widget ready, SEO optimized, fast loading, and easy to customize. It features 1, 2 or 3 columns and supports Schema.org microdata format.
Version: 1.0.8
License: GPLv3
License URI: http://www.gnu.org/licenses/gpl-3.0.html
Text Domain: creativefocus
Tags: blue, black, white, light, one-column, two-columns, three-columns, left-sidebar, right-sidebar, responsive-layout, custom-header, custom-menu, featured-images, threaded-comments, sticky-post, translation-ready, microformats, translation-ready

This theme, like WordPress, is licensed under the GPL.
Use it to make something cool, have fun, and share what you've learned with others.

FontAwesome License: SIL Open Font License - http://scripts.sil.org/OFL
Images License: GNU General Public License v2 or later
*/

#31 @poena
2 years ago

Ah, I missed that!
But I could not find a copyright for the theme. Example: Fred WordPress Theme, Copyright 2012 Joe Smith

See https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

#32 @Mladjo
2 years ago

@poena
I can add something like in the style.css

Ginger WordPress Theme, Copyright 2012 Joe Smith
Ginger is distributed under the terms of the GNU GPL

This program is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program.  If not, see .

But I already pointed at http://www.gnu.org/licenses/gpl-3.0.html in License URI theme header tag.
I also checked WordPress default tweenty... themes (and some other) and was not able to find any difference between my license and theirs.

So please let my theme go live.

#33 @poena
2 years ago

  • Status changed from approved to reopened

#34 @poena
2 years ago

  • Owner changed from antsanchez to poena
  • Status changed from reopened to reviewing

#35 @themetracbot
2 years ago

  • Summary changed from THEME: Creative Focus – 1.0.8 to THEME: Creative Focus – 1.0.9

Creative Focus - 1.0.9

Creative Focus is Minimal, Responsive, Developer Friendly WordPress Theme with Clean and Modern Layout. Theme is widget ready, SEO optimized, fast loading, and easy to customize. It features 1, 2 or 3 columns and supports Schema.org microdata format.

Theme URL - https://github.com/mladjom/creativefocus
Author URL - http://milentijevic.com

SVN - https://themes.svn.wordpress.org/creative-focus/1.0.9
ZIP - https://wordpress.org/themes/download/creative-focus.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=creative-focus/1.0.8&new_path=creative-focus/1.0.9

History:


https://themes.svn.wordpress.org/creative-focus/1.0.9/screenshot.png

#36 @poena
2 years ago

  • Resolution set to live
  • Status changed from reviewing to closed

Thank you for fixing this last issue. Congratulations, this theme is now live!

Note: See TracTickets for help on using tickets.