WordPress.org

Make WordPress Themes

Changes between Initial Version and Version 1 of Ticket #23430, comment 23


Ignore:
Timestamp:
06/03/15 14:07:08 (2 years ago)
Author:
jancbeck
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #23430, comment 23

    initial v1  
    4040since you already declared jQuery as a dependency of '''apricot-script''' that you enqueue a few lines later. 
    4141 
    42 You often use $_SERVER['HTTP_HOST'] without checking wether the key is present in $_SERVER. When running WordPress over CLI this will show a notice. Please use '''isset''' to avoid this. Also, why are you frequently testing for  
    43 {{{ 
    44 $_SERVER['HTTP_HOST']=='localhost' || $_SERVER['HTTP_HOST']=='ncrafts.net' 
    45 }}} 
    46 ? 
     42You often use `$_SERVER['HTTP_HOST']` without checking wether the key is present in $_SERVER. When running WordPress over CLI this will show a notice. Please use '''isset''' to avoid this. Also, why are you frequently testing for `$_SERVER['HTTP_HOST']=='localhost' || $_SERVER['HTTP_HOST']=='ncrafts.net'`? 
    4743 
    4844Throughout the theme there is code that seems to be some kind of contact form except there is only JavaScript and CSS.