WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#23520 closed theme (live)

THEME: WR-Elite – 1.4

Reported by: woorockets Owned by: cats_456
Priority: previously reviewed Keywords: theme-wr-elite
Cc: woorockets@…

Description

WR-Elite - 1.1

Elite is a free one page WordPress theme with edgy clean design and responsive layout. The theme is suitable for business pages, personal websites, portfolio, blog or any websites embracing simplicity. Well-designed layout with parallax background sections make scrolling through Elite a really pleasurable experience. View Elite’s live demo at http://demo.woorockets.com/#elite

Theme URL - http://www.woorockets.com/themes/elite/
Author URL - http://www.woorockets.com/

SVN - https://themes.svn.wordpress.org/wr-elite/1.1
ZIP - https://wordpress.org/themes/download/wr-elite.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wr-elite/1.0&new_path=wr-elite/1.1

History:

Ticket Summary Status Resolution Owner
#23226 THEME: WR-Elite - 1.0 closed closed-newer-version-uploaded yawalkarm
#23520 THEME: WR-Elite – 1.4 closed live cats_456

(this ticket)

#26284 THEME: WR-Elite – 1.6 closed live jcastaneda


https://themes.svn.wordpress.org/wr-elite/1.1/screenshot.png

Change History (14)

This ticket was mentioned in Slack in #themereview by quang2o12. View the logs.


3 years ago

#2 @themetracbot
3 years ago

  • Owner set to miyauchi
  • Status changed from new to reviewing

#3 follow-up: @woorockets
3 years ago

hello, any reviewer ?

#4 in reply to: ↑ 3 @ProComm365
3 years ago

Replying to woorockets:

hello, any reviewer ?

Sample Data is opening http://demo.woorockets.com/#Ferado, instead of the Elite demo.

Also all pages created using this theme keep hidden on the admin dashboard; although they are counted as "Published", cannot be accessible for editing, etc

#5 @cats_456
3 years ago

@grapplerulrich, I can review this theme, assign it to me please.

#6 @grapplerulrich
3 years ago

  • Owner changed from miyauchi to cats_456

Thank you @cats_456 for taking on this theme. :) It really appricated

#7 @cats_456
3 years ago

Hello @woorockets! This is a review for your theme. Please, fix issues from required section to continue.

Required

Code

  • header.php, line 51; extras.php, line 181, 191: If using templates, custom template files should be called using get_template_part() or locate_template().
  • extras.php: Use edit_theme_options capability for determining user permission to edit options, rather than rely on a role (e.g. “administrator”), or a different capability (e.g. “edit_themes”, “manage_options”).
  • init.php, line 128, 137, 152: all strings should be translatable
  • footer.php, line 19, 22, offline.php, etc: all untrusted data should be escaped before output (esc_attr, esc_textarea) ie all options from the db should be escaped
  • offline.php: all untrusted data in inline js should be escapes (esc_js) and strings translatable
  • acf.php: lack of translation functions
  • customzer.php, line > 337: wrong text-domen - 'ferado'
  • customizer.php, line 631-636: sanitisation/translation for js is needed
  • sample-data-installer: Don’t do things in a theme considered plugin territory.

Deleting/updating content is plugin territory.

  • extras.php, line 133: no escaping
  • extras.php, line 254: wrong text-domen
  • extras.php, line 289: lack of the translation function
  • breadcrumbs.php, line 34, 37 and so on: lack of translation functions
  • breadcrumbs.php, line > 40: lack of escape functions
  • rtl.css: empty file
  • The Screenshot should be of the actual theme as it appears with default options, not a logo or mockup.

Licensing

  • readme.txt: Declare licenses of any resources included such as fonts or images.
  • if theme uses code from other themes, it should include info about it

Other

Theme unit test:

  • There are no margins or paddings for content on smaller screens
  • Mobile menu doesn't work
  • Content background color is transparent on some pages
  • Header image seems to be too short
  • Featured image size: width 100% for all images
  • Images and video do not resize on small screens
  • Content-width seems to be wrong for some layouts

Note

  • adding copyright info to each file is not required
Last edited 3 years ago by cats_456 (previous) (diff)

#8 @themetracbot
3 years ago

  • Summary changed from THEME: WR-Elite – 1.1 to THEME: WR-Elite – 1.2

WR-Elite - 1.2

Elite is a free one page WordPress theme with edgy clean design and responsive layout. The theme is suitable for business pages, personal websites, portfolio, blog or any websites embracing simplicity. Well-designed layout with parallax background sections make scrolling through Elite a really pleasurable experience. View Elite’s live demo at http://demo.woorockets.com/#elite

Theme URL - http://www.woorockets.com/themes/elite/
Author URL - http://www.woorockets.com/

SVN - https://themes.svn.wordpress.org/wr-elite/1.2
ZIP - https://wordpress.org/themes/download/wr-elite.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wr-elite/1.1&new_path=wr-elite/1.2

History:

Ticket Summary Status Resolution Owner
#23226 THEME: WR-Elite - 1.0 closed closed-newer-version-uploaded yawalkarm
#23520 THEME: WR-Elite – 1.4 closed live cats_456

(this ticket)

#26284 THEME: WR-Elite – 1.6 closed live jcastaneda


https://themes.svn.wordpress.org/wr-elite/1.2/screenshot.png

#9 @cats_456
3 years ago

Hello @woorockets! This is a review for a new version.

Required

  • footer.php, line 21: there is no sanitization for:
<?php echo _e( wr_elite_theme_option( 'wr_footer_info' ) ); ?>


  • offline.php, line 30, there is no translation for:
$(this.el).html("<li>" + this.leadingZeros(data.years, 2) + " <span>years</span></li><li>" + this.leadingZeros(data.days, 3) + " <span>days</span></li><li>" + this.leadingZeros(data.hours, 2) + " <span>hours</span></li><li>" + this.leadingZeros(data.min, 2) + " <span>min</span></li><li>" + this.leadingZeros(data.sec, 2) + " <span>sec</span></li>");


  • editor-style.css: empty => tag 'editor-style' from style css and that file should be removed
  • custom.css: empty file
  • jquery.singlePageNav.min.js minification of script (original file should be provided)
  • welcome.php, line 126: data should be validated before saving (update_option function)
  • sample-data-installer.php/sample-data-installer folder: remove it please

Theme unit test

  • I have noticed some issue between date and left/two column layout
  • Theme version: should be increased after update I think

#10 @themetracbot
3 years ago

  • Summary changed from THEME: WR-Elite – 1.2 to THEME: WR-Elite – 1.3

WR-Elite - 1.3

Elite is a free one page WordPress theme with edgy clean design and responsive layout. The theme is suitable for business pages, personal websites, portfolio, blog or any websites embracing simplicity. Well-designed layout with parallax background sections make scrolling through Elite a really pleasurable experience. View Elite’s live demo at http://demo.woorockets.com/#elite

Theme URL - http://www.woorockets.com/themes/elite/
Author URL - http://www.woorockets.com/

SVN - https://themes.svn.wordpress.org/wr-elite/1.3
ZIP - https://wordpress.org/themes/download/wr-elite.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wr-elite/1.2&new_path=wr-elite/1.3

History:

Ticket Summary Status Resolution Owner
#23226 THEME: WR-Elite - 1.0 closed closed-newer-version-uploaded yawalkarm
#23520 THEME: WR-Elite – 1.4 closed live cats_456

(this ticket)

#26284 THEME: WR-Elite – 1.6 closed live jcastaneda


https://themes.svn.wordpress.org/wr-elite/1.3/screenshot.png

#11 @cats_456
3 years ago

Hello @woorockets!

  • footer.php: all untrusted data should be escaped before output, please escape it
<?php echo wr_elite_theme_option( 'wr_footer_info' ); ?>

should be

<?php echo esc_attr( wr_elite_theme_option( 'wr_footer_info' ) ); ?>

Check this for more info https://codex.wordpress.org/Data_Validation

  • welcome.php, line 126

I think data should be sanitized before saving for security purpose

	$status = $_REQUEST['status'];
	if( ! empty( $status ) ){
		update_option( 'wr_elite_welcome_banner_status', $status );
	}

#12 @themetracbot
3 years ago

  • Summary changed from THEME: WR-Elite – 1.3 to THEME: WR-Elite – 1.4

WR-Elite - 1.4

Elite is a free one page WordPress theme with edgy clean design and responsive layout. The theme is suitable for business pages, personal websites, portfolio, blog or any websites embracing simplicity. Well-designed layout with parallax background sections make scrolling through Elite a really pleasurable experience. View Elite’s live demo at http://demo.woorockets.com/#elite

Theme URL - http://www.woorockets.com/themes/elite/
Author URL - http://www.woorockets.com/

SVN - https://themes.svn.wordpress.org/wr-elite/1.4
ZIP - https://wordpress.org/themes/download/wr-elite.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=wr-elite/1.3&new_path=wr-elite/1.4

History:

Ticket Summary Status Resolution Owner
#23226 THEME: WR-Elite - 1.0 closed closed-newer-version-uploaded yawalkarm
#23520 THEME: WR-Elite – 1.4 closed live cats_456

(this ticket)

#26284 THEME: WR-Elite – 1.6 closed live jcastaneda


https://themes.svn.wordpress.org/wr-elite/1.4/screenshot.png

#13 @cats_456
3 years ago

  • Status changed from reviewing to approved

#14 @karmatosed
3 years ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations, this theme is now live!

Note: See TracTickets for help on using tickets.