WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#23555 closed theme (not-approved)

THEME: Stacker Lite – 1.0

Reported by: themefurnace Owned by: lancewillett
Priority: new theme Keywords: theme-stacker-lite
Cc: olidale+wordpress@…

Description

Stacker Lite - 1.0

Stacker Lite is a Grid-Based theme for showing off your photos, sketches and images.

Theme URL - http://themefurnace.com/stacker-lite-theme
Author URL - http://www.themefurnace.com

SVN - https://themes.svn.wordpress.org/stacker-lite/1.0
ZIP - https://wordpress.org/themes/download/stacker-lite.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#23555 THEME: Stacker Lite – 1.0 closed not-approved lancewillett

(this ticket)

#24142 THEME: Stacker Lite – 1.0.1 closed live lancewillett
#24230 THEME: Stacker Lite – 1.0.2 closed live jacenty3590
#46977 THEME: Stacker Lite – 1.0.4 closed live rabmalin


https://themes.svn.wordpress.org/stacker-lite/1.0/screenshot.png

Change History (5)

#1 @themetracbot
3 years ago

  • Owner set to lancewillett
  • Status changed from new to reviewing

#2 @lancewillett
3 years ago

Hi there. ;)

Wanted to say hello and let you know I'll be reviewing your theme.

#3 @themefurnace
3 years ago

Nice to meet you Lance,
Thanks a lot :)

#4 @lancewillett
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Stacker Lite

This theme is very close to approval. Nice job! If you upload a new version with fixes, please note in the comments to refer back to this review to see what was fixed.

Required

Theme will not be approved until these are fixed.

  • Escape stackerfooter_footer_text in footer.php -- see http://codex.wordpress.org/Data_Validation, probably esc_html()
  • Prefix all custom functions with the theme slug: missing are load_homepage_column_count(), custom_wp_trim_excerpt(), and custom_tag_cloud_widget()
  • Missing wp_link_pages() in single post template (it's only in page template right now). If you load the Theme Unit test data and look at the post "Template: Paginated" you'll see it doesn't work correctly.
  • Missing edit_post_link() for posts and pages (Edit link).

Recommended

Please consider fixing but won't block approval.

  • Move themefurnace_render_title to functions.php rather than putting it in header.php
  • Consider getting rid of your custom category logic and output and using WP function like get_the_category_list() instead: https://developer.wordpress.org/reference/functions/get_the_category_list/

Notes

You can see the Review guidelines and recommendations here: https://make.wordpress.org/themes/handbook/review/

Also see https://developer.wordpress.org/themes/release/theme-checklist/

Note: See TracTickets for help on using tickets.