WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#23646 closed theme (live)

THEME: Storefront – 1.4.2

Reported by: woothemes Owned by: jcastaneda
Priority: theme update Keywords: theme-storefront accessibility-ready
Cc: admin@…, joedolson

Description

Storefront - 1.4.0

Storefront is the perfect theme for your next WooCommerce project. Designed and developed by WooThemes, it features a deep integration with our market leading WooCommerce plugin, several layout & color options to personalise your shop, multiple widget regions, a responsive design and much more. Developers will love it’s lean and extensible codebase making it a joy to customise and extend. Looking for a WooCommerce theme? Look no further!

Theme URL - http://www.woothemes.com/storefront
Author URL - http://www.woothemes.com

SVN - https://themes.svn.wordpress.org/storefront/1.4.0
ZIP - https://wordpress.org/themes/download/storefront.1.4.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storefront/1.3.1&new_path=storefront/1.4.0

History:

Ticket Summary Status Resolution Owner
#10266 THEME: Storefront Paper - 1.0 closed not-approved chipbennett
#10515 THEME: Storefront Paper - 1.0.1 closed not-approved nishasingh
#15298 THEME: Storefront Paper - 1.0.5 closed live alex27
#15410 THEME: Storefront Paper - 1.0.6 closed live alex27
#17608 THEME: Storefront Paper - 1.1 closed not-approved Frank Klein
#17758 THEME: Storefront Paper - 1.1.1 closed live Frank Klein
#20573 THEME: Storefront - 1.0.2 closed closed-newer-version-uploaded gpriday
#21263 THEME: Storefront - 1.0.3 closed live gpriday
#21758 THEME: Storefront - 1.1.0 closed live emiluzelac
#21788 THEME: Storefront - 1.1.1 closed live karmatosed
#21928 THEME: Storefront - 1.2.0 closed live karmatosed
#22042 THEME: Storefront - 1.2.1 closed live karmatosed
#22476 THEME: Storefront - 1.2.2 closed live karmatosed
#22533 THEME: Storefront - 1.2.3 closed live karmatosed
#22681 THEME: Storefront - 1.2.4 closed live sakinshrestha
#22810 THEME: Storefront - 1.2.5 closed live jcastaneda
#23163 THEME: Storefront - 1.3.0 closed live emiluzelac
#23347 THEME: Storefront - 1.3.1 closed live emiluzelac
#23646 THEME: Storefront – 1.4.2 closed live jcastaneda

(this ticket)

#24170 THEME: Storefront – 1.4.3 closed live jcastaneda
#24484 THEME: Storefront – 1.4.4 closed live greenshady
#24888 THEME: Storefront – 1.4.5 closed live poena
#25322 THEME: Storefront – 1.4.6 closed live downstairsdev
#26413 THEME: Storefront – 1.5.0 closed live jcastaneda
#27103 THEME: Storefront – 1.5.1 closed live jcastaneda
#28155 THEME: Storefront – 1.5.2 closed live karmatosed
#28257 THEME: Storefront – 1.5.3 closed live jcastaneda
#29628 THEME: Storefront – 1.6.0 closed live greenshady
#29911 THEME: Storefront – 1.6.1 closed live Otto42
#32888 THEME: Storefront – 2.0.0 closed live themetracbot
#33053 THEME: Storefront – 2.0.1 closed live themetracbot
#33543 THEME: Storefront – 2.0.2 closed live themetracbot
#33580 THEME: Storefront – 2.0.3 closed live themetracbot
#33873 THEME: Storefront – 2.0.4 closed live themetracbot
#34387 THEME: Storefront – 2.0.5 closed live themetracbot
#34930 THEME: Storefront – 2.0.6 closed live themetracbot
#35093 THEME: Storefront – 2.0.7 closed live themetracbot
#35837 THEME: Storefront – 2.1.0 closed live themetracbot
#36084 THEME: Storefront – 2.1.1 closed live themetracbot
#36245 THEME: Storefront – 2.1.2 closed live themetracbot
#36641 THEME: Storefront – 2.1.3 closed live themetracbot
#37036 THEME: Storefront – 2.1.4 closed live themetracbot
#37329 THEME: Storefront – 2.1.5 closed live themetracbot
#37354 THEME: Storefront Child Theme – 1.0.0 closed not-approved poena
#37836 THEME: Storefront – 2.1.6 closed live themetracbot
#38474 THEME: Storefront Travel – 1.0 closed not-approved acosmin
#39515 THEME: Storefront – 2.1.7 closed live themetracbot
#40380 THEME: Storefront – 2.1.8 closed live themetracbot
#43062 THEME: Storefront – 2.2.0 closed live themetracbot
#43072 THEME: Storefront – 2.2.1 closed live themetracbot
#43079 THEME: Storefront – 2.2.2 closed live themetracbot
#43133 THEME: Storefront – 2.2.3 closed live themetracbot
#44245 THEME: Storefront – 2.2.4 closed live themetracbot
#45839 THEME: Storefront – 2.2.5 closed live themetracbot


https://themes.svn.wordpress.org/storefront/1.4.0/screenshot.png

Change History (19)

#1 @jcastaneda
3 years ago

  • Cc joedolson added
  • Keywords changed from theme-storefront, accessibility-ready to theme-storefront accessibility-ready
  • Owner set to jcastaneda
  • Status changed from new to reviewing

codewise the theme is good to go. This will need to have the a11y review so I've cc'd joedolson

@joe, would you be able to take on this or would you like to have david conduct it?

#2 @joedolson
3 years ago

  • Cc davidakennedy added; joedolson removed

If David has some availability, I'd prefer that; I'm pretty heavily committed right now. I'll add his CC.

#3 @jcastaneda
3 years ago

Great! Thanks Joe! :)

#4 @jameskoster
3 years ago

Any idea when this might get looked at? We're close to having another release ready :p

#5 @joedolson
3 years ago

  • Cc joedolson added

I haven't heard anything from David; I'm assuming he doesn't have time right now. I'll take a look at it tomorrow or Monday, unless he gets to it first.

#6 @davidakennedy
3 years ago

Hey @joedolson,

Sorry, I haven't got to this one yet. I was catching up on some other reviews. If you don't get to it tomorrow, I can grab Monday.

Question: Would we need to look through the WooCommerce portions of the theme as well? I've never done one like this before?

#7 @jameskoster
3 years ago

Thanks for the update guys.

#8 @joedolson
3 years ago

  • Cc davidakennedy removed

I'm going to take this one instead of David, since I've got more familiarity with Woo Commerce. I'll do it later today.

#9 @joedolson
3 years ago

Accessibility Review:

1) Headings

It looks like you're only use H1 headings. This extremely flat heading structure doesn't really help screen reader users understand the structure of your site, although it's technically accessible. I'd prefer to see a hierarchical structure, so that regions of your site appear to be clearly grouped by the heading structure. This passes, but it's not preferred.

2) Landmark Roles

The role for the footer is incorrect; it should be 'contentinfo'. (Yes, the guidelines had a mistake, which I've now fixed!) Skip links are not contained inside any role; they should be inside the banner role or be wrapped in their own navigation role. (Inside banner role is preferred.)

There's a header region for widgets that should also have a role (complementary). Ideally, the region container would not appear at all when there are no widgets assigned to the region. (See wp_get_sidebars_widgets())

3) Link text

Looks good.

4) Controls

The submit button on the search form is hidden using display: none - it should be hidden using screen-reader-text, instead.

The menu button looks fine...but didn't appear to work. Not an accessibility issue, per se, it just didn't work. The aria-expanded attribute was toggled, which is great - but the menu wasn't.

5) Keyboard Navigation

Everything is available, but the keyboard :focus visible state is extremely minimal, and difficult to see. It appears to be the browser default, which is pretty good on Chrome, but everywhere else is pretty minimal. I'd advise you to add some kind of visible change on :focus (for inputs, buttons, and links) that makes it easier for users to see where they are while navigating using the keyboard.

6) Contrast

A bunch of the inline code tags (kbd, code, etc.) fall just under the required color contrast ratio at 4.31:1; darken those just a little bit and they should be fine.

7) Skip Links

I don't think that the Skip to Navigation link serves any significant purpose, but you're not required to remove it. The purpose of a Skip link is not so much navigational as efficiency: the ability to choose something from navigation, then not have to go through the navigation bar again once arriving at the target page. If there's a possibility of a large volume of content between the skip link and the navigation, however, this could be valuable.

8) Forms

The hidden submit on the search widget, as mentioned previously. Otherwise they look fine.

9) Images

No concerns.

10) Media

No concerns.

11) Disallowed attributes

No concerns.

Recommended:

1) Text zoom

Looks pretty good.

2) title attributes

Look pretty good.

WooCommerce integration:

  • Replace display: none on search form with screen reader text styles.
  • Color contrast on .woocommerce-message has 2.54:1 contrast; improve contrast

There are other issues with WooCommerce that would benefit from improvement, but it's OK, and those aren't issues readily addressed within a theme.

On the whole, what you must change for the tag are the Landmark Role issues, the submit buttons, the menu, and the color contrast issues.

I'd like to see a better hierarchy for the headings; the completely flat hierarchy doesn't offer much for either accessibility or SEO, because it doesn't give any perspective on content organization, and I'd *really* like to see better :hover and :focus states, but they aren't explicitly required.

#10 @themetracbot
3 years ago

  • Summary changed from THEME: Storefront – 1.4.0 to THEME: Storefront – 1.4.1

Storefront - 1.4.1

Storefront is the perfect theme for your next WooCommerce project. Designed and developed by WooThemes, it features a deep integration with our market leading WooCommerce plugin, several layout & color options to personalise your shop, multiple widget regions, a responsive design and much more. Developers will love it’s lean and extensible codebase making it a joy to customise and extend. Looking for a WooCommerce theme? Look no further!

Theme URL - http://www.woothemes.com/storefront
Author URL - http://www.woothemes.com

SVN - https://themes.svn.wordpress.org/storefront/1.4.1
ZIP - https://wordpress.org/themes/download/storefront.1.4.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storefront/1.4.0&new_path=storefront/1.4.1

History:

Ticket Summary Status Resolution Owner
#10266 THEME: Storefront Paper - 1.0 closed not-approved chipbennett
#10515 THEME: Storefront Paper - 1.0.1 closed not-approved nishasingh
#15298 THEME: Storefront Paper - 1.0.5 closed live alex27
#15410 THEME: Storefront Paper - 1.0.6 closed live alex27
#17608 THEME: Storefront Paper - 1.1 closed not-approved Frank Klein
#17758 THEME: Storefront Paper - 1.1.1 closed live Frank Klein
#20573 THEME: Storefront - 1.0.2 closed closed-newer-version-uploaded gpriday
#21263 THEME: Storefront - 1.0.3 closed live gpriday
#21758 THEME: Storefront - 1.1.0 closed live emiluzelac
#21788 THEME: Storefront - 1.1.1 closed live karmatosed
#21928 THEME: Storefront - 1.2.0 closed live karmatosed
#22042 THEME: Storefront - 1.2.1 closed live karmatosed
#22476 THEME: Storefront - 1.2.2 closed live karmatosed
#22533 THEME: Storefront - 1.2.3 closed live karmatosed
#22681 THEME: Storefront - 1.2.4 closed live sakinshrestha
#22810 THEME: Storefront - 1.2.5 closed live jcastaneda
#23163 THEME: Storefront - 1.3.0 closed live emiluzelac
#23347 THEME: Storefront - 1.3.1 closed live emiluzelac
#23646 THEME: Storefront – 1.4.2 closed live jcastaneda

(this ticket)

#24170 THEME: Storefront – 1.4.3 closed live jcastaneda
#24484 THEME: Storefront – 1.4.4 closed live greenshady
#24888 THEME: Storefront – 1.4.5 closed live poena
#25322 THEME: Storefront – 1.4.6 closed live downstairsdev
#26413 THEME: Storefront – 1.5.0 closed live jcastaneda
#27103 THEME: Storefront – 1.5.1 closed live jcastaneda
#28155 THEME: Storefront – 1.5.2 closed live karmatosed
#28257 THEME: Storefront – 1.5.3 closed live jcastaneda
#29628 THEME: Storefront – 1.6.0 closed live greenshady
#29911 THEME: Storefront – 1.6.1 closed live Otto42
#32888 THEME: Storefront – 2.0.0 closed live themetracbot
#33053 THEME: Storefront – 2.0.1 closed live themetracbot
#33543 THEME: Storefront – 2.0.2 closed live themetracbot
#33580 THEME: Storefront – 2.0.3 closed live themetracbot
#33873 THEME: Storefront – 2.0.4 closed live themetracbot
#34387 THEME: Storefront – 2.0.5 closed live themetracbot
#34930 THEME: Storefront – 2.0.6 closed live themetracbot
#35093 THEME: Storefront – 2.0.7 closed live themetracbot
#35837 THEME: Storefront – 2.1.0 closed live themetracbot
#36084 THEME: Storefront – 2.1.1 closed live themetracbot
#36245 THEME: Storefront – 2.1.2 closed live themetracbot
#36641 THEME: Storefront – 2.1.3 closed live themetracbot
#37036 THEME: Storefront – 2.1.4 closed live themetracbot
#37329 THEME: Storefront – 2.1.5 closed live themetracbot
#37354 THEME: Storefront Child Theme – 1.0.0 closed not-approved poena
#37836 THEME: Storefront – 2.1.6 closed live themetracbot
#38474 THEME: Storefront Travel – 1.0 closed not-approved acosmin
#39515 THEME: Storefront – 2.1.7 closed live themetracbot
#40380 THEME: Storefront – 2.1.8 closed live themetracbot
#43062 THEME: Storefront – 2.2.0 closed live themetracbot
#43072 THEME: Storefront – 2.2.1 closed live themetracbot
#43079 THEME: Storefront – 2.2.2 closed live themetracbot
#43133 THEME: Storefront – 2.2.3 closed live themetracbot
#44245 THEME: Storefront – 2.2.4 closed live themetracbot
#45839 THEME: Storefront – 2.2.5 closed live themetracbot


https://themes.svn.wordpress.org/storefront/1.4.1/screenshot.png

#11 @themetracbot
3 years ago

  • Summary changed from THEME: Storefront – 1.4.1 to THEME: Storefront – 1.4.2

Storefront - 1.4.2

Storefront is the perfect theme for your next WooCommerce project. Designed and developed by WooThemes, it features a deep integration with our market leading WooCommerce plugin, several layout & color options to personalise your shop, multiple widget regions, a responsive design and much more. Developers will love it’s lean and extensible codebase making it a joy to customise and extend. Looking for a WooCommerce theme? Look no further!

Theme URL - http://www.woothemes.com/storefront
Author URL - http://www.woothemes.com

SVN - https://themes.svn.wordpress.org/storefront/1.4.2
ZIP - https://wordpress.org/themes/download/storefront.1.4.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=storefront/1.4.1&new_path=storefront/1.4.2

History:

Ticket Summary Status Resolution Owner
#10266 THEME: Storefront Paper - 1.0 closed not-approved chipbennett
#10515 THEME: Storefront Paper - 1.0.1 closed not-approved nishasingh
#15298 THEME: Storefront Paper - 1.0.5 closed live alex27
#15410 THEME: Storefront Paper - 1.0.6 closed live alex27
#17608 THEME: Storefront Paper - 1.1 closed not-approved Frank Klein
#17758 THEME: Storefront Paper - 1.1.1 closed live Frank Klein
#20573 THEME: Storefront - 1.0.2 closed closed-newer-version-uploaded gpriday
#21263 THEME: Storefront - 1.0.3 closed live gpriday
#21758 THEME: Storefront - 1.1.0 closed live emiluzelac
#21788 THEME: Storefront - 1.1.1 closed live karmatosed
#21928 THEME: Storefront - 1.2.0 closed live karmatosed
#22042 THEME: Storefront - 1.2.1 closed live karmatosed
#22476 THEME: Storefront - 1.2.2 closed live karmatosed
#22533 THEME: Storefront - 1.2.3 closed live karmatosed
#22681 THEME: Storefront - 1.2.4 closed live sakinshrestha
#22810 THEME: Storefront - 1.2.5 closed live jcastaneda
#23163 THEME: Storefront - 1.3.0 closed live emiluzelac
#23347 THEME: Storefront - 1.3.1 closed live emiluzelac
#23646 THEME: Storefront – 1.4.2 closed live jcastaneda

(this ticket)

#24170 THEME: Storefront – 1.4.3 closed live jcastaneda
#24484 THEME: Storefront – 1.4.4 closed live greenshady
#24888 THEME: Storefront – 1.4.5 closed live poena
#25322 THEME: Storefront – 1.4.6 closed live downstairsdev
#26413 THEME: Storefront – 1.5.0 closed live jcastaneda
#27103 THEME: Storefront – 1.5.1 closed live jcastaneda
#28155 THEME: Storefront – 1.5.2 closed live karmatosed
#28257 THEME: Storefront – 1.5.3 closed live jcastaneda
#29628 THEME: Storefront – 1.6.0 closed live greenshady
#29911 THEME: Storefront – 1.6.1 closed live Otto42
#32888 THEME: Storefront – 2.0.0 closed live themetracbot
#33053 THEME: Storefront – 2.0.1 closed live themetracbot
#33543 THEME: Storefront – 2.0.2 closed live themetracbot
#33580 THEME: Storefront – 2.0.3 closed live themetracbot
#33873 THEME: Storefront – 2.0.4 closed live themetracbot
#34387 THEME: Storefront – 2.0.5 closed live themetracbot
#34930 THEME: Storefront – 2.0.6 closed live themetracbot
#35093 THEME: Storefront – 2.0.7 closed live themetracbot
#35837 THEME: Storefront – 2.1.0 closed live themetracbot
#36084 THEME: Storefront – 2.1.1 closed live themetracbot
#36245 THEME: Storefront – 2.1.2 closed live themetracbot
#36641 THEME: Storefront – 2.1.3 closed live themetracbot
#37036 THEME: Storefront – 2.1.4 closed live themetracbot
#37329 THEME: Storefront – 2.1.5 closed live themetracbot
#37354 THEME: Storefront Child Theme – 1.0.0 closed not-approved poena
#37836 THEME: Storefront – 2.1.6 closed live themetracbot
#38474 THEME: Storefront Travel – 1.0 closed not-approved acosmin
#39515 THEME: Storefront – 2.1.7 closed live themetracbot
#40380 THEME: Storefront – 2.1.8 closed live themetracbot
#43062 THEME: Storefront – 2.2.0 closed live themetracbot
#43072 THEME: Storefront – 2.2.1 closed live themetracbot
#43079 THEME: Storefront – 2.2.2 closed live themetracbot
#43133 THEME: Storefront – 2.2.3 closed live themetracbot
#44245 THEME: Storefront – 2.2.4 closed live themetracbot
#45839 THEME: Storefront – 2.2.5 closed live themetracbot


https://themes.svn.wordpress.org/storefront/1.4.2/screenshot.png

#12 @jameskoster
3 years ago

@joedolson hopefully that's everything :-)

#13 @joedolson
3 years ago

Awesome. I'll check it out shortly.

#14 @joedolson
3 years ago

Sorry about the delay; this will be done in the next couple hours.

#15 @joedolson
2 years ago

Looks good! Pass for accessibility ready. Thank you!

#16 @jcastaneda
2 years ago

  • Resolution set to live
  • Status changed from reviewing to closed

Awesomesauce! Thanks for that! :)

I cam across no issues, so setting live. :)

#17 @joedolson
2 years ago

While reviewing Boutique, I noticed that the mini cart dropdown in the menu when Woo Commerce is activated is only available on :hover, and not when the trigger link receives keyboard focus; this should be fixed in the next release. Thanks!

#19 @joedolson
2 years ago

Awesome. Thanks!

Note: See TracTickets for help on using tickets.