WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

#24060 closed theme (not-approved)

THEME: Microblog – 1.0

Reported by: bestwebsoft Owned by: webulous
Priority: new theme Keywords: theme-microblog
Cc: wp@…, grapplerulrich

Description

Microblog - 1.0

Microblog is a state-of-the-art theme, which will be perfect for news websites and blogs that are meant for sharing large amounts of data to the wide audience. With Microblog, readers will stay focused on the content, while the aesthetically pleasing design will ensure that your website will be remembered and returned to. At the same time, this theme is rich in functionality, and simple in operation, which is a bonus if you don’t want to waste to spend hours on customization. Furthermore, Microblog introduces a fresh and handy way to navigate through your website. Check out theme demo at http://bestwebsoft.com/wordpress_demo_theme/microblog/

Theme URL - http://bestwebsoft.com/products/microblog
Author URL - https://github.com/bestwebsoft/

SVN - https://themes.svn.wordpress.org/microblog/1.0
ZIP - https://wordpress.org/themes/download/microblog.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#24060 THEME: Microblog – 1.0 closed not-approved webulous

(this ticket)

#25598 THEME: Microblog – 1.2 closed live catchthemes
#36059 THEME: Microblog – 1.3 closed live themetracbot


https://themes.svn.wordpress.org/microblog/1.0/screenshot.png

Change History (5)

#1 @themetracbot
3 years ago

  • Owner set to webulous
  • Status changed from new to reviewing

#2 @grapplerulrich
3 years ago

  • Cc grapplerulrich added

I am adding myself as a mentor.

#3 @webulous
3 years ago

Thank Ulrich!

Hello BestWebSoft,
Thank you for submitting your theme. Below are my observation during review.

Required

  • Theme URI returns 404

header.php

  • charset, pingback_url and profile are not used
  • Please remove these unwanted code
    elseif ( get_post_type() == 'portfolio' ) : {/*block for plugin portfolio header support*/
    	global $post, $wpdb, $wp_query, $request;
    	$portfolio_options = get_option( 'prtfl_options' );
    	if ( isset( $wp_query->query_vars['technologies'] ) ) {
    		$term = get_term_by( 'slug', $wp_query->query_vars['technologies'], 'portfolio_technologies' );
    		echo $portfolio_options['prtfl_technologies_text_field'] . ' ' . ( $term->name );
    	} elseif ( isset( $wp_query->query_vars['portfolio_executor_profile'] ) ) {
    		$term = get_term_by( 'slug', $wp_query->query_vars['portfolio_executor_profile'], 'portfolio_executor_profile' );
    		echo __( 'Executor Profile', 'microblog' ) . ': ' . ( $term->name );
    		$_SESSION['prtfl_page_name'] = __( 'Executor Profile', 'microblog' ) . ': ' . ( $term->name );
    		$_SESSION['prtfl_page_url']  = get_pagenum_link( $wp_query->query_vars['paged'] );
    	} else {
    		the_title();
    	}
    } /*end portfolio header*/
    

sidebar.php

Could you please explain why you add and remove filter, just curious?
`<?php add_filter( 'get_search_form', 'mcrblg_searchform' ); /*custom searchorm in sidebar*/?>
<?php remove_filter( 'get_search_form', 'mcrblg_searchform' ); ?>`

editor-style.css

*is empty

function_exists() and backward compatibility

  • wp_get_theme() exists since 3.4.0, so you shouldn't use function_exists for that
  • is_plugin_active_for_network exists since 3.0, so no function_exists
  • is_multisite exists since 3.0, so no function_exists check
  • No backward compatibility is necessary other than previous 2 major releases.

So this check seems unnecessary $wp_version >= '3.4'

style.css

  • screen-reader-text is not present, .gallery-caption is not styled

Translation Ready

In $bws_plugins = array() 'name' elements should be translatable.
Also, this menu library uses different textdomain (of course, you've provided separate languages folder for that). I'm not sure whether 2 textdomain are allowed except for third party frameworks such as Redux, etc @grapplerulrich will clarify this

Notes (to Ulrich)

I'm not sure whether you can include core WP file and use ABSPATH
in bws_menu.php file.

I know that Upselling is allowed. But selling other themes and plugins are allowed?
Also, there is an option to send system info to theme author as email. Is this allowed?

#4 @grapplerulrich
3 years ago

You did a good review. :)

I'm not sure whether you can include core WP file and use ABSPATH in bws_menu.php file.

This is one of the few exceptions where ABSPATH can be used.

I know that Upselling is allowed. But selling other themes and plugins are allowed?

It is border line but I would allow it. I reviewed anther theme with the same bws_menu folder and issue I saw was that the code was allowing installation of plugins from not WordPress.org
https://themes.trac.wordpress.org/ticket/24059#comment:2

Also, there is an option to send system info to theme author as email. Is this allowed?

The system information is plugin territory.

#5 @webulous
3 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello BestWebSoft,

I'm closing this ticket due to inactivity.
https://make.wordpress.org/themes/handbook/review/

Venkat

Note: See TracTickets for help on using tickets.