WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#24071 closed theme (live)

THEME: Kichu – 1.4.1

Reported by: hardeepasrani Owned by: kevinhaig
Priority: new theme Keywords: theme-kichu
Cc: hardeepasrani@…

Description

Kichu - 1.0

Kichu is one column theme, which supports all the post formats. This design focuses on your content & is perfect for an elegant blog site. This theme allows you to customize colors, and is translation-ready.

Theme URL - http://www.hardeepasrani.com/portfolio/wordpress-themes/kichu/
Author URL - http://www.hardeepasrani.com

SVN - https://themes.svn.wordpress.org/kichu/1.0
ZIP - https://wordpress.org/themes/download/kichu.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#24071 THEME: Kichu – 1.4.1 closed live kevinhaig

(this ticket)

#24880 THEME: Kichu – 1.4.2.1 closed live poena
#25293 THEME: Kichu – 1.4.2.2 closed live poena
#28215 THEME: Kichu – 1.4.3 closed live jcastaneda
#28295 THEME: Kichu – 1.4.3.1 closed live jcastaneda
#28406 THEME: Kichu – 1.4.3.2 closed live jcastaneda
#29127 THEME: Kichu – 1.4.3.3 closed live karmatosed
#29418 THEME: Kichu – 1.5 closed live emiluzelac
#31804 THEME: Kichu – 1.5.1 closed live themetracbot
#32031 THEME: Kichu – 1.5.2 closed live themetracbot


https://themes.svn.wordpress.org/kichu/1.0/screenshot.png

Change History (24)

#1 @themetracbot
3 years ago

  • Summary changed from THEME: Kichu – 1.0 to THEME: Kichu – 1.1

Kichu - 1.1

Kichu is one column theme, which supports all the post formats. This design focuses on your content & is perfect for an elegant blog site. This theme allows you to customize colors, and is translation-ready.

Theme URL - http://www.hardeepasrani.com/portfolio/wordpress-themes/kichu/
Author URL - http://www.hardeepasrani.com

SVN - https://themes.svn.wordpress.org/kichu/1.1
ZIP - https://wordpress.org/themes/download/kichu.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=kichu/1.0&new_path=kichu/1.1

History:

Ticket Summary Status Resolution Owner
#24071 THEME: Kichu – 1.4.1 closed live kevinhaig

(this ticket)

#24880 THEME: Kichu – 1.4.2.1 closed live poena
#25293 THEME: Kichu – 1.4.2.2 closed live poena
#28215 THEME: Kichu – 1.4.3 closed live jcastaneda
#28295 THEME: Kichu – 1.4.3.1 closed live jcastaneda
#28406 THEME: Kichu – 1.4.3.2 closed live jcastaneda
#29127 THEME: Kichu – 1.4.3.3 closed live karmatosed
#29418 THEME: Kichu – 1.5 closed live emiluzelac
#31804 THEME: Kichu – 1.5.1 closed live themetracbot
#32031 THEME: Kichu – 1.5.2 closed live themetracbot


https://themes.svn.wordpress.org/kichu/1.1/screenshot.png

#2 @themetracbot
3 years ago

  • Summary changed from THEME: Kichu – 1.1 to THEME: Kichu – 1.1.1

Kichu - 1.1.1

Kichu is one column theme, which supports all the post formats. This design focuses on your content & is perfect for an elegant blog site. This theme allows you to customize colors, and is translation-ready.

Theme URL - http://www.hardeepasrani.com/portfolio/wordpress-themes/kichu/
Author URL - http://www.hardeepasrani.com

SVN - https://themes.svn.wordpress.org/kichu/1.1.1
ZIP - https://wordpress.org/themes/download/kichu.1.1.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=kichu/1.1&new_path=kichu/1.1.1

History:

Ticket Summary Status Resolution Owner
#24071 THEME: Kichu – 1.4.1 closed live kevinhaig

(this ticket)

#24880 THEME: Kichu – 1.4.2.1 closed live poena
#25293 THEME: Kichu – 1.4.2.2 closed live poena
#28215 THEME: Kichu – 1.4.3 closed live jcastaneda
#28295 THEME: Kichu – 1.4.3.1 closed live jcastaneda
#28406 THEME: Kichu – 1.4.3.2 closed live jcastaneda
#29127 THEME: Kichu – 1.4.3.3 closed live karmatosed
#29418 THEME: Kichu – 1.5 closed live emiluzelac
#31804 THEME: Kichu – 1.5.1 closed live themetracbot
#32031 THEME: Kichu – 1.5.2 closed live themetracbot


https://themes.svn.wordpress.org/kichu/1.1.1/screenshot.png

#3 @themetracbot
3 years ago

  • Summary changed from THEME: Kichu – 1.1.1 to THEME: Kichu – 1.1.2

Kichu - 1.1.2

Kichu is one column theme, which supports all the post formats. This design focuses on your content & is perfect for an elegant blog site. This theme allows you to customize colors, and is translation-ready.

Theme URL - http://www.hardeepasrani.com/portfolio/wordpress-themes/kichu/
Author URL - http://www.hardeepasrani.com

SVN - https://themes.svn.wordpress.org/kichu/1.1.2
ZIP - https://wordpress.org/themes/download/kichu.1.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=kichu/1.1.1&new_path=kichu/1.1.2

History:

Ticket Summary Status Resolution Owner
#24071 THEME: Kichu – 1.4.1 closed live kevinhaig

(this ticket)

#24880 THEME: Kichu – 1.4.2.1 closed live poena
#25293 THEME: Kichu – 1.4.2.2 closed live poena
#28215 THEME: Kichu – 1.4.3 closed live jcastaneda
#28295 THEME: Kichu – 1.4.3.1 closed live jcastaneda
#28406 THEME: Kichu – 1.4.3.2 closed live jcastaneda
#29127 THEME: Kichu – 1.4.3.3 closed live karmatosed
#29418 THEME: Kichu – 1.5 closed live emiluzelac
#31804 THEME: Kichu – 1.5.1 closed live themetracbot
#32031 THEME: Kichu – 1.5.2 closed live themetracbot


https://themes.svn.wordpress.org/kichu/1.1.2/screenshot.png

#4 @themetracbot
3 years ago

  • Summary changed from THEME: Kichu – 1.1.2 to THEME: Kichu – 1.2

Kichu - 1.2

Kichu is one column theme, which supports all the post formats. This design focuses on your content & is perfect for an elegant blog site. This theme allows you to customize colors, and is translation-ready.

Theme URL - http://www.hardeepasrani.com/portfolio/wordpress-themes/kichu/
Author URL - http://www.hardeepasrani.com

SVN - https://themes.svn.wordpress.org/kichu/1.2
ZIP - https://wordpress.org/themes/download/kichu.1.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=kichu/1.1.2&new_path=kichu/1.2

History:

Ticket Summary Status Resolution Owner
#24071 THEME: Kichu – 1.4.1 closed live kevinhaig

(this ticket)

#24880 THEME: Kichu – 1.4.2.1 closed live poena
#25293 THEME: Kichu – 1.4.2.2 closed live poena
#28215 THEME: Kichu – 1.4.3 closed live jcastaneda
#28295 THEME: Kichu – 1.4.3.1 closed live jcastaneda
#28406 THEME: Kichu – 1.4.3.2 closed live jcastaneda
#29127 THEME: Kichu – 1.4.3.3 closed live karmatosed
#29418 THEME: Kichu – 1.5 closed live emiluzelac
#31804 THEME: Kichu – 1.5.1 closed live themetracbot
#32031 THEME: Kichu – 1.5.2 closed live themetracbot


https://themes.svn.wordpress.org/kichu/1.2/screenshot.png

#5 @themetracbot
3 years ago

  • Summary changed from THEME: Kichu – 1.2 to THEME: Kichu – 1.3

Kichu - 1.3

Kichu is one column theme, which supports all the post formats. This design focuses on your content & is perfect for an elegant blog site. This theme allows you to customize colors, and is translation-ready.

Theme URL - http://www.hardeepasrani.com/portfolio/wordpress-themes/kichu/
Author URL - http://www.hardeepasrani.com

SVN - https://themes.svn.wordpress.org/kichu/1.3
ZIP - https://wordpress.org/themes/download/kichu.1.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=kichu/1.2&new_path=kichu/1.3

History:

Ticket Summary Status Resolution Owner
#24071 THEME: Kichu – 1.4.1 closed live kevinhaig

(this ticket)

#24880 THEME: Kichu – 1.4.2.1 closed live poena
#25293 THEME: Kichu – 1.4.2.2 closed live poena
#28215 THEME: Kichu – 1.4.3 closed live jcastaneda
#28295 THEME: Kichu – 1.4.3.1 closed live jcastaneda
#28406 THEME: Kichu – 1.4.3.2 closed live jcastaneda
#29127 THEME: Kichu – 1.4.3.3 closed live karmatosed
#29418 THEME: Kichu – 1.5 closed live emiluzelac
#31804 THEME: Kichu – 1.5.1 closed live themetracbot
#32031 THEME: Kichu – 1.5.2 closed live themetracbot


https://themes.svn.wordpress.org/kichu/1.3/screenshot.png

#6 @themetracbot
3 years ago

  • Owner set to marioernestoms
  • Status changed from new to reviewing

#7 @hardeepasrani
3 years ago

Hi,

Thanks for reviewing my theme. I've found a new issue in my theme so if you don't find anything then please reply once before approving so I could fix the issue with floating image. Thanks. :)

#8 @hardeepasrani
3 years ago

@marioernestoms Could you please let me know when will you do the review? :)

This ticket was mentioned in Slack in #themereview by hardeepasrani. View the logs.


3 years ago

#10 @emiluzelac
3 years ago

  • Owner changed from marioernestoms to kevinhaig

#11 @kevinhaig
3 years ago

Kichu 1.4
Theme Review
==================
Hi @hardeepasrani, I am @kevinhaig and I picked up the review of your theme. PS never found the problem with the floating image :)

Outcome

  • Theme left as reviewing for 7 days, and it may be closed after that if there is no response. Note that if you need more time, please make a comment in the ticket.

Required

  • Code
    • your chat post format is showing the excerpt at the top of the content area in single.php
    • your custom menu system does not support nested menus or long menus, you simply can't get to menu items beyond the screen, shouldn't the vertical scroll extend to include all menu items?
    • Support the following WordPress-generated CSS classes:
      • screen-reader-text (can be unstyled)
  • Core Functionality and Features
    • Use get_template_directory() rather than TEMPLATEPATH to return the template path, functions.php
    • The theme tags and description must match the what the theme actually does in respect to functionality and design.
      • you have added support for featured images but I don't see any featured images anywhere?
  • Licensing
    • Declare copyright and license explicitly. Use the license and license uri header slugs to style.css.
      • add this to you your style.css, for example (recommended but not required)
             Fred WordPress Theme, Copyright 2012 Joe Smith
             Fred is distributed under the terms of the GNU GPL
        
      • You need to add documentation to your files, including licensing. (Strongly recommended but not required)
        • here is an example of what I would recommend
          /**
           * themeslug XXXXXXXX file
           * This file does ...... see example below
           *
           * This file is the Error 404 Page template file, which is output whenever
           * the server encounters a "404 - file not found" error.
           *
           * @package       themeslug WordPress Theme 
           * @copyright    Copyright (C) YEAR, AUTHOR
           * @license         GPLv2 or later http://www.gnu.org/licenses/quick-guide-gplv3.html
           * @author          AUTHOR <www.author.site/contact/>
           * themeslug is distributed under the terms of the GNU GPL
           */
          
    • ref: https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/
  • Screenshot
    • The screenshot.png should be no bigger than1200x 900px.
    • this is a recent change if you would like to update your screenshot, now is the time
  • Security and Privacy
    • All untrusted data should be escaped before output.
      • you are not escaping any option data in kichu_customizer_head()
  • Stylesheets and Scripts
    • No hard coding of scripts, styles and Favicons unless a browser workaround script. Everything should be enqueued.
      • don't need to register styles anymore, just enqueue them
      • don't need to enqueue jquery any more, core does that
  • Language
    • translate 'Primary Menu' in header.php
    • your load_theme_textdomain('kichu'); does not include a folder?
    • it is strongly recommended to include a kichu.pot file

Recommended

  • Recommended items are not required for theme approval, however if you decide to add them they are Required to function properly

Recommended from Theme Check (@hardeepasrani, I always mention these once, I realize you have probably considered them already)

  • This theme contains no sidebars/widget areas. See Widgets API
  • No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
  • No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • No reference to add_editor_style() was found in the theme. It is recommended that the theme implement editor styling, so as to make the editor content match the resulting post output in the theme, for a better user experience.

Recommended from Theme Unit Test

  • Template: Paginated, shouldn't the pagination links show on the blog as well as single.php?
  • Antiestablishmentarianism, your css fails this test

code/design considerations

  • these comments are not required for theme approval, they are just my observations
  • you should consider removing image captions from your galleries, they would show better

Notes to Author

  • theme is open for 7 days, if you need additional time to address the review make sure you make a comment to that effect in the ticket, or the theme may be closed
  • reminders
    • make sure you thoroughly test your changes functionally and visually
    • download Debug Bar by wordpressdotorg, and get it running properly, it will help you debug your theme
    • use the Theme Unit Test data as the basis for your testing
    • always test your theme in a brand new test bed to see that it loads into the admin section and displays for the first time without errors

#12 follow-up: @hardeepasrani
3 years ago

Hi Kevin,

Thanks a lot for a very detailed review. I will fix them in 1.5 update but I've some questions before I do that.


your chat post format is showing the excerpt at the top of the content area in single.php

Is it not right? It's like the chat summary with the chat content below. Justin Tadlock(@greenshady) uses the same in his Chun theme, so it shouldn't be an issue: https://themes.svn.wordpress.org/chun/0.1.2/content-chat.php


The theme tags and description must match the what the theme actually does in respect to functionality and design.

Please let me what you found in the tags/description which you think don't go with the theme, so I could fix it. :)


you have added support for featured images but I don't see any featured images anywhere?

I added that more for plugins that uses featured images for SEO and stuff. Am I required to display it somewhere at least?


Template: Paginated, shouldn't the pagination links show on the blog as well as single.php?

What? I believe I missed something. Please describe this issue because I'm not clear about this one. :p


Thanks a lot for the review. Please answer my questions so I could upload a new updated version. And for future, would you like me to contact your on the trac or on Slack? :)

PS: I was talking about this floating image issue: http://www.hardeepasrani.com/demo/kichu/about/clearing-floats/ :)

#13 in reply to: ↑ 12 @kevinhaig
3 years ago

Replying to hardeepasrani:

Hi Kevin,

Thanks a lot for a very detailed review. I will fix them in 1.5 update but I've some questions before I do that.


your chat post format is showing the excerpt at the top of the content area in single.php

Is it not right? It's like the chat summary with the chat content below. Justin Tadlock(@greenshady) uses the same in his Chun theme, so it shouldn't be an issue: https://themes.svn.wordpress.org/chun/0.1.2/content-chat.php

OK if you are happy with that....actually it looks like a bug to me


The theme tags and description must match the what the theme actually does in respect to functionality and design.

Please let me what you found in the tags/description which you think don't go with the theme, so I could fix it. :)

That is referring to the featured-images tag, as my comment about your featured image support was listed under this requirement


you have added support for featured images but I don't see any featured images anywhere?

I added that more for plugins that uses featured images for SEO and stuff. Am I required to display it somewhere at least?

I am checking on slack for this one, I am still of the opinion that it should be used if you support it.


Template: Paginated, shouldn't the pagination links show on the blog as well as single.php?

What? I believe I missed something. Please describe this issue because I'm not clear about this one. :p

The blog page does not list the pagination pages because you are including that in your meta. If you are fine with having to go to single.php to see the page links, then that is fine.


Thanks a lot for the review. Please answer my questions so I could upload a new updated version. And for future, would you like me to contact your on the trac or on Slack? :)

PS: I was talking about this floating image issue: http://www.hardeepasrani.com/demo/kichu/about/clearing-floats/ :)

#14 @themetracbot
3 years ago

  • Summary changed from THEME: Kichu – 1.3 to THEME: Kichu – 1.4

Kichu - 1.4

Kichu is one column theme, which supports all the post formats. This design focuses on your content &amp; is perfect for an elegant blog site. This theme allows you to customize colors, and is translation-ready.

Theme URL - http://www.hardeepasrani.com/portfolio/wordpress-themes/kichu/
Author URL - http://www.hardeepasrani.com

SVN - https://themes.svn.wordpress.org/kichu/1.4
ZIP - https://wordpress.org/themes/download/kichu.1.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=kichu/1.3&new_path=kichu/1.4

History:

Ticket Summary Status Resolution Owner
#24071 THEME: Kichu – 1.4.1 closed live kevinhaig

(this ticket)

#24880 THEME: Kichu – 1.4.2.1 closed live poena
#25293 THEME: Kichu – 1.4.2.2 closed live poena
#28215 THEME: Kichu – 1.4.3 closed live jcastaneda
#28295 THEME: Kichu – 1.4.3.1 closed live jcastaneda
#28406 THEME: Kichu – 1.4.3.2 closed live jcastaneda
#29127 THEME: Kichu – 1.4.3.3 closed live karmatosed
#29418 THEME: Kichu – 1.5 closed live emiluzelac
#31804 THEME: Kichu – 1.5.1 closed live themetracbot
#32031 THEME: Kichu – 1.5.2 closed live themetracbot


https://themes.svn.wordpress.org/kichu/1.4/screenshot.png

#15 @kevinhaig
3 years ago

Kichu 1.4
Theme Review
==================
Hi @hardeepasrani, I am @kevinhaig and I picked up the review of your theme. PS never found the problem with the floating image :)

Outcome

  • Theme left as reviewing for 7 days, and it may be closed after that if there is no response. Note that if you need more time, please make a comment in the ticket.
  • Stylesheets and Scripts
    • don't need to enqueue jquery any more, core does that, please remove wp_enqueue_script( 'jquery' );
  • Licensing

#16 follow-up: @emiluzelac
3 years ago

FYI: Core does not add the jQuery unless we call it like this array( 'jquery' )

#17 in reply to: ↑ 16 @hardeepasrani
3 years ago

Replying to emiluzelac:

FYI: Core does not add the jQuery unless we call it like this array( 'jquery' )

In the latest update I added array( 'jquery') but I forgot to remove jQuery. :p I will fix it now. :)

#18 @emiluzelac
3 years ago

Yes, I saw that :)

#19 @themetracbot
3 years ago

  • Summary changed from THEME: Kichu – 1.4 to THEME: Kichu – 1.4.1

Kichu - 1.4.1

Kichu is one column theme, which supports all the post formats. This design focuses on your content &amp; is perfect for an elegant blog site. This theme allows you to customize colors, and is translation-ready.

Theme URL - http://www.hardeepasrani.com/portfolio/wordpress-themes/kichu/
Author URL - http://www.hardeepasrani.com

SVN - https://themes.svn.wordpress.org/kichu/1.4.1
ZIP - https://wordpress.org/themes/download/kichu.1.4.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=kichu/1.4&new_path=kichu/1.4.1

History:

Ticket Summary Status Resolution Owner
#24071 THEME: Kichu – 1.4.1 closed live kevinhaig

(this ticket)

#24880 THEME: Kichu – 1.4.2.1 closed live poena
#25293 THEME: Kichu – 1.4.2.2 closed live poena
#28215 THEME: Kichu – 1.4.3 closed live jcastaneda
#28295 THEME: Kichu – 1.4.3.1 closed live jcastaneda
#28406 THEME: Kichu – 1.4.3.2 closed live jcastaneda
#29127 THEME: Kichu – 1.4.3.3 closed live karmatosed
#29418 THEME: Kichu – 1.5 closed live emiluzelac
#31804 THEME: Kichu – 1.5.1 closed live themetracbot
#32031 THEME: Kichu – 1.5.2 closed live themetracbot


https://themes.svn.wordpress.org/kichu/1.4.1/screenshot.png

#20 @kevinhaig
3 years ago

  • Status changed from reviewing to approved

good luck with the theme :)

#21 @hardeepasrani
3 years ago

@kevinhaig Thanks a lot for reviewing this theme and helping me throughout the process. :)

#22 @alex27
3 years ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations! Your theme is now live.

#23 follow-up: @greenshady
3 years ago

@kevinhaig - I was just dropping in to say that the manual excerpt on chat posts is a feature and not a bug.

#24 in reply to: ↑ 23 @hardeepasrani
3 years ago

Replying to greenshady:

@kevinhaig - I was just dropping in to say that the manual excerpt on chat posts is a feature and not a bug.

Exactly! A brief description/summary of the chat followed by the chat. :)

Note: See TracTickets for help on using tickets.