WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 2 years ago

Last modified 2 years ago

#24273 closed theme (live)

THEME: Konmi – 1.0.4

Reported by: Imnok Owned by: ShinichiN
Priority: previously reviewed Keywords: theme-konmi
Cc: freezise@…

Description

Konmi - 1.0.2

A mininal theme with fully responsive

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/konmi/1.0.2
ZIP - https://wordpress.org/themes/download/konmi.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=konmi/1.0.1&new_path=konmi/1.0.2

History:

Ticket Summary Status Resolution Owner
#23913 THEME: Konmi – 1.0.1 closed not-approved anaklado
#24273 THEME: Konmi – 1.0.4 closed live ShinichiN

(this ticket)

#40555 THEME: Konmi – 1.0.5 closed live themetracbot
#40846 THEME: Konmi – 1.0.6 closed live themetracbot
#40870 THEME: Konmi – 1.0.7 closed live themetracbot


https://themes.svn.wordpress.org/konmi/1.0.2/screenshot.png

Change History (13)

#1 @Imnok
3 years ago

Hi again

#2 @ShinichiN
3 years ago

  • Owner set to ShinichiN
  • Status changed from new to reviewing

#3 @ShinichiN
3 years ago

Hi @Imnok,

I began reviewing the theme.
Give me around 5 days until I post my first review here.

The whole review process will be as described below.

  1. I review the theme according to theme review handbook and post the result here as a comment.
  2. You solve all the issues.
  3. You go to https://wordpress.org/themes/upload/ and reupload the new version.
    • The theme must have the same name
    • You need to change the Version tag in style.css
    • New version will be attached to this ticket.
    • It's better to log your changes in document.
  4. We repeat going through the process no.1 to 3 until I find no issues any more.
  5. I approve the theme and this ticket will have a status approved.
  6. One of the admin will check this theme and review the theme himself/herself and make it live. It is possible that the admin reviewer adds more issues. I'm a new reviewer and need double check.

Note: This theme was closed accidentally with no reason: https://themes.trac.wordpress.org/ticket/23913

#4 follow-ups: @ShinichiN
3 years ago

Hi, @Imnok

Here's my review. Please check them all and fix the issues. When you've fixed the theme, please go to https://wordpress.org/themes/upload/ and reupload that.

  • The theme must have the same name
  • You need to change the Version tag in style.css
  • New version will be attached to this ticket.
  • It's better to log your changes in document.

# required
(Required are something you need to fix to get approved.)

  • themify-icons.css and font-awesome.css are required to be enqueued through wp_enqueue_style() function. See https://codex.wordpress.org/Function_Reference/wp_enqueue_style
  • You have textdomain "twentyfifteen" in line 54 of functions.php
  • custom_excerpt_length and new_excerpt_more functions must be prefixed.
  • Line 21, 37 in customizer.php are not translation ready.
  • You have both 'konmi' and 'konmi_theme' as text domain. A theme can have only one text domain.

# recommended
(Recommended are something you don't need to fix to get approved.)

  • Nested lists in the sidebar has no margins in the left of each lists.
  • I didn't understand what "Post" and "Posts" means in the customizer's Sidebar section.
  • It's better to use get_template_directory_uri rather than get_stylesheet_directory_uri if we think about the child themes. It might be a good idea to get every css/js by get_template_directory_uri and wrap it with if( function_exists( 'konmi_theme_scripts' ) ){} to let the child theme authors to use it.
  • konmi_theme_url can be esc_url_raw
  • You can delete konmi_theme_setup_author function because it's included in the core.
  • You have a "z" in the beginning of the content-audio.php
  • I think you can delete the readme.md file. It's for developers and not for users.

# Notes:
(Notes are something I want to talk with you but what you'll do with these issues is up to you and you don't need to answer.)

  • Screenshot can be 1200 x 900px
  • You can just delete the underscores nav in header.php

Thanks!

Last edited 3 years ago by ShinichiN (previous) (diff)

#5 in reply to: ↑ 4 @Imnok
3 years ago

Replying to ShinichiN:

Hi @ShinichiN,

Thank you very much for reviewing my theme.
Please give me 5 days, I'll fix them all and upload soon.

:)

#6 @themetracbot
2 years ago

  • Summary changed from THEME: Konmi – 1.0.2 to THEME: Konmi – 1.0.3

Konmi - 1.0.3

A mininal theme with fully responsive

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/konmi/1.0.3
ZIP - https://wordpress.org/themes/download/konmi.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=konmi/1.0.2&new_path=konmi/1.0.3

History:

Ticket Summary Status Resolution Owner
#23913 THEME: Konmi – 1.0.1 closed not-approved anaklado
#24273 THEME: Konmi – 1.0.4 closed live ShinichiN

(this ticket)

#40555 THEME: Konmi – 1.0.5 closed live themetracbot
#40846 THEME: Konmi – 1.0.6 closed live themetracbot
#40870 THEME: Konmi – 1.0.7 closed live themetracbot


https://themes.svn.wordpress.org/konmi/1.0.3/screenshot.png

#7 in reply to: ↑ 4 @Imnok
2 years ago

Replying to ShinichiN:

Hi @ShinichiN,

I fix all issues as per your previous comments.

# Required

  • Enqueued both themify-icons.css and font-awesome.css through wp_enqueue_style() function.
  • Removed text domain "twenty fifteen" in line 54 of functions.php.
  • Prefixed both custom_excerpt_length and new_excerpt_more functions.
  • Make line 21, 37 in customizer.php are translation ready.
  • Reviewed and managed to one text domain 'konmi'.

# Recommended

  • 'Nested lists in the sidebar has no margins in the left of each lists.' - I am not sure what does it mean, would you please take a screen capture or give me more some details or examples that I’ll able to make it :)
  • Changed the description of customiser's Sidebar section, hope it's more clear to understand.
  • Changed 'get_template_directory_uri' to 'get_stylesheet_directory_uri', line 159, 160, 163 of functions.php.
  • Changed 'konmi_theme_url' to 'esc_url_raw', line 25 of customizer.php.
  • Removed konmi_theme_setup_author function.
  • Removed a "z" in the beginning of the content-audio.php
  • Deleted readme.md file.

# Notes:

  • Up dimensions of screenshot.png to be 1200 x 900px.
  • Deleted the underscores nav in header.php.

# Others update:

  • Removed konmi_theme_url function.

Looking forward to your comments :)

Thanks!

Last edited 2 years ago by Imnok (previous) (diff)

#8 @ShinichiN
2 years ago

Hi :)

required

  • You still have a "z" in content-audio.php
  • I think the description of "Sidebars in customizer" can be like below.
'description' => __( 'Choose to show or hide sidebars on home and sigle post pages.', 'konmi' ),

and labels for them can be "Home" and "Single post pages"?

  • About the "nested lists' style", I'm sorry that it was not clear. Please see this.

Konmi sidebar.
https://www.evernote.com/shard/s20/sh/1661ba16-2185-450b-a512-4f837c6acd02/82a396a1a16cd264a98bf82e5e2c659c/deep/0/スクリーンショット-2015-05-04-11-05.png

TwentyFifteen sidebar
https://www.evernote.com/shard/s20/sh/d5cecf04-9c81-45e7-bcb7-fe6481db4a32/5ffe6ea14361e7ee1a74de71bdc123ba/deep/0/スクリーンショット-2015-05-04-11-06.png

#9 @themetracbot
2 years ago

  • Summary changed from THEME: Konmi – 1.0.3 to THEME: Konmi – 1.0.4

Konmi - 1.0.4

A mininal theme with fully responsive

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/konmi/1.0.4
ZIP - https://wordpress.org/themes/download/konmi.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=konmi/1.0.3&new_path=konmi/1.0.4

History:

Ticket Summary Status Resolution Owner
#23913 THEME: Konmi – 1.0.1 closed not-approved anaklado
#24273 THEME: Konmi – 1.0.4 closed live ShinichiN

(this ticket)

#40555 THEME: Konmi – 1.0.5 closed live themetracbot
#40846 THEME: Konmi – 1.0.6 closed live themetracbot
#40870 THEME: Konmi – 1.0.7 closed live themetracbot


https://themes.svn.wordpress.org/konmi/1.0.4/screenshot.png

#10 @Imnok
2 years ago

Hi @ShinichiN,

Log update.

# Required

  • Definitely removed a "z" in the beginning of the content-audio.php :)

# Recommended

  • I leave the description of Sidebar section as “Choose to show or hide sidebar for Posts page and Single page.” because if user setting Static Front Page as A static page, there will be no sidebar on Home. So basically the sidebar of this theme will be active only for Posts page and Single page.
  • Updated Nested lists style for sidebar. Thanks for your kindly explanation.

Thanks!

#11 follow-up: @ShinichiN
2 years ago

  • Resolution set to live
  • Status changed from reviewing to closed

@Imnok

I don't find any issues anymore. I mark this theme as approved and make it live.

It's really a beautiful theme. Thank you for sharing Konmi. Unbelievable that it's the first theme you built. One of the best written theme I've reviewed :)

#12 in reply to: ↑ 11 @Imnok
2 years ago

Replying to ShinichiN:

Hi @ShinichiN,

Thank you very much for your approval. I've learned a lot!
Your compliments give me a confident to make the next one ;)

Thanks!

This ticket was mentioned in Slack in #themereview by otto42. View the logs.


2 years ago

Note: See TracTickets for help on using tickets.