WordPress.org

Make WordPress Themes

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#2429 closed theme (not-approved)

THEME: Modern Blue Style - 1.5

Reported by: webm.pl Owned by: FurciferRising
Priority: Keywords: theme-modern-blue-style,
Cc: info@…

Change History (5)

#1 @webm.pl
7 years ago

Hi,

All issues and bugs from previous tickets are corrected.
Hope now everything will be fine.

With regards

#2 @FurciferRising
7 years ago

  • Owner set to FurciferRising
  • Status changed from new to assigned

#3 @FurciferRising
7 years ago

Review:

=>Floated images not clearing in the "layout test" post to fix this add <div class="clear"></div> Directly beneath the_content(); in single.php and on the main index.

# RECOMMENDED: could not find the file readme.txt in the theme.
# RECOMMENDED: No reference to add_custom_image_header was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
# RECOMMENDED: No reference to add_custom_background() was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.


Overall: Not approved, until the floated image issue is resolved as it impacts visibly on the theme.


Items marked with => are reasons for not being approved
Items marked with / are just suggestions
Items marked with - are notes


Review Summary

Theme cannot be accepted until items listed under Required are addressed. Once these issues have been resolved, please re-submit your Theme using the uploader tool on wordpress.org/extend/themes, and a new Trac ticket will be generated.

Note:

  • Re-submitted Themes are given review priority over new Themes.
  • Prior to re-submitting, please ensure Theme meets all requirements in the Theme Review Guidelines and the Theme Unit Tests.
  • In order to facilitate subsequent reviews of this Theme, once you have re-uploaded the revised Theme and a new Trac ticket has been generated, please add a comment to the new ticket, indicating which previous-ticket review comments have been addressed, and how (if applicable). Doing so will help ensure a more expedited review.

#4 @FurciferRising
7 years ago

  • Resolution set to not-approved
  • Status changed from assigned to closed

#5 @web-design.se
7 years ago

Hi,

Thanks, I uploaded the new version with fixed floated images as you mentioned this bug.

Newest ticket is here: http://themes.trac.wordpress.org/ticket/2506

I also made posts more shorter on the index page and added height: auto; for images to rescale the big image more proper. I've also changed the date format to the_time( get_option( 'date_format' ) ).

Greetings

Note: See TracTickets for help on using tickets.