WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#24556 closed theme (live)

THEME: Skrollr – 1.0.9

Reported by: Fab1en Owned by: poena
Priority: new theme Keywords: theme-skrollr
Cc: fabien.quatravaux@…, greenshady, emiluzelac

Description

Skrollr - 1.0

A WordPress theme to tell stories with Skrollr js library. Do you have a story to tell ? Or a multimedia report to publish ? Or a long form article to lay-out ? This natural-scrolling theme is the one you need. Its native navigation on mobile let user scroll you content with their finger. No click or tap is needed to view the content.

Theme URL - http://skrollr.1nterval.com
Author URL - http://fab1en.github.io

SVN - https://themes.svn.wordpress.org/skrollr/1.0
ZIP - https://wordpress.org/themes/download/skrollr.1.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/skrollr/1.0/screenshot.png

Change History (54)

#1 @alex27
2 years ago

Hi there!

This is not a review, just a note, that screenshot needs to be of an actual theme, not a mockup or a photo.

#2 @Fab1en
2 years ago

Hi @alex27. That's a screenshot of the actual theme ! The theme displays the header image fullscreen with the site name on top of it. You have to scroll down to see the content. The theme screenshot shows the default suggested header image, included in the theme.

Please have a look at http://skrollr.1nterval.com to see it in action.

#3 @alex27
2 years ago

Don't mind my comment then and carry on :)

#4 @themetracbot
2 years ago

  • Owner set to hideokamoto
  • Status changed from new to reviewing

#5 @hideokamoto
2 years ago

Hi @Fab1en ,

I began reviewing the theme.
Give me around 5 days until I post my first review here.

The whole review process will be as described below.

  1. I review the theme according to theme review handbook and post the result here as a comment.
  2. You solve all the issues.
  3. You go to https://wordpress.org/themes/upload/ and reupload the new version.
    • The theme must have the same name
    • You need to change the Version tag in style.css
    • New version will be attached to this ticket.
    • It's better to log your changes in document.
  4. We repeat going through the process no.1 to 3 until I find no issues any more.
  5. I approve the theme and this ticket will have a status approved.
  6. One of the admin will check this theme and review the theme himself/herself and make it live. It is possible that the admin reviewer adds more issues. I'm a new reviewer and need double check.

#6 @Fab1en
2 years ago

Hi @hideokamoto
Thanks for this kind and well explained message. The process you describe is what I was expecting, so that is great.

I have a question though : since the submission of the version 1.0 of this theme, I have worked on the code to add new features. What, in you opinion, is the best option :

  1. I don't add those new features yet, and continue to work with you on the 1.0 branch until my theme is approved, and then submit it again with a version bump, or
  2. I add those new features right now using https://wordpress.org/themes/upload/ so that you can test everything at once ?

#7 @hideokamoto
2 years ago

Thanks for message.

I think that if you add new features for this theme, you had better to make a new ticket about new version's theme (ex: Skrollr – 1.1).

Because this theme that added new features is upgraded versions.

I had not test your theme yet.

So, if you upload new version's theme using https://wordpress.org/themes/upload/, I will test all features test.

#8 @Fab1en
2 years ago

OK, forget my last message. Please go ahead with this version testing.
I will work with you on the 1.0 branch, and wait before adding new features.

#9 @hideokamoto
2 years ago

Hi @Fab1en

Thank you for waiting and here's my review. Please check them all and fix the issues. When you've
fixed the theme, please go to https://wordpress.org/themes/upload/ and reupload that.

  • The theme must have the same name
  • You need to change the Version tag in style.css
  • New version will be attached to this ticket.
  • It's better to log your changes in document.

testing enviroment

required

(Required are something you need to fix to get approved.)

(Recommended are something you don't need to fix to get approved.)

  • This theme contains no sidebars/widget areas. See Widgets API
  • No reference to the_post_thumbnail() was found in the theme. It is recommended that the theme implement this functionality instead of using custom fields for thumbnails.
  • No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
  • Audio tag’s style should fix. [see http://wp-kyoto.net/upload/review/review-skroller1-0.pdf - page7.]
  • long site title is forced out. [see http://wp-kyoto.net/upload/review/review-skroller1-0.pdf - page8.]

Notes:

(Notes are something I want to talk with you but what you'll do with these issues is up to you and you don't need to answer.)

  • INFO: Possible hard-coded links were found in the file header.php.

Line 2: <p class='browsehappy'>You are using an <strong>outdated</strong> browser. Please <a href='http://browsehappy.com/'>upgrade your browser</a> to improve your experienc.

Thanks!

#10 @themetracbot
2 years ago

  • Summary changed from THEME: Skrollr – 1.0 to THEME: Skrollr – 1.0.1

Skrollr - 1.0.1

A WordPress theme to tell stories with Skrollr js library. Do you have a story to tell ? Or a multimedia report to publish ? Or a long form article to lay-out ? This natural-scrolling theme is the one you need. Its native navigation on mobile let user scroll you content with their finger. No click or tap is needed to view the content.

Theme URL - http://skrollr.1nterval.com
Author URL - http://fab1en.github.io

SVN - https://themes.svn.wordpress.org/skrollr/1.0.1
ZIP - https://wordpress.org/themes/download/skrollr.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=skrollr/1.0&new_path=skrollr/1.0.1

History:


https://themes.svn.wordpress.org/skrollr/1.0.1/screenshot.png

#11 @themetracbot
2 years ago

  • Summary changed from THEME: Skrollr – 1.0.1 to THEME: Skrollr – 1.0.2

Skrollr - 1.0.2

A WordPress theme to tell stories with Skrollr js library. Do you have a story to tell ? Or a multimedia report to publish ? Or a long form article to lay-out ? This natural-scrolling theme is the one you need. Its native navigation on mobile let user scroll you content with their finger. No click or tap is needed to view the content.

Theme URL - http://skrollr.1nterval.com
Author URL - http://fab1en.github.io

SVN - https://themes.svn.wordpress.org/skrollr/1.0.2
ZIP - https://wordpress.org/themes/download/skrollr.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=skrollr/1.0.1&new_path=skrollr/1.0.2

History:


https://themes.svn.wordpress.org/skrollr/1.0.2/screenshot.png

#12 @Fab1en
2 years ago

Hi @hideokamoto, and thanks for reviewing my theme.

I uploaded a new version of the theme with three fixes :

  • Audio tag’s style. You can see the diff on github.
  • Pager does not action if has gallery content in article : the problem only appears when there is no menu selected as "Footer menu". You can see the diff on github.
  • This theme contains no sidebars/widget areas : I have added one in the footer, next to the menu. You can see the diff on github.

Regarding the other issues :

  • No reference to the_post_thumbnail() : I'm using the post thumbnail functionality, but with get_post_thumbnail_id as I need the image source to set it as a background.
  • No reference to add_theme_support( "custom-background", $args ) : I rather use add_theme_support( 'custom-header', $args ).
  • long site title is forced out : I cannot reproduce this. Could you please give me more details on where and when this occurs ?

#13 @hideokamoto
2 years ago

  • Status changed from reviewing to approved

I'm sorry too late.
Thank you very much for sharing your theme!

I don't find any issues anymore. As I told you before, one of the theme review team admins will check this theme and review again before making it live.It is possible that the admin reviewer adds more issues. I'm a new reviewer and need double check.

#14 @Fab1en
2 years ago

Thanks @hideokamoto !

#15 @poena
2 years ago

  • Status changed from approved to reopened

#16 @poena
2 years ago

  • Owner changed from hideokamoto to poena
  • Status changed from reopened to reviewing

#17 @poena
2 years ago

Hi!
Unfortunately there are a few things that needs to be fixed before your theme can be set live.

When minified scripts or styles are used, you need to include the original, unminified version too.
When you enqueue custom styles and scripts, the handle should be prefixed.
Example:

wp_enqueue_style('skrollr-layout', get_stylesheet_directory_uri().'/css/layout.css', array('base'), $ver);

Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc.
-There are functions that are not yet prefixed. (Check color_tools.php -there might be more)
You are also using both scrollr and skrollr as a prefix, please replace scrollr.

Social sharing is plugin territory. You can add a menu or an option with links to the users social pages if you like, but not sharing. -Also, when a user is logged in, the admin bar covers part of the sharing icons.

The logo position option in the customizer is not working, only the title is showing, as if there was no control.

There needs to either be a link to the single post view, or comments must display on front.

The theme needs to be 100% GPL compatible, please declare licenses of any resources included such as fonts or images.
Declare copyright for the theme itself. Example: Theme name Copyright Author name 2015.

#18 @poena
2 years ago

Just a reminder: tickets will kept open for 7 days without activity.

#19 @Fab1en
2 years ago

OK, thanks for this reminder @poema, and thanks for your remarks on my theme.
I will try to fix it as soon as possible.

#20 @Fab1en
2 years ago

I'm working on it, sorry for the delay ...

#21 @themetracbot
2 years ago

  • Summary changed from THEME: Skrollr – 1.0.2 to THEME: Skrollr – 1.0.3

Skrollr - 1.0.3

A WordPress theme to tell stories with Skrollr js library. Do you have a story to tell ? Or a multimedia report to publish ? Or a long form article to lay-out ? This natural-scrolling theme is the one you need. Its native navigation on mobile let user scroll you content with their finger. No click or tap is needed to view the content.

Theme URL - http://skrollr.1nterval.com
Author URL - http://fab1en.github.io

SVN - https://themes.svn.wordpress.org/skrollr/1.0.3
ZIP - https://wordpress.org/themes/download/skrollr.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=skrollr/1.0.2&new_path=skrollr/1.0.3

History:


https://themes.svn.wordpress.org/skrollr/1.0.3/screenshot.png

#22 @Fab1en
2 years ago

Hi @poena.
I have updated my theme to follow some of your recommendations. You can see the diff on the github repository.

  • non-minified versions are now used for each external library assets
  • everything is now prefixed with the theme domain
  • social icons no longer default to sharing : the user can define which URL is pointed at
  • social icon overlap with admin bar is fixed

But I need more clarification for other items :

  • logo position option : this option is working as intended. To move the logo, you just have to drag it around the page with your mouse. There is no control showing in the left customizer pane because there is no need of. I understand that this behavior is not straightforward. How could I make it clearer ? Adding a small text under the "Logo position" title ?
  • 100% GPL compatible : could you please tell me where I should declare those resources licenses ? I use skrollr.js, Modernizr, slabText, IcoMoon and Titillium font.
  • copyright : same question, could you tell me where I should put the theme copyright ?
  • regarding comments, the theme is not well suited for that (its aimed to be used as a single page site) but I will display comments on the front page if needed.

Thanks for your help.

#23 @poena
2 years ago

Hi!
The update looks good.

Yes adding a description about the logo would be helpful. -I was able to move the logo around, but then I accidentally placed it under the site title, and then I couldn't move it again.

The current guideline doesn't allow themes without comments.

The license and copyright is usually in the readme file.

This ticket was mentioned in Slack in #themereview by poena. View the logs.


2 years ago

#25 @themetracbot
2 years ago

  • Summary changed from THEME: Skrollr – 1.0.3 to THEME: Skrollr – 1.0.4

Skrollr - 1.0.4

A WordPress theme to tell stories with Skrollr js library. Do you have a story to tell ? Or a multimedia report to publish ? Or a long form article to lay-out ? This natural-scrolling theme is the one you need. Its native navigation on mobile let user scroll you content with their finger. No click or tap is needed to view the content.

Theme URL - http://skrollr.1nterval.com
Author URL - http://fab1en.github.io

SVN - https://themes.svn.wordpress.org/skrollr/1.0.4
ZIP - https://wordpress.org/themes/download/skrollr.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=skrollr/1.0.3&new_path=skrollr/1.0.4

History:


https://themes.svn.wordpress.org/skrollr/1.0.4/screenshot.png

#26 @Fab1en
2 years ago

I made the corrections for the remaining points :

  • Description text to help user to understand how to use the logo position control
  • Prevent the logo from going under the site title
  • Add copyright and external resources licenses to the readme.txt
  • Display a link to the single post view when there are comments. I tried to display comments right on the front page, but then comments pagination doesn't work anymore.

Please tell me if anything else is missing.

#27 @poena
2 years ago

Hi!
We are not allowed to use images that are "free" but don't have an explicit license, so the image needs to be replaced. It needs to be GPL compatible.

One of the admins pointed out that some of your options are not escaped, sorry for missing that on the first round:
Your links (for example the social links) needs to be escaped with esc_url(). (Also see positionIcon/register.php)
Your width and colors needs to be escaped with esc_attr() (see templates/chapo.php)

https://developer.wordpress.org/reference/functions/esc_url/
https://developer.wordpress.org/reference/functions/esc_attr/

I'm a little confused by the wpseo_titles. SEO is not theme dependent, so it needs to be left to site owner:
it is plugin territory. -But it doesn't look like the meta description is an actual meta description?

#28 @Fab1en
2 years ago

Hi @poena

Regarding the image license issue, I will check and get back to you soon.

For the escaping of options, I think that I've done it the right way : each URL option is a theme_mod that is escaped within the customizer (see here and here). Social links are also escaped in the customizer (see here).content_width is escaped with absint (see here). Do I have to add more escape function if all the escaping is done by the customizer ?

About the wpseo_titles option, it's just some additional code to help support WordPress SEO by Yoast plugin. My theme provide a way to enter a long description that appears at the top of the front page. If WP SEO plugin is installed, this long description is synchronized automatically with the SEO meta description. But my theme is not providing SEO features that are on the plugin territory.

#29 @poena
2 years ago

Supporting plugins is fine, but you need to check if the plugin is installed or not. (You can use if function_exists() or if class_exists() depending on plugin)

You need to both sanitize before saving the option to the database, and escape on output, as late as possible.
Some resources:
https://codex.wordpress.org/Validating_Sanitizing_and_Escaping_User_Data#Escaping:_Securing_Output
https://make.wordpress.org/themes/2015/06/02/a-guide-to-writing-secure-themes-part-3-sanitization/
https://codex.wordpress.org/Data_Validation

And the requirement: https://make.wordpress.org/themes/handbook/review/required/#security-and-privacy

#30 @themetracbot
2 years ago

  • Summary changed from THEME: Skrollr – 1.0.4 to THEME: Skrollr – 1.0.5

Skrollr - 1.0.5

A WordPress theme to tell stories with Skrollr js library. Do you have a story to tell ? Or a multimedia report to publish ? Or a long form article to lay-out ? This natural-scrolling theme is the one you need. Its native navigation on mobile let user scroll you content with their finger. No click or tap is needed to view the content.

Theme URL - http://skrollr.1nterval.com
Author URL - http://fab1en.github.io

SVN - https://themes.svn.wordpress.org/skrollr/1.0.5
ZIP - https://wordpress.org/themes/download/skrollr.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=skrollr/1.0.4&new_path=skrollr/1.0.5

History:


https://themes.svn.wordpress.org/skrollr/1.0.5/screenshot.png

#31 @Fab1en
2 years ago

Hi @poena

With the appropriate consent of the original copyright holder, I have republished the image under CC-BY-SA license, so this should not be an issue anymore.

I have also added the proper escaping function where required. Please let me know if something else is missing.

Regarding WP SEO plugin support, I think I don't need the function_exists checks because all the actions done can work when the plugin is not installed or activated. The theme simply checks if WP SEO options are here and update then if needed.

#32 @poena
2 years ago

Hi!
CC-BY-SA is not GPL compatible, the only creative commons licenses allowed are CC0 and CC-BY 4.0
See: http://www.gnu.org/licenses/license-list.en.html#ccby

SEO can only be part of a theme if it is to support a plugin, so what you are trying to do is not allowed, it is plugin territory.
SEO is not theme dependent, it should be the same no matter what theme is used.
And when I tried it together with the plugin, it uses the meta description from the customizer
when the latest posts are displayed, but the meta description from the plugin, if a static paged is displayed.
(as a meta that is -the text that is showing is always the text from the customizer)

#33 @themetracbot
2 years ago

  • Summary changed from THEME: Skrollr – 1.0.5 to THEME: Skrollr – 1.0.6

Skrollr - 1.0.6

A WordPress theme to tell stories with Skrollr js library. Do you have a story to tell ? Or a multimedia report to publish ? Or a long form article to lay-out ? This natural-scrolling theme is the one you need. Its native navigation on mobile let user scroll you content with their finger. No click or tap is needed to view the content.

Theme URL - http://skrollr.1nterval.com
Author URL - http://fab1en.github.io

SVN - https://themes.svn.wordpress.org/skrollr/1.0.6
ZIP - https://wordpress.org/themes/download/skrollr.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=skrollr/1.0.5&new_path=skrollr/1.0.6

History:


https://themes.svn.wordpress.org/skrollr/1.0.6/screenshot.png

#34 @Fab1en
2 years ago

Hi @poena

I changed the image license to CC-BY (see it on this page, on the bottom right corner) and I reflected this change on the readme.

Regarding SEO, what you describe is what was intended. If the theme is changed, SEO is not changed : my theme does not output the meta tag itself, it just synchronizes the text displayed on the front page and the one used for home meta description. But I understand this can be confusing and this is more a personal preference than a real feature : I can still synchronize those two contents by hand. So I removed it from my theme.

I really appreciate your efforts to make my theme perfect ! Your remarks always come with very good arguments. Please let me know if something else is missing or must be changed.

#35 @poena
2 years ago

Looks good, but only CC-BY 4.0 is compatible, 3 is not.

#36 @themetracbot
2 years ago

  • Summary changed from THEME: Skrollr – 1.0.6 to THEME: Skrollr – 1.0.7

Skrollr - 1.0.7

A WordPress theme to tell stories with Skrollr js library. Do you have a story to tell ? Or a multimedia report to publish ? Or a long form article to lay-out ? This natural-scrolling theme is the one you need. Its native navigation on mobile let user scroll you content with their finger. No click or tap is needed to view the content.

Theme URL - http://skrollr.1nterval.com
Author URL - http://fab1en.github.io

SVN - https://themes.svn.wordpress.org/skrollr/1.0.7
ZIP - https://wordpress.org/themes/download/skrollr.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=skrollr/1.0.6&new_path=skrollr/1.0.7

History:


https://themes.svn.wordpress.org/skrollr/1.0.7/screenshot.png

#37 @Fab1en
2 years ago

I updated the license version to CC-BY 4.0
I hope everything is OK now.

#38 @poena
2 years ago

Hi!
I wanted to look through the code a final time before making the theme live, and I saw this function
gallery_settings_template() in shortcodes.php.

Overide the gallery settings template used in the media manager to add custom settings.

Doing this borders on plugin territory, but, I also can't find these options anywhere?
If it is meant to display in the media manager then it is not working for me.
I have never tried to change the media manager but I don't think that 'wp_enqueue_media' is used correctly here.

Please tell me what you want to accomplish with shortcodes.php and why the shortcodes needs to be edited.

Also one minor thing, the browse happy text needs to be translatable too.

Last edited 2 years ago by poena (previous) (diff)

#39 @Fab1en
2 years ago

Hi @poena.
The shotcodes.php file role is to make [video] and [gallery] shortcodes display correctly on the front side. I need a very special markup to handle galleries and videos.

I have also added some custom settings on the gallery shortcode : transitions between pictures can be selected ("melded", "rolling up", "rolling down" or "shutter"). You can see the custom settings when editing a gallery. Here is a screenshot :

http://skrollr.1nterval.com/wp-content/uploads/2015/07/custom-gallery-setting.png

#40 @themetracbot
2 years ago

  • Summary changed from THEME: Skrollr – 1.0.7 to THEME: Skrollr – 1.0.8

Skrollr - 1.0.8

A WordPress theme to tell stories with Skrollr js library. Do you have a story to tell ? Or a multimedia report to publish ? Or a long form article to lay-out ? This natural-scrolling theme is the one you need. Its native navigation on mobile let user scroll you content with their finger. No click or tap is needed to view the content.

Theme URL - http://skrollr.1nterval.com
Author URL - http://fab1en.github.io

SVN - https://themes.svn.wordpress.org/skrollr/1.0.8
ZIP - https://wordpress.org/themes/download/skrollr.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=skrollr/1.0.7&new_path=skrollr/1.0.8

History:


https://themes.svn.wordpress.org/skrollr/1.0.8/screenshot.png

#41 @Fab1en
2 years ago

In the new version, I have corrected the issue about wp_enqueue_media. I now use admin_footer to display the gallery settings template.
I have also made the "Browse Happy" warning translatable.

#42 @poena
2 years ago

  • Cc greenshady emiluzelac added

Hi!
The options are showing now, and it is working for the gallery post type but not the standard post type, where I'm getting a javascript error:

uncaught exception: Unable to find anchor target "#standard-post-gallery-test .the_gallery"

(standard-post-gallery-test is the name of the post.)

But I'm concerned about the way the option is added, this javascript is out of my scope and we should check with the admins. -Perhaps this option should be a post meta, built with WordPress functions. What do you think @greenshady @emiluzelac?

#43 @Fab1en
2 years ago

The option is not related to the post, it's related to the gallery itself. That's why I thought I would extend the gallery shortcode with a new option. When you select one of the display options in the gallery settings panel, the shortcode will have the option "skrollr" added with the selected display option. You can see the result in the "Text" tab.

To do this, I'm using the new TimyMce view API for shortcodes, the same that the one used to edit video and audio shortcodes (as well as gallery one). I could not find any official documentation about this.

#44 @poena
2 years ago

-Ah yes, I did not take into account that you can have more than one gallery per post.
Please fix the javascript error, and I hope that an admin has time to look at it soon.

#45 @emiluzelac
2 years ago

Sorry, so many things on my plate and I was unable to reply earlier.

Errors should not show which we already established and authors can extend the gallery. Does that help?

#46 @Fab1en
2 years ago

Hi Emil, and thanks for your answer.
The question of @poena was specifically about the JavaScript implementation of the gallery settings modifications. I use a new Underscore template for the settings that appears in shortcodes.php file, line 49 and I set this template on the js/gallery-settings.js file.

Here is a screenshot of the result :
http://skrollr.1nterval.com/wp-content/uploads/2015/07/custom-gallery-setting.png

Regarding the error when using a gallery inside a standard post, yes I will fix it. I'm starting tonight a 2 weeks vacation, so the fix could take quite some time to land. Excuse me by advance for that delay.

#47 @Fab1en
2 years ago

Sorry, I still did not found the time to work on this issue, and I will not have time either next week. I will try to propose a patch before the end of august.

#48 @poena
2 years ago

Any update?

#49 @Fab1en
2 years ago

Sorry, I'm working on it but I have not finished yet. Please give me more time and I will fix the remaining issues.

Thanks.

#50 @Fab1en
2 years ago

Hi Poena.

I've fixed the issue with galleries, and submitted the patch on the theme github repo. Please let me run some final tests before submitting it here to verify everything is OK. I had to rethink the way I managed galleries : now the default WordPress galleries with 3 columns displays for articles that do not have the "gallery" format.

#51 @themetracbot
2 years ago

  • Summary changed from THEME: Skrollr – 1.0.8 to THEME: Skrollr – 1.0.9

Skrollr - 1.0.9

A WordPress theme to tell stories with Skrollr js library. Do you have a story to tell ? Or a multimedia report to publish ? Or a long form article to lay-out ? This natural-scrolling theme is the one you need. Its native navigation on mobile let user scroll you content with their finger. No click or tap is needed to view the content.

Theme URL - http://skrollr.1nterval.com
Author URL - http://fab1en.github.io

SVN - https://themes.svn.wordpress.org/skrollr/1.0.9
ZIP - https://wordpress.org/themes/download/skrollr.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=skrollr/1.0.8&new_path=skrollr/1.0.9

History:


https://themes.svn.wordpress.org/skrollr/1.0.9/screenshot.png

#52 @Fab1en
2 years ago

Hi @poena.
Did you find some time to test this new version ?

Thanks

#53 @poena
2 years ago

  • Resolution set to live
  • Status changed from reviewing to closed

The javascript error have been fixed, thank you!

Last edited 2 years ago by poena (previous) (diff)

#54 @Fab1en
2 years ago

Thank you poena !

Note: See TracTickets for help on using tickets.