WordPress.org

Make WordPress Themes

Opened 3 years ago

Closed 2 years ago

Last modified 8 months ago

#24853 closed theme (live)

THEME: Business Group - VSS – 1.0.13

Reported by: Muruganathan Owned by: alex27
Priority: new theme Keywords: theme-business-group-vss
Cc: muruganathan@…

Description

Business Group - VSS - 1.0.0

The Business Group – VSS theme is mainly focus on the company portfolio website.where we can maintain our blog,project,details etc..,

Theme URL - http://vegamsoft.com/themes/business-group-vss
Author URL - http://vegamsoft.com/

SVN - https://themes.svn.wordpress.org/business-group-vss/1.0.0
ZIP - https://wordpress.org/themes/download/business-group-vss.1.0.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/business-group-vss/1.0.0/screenshot.png

Attachments (2)

vssbusiness-headerimg.png (352.1 KB) - added by alex27 2 years ago.
Custom header image is not being displayed
vssbusiness-logo.png (303.5 KB) - added by alex27 2 years ago.
Website title is not being displayed when using custom logo, also logo is hidden behind menu

Download all attachments as: .zip

Change History (50)

#1 @alex27
3 years ago

  • Owner set to alex27
  • Status changed from new to reviewing

#2 @alex27
3 years ago

Hi there!

Thank you for your theme submission! Below are the theme review results. Anything marked REQUIRED needs a resolution. Anything marked RECOMMENDED is suggested a fix but not a grounds for failing. Anything marked INFORMATION is there as a suggestion.

REQUIRED

  • All functions, class names, public and global variables are properly prefixed with your theme slug.
    • Multiple unprefixed functions found in multiple files. All custom functions need to be prefixed with theme slug.
    • When you save theme options to the database, you should prefix the option name that stores the settings with your theme slug. Generic name like ‘theme_settings_ is not acceptable.
    • Script and stylesheet handles need to be prefixed with theme slug in the same way.
  • There’s no need to register internal scripts and stylesheets. Proceed straight to wp_enqueue_script or wp_enqueue_style().
  • Please remove all hard-coded scripts and stylesheets from the header.php. Those are already enqueued from functions.php
  • Theme should display website title be default. Logo should be user configuraed and disabled by default. The same goes for social media icons and the "Theme Design by" bit in the footer - those items should not be displayed, when user didn't set any values for them.
  • img folder - please remove all watermarked images and provide copyright and license info for all other images bundled with the theme.
  • All theme text strings are to be translatable. This means wrapping all strings in a gettext function and loading text domain via load_theme_textdomain() See Twenty Fifteen for code example.
  • All theme options need to be sanitized on input and escaped on output. See this Codex page for more information.
  • All add_theme_support, add_image_size, add_nav_menu, register_nav_menus and load_theme_textdomain should be setup and registered within a theme specific setup function tied to the after_setup_theme action. Please look into Twenty Fourteen theme if you need an example.
  • You need to properly escape home_url() function, like so: esc_url( home_url() ).
  • Themes cannot bundle plugins with themes. You can recommend users to use a plugin or plugins, but only those available in plugin repository.
  • jQuery cannot be bundled with the theme. Please remove jquery.min.js and jquery-1.9.1.js from js folder and use only jQuery version included with WordPress.

Overall, theme codebase is pretty outdated and needs a lot of work. I would strongly suggest using Customizer for theme options and rebuilding the theme using a sold, up-to-date base theme like Underscores.

Please fix above issues and upload new version of your theme, I'll leave this ticket open for another 7 days. Feel free to ask if you have any questions

#3 @Muruganathan
3 years ago

Hi,

I have some doubt img folder issues:

if images is created by us then whether we need any license for that images.
Else we can take images from any other site with license.please can you guide me any sample site for that.

#4 @themetracbot
3 years ago

  • Summary changed from THEME: Business Group - VSS – 1.0.0 to THEME: Business Group - VSS – 1.0.1

Business Group - VSS - 1.0.1

The Business Group – VSS theme is mainly focus on the company portfolio website.where we can maintain our blog,project,details etc..,

Theme URL - http://vegamsoft.com/themes/business-group-vss
Author URL - http://vegamsoft.com/

SVN - https://themes.svn.wordpress.org/business-group-vss/1.0.1
ZIP - https://wordpress.org/themes/download/business-group-vss.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=business-group-vss/1.0.0&new_path=business-group-vss/1.0.1

History:


https://themes.svn.wordpress.org/business-group-vss/1.0.1/screenshot.png

#5 @alex27
3 years ago

if images is created by us then whether we need any license for that images.
Else we can take images from any other site with license.please can you guide me any sample site for that.

You always need to explicitly provide credit and license info for all resources bundled with the theme (not only images), regardless of who created them. The resources must be on a GPL-compatible license. That't why I asked that you remove watermarked images, are those clearly are not GPL licensed and cannot be distributed with a theme.

#6 @alex27
3 years ago

I would strongly suggest using Customizer for theme options and rebuilding the theme using a sold, up-to-date base theme like Underscores.

I double checked, and using Customizer for theme options is no longer just a recommendation, but a requirement. Since this is a major change, I'd like you to focus on implementing it, before I continue with the full review.

Feel free to ask, if you have any questions.

#7 @themetracbot
3 years ago

  • Summary changed from THEME: Business Group - VSS – 1.0.1 to THEME: Business Group - VSS – 1.0.2

Business Group - VSS - 1.0.2

The Business Group – VSS theme is mainly focus on the company portfolio website.where we can maintain our blog,project,details etc..,

Theme URL - http://vegamsoft.com/themes/business-group-vss
Author URL - http://vegamsoft.com/

SVN - https://themes.svn.wordpress.org/business-group-vss/1.0.2
ZIP - https://wordpress.org/themes/download/business-group-vss.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=business-group-vss/1.0.1&new_path=business-group-vss/1.0.2

History:


https://themes.svn.wordpress.org/business-group-vss/1.0.2/screenshot.png

#8 @Muruganathan
3 years ago

Hi,

I have update a new theme version with customizer option.Please give the review for our theme.

Thank You
Vegam Soft Solutions.

#9 @alex27
3 years ago

I don't see any change. You still haveVSS Theme Options section under Appearance, and none of the settings were added to Customizer. Here you'll find a post that explains the transition: https://make.wordpress.org/themes/2015/06/11/moving-to-the-customizer-api-from-the-settings-api-using-options-api/

#10 @Muruganathan
3 years ago

Hi,

Q1. You still have VSS Theme Options section under Appearance ?

I don't understand this point,because we can add theme options in the VSS Theme Options section.if we can't use that under Appearance means where we can use that.Please give some idea to me.

Q2. None of the settings were added to Customizer ?

we have all customize theme option in the theme option section,So we have uses that to customize our theme.Some other options like ( the header text color, background color, Website title, latest pages)these option in the customize menu.

why we cannot use (Theme Option) by this ways.If you have any sample theme.Please send me that link.It will easy for to me to understand your view.Whether it is must for our theme and also I have seen many wordpress theme use the theme option in the Appearance Menu.
--
Thank You
Vegam Soft Solutions

Last edited 3 years ago by Muruganathan (previous) (diff)

#11 @alex27
3 years ago

why we cannot use (Theme Option) by this ways.

Because this is a requirement. From the announcement post: https://make.wordpress.org/themes/2015/04/22/details-on-the-new-theme-settings-customizer-guideline/

Themes are now required to utilize the Customizer API if the theme has custom theme settings. This means no custom settings screens.

You need to move all your custom settings into Customizer, if you want to keep them.

I have seen many wordpress theme use the theme option in the Appearance Menu.

Yes, because this is a recent change introduced on April 23, 2015. Please note, that requirements change over time, and the fact that you found a theme in the repository using certain technique, does not mean that it's still allowed.

#12 @Muruganathan
3 years ago

Hi,

Now i understand, I will upgrade the latest version with Customizer API soon.

--
Thank You
Vegam Soft Solutions

#13 @themetracbot
2 years ago

  • Summary changed from THEME: Business Group - VSS – 1.0.2 to THEME: Business Group - VSS – 1.0.3

Business Group - VSS - 1.0.3

The Business Group – VSS theme is mainly focus on the company portfolio website.where we can maintain our blog,project,details etc..,

Theme URL - http://vegamsoft.com/themes/business-group-vss
Author URL - http://vegamsoft.com/

SVN - https://themes.svn.wordpress.org/business-group-vss/1.0.3
ZIP - https://wordpress.org/themes/download/business-group-vss.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=business-group-vss/1.0.2&new_path=business-group-vss/1.0.3

History:


https://themes.svn.wordpress.org/business-group-vss/1.0.3/screenshot.png

#14 @alex27
2 years ago

Hi there!

Thank you for the update. I went through you theme again and found some additional issues that need addressing:

  • Wrong screenshot size. Maximum screenshot size is 1200x900, but any image with 4:3 ratio is acceptable.
  • please remove jQuery.min.js from js folder. Bundling jQuery script with the theme is not allowed.
  • content related metaboxes are not allowed in themes. Please remove vss-about-metabox.php and vss-contact-metabox.php
  • For logo and faviocon upload you should be using esc_url_raw as the sanitize function in customizer.php. The same goes for slider images upload.
  • esc_url() is not the proper sanitization function for settings like blog and portfolio count. If you expect a positive integer here use absint() instead. esc_url() is also not the proper function to sanitize footer settings, where text is expected.
  • The social media links and footer text and slider images are not being escaped on output;
  • Please remove brand logos from from the screenshot;
  • vssgroup_theme_slug_widgets_init - please move this function and the action it’s attached to outside the vssgroup_theme_features function. Also, why is there the word ‘slug’ in the name?
  • add_editor_style() call should be placed in vssgroup_theme_features function.
  • Please remove:
    • wp_enqueue_script( 'jquery-1.9.1', 'http://code.jquery.com/jquery-1.10.2.js', false, '1.9.1' );
    • wp_enqueue_script('jquery’);
    • wp_enqueue_script('vss-jquery-min', 'http://code.jquery.com/jquery.min.js', array('jquery'), '', false); from functions.php. Themes must use jQuery version included in WordPress. You should be adding jQuery as a dependency to the scripts that need it.
  • vssgroup_load_custom_wp_admin_style - is this function still needed, since theme options page has been removed in favour of Customizer?
  • style handles in vssgroup_wp_enqueue_style should be prefixed with theme slug.
  • Themes can recommend but not require plugins - please change the setting in TGM activation options to recommended.
  • Please remove show_admin_bar( false ); from functions.php. Disabling admin bar is not allowed.

CONCLUSION

Please fix above issues and upload new version of your theme, I'll leave this ticket open for another 7 days. Feel free to ask if you have any questions.

#15 @themetracbot
2 years ago

  • Summary changed from THEME: Business Group - VSS – 1.0.3 to THEME: Business Group - VSS – 1.0.4

Business Group - VSS - 1.0.4

The Business Group – VSS theme is mainly focus on the company portfolio website.where we can maintain our blog,project,details etc..,

Theme URL - http://vegamsoft.com/themes/business-group-vss
Author URL - http://vegamsoft.com/

SVN - https://themes.svn.wordpress.org/business-group-vss/1.0.4
ZIP - https://wordpress.org/themes/download/business-group-vss.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=business-group-vss/1.0.3&new_path=business-group-vss/1.0.4

History:


https://themes.svn.wordpress.org/business-group-vss/1.0.4/screenshot.png

#16 @alex27
2 years ago

Hi there!

Thank you for the update. Some items still need attention:

  • Loading jQuery (or any other script) from CDN is not allowed. Please use the jQuery version included with WordPress. This wp_enqueue_script('vssgroup-jquery-min’); can be safely removed, as you’re already passing jQuery as a dependency to scripts.
  • What’s the point of having hard coded strings in page templates, for example contact information in vs-contact.php? It’s not editable and thus useless to the user. Please remove all the hard coded data from page templates.
  • Please remove contact form from contact page template. This is plugin territory and in fact there are many contact form plugins out there.
  • Portfolio template gives the following errors:
    • Notice: Trying to get property of non-object in wp-content/themes/business-group-vss/templates/vss-portfolio.php on line 46
    • Notice: Trying to get property of non-object in wp-content/themes/business-group-vss/templates/vss-portfolio.php on line 47
    • Notice: Trying to get property of non-object in wp-content/themes/business-group-vss/templates/vss-portfolio.php on line 48
    • while I understand that this page template needs the Custom CPT plugin to work correctly, it should not produce any PHP errors, warnings or notices without the plugin.
  • The screenshot is slightly distorted, could you please fix and update?
  • There are some serious visual issues with menus https://cloudup.com/cu0L85qRKSG:
    • Drop-down menu is hidden behind the slider
    • Nav menus in sidebar widgets
    • Menu in the footer
  • When front page is set to display latest posts, there is no navigation to older posts.
  • Search does not work properly - searching for any term returns the same set of posts every time.
  • Sorry for not catching it earlier, but settings like blog and portfolio count should be removed as themes should observe WordPress setting Blog pages show at most under Settings > Reading
  • In sanitize_callback settings in Customizer, you should use function names like so: 'sanitize_callback' => 'absint’, instead of 'sanitize_callback' => 'absint()';

#17 @Muruganathan
2 years ago

Hi,

Can you please guide me on this below issues and also how can i see this.
-> Loading jQuery (or any other script) from CDN is not allowed. Please use the jQuery version included with WordPress. This wp_enqueue_script('vssgroup-jquery-min’); can be safely removed, as you’re already passing jQuery as a dependency to scripts.

--
Thank You
Vegam Soft Solutions

#18 @alex27
2 years ago

All you need to do, is remove these two lines from functions.php:

wp_register_script('vssgroup-jquery-min', ("https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"), false, '1.11.1'); 
wp_enqueue_script('vssgroup-jquery-min');

#19 @Muruganathan
2 years ago

Hi,

Error : Portfolio template gives the following errors:

Notice: Trying to get property of non-object in wp-content/themes/business-group-vss/templates/vss-portfolio.php on line 46
Notice: Trying to get property of non-object in wp-content/themes/business-group-vss/templates/vss-portfolio.php on line 47
Notice: Trying to get property of non-object in wp-content/themes/business-group-vss/templates/vss-portfolio.php on line 48
while I understand that this page template needs the Custom CPT plugin to work correctly, it should not produce any PHP errors, warnings or notices without the plugin.

-> I have find that this error came due to the use of this below code in wp_config.php file.

define('WP_DEBUG', true);

-> if you change that to define('WP_DEBUG', false); its working fine

--
Thank You
Vegam Soft Solutions

#20 @themetracbot
2 years ago

  • Summary changed from THEME: Business Group - VSS – 1.0.4 to THEME: Business Group - VSS – 1.0.5

Business Group - VSS - 1.0.5

The Business Group – VSS theme is mainly focus on the company portfolio website.where we can maintain our blog,project,details etc..,

Theme URL - http://vegamsoft.com/themes/business-group-vss
Author URL - http://vegamsoft.com/

SVN - https://themes.svn.wordpress.org/business-group-vss/1.0.5
ZIP - https://wordpress.org/themes/download/business-group-vss.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=business-group-vss/1.0.4&new_path=business-group-vss/1.0.5

History:


https://themes.svn.wordpress.org/business-group-vss/1.0.5/screenshot.png

#21 @alex27
2 years ago

Hello!

Thank you for the update. Some items still need work:

  • All prompts like "Please install a Contact Form 7" should be wrapped in translation function.
  • echo do_shortcode('[contact-form-7 id="260" title="Contact form 1"]'); will not work - the form ID for each user will be different. This should be removed entirely, the user will paste form shortcode provided by the plugin, if he wants to use it.
  • Related to the above, all prompts to install plugins, like "Please install a Contact Form 7" should be displayed only to logged in admins. Why would you show that to all visitors? Also, some users might not want that functionality and don't install plugin on purpose. Those prompts are not helpful at all, and I'd suggest removing entirely.
  • All the PHP notices on portfolio template are still there. define('WP_DEBUG', true); is required when reviewing and testing a theme precisely to see such notices. You need to fix this.
  • In footer.php, please either remove the the hard-coded alt="Fot-sos1". Either remove the alts completely or make the message relevant.
  • All strings in alt and title need to be wrapped in a translation function!
  • JavaScript erros:
    • Uncaught TypeError: undefined is not a function in script.js:1 and vssgroup-animation-code.js:4
    • business-group-vss/images/line.png Failed to load resource: the server responded with a status of 404 (Not Found)
  • search.php - Search for.... string should be wrapped in translation function.
  • In home-front.php for blog and portfolio count you're still not using user settings, you just changed theme option to hard-coded number of posts to display! You need to use $posts_per_page variable instead. The same goes for blog page template.
  • Please remove Template Name: Search Page from search.php. The name is in conflict with default file name for search template.

Please fix above issues and upload new version of your theme, I'll leave this ticket open for another 7 days. Feel free to ask if you have any questions.

#22 @themetracbot
2 years ago

  • Summary changed from THEME: Business Group - VSS – 1.0.5 to THEME: Business Group - VSS – 1.0.6

Business Group - VSS - 1.0.6

The Business Group – VSS theme is mainly focus on the company portfolio website.where we can maintain our blog,project,details etc..,

Theme URL - http://vegamsoft.com/themes/business-group-vss
Author URL - http://vegamsoft.com/

SVN - https://themes.svn.wordpress.org/business-group-vss/1.0.6
ZIP - https://wordpress.org/themes/download/business-group-vss.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=business-group-vss/1.0.5&new_path=business-group-vss/1.0.6

History:


https://themes.svn.wordpress.org/business-group-vss/1.0.6/screenshot.png

#23 @alex27
2 years ago

Hi there!

The theme needs a lot of work, I still found quite a few major issues:

REQUIRED

  • theme settings need to be prefixed with theme slug (cont_form_phone, slider_add etc.)
  • main widget area is called "left Sidebar", while it's default position is on the right. Please change to "Sidebar Right" or simply "Sidebar"
  • with custom logo the "Display Header Text" setting is not respected (see screenshot). Also, the image is hidden behind the menu.
  • "Homepage Brand Logo Option" - what is this option for and how is it different from website logo option?
  • Please remove the "CONNECT WITH US" text when no social links are configured by the user.
  • Custom header image is not being applied (see screenshot)
  • User settings are still not applied - my front page shows latest posts and my setting was to show 10 posts, but the theme shows 4.
  • "A FEW OF OUR RECENT PROJECTS", "Branch Address", "Head Office" - those texts should not be displayed if there is no relevant data to display.
  • to retrieve Customizer settings, use get_theme_mod(), not get_option()
  • for a theme to be translatable, you need to load theme textdomain in the setup function with load_theme_textdomain()
  • theme textdomain cannot contain spaces, so vssgroup theme will have to be changed to vssgroup-theme or vssgroup_theme
  • add_editor_style() should not be wrapped in additional function;
  • After adding "Lates project" widget I get the following PHP notices:
    • Notice: Use of undefined constant SORRY_NO_POST_MATCHED - assumed 'SORRY_NO_POST_MATCHED' in /wp-content/themes/business-group-vss/widgets/vss-recent-project.php on line 85
  • All user input in custom widget needs to sanitized on input and escaped on output.

CONCLUSION

Please fix above issues and upload new version of your theme, I'll leave this ticket open for another 7 days. Feel free to ask if you have any questions.

@alex27
2 years ago

Custom header image is not being displayed

@alex27
2 years ago

Website title is not being displayed when using custom logo, also logo is hidden behind menu

#24 @Muruganathan
2 years ago

Hi,

Question : Homepage Brand Logo Option - what is this option for and how is it different from website logo option?

Answer : This option is used for brand logo which is present in the homepage.
We have to paste the logo slider shortcode in this box.This will display the all brand logo upload by the user in the homepage.please refer below images.

http://demo1.testing.vegamsoft.co.uk/homepageslider.png

#25 @themetracbot
2 years ago

  • Summary changed from THEME: Business Group - VSS – 1.0.6 to THEME: Business Group - VSS – 1.0.7

Business Group - VSS - 1.0.7

The Business Group – VSS theme is mainly focus on the company portfolio website.where we can maintain our blog,project,details etc..,

Theme URL - http://vegamsoft.com/themes/business-group-vss
Author URL - http://vegamsoft.com/

SVN - https://themes.svn.wordpress.org/business-group-vss/1.0.7
ZIP - https://wordpress.org/themes/download/business-group-vss.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=business-group-vss/1.0.6&new_path=business-group-vss/1.0.7

History:


https://themes.svn.wordpress.org/business-group-vss/1.0.7/screenshot.png

#26 @alex27
2 years ago

Hi there!

Thanks for the update. Most issues from previous ticket have been resolved, so we can move forward. Here's another portion:

  • NOT FIXED: Website title is not being displayed when using custom logo, also logo is hidden behind menu
  • Theme text domain defined in load_theme_textdomain() must be used throughout the theme. You have two different text domains.
  • Default background image needs to be included with the theme. This path is relative to user's uploads folder and won't work: wp-content/uploads/2014/03/cross-background.png (functions.php, line 13)
  • The vssgroup-editor-style.css file is empty. Please remove it, and remove add_editor_style() call as well.
  • functions.php, line 68 - wrong text domain
  • functions.php, line 115 - please use https when enqueuing Google fonts. Also, you cannot use /css?family=EB Garamond like that, you need to include + sign like so: /css?family=EB+Garamond
  • You're bunding Source Sans Pro font with the theme, but it's not used by the theme. Please remove it, if that's the case.
  • wvv_sitemap.php - this page template does not make any sense - you're hard coding a bunch of link here to pages that may not exist on user site at all. Even if they existed, the links would not work anyway, since you're hardcoding some arbitrary relative path. Either remove this template or make it generate the correct sitemap automatically. Personally I feel removing it is the best way, there are many sitemaps plugins out there already.
  • Some strings are still not wrapped in translation function: vss-portfolio.php
  • Blog page template is confusing? Why can't is be the default blog template (index.php)? Also, it throws the following PHP Notice:

Notice: Use of undefined constant SORRY_NO_POST_MATCHED - assumed 'SORRY_NO_POST_MATCHED' in wp-content/themes/business-group-vss/templates/vss-blog.php on line 77 SORRY_NO_POST_MATCHED

  • customizer.php - all labels, descriptions and option titles need to be wrapped in translation function.
  • You're using vssgroup_footer_sanitize_text as your sanitization function for almost all settings. This is not the appropriate function for things like URL. Please use sanitization function appropraite for the each type of data. For more information see this guide.
  • "My Customizer Tagline" section in Customizer - what is it for?

#27 @Muruganathan
2 years ago

Hi,

Q1 . Blog page template is confusing? Why can't is be the default blog template (index.php)?

When we use home page(home-front.php) template we cannot use the index.php file for that only if we want blog means we can use the blog templates files.

--
Thank You
Vegam Soft Solutions

#28 @alex27
2 years ago

I still don't understand. When user selects to display latest posts on the homepage the lists of posts looks different then the one using blog template. Why can't it be the same?

#29 @Muruganathan
2 years ago

Hi,

Now I Understand i will solve that.Another doubt is

Q1. customizer.php - all labels, descriptions and option titles need to be wrapped in translation function.?

I don't understand this point because already all labels, descriptions and option titles are used the translation function.Please can you explain this point briefly.

#30 @alex27
2 years ago

I don't understand this point because already all labels, descriptions and option titles are used the translation function.

This refers to "My Customizer Tagline" section in Customizer and checkbox setting inside. Removing those dummy settings will solve the issue.

#31 @themetracbot
2 years ago

  • Summary changed from THEME: Business Group - VSS – 1.0.7 to THEME: Business Group - VSS – 1.0.8

Business Group - VSS - 1.0.8

The Business Group – VSS theme is mainly focus on the company portfolio website.where we can maintain our blog,project,details etc..,

Theme URL - http://vegamsoft.com/themes/business-group-vss
Author URL - http://vegamsoft.com/

SVN - https://themes.svn.wordpress.org/business-group-vss/1.0.8
ZIP - https://wordpress.org/themes/download/business-group-vss.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=business-group-vss/1.0.7&new_path=business-group-vss/1.0.8

History:


https://themes.svn.wordpress.org/business-group-vss/1.0.8/screenshot.png

#32 @alex27
2 years ago

Sorry for the long silence, I'll get back to you today!

#33 @alex27
2 years ago

Hi there!

Thank you for your patience! I feel like we're getting closer.
Here's what still needs fixing:

  • 404.php - Search… and Search strings need to be wrapped in a translation function;
  • category.php, tag.php CATEGORY : , TAG : strings need to be wrapped in a translation function;
  • vss-blog.php - No Post Found string should be wrapped in a translation function.
  • Social media links - providing just one URL, displays all three icons. Expected behaviour: only icons with explicitly provided URL should be displayed.
  • Your implementation of custom header and custom background features is wrong. It should be

add_theme_support( 'custom-background', $background_args ); instead of add_theme_support( 'vssgroup_background', $background_args ); and for header add_theme_support( 'custom-header', $header_args );

  • When I set the front page to a static page using Home template I got the following PHP notice:

Notice: Undefined property: stdClass::$publish in /wp-content/themes/business-group-vss/home-front.php on line 27
Wrong text domain in single.php, l39

  • loop.php - function_exists('has_post_thumbnail’) this is not necessary, as has_post_thumbnail() function was add in WordPress 2.9 and we only check for compatibility two major versions back.
  • index.php, home-front.php, vss-blog.php - thumbnail url output should be properly escaped
  • home-front.php - echo substr(get_the_excerpt(), 0,100); this is not the proper way to limit the excerpt length. substr will cut off text in the middle of a word - not very user friendly. The proper way is to use excerpt length filter.
  • Theme tags in style.css - I don’t see how the following refer to this theme: brown, orange, yellow, tan, editor-style, microformats, post-formats, fluid-layout. You could add the following though: blue, responsive-layout

#34 @themetracbot
2 years ago

  • Summary changed from THEME: Business Group - VSS – 1.0.8 to THEME: Business Group - VSS – 1.0.9

Business Group - VSS - 1.0.9

The Business Group – VSS theme is mainly focus on the company portfolio website.where we can maintain our blog,project,details etc..,

Theme URL - http://vegamsoft.com/themes/business-group-vss
Author URL - http://vegamsoft.com/

SVN - https://themes.svn.wordpress.org/business-group-vss/1.0.9
ZIP - https://wordpress.org/themes/download/business-group-vss.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=business-group-vss/1.0.8&new_path=business-group-vss/1.0.9

History:


https://themes.svn.wordpress.org/business-group-vss/1.0.9/screenshot.png

#35 @alex27
2 years ago

Hi there!

Thanks for the update. I was still able to find the following issues:

  • index.php - query_posts() is not to be used to create custom loops in themes or plugins, please remove it. Also, you don't need custom query here at all - you're just duplicating the default WordPress query for index page.
  • Please remove all instances of function_exists('has_post_thumbnail’) (found in index.php as well, but please check all files);
  • The default background image makes text unreadable https://cldup.com/3I3LimSzxj.png
  • Theme tags in style.css : fixed-layout and responsive-layout are mutually exclusive. Please refer to this page and choose appropriate tags.
  • You should not be hardcoding http: in social links. This will result in broken links.
  • Favicons are now supported in WordPress core, so please remove the custom theme option and add support for the core implementation. More info here.
  • The "Read more" link on custom Home page template opens links in new tab, please change it so that links are opened in the same tab.

#36 @themetracbot
2 years ago

  • Summary changed from THEME: Business Group - VSS – 1.0.9 to THEME: Business Group - VSS – 1.0.10

Business Group - VSS - 1.0.10

The Business Group – VSS theme is mainly focus on the company portfolio website.where we can maintain our blog,project,details etc..,

Theme URL - http://vegamsoft.com/themes/business-group-vss
Author URL - http://vegamsoft.com/

SVN - https://themes.svn.wordpress.org/business-group-vss/1.0.10
ZIP - https://wordpress.org/themes/download/business-group-vss.1.0.10.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=business-group-vss/1.0.9&new_path=business-group-vss/1.0.10

History:


https://themes.svn.wordpress.org/business-group-vss/1.0.10/screenshot.png

#37 @alex27
2 years ago

Hi there!

Really sorry about the long wait!

There are still some issues leftover from previous round:

NOT FIXED

  • query_posts() is not to be used to create custom loops in themes or plugins, please remove it in all files.
  • Please remove all instances of function_exists('has_post_thumbnail’).
  • On index.php and home-front.php you should check if the post thumbnail image is set, otherwise you have broken <img> elements.

#38 @themetracbot
2 years ago

  • Summary changed from THEME: Business Group - VSS – 1.0.10 to THEME: Business Group - VSS – 1.0.11

Business Group - VSS - 1.0.11

The Business Group &#8211; VSS theme is mainly focus on the company portfolio website.where we can maintain our blog,project,details etc..,

Theme URL - http://vegamsoft.com/themes/business-group-vss
Author URL - http://vegamsoft.com/

SVN - https://themes.svn.wordpress.org/business-group-vss/1.0.11
ZIP - https://wordpress.org/themes/download/business-group-vss.1.0.11.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=business-group-vss/1.0.10&new_path=business-group-vss/1.0.11

History:


https://themes.svn.wordpress.org/business-group-vss/1.0.11/screenshot.png

#39 @alex27
2 years ago

Thanks for the update, we're really close now!

Just a couple of issues:

  • More than one text-domain is being used in this theme. The domains found are vssgroup_theme,tgmpa,sidebar,vssgroup_wpb_widget_domain. Please make sure that you're using one text-domain throughout.
  • Related to the above, I found a bunch of translation functions (_n_noop) missing a text-domain in functions.php and class-tgm-plugin-activation.php. You might want to update the TGM plugin activation script as well, I believe a new version is out.

#40 @themetracbot
2 years ago

  • Summary changed from THEME: Business Group - VSS – 1.0.11 to THEME: Business Group - VSS – 1.0.12

Business Group - VSS - 1.0.12

The Business Group &#8211; VSS theme is mainly focus on the company portfolio website.where we can maintain our blog,project,details etc..,

Theme URL - http://vegamsoft.com/themes/business-group-vss
Author URL - http://vegamsoft.com/

SVN - https://themes.svn.wordpress.org/business-group-vss/1.0.12
ZIP - https://wordpress.org/themes/download/business-group-vss.1.0.12.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=business-group-vss/1.0.11&new_path=business-group-vss/1.0.12

History:


https://themes.svn.wordpress.org/business-group-vss/1.0.12/screenshot.png

#41 @karmatosed
2 years ago

@alex27 are you able to carry on this review as there is now an update?

#42 @alex27
2 years ago

Yes! Sorry about that! Will take a look & post feedback today.

#43 @alex27
2 years ago

Hi there!

We're almost there! Last changes look good.
I noticed that glyphicons in fonts folder are not used at all. Please remove the folder if that's the case. If you want to keep them, please provide license & copyright information in readme.txt.

I think this is the last of it! Sorry again for the delays. I'll keep a close eye on updates and will do my best to wrap up quickly!

#44 @themetracbot
2 years ago

  • Summary changed from THEME: Business Group - VSS – 1.0.12 to THEME: Business Group - VSS – 1.0.13

Business Group - VSS - 1.0.13

The Business Group &#8211; VSS theme is mainly focus on the company portfolio website.where we can maintain our blog,project,details etc..,

Theme URL - http://vegamsoft.com/themes/business-group-vss
Author URL - http://vegamsoft.com/

SVN - https://themes.svn.wordpress.org/business-group-vss/1.0.13
ZIP - https://wordpress.org/themes/download/business-group-vss.1.0.13.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=business-group-vss/1.0.12&new_path=business-group-vss/1.0.13

History:


https://themes.svn.wordpress.org/business-group-vss/1.0.13/screenshot.png

#45 @alex27
2 years ago

  • Status changed from reviewing to approved

Thanks for the update. This is it - I'm marking the theme as approved!

I have one general suggestion for future update - you should take a look at WordPress coding standards and work on your code to make it more readable. This will make the theme easier to work with both for you and your users. This is just a recommendation though.

#46 @alex27
2 years ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations, your theme is now live!

#47 @Muruganathan
2 years ago

Hi Alex,

Thank You for approving my theme. We will Upgrade the theme version soon with addition features.

--
Thank you ,
Johnsha

#48 @rabmalin
8 months ago

Hello

Your theme has following issues regarding TGM library. Please fix those and re-upload your theme.

  • Upgrade of the included TGM plugin activation library (Latest version: 2.6.1) required.
  • You are required to use a version of the TGM Plugin Activation library downloaded through the Custom TGMPA Generator. Download a fresh copy and make sure you select "WordPress.org" as your publication channel to get the correct version. http://tgmpluginactivation.com/download/

Thanks

Note: See TracTickets for help on using tickets.