WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#24935 closed theme (not-approved)

THEME: Pagee – 1.0.1

Reported by: kharisblank Owned by: mantismamita
Priority: new theme Keywords: theme-pagee
Cc: kharisblank@…

Description

Pagee - 1.0.0

Modern and Clean WordPress theme for blogging

Theme URL - http://dev.risbl.org/pagee-wp
Author URL - https://dev.risbl.org/

SVN - https://themes.svn.wordpress.org/pagee/1.0.0
ZIP - https://wordpress.org/themes/download/pagee.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#24935 THEME: Pagee – 1.0.1 closed not-approved mantismamita

(this ticket)


https://themes.svn.wordpress.org/pagee/1.0.0/screenshot.png

Change History (4)

#1 @themetracbot
2 years ago

  • Summary changed from THEME: Pagee – 1.0.0 to THEME: Pagee – 1.0.1

#2 @themetracbot
2 years ago

  • Owner set to mantismamita
  • Status changed from new to reviewing

#3 follow-up: @mantismamita
2 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hello Kharis,

Thank you for submitting your theme to the WordPress.org repository.

Unfortunately we won't be able to accept you theme until the following corrections are made. I have listed the corrections under the headings of Required (must be fixed for approval), Recommended (best practices), and Notes, which are things that I noticed when reviewing your theme.

Required

Recommended

  • `header#masthead doesn't accommodate a long title and multiple top-level menu items. Layout breaks at full width and also at smaller widths when title is long. Content is obscured by overflowing title and menu.
  • namespaces could be more obscure "pagee" could be used accidently in case of typo.
  • no link color (by default) on title in blog roll and archive to indicate that it links to the full post.
  • you have 3 @import statements for Google fonts which isn't good for performance. Please enqueue them via functions.php like so :


function pageetheme_load_fonts() {
            wp_register_style('googleFonts', 'http://fonts.googleapis.com/css?family=Rock+Salt|Neucha');
            wp_enqueue_style( 'googleFonts');
     }
    
     add_action('wp_print_styles', 'load_fonts');
  • instead of hardcoding the Theme Uri in the footer you can use:


$my_theme = wp_get_theme();
    echo $my_theme->get( 'ThemeURI' );

Notes

  • .page-has-children line-height issue (padding-top for ul.children?, indentation to indicate hierarchy?)

The next step will be to resubmit the theme with the corrections.

#4 in reply to: ↑ 3 @kharisblank
2 years ago

Replying to mantismamita:

Hello mantismamita.

Thanks a lot for your review summary. I'll fix them asap.

Note: See TracTickets for help on using tickets.