WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

#25036 closed theme (not-approved)

THEME: ProGo Base – 0.5.1

Reported by: ProGo Owned by: saurav.rox
Priority: new theme Keywords: theme-progo-base
Cc: progothemes@…

Description

ProGo Base - 0.4.1

ProGo Base is WordPress, Underscores, Bootstrap, Theme Hook Alliance, get-out-the-way-lemme-do-it all-in-one “Theme Framework”.

Theme URL - https://github.com/progothemes/pgb
Author URL - http://www.progo.com

SVN - https://themes.svn.wordpress.org/progo-base/0.4.1
ZIP - https://wordpress.org/themes/download/progo-base.0.4.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#25036 THEME: ProGo Base – 0.5.1 closed not-approved saurav.rox

(this ticket)


https://themes.svn.wordpress.org/progo-base/0.4.1/screenshot.png

Change History (10)

#1 @themetracbot
2 years ago

  • Summary changed from THEME: ProGo Base – 0.4.1 to THEME: ProGo Base – 0.4.2

ProGo Base - 0.4.2

ProGo Base is WordPress, Underscores, Bootstrap, Theme Hook Alliance, get-out-the-way-lemme-do-it all-in-one “Theme Framework”.

Theme URL - https://github.com/progothemes/pgb
Author URL - http://www.progo.com

SVN - https://themes.svn.wordpress.org/progo-base/0.4.2
ZIP - https://wordpress.org/themes/download/progo-base.0.4.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=progo-base/0.4.1&new_path=progo-base/0.4.2

History:

Ticket Summary Status Resolution Owner
#25036 THEME: ProGo Base – 0.5.1 closed not-approved saurav.rox

(this ticket)


https://themes.svn.wordpress.org/progo-base/0.4.2/screenshot.png

#2 @greenshady
2 years ago

Please note that custom theme options panels are not allowed. You must use the customizer. See: https://make.wordpress.org/themes/handbook/review/required/#options-and-settings

#3 @ProGo
2 years ago

Thank you for the insight, @greenshady . we will work to move our handful of theme options strictly over to the customizer, and resubmit when that is all set.

Maybe that "* Use the Customizer for implementing theme options." on the make.wordess.org page could have a little stronger wording in the future, like "Any and all Theme Options should be handled strictly through the Customizer" or something?

Cheers

#4 @greenshady
2 years ago

It's listed under the "requirements" section of the handbook. I'm not sure how much stronger it needs to be. Anything more would just be fluff. Nevertheless, feel free to bring up such matters on Slack or during one of the team meetings.

#5 @themetracbot
2 years ago

  • Summary changed from THEME: ProGo Base – 0.4.2 to THEME: ProGo Base – 0.5.1

ProGo Base - 0.5.1

ProGo Base is WordPress, Underscores, Bootstrap, Theme Hook Alliance, get-out-the-way-lemme-do-it all-in-one “Theme Framework”.

Theme URL - https://github.com/progothemes/pgb
Author URL - http://www.progo.com

SVN - https://themes.svn.wordpress.org/progo-base/0.5.1
ZIP - https://wordpress.org/themes/download/progo-base.0.5.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=progo-base/0.4.2&new_path=progo-base/0.5.1

History:

Ticket Summary Status Resolution Owner
#25036 THEME: ProGo Base – 0.5.1 closed not-approved saurav.rox

(this ticket)


https://themes.svn.wordpress.org/progo-base/0.5.1/screenshot.png

#6 @ProGo
2 years ago

Hello is there anything else we need to do to re submit this to the Theme Review process?

When we initially submitted, greenshady replied in less than 24 hours with the issue we needed to fix. We fixed it and resubmitted on the 29th, but haven't seen any movement since then.

Please let us know? thank you!!

#7 @greenshady
2 years ago

You'll need to wait your turn in the queue. You'll get a reviewer once the themes before you have been reviewed.

Also, as a sidenote: The post formats meta boxes are also not allowed. While waiting for a reviewer, I highly recommend going through the theme to make sure you're conforming to the guidelines.

#8 @themetracbot
2 years ago

  • Owner set to saurav.rox
  • Status changed from new to reviewing

#9 @saurav.rox
2 years ago

Hello josh,

Thanks for uploading theme. Here is the first level review. Please reupload your theme after fixing issues so that I can proceed for full review.

THEME CHECK

REQUIRED: Found a translation function that is missing a text-domain. Function esc_attr_e, with the arguments
REQUIRED: Found a translation function that is missing a text-domain. Function _e, with the arguments
REQUIRED: Found a translation function that is missing a text-domain. Function , with the arguments 'You may use these HTML tags and attributes:'
RECOMMENDED: Possible variable $value found in translation function in class.post_formats.php. Translation function calls must NOT contain PHP variables.
Line 328: <td><input type='text' id='postformats[video_title]' name='postformats[video_title]' value='<?php _e( isset( $valuevideo_title? ) ? esc_attr( $valuevideo_title? ) :

RECOMMENDED: Possible variable $value found in translation function in class.post_formats.php. Translation function calls must NOT contain PHP variables.
Line 324: <td><input type='text' id='postformats[video_embed]' name='postformats[video_embed]' value='<?php _e( isset( $valuevideo_embed? ) ? esc_attr( $valuevideo_embed? ) :
RECOMMENDED: Possible variable $value found in translation function in class.post_formats.php. Translation function calls must NOT contain PHP variables.
Line 292: <td><input type='text' id='postformats[quote_source_date]' name='postformats[quote_source_date]' value='<?php _e( isset( $valuequote_source_date? ) ? esc_attr( $value['quote_source_d
RECOMMENDED: Possible variable $value found in translation function in class.post_formats.php. Translation function calls must NOT contain PHP variables.
Line 288: <td><input type='text' id='postformats[quote_source_title]' name='postformats[quote_source_title]' value='<?php _e( isset( $valuequote_source_title? ) ? esc_attr( $value['quote_source_
RECOMMENDED: Possible variable $value found in translation function in class.post_formats.php. Translation function calls must NOT contain PHP variables.
Line 284: <td><input type='text' id='postformats[quote_source_url]' name='postformats[quote_source_url]' value='<?php _e( isset( $valuequote_source_url? ) ? esc_attr( $value['quote_source_ur
RECOMMENDED: Possible variable $value found in translation function in class.post_formats.php. Translation function calls must NOT contain PHP variables.
Line 280: <td><input type='text' id='postformats[quote_source_name]' name='postformats[quote_source_name]' value='<?php _e( isset( $valuequote_source_name? ) ? esc_attr( $value['quote_source_n
RECOMMENDED: Possible variable $value found in translation function in class.post_formats.php. Translation function calls must NOT contain PHP variables.
Line 249: <td><input type='text' id='postformats[link_title]' name='postformats[link_title]' value='<?php _e( isset( $valuelink_title? ) ? esc_attr( $valuelink_title? ) :
)
RECOMMENDED: Possible variable $value found in translation function in class.post_formats.php. Translation function calls must NOT contain PHP variables.
Line 245: <td><input type='text' id='postformats[link_url]' name='postformats[link_url]' value='<?php _e( isset( $valuelink_url? ) ? esc_attr( $valuelink_url? ) : ); ?>
RECOMMENDED: Possible variable $value found in translation function in class.post_formats.php. Translation function calls must NOT contain PHP variables.
Line 214: <td><input type='text' id='postformats[image_alt]' name='postformats[image_alt]' value='<?php _e( isset( $valueimage_alt? ) ? esc_attr( $valueimage_alt? ) :
);
RECOMMENDED: Possible variable $value found in translation function in class.post_formats.php. Translation function calls must NOT contain PHP variables.
Line 210: <td><input type='text' id='postformats[image_caption]' name='postformats[image_caption]' value='<?php _e( isset( $valueimage_caption? ) ? esc_attr( $valueimage_caption? )
RECOMMENDED: Possible variable $value found in translation function in class.post_formats.php. Translation function calls must NOT contain PHP variables.
Line 206: <td><input type='text' id='postformats[image_link]' name='postformats[image_link]' value='<?php _e( isset( $valueimage_link? ) ? esc_attr( $valueimage_link? ) : )
RECOMMENDED: Possible variable $value found in translation function in class.post_formats.php. Translation function calls must NOT contain PHP variables.
Line 175: <td><input type='text' id='postformats[audio_title]' name='postformats[audio_title]' value='<?php _e( isset( $valueaudio_title? ) ? esc_attr( $valueaudio_title? ) :

RECOMMENDED: Possible variable $value found in translation function in class.post_formats.php. Translation function calls must NOT contain PHP variables.
Line 171: <td><input type='text' id='postformats[audio_embed]' name='postformats[audio_embed]' value='<?php _e( isset( $valueaudio_embed? ) ? esc_attr( $valueaudio_embed? ) :
RECOMMENDED: Possible variable $meta_box found in translation function in class.post_formats.php. Translation function calls must NOT contain PHP variables.
Line 87:
( $meta_boxtitle?, 'pgb' ),
RECOMMENDED: Possible variable $menuleftright found in translation function in block-navtop.php. Translation function calls must NOT contain PHP variables.
Line 34: <div class='collapse navbar-collapse navbar-responsive-collapse <?php esc_attr_e( $menuleftright ); ?>'>
RECOMMENDED: No reference to add_theme_support( "custom-header", $args ) was found in the theme. It is recommended that the theme implement this functionality if using an image for the header.
RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
INFO: Possible hard-coded links were found in the file upload-theme.php.
Line 27: <td><a href='http://getbootstrap.com/customize/' target='_blank'><?php _e( 'Generate and
REQUIRED: More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are pgb, myplugin_textdomain.

style.css

  • REQUIRED: The theme text-domain is missing. It must be in small case with exactly matching the theme name i.e. progo-base. Please put it.

Language

readme.txt

  • REQUIRED: Please remove 'README.md'. You can copy the content of it to readme.txt.

License

  • REQUIRED: Please put the sources of the images with the license they are licensed under. You can keep them in readme.txt.

Data Sanitization

CODE

FILE

  • REQUIRED: Please remove the file 'upload-theme.php'.

js & styles

  • REQUIRED: File such as 'color-picker.min.css', 'iris.min.css' are the minified css files. However, there are no unminified files for them in the theme. There must be unminified files included if minified file is to be used. Please check other files too.

OTHERS

  • RECOMMEDED: Please maintain the code indent so that codes are readable for everyone.


Note:

Best Regards,

#10 @saurav.rox
2 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

No response from the theme author within the 7 days of the latest review. That is why sorry for marking it as 'not-approved'

Note: See TracTickets for help on using tickets.