WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

#25450 closed theme (not-approved)

THEME: Topcat – 1.0.3

Reported by: dejanmarkovic Owned by: rabmalin
Priority: new theme Keywords: theme-topcat
Cc: dejan@…

Description

Topcat - 0.1

Topcat Lite is a responsive, clean and beautiful business and blog style theme featuring custom menu and custom background, custom header and easy to read typography that scales to fit all screens.

Theme URL - http://nytogroup.com/wordpress-themes/topcat-lite
Author URL - http://dejanmarkovic.com/

SVN - https://themes.svn.wordpress.org/topcat/0.1
ZIP - https://wordpress.org/themes/download/topcat.0.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#25450 THEME: Topcat – 1.0.3 closed not-approved rabmalin

(this ticket)

#25864 THEME: Topcat Lite – 1.0.10 closed live rabmalin
#26890 THEME: Topcat Lite – 1.0.13 closed live jcastaneda
#27210 THEME: Topcat Lite – 1.0.14 closed live jcastaneda
#27673 THEME: Topcat Lite – 1.0.15 closed live emiluzelac
#27981 THEME: Topcat Lite – 1.0.16 closed live karmatosed
#30560 THEME: Topcat Lite – 1.0.17 closed live jcastaneda
#30847 THEME: Topcat Lite – 1.0.18 closed live Otto42


https://themes.svn.wordpress.org/topcat/0.1/screenshot.png

Change History (8)

#1 @themetracbot
2 years ago

  • Summary changed from THEME: Topcat – 0.1 to THEME: Topcat – 1.0

Topcat - 1.0

Topcat Lite is a responsive, clean and beautiful business and blog style theme featuring custom menu and custom background, custom header and easy to read typography that scales to fit all screens.

Theme URL - http://nytogroup.com/wordpress-themes/topcat-lite
Author URL - http://dejanmarkovic.com/

SVN - https://themes.svn.wordpress.org/topcat/1.0
ZIP - https://wordpress.org/themes/download/topcat.1.0.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=topcat/0.1&new_path=topcat/1.0

History:

Ticket Summary Status Resolution Owner
#25450 THEME: Topcat – 1.0.3 closed not-approved rabmalin

(this ticket)

#25864 THEME: Topcat Lite – 1.0.10 closed live rabmalin
#26890 THEME: Topcat Lite – 1.0.13 closed live jcastaneda
#27210 THEME: Topcat Lite – 1.0.14 closed live jcastaneda
#27673 THEME: Topcat Lite – 1.0.15 closed live emiluzelac
#27981 THEME: Topcat Lite – 1.0.16 closed live karmatosed
#30560 THEME: Topcat Lite – 1.0.17 closed live jcastaneda
#30847 THEME: Topcat Lite – 1.0.18 closed live Otto42


https://themes.svn.wordpress.org/topcat/1.0/screenshot.png

#2 @themetracbot
2 years ago

  • Summary changed from THEME: Topcat – 1.0 to THEME: Topcat – 1.0.1

Topcat - 1.0.1

Topcat Lite is a responsive, clean and beautiful business and blog style theme featuring custom menu and custom background, custom header and easy to read typography that scales to fit all screens.

Theme URL - http://nytogroup.com/wordpress-themes/topcat-lite
Author URL - http://dejanmarkovic.com/

SVN - https://themes.svn.wordpress.org/topcat/1.0.1
ZIP - https://wordpress.org/themes/download/topcat.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=topcat/1.0&new_path=topcat/1.0.1

History:

Ticket Summary Status Resolution Owner
#25450 THEME: Topcat – 1.0.3 closed not-approved rabmalin

(this ticket)

#25864 THEME: Topcat Lite – 1.0.10 closed live rabmalin
#26890 THEME: Topcat Lite – 1.0.13 closed live jcastaneda
#27210 THEME: Topcat Lite – 1.0.14 closed live jcastaneda
#27673 THEME: Topcat Lite – 1.0.15 closed live emiluzelac
#27981 THEME: Topcat Lite – 1.0.16 closed live karmatosed
#30560 THEME: Topcat Lite – 1.0.17 closed live jcastaneda
#30847 THEME: Topcat Lite – 1.0.18 closed live Otto42


https://themes.svn.wordpress.org/topcat/1.0.1/screenshot.png

#3 @themetracbot
2 years ago

  • Summary changed from THEME: Topcat – 1.0.1 to THEME: Topcat – 1.0.2

Topcat - 1.0.2

Topcat Lite is a responsive, clean and beautiful business and blog style theme featuring custom menu and custom background, custom header and easy to read typography that scales to fit all screens.

Theme URL - http://nytogroup.com/wordpress-themes/topcat-lite
Author URL - http://dejanmarkovic.com/

SVN - https://themes.svn.wordpress.org/topcat/1.0.2
ZIP - https://wordpress.org/themes/download/topcat.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=topcat/1.0.1&new_path=topcat/1.0.2

History:

Ticket Summary Status Resolution Owner
#25450 THEME: Topcat – 1.0.3 closed not-approved rabmalin

(this ticket)

#25864 THEME: Topcat Lite – 1.0.10 closed live rabmalin
#26890 THEME: Topcat Lite – 1.0.13 closed live jcastaneda
#27210 THEME: Topcat Lite – 1.0.14 closed live jcastaneda
#27673 THEME: Topcat Lite – 1.0.15 closed live emiluzelac
#27981 THEME: Topcat Lite – 1.0.16 closed live karmatosed
#30560 THEME: Topcat Lite – 1.0.17 closed live jcastaneda
#30847 THEME: Topcat Lite – 1.0.18 closed live Otto42


https://themes.svn.wordpress.org/topcat/1.0.2/screenshot.png

#4 @themetracbot
2 years ago

  • Summary changed from THEME: Topcat – 1.0.2 to THEME: Topcat – 1.0.3

Topcat - 1.0.3

Topcat Lite is a responsive, clean and beautiful business and blog style theme featuring custom menu and custom background, custom header and easy to read typography that scales to fit all screens.

Theme URL - http://nytogroup.com/wordpress-themes/topcat-lite
Author URL - http://dejanmarkovic.com/

SVN - https://themes.svn.wordpress.org/topcat/1.0.3
ZIP - https://wordpress.org/themes/download/topcat.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=topcat/1.0.2&new_path=topcat/1.0.3

History:

Ticket Summary Status Resolution Owner
#25450 THEME: Topcat – 1.0.3 closed not-approved rabmalin

(this ticket)

#25864 THEME: Topcat Lite – 1.0.10 closed live rabmalin
#26890 THEME: Topcat Lite – 1.0.13 closed live jcastaneda
#27210 THEME: Topcat Lite – 1.0.14 closed live jcastaneda
#27673 THEME: Topcat Lite – 1.0.15 closed live emiluzelac
#27981 THEME: Topcat Lite – 1.0.16 closed live karmatosed
#30560 THEME: Topcat Lite – 1.0.17 closed live jcastaneda
#30847 THEME: Topcat Lite – 1.0.18 closed live Otto42


https://themes.svn.wordpress.org/topcat/1.0.3/screenshot.png

#5 @rabmalin
2 years ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#6 follow-up: @rabmalin
2 years ago

Hello,

Thanks for uploading theme. Here is the first level review. Please reupload your theme after fixing issues so that I can proceed for full review.

Theme Check

  • RECOMMENDED: No reference to add_theme_support( "title-tag" ) was found in the theme. It is recommended that the theme implement this functionality for WordPress 4.1 and above.

style.css

readme

License

Language

  • REQUIRED: All strings are not translatable. Please fix it. You can check it with Pig Latin plugin https://wordpress.org/plugins/piglatin/
  • REQUIRED: Please update POT file.
  • REQUIRED: Use your text domain for displaying every strings.

Code

File

  • RECOMMENDED: It is highly recommended to have changelog.txt file to track changelog.
  • REQUIRED: Please remove unnecessary files. Eg: README.md, layout folder, less and scss of Font Awesome., install folder. Please check other files and folder also.

Note:

#7 in reply to: ↑ 6 @dejanmarkovic
2 years ago

Hi here is my response:
Theme Check

  1. RECOMMENDED: No reference to add_theme_support( "title-tag" ) was found in the theme. It is recommended that the theme implement this functionality for WordPress 4.1 and above.

DONE
style.css

  1. REQUIRED: Theme URI is not valid. It is redirecting to other page. https://make.wordpress.org/themes/handbook/review/recommended/selling-themes-and-links/

DONE

readme

  1. REQUIRED: Please update license information for bundled resources like fonts, javascripts, images, etc. https://make.wordpress.org/themes/handbook/guidelines/license-theme-name-credit-links-up-sell-themes/ updated both style.css and readme.txt DONE
  1. REQUIRED: Please mention license information and full image URL of images used in theme.

DONE


License

  1. REQUIRED: Bundled license should be GPL compatible. See this link for GPL compatible licenses. https://make.wordpress.org/themes/handbook/review/resources/#licenses-bundled-resources DONE


Language

  1. REQUIRED: All strings are not translatable. Please fix it. You can check it with Pig Latin plugin https://wordpress.org/plugins/piglatin/

It looks like they are translatable. I am not sure where to look. I have checked it with the Pig Latin + all the files manually, and also I have tested it with https://codex.wordpress.org/Theme_Unit_Test. Please advise.

  1. REQUIRED: Please update POT file. DONE
  2. REQUIRED: Use your text domain for displaying every strings.

I think text domain is used, I have checked all the files manually. Please advise.


Code

  1. REQUIRED: Function topcat_setup is not hooked to after_setup_theme hook.

(DONE)

  1. REQUIRED: Please prefix theme functions, classes, global variables, image size name, script and style handles, etc with theme slug. http://themereview.co/prefix-all-the-things/

'DONE, Not sure which one was wrong?. Please advise


  1. REQUIRED: Please use correct handling of front page content. https://make.wordpress.org/themes/2014/06/28/correct-handling-of-static-front-page-and-custom-blog-posts-index-template/

DONE


  1. RECOMMENDED: Check this link for implementing title-tag. https://make.wordpress.org/core/2014/10/29/title-tags-in-4-1/

(DONE)


  1. REQUIRED: Please remove unnecessary code comments. DONE


  1. REQUIRED: TGM Recommendation - You can only recommend relevant plugin which will work on the appearance. Plugin like Tweet Old Custom Post and Buffer My Post seems pretty unrelated to appearance of theme. DONE. Although I have seen many themes at wordpress.org that are recomending usage of their plugins. Can you please clarify that too?

File

  1. RECOMMENDED: It is highly recommended to have changelog.txt file to track changelog.

DONE

  1. REQUIRED: Please remove unnecessary files. Eg: README.md, layout folder, less and css of Font Awesome., install folder. Please check other files and folder also.

DONE

Thank you very much. I am looking forward to your feedback!

#8 @rabmalin
2 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

New ticket is created for this theme. So I will continue review in other ticket.

https://themes.trac.wordpress.org/ticket/25864

Closing this ticket.

Note: See TracTickets for help on using tickets.