WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

#25662 closed theme (not-approved)

THEME: scarlett – 1.0.0

Reported by: PurelyThemes Owned by: grvrulz
Priority: new theme Keywords: theme-scarlett
Cc: pure@…

Description

scarlett - 1.0.0

Supports WooCommerce, Simple layout, featuring unlimited color options, together with a responsive-first theme, this is sure to be a great starter theme to hack away with, or even to use as is!

Theme URL - http://purelythemes.com/scarlett
Author URL - http://www.purelythemes.com

SVN - https://themes.svn.wordpress.org/scarlett/1.0.0
ZIP - https://wordpress.org/themes/download/scarlett.1.0.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#25662 THEME: scarlett – 1.0.0 closed not-approved grvrulz

(this ticket)


https://themes.svn.wordpress.org/scarlett/1.0.0/screenshot.png

Attachments (1)

Screenshot from 2015-11-21 15:28:41.png (11.9 KB) - added by grvrulz 2 years ago.
Screenshot of layout issue

Download all attachments as: .zip

Change History (13)

#1 @themetracbot
2 years ago

  • Owner set to EunJiY
  • Status changed from new to reviewing

#2 follow-up: @karmatosed
2 years ago

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the urgent review queue. This may mean it still takes time, but should be of more priority. Thanks for your patience.

#3 in reply to: ↑ 2 @EunJiY
2 years ago

Oh, first of all, sorry for my bad English. I'd like to make an apology. I'm a student who studied about Wordpress. 3 month ago, I investigated 'Wordpress.org's theme registration system', enrolled this theme by mistake! Exactly, this is not my theme. I found way to delete this, but couldn't, even forgot... I couldn't find a way how to delete this ticket even now... If you would, could you delete this review? I'm so sorry to org's review team including you and this theme's real owner. I'm really sorry about my fault.

Last edited 2 years ago by EunJiY (previous) (diff)

#4 @karmatosed
2 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

No problem. I have removed this.

#5 @karmatosed
2 years ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

My apologies, this was closed by mistake as should just be reassigned.

#6 @karmatosed
2 years ago

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the urgent review queue. This may mean it still takes time, but should be of more priority. Thanks for your patience.

#7 @Otto42
2 years ago

  • Owner EunJiY deleted
  • Status changed from reopened to reviewing

#8 @themetracbot
2 years ago

  • Owner set to grvrulz

#9 @grvrulz
2 years ago

Hi there,

I'm sorry that you've had to wait this long for this review. I'll take this up on priority and give you an update very soon.

Cheers

This ticket was mentioned in Slack in #themereview by grvrulz. View the logs.


2 years ago

#11 @grvrulz
2 years ago

##REQUIRED

  • Prefix all options and function names with your slug.
  • Remove this stray textdomain called vdperanto.
  • Use sane defaults for theme options.
  • Include a readme for some instructions about the setup.
  • Properly escape values when printing them out. e.g. printing out values of theme options in templates etc.

##RECOMMENDED

  • You are setting the font family to FontAwesome on the body. Please consider using a proper font family. Currently the typography looks all weird and inconsistent across browsers.
  • There are some weird styling issues. Please see attached screenshot below and see styling for .single .byline, .group-blog .byline
  • Theme looks different in customizer vs in real. Please take a look.

I'll go through the files more deeply and let you know if I find any issues. Please start working on these in the meantime.

Cheers
Gaurav

@grvrulz
2 years ago

Screenshot of layout issue

#12 @grvrulz
2 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Please submit an updated version and I'll start reviewing again. Thanks.

Note: See TracTickets for help on using tickets.