WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

#25732 closed theme (live)

THEME: Libre – 1.0.1

Reported by: sixhours Owned by: psdtohtmlguru
Priority: new theme Keywords: theme-libre accessibility-ready
Cc: calobee@…

Description

Libre - 1.0.1

A stylish, classic look for your personal blog or long-form writing site. The main navigation bar stays fixed to the top while your visitors read, keeping your most important content at hand, while three footer widget areas give your secondary content a comfortable home.

Theme URL - https://wordpress.com/themes/libre/
Author URL - http://wordpress.com/themes/

SVN - https://themes.svn.wordpress.org/libre/1.0.1
ZIP - https://wordpress.org/themes/download/libre.1.0.1.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#25732 THEME: Libre – 1.0.1 closed live psdtohtmlguru

(this ticket)

#26134 THEME: Libretto – 1.0.1 closed live utsavsinghrathour
#28232 THEME: Libretto – 1.0.2 closed live jcastaneda
#30696 THEME: Libre Poppyz – 1.1.2 closed not-approved trkr
#34354 THEME: Libretto – 1.0.3 closed live themetracbot
#35071 THEME: Libretto – 1.0.4 closed live themetracbot
#44231 THEME: Libretto – 1.0.5 closed live themetracbot
#45965 THEME: Libretto – 1.0.6 closed live themetracbot
#46887 THEME: Libretto – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/libre/1.0.1/screenshot.png

Change History (18)

#1 @automattic
2 years ago

Sigh. I uploaded this under my personal account by mistake. Can we switch the owner to @automattic?

#2 @karmatosed
2 years ago

  • Keywords changed from theme-libre, accessibility-ready to theme-libre accessibility-ready
  • Owner set to karmatosed
  • Status changed from new to reviewing

Closing so we can re-upload.

#3 @karmatosed
2 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

#4 @karmatosed
2 years ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#5 @Otto42
2 years ago

We'll switch the ownership after the theme has been approved and is listed in the directory. In the meantime, just proceed as normal using your personal account.

#6 @karmatosed
2 years ago

Note to reviewer: we are unable to make this theme have the owner changed until the review is done. Caroline is a member of the team at Automattic, so please carry on the review as normal. Once we have the review done, we can change ownership. Thanks for doing this.

#7 @karmatosed
2 years ago

  • Owner karmatosed deleted
  • Status changed from reopened to reviewing

#8 @emiluzelac
2 years ago

  • Owner set to psdtohtmlguru

This ticket was mentioned in Slack in #themereview by emiluzelac. View the logs.


2 years ago

#10 @psdtohtmlguru
2 years ago

Thanks @emiluzelac, i will review this theme now.

#11 @psdtohtmlguru
2 years ago

Here is my review:

  1. When the user is logged in, the website width is increased, have a look here: https://drive.google.com/file/d/0B_PXQJiDwwstQ0FaT1cwdzhzYlU/view?usp=drivesdk
  2. The sticky post should be distinctly recognizable in some way in comparison to normal posts.
  3. Make sure you add word-wrap: break-word; to the content, titles, sidebar links, widget titles and comments to prevent Super/Duper/Long text. https://drive.google.com/file/d/0B_PXQJiDwwstc3JfTDNnWWtTMTQ/view?usp=drivesdk
  4. Please escape_url header_image() in header.php line 26
  5. Please escape_html $description in header.php line 41.
  6. Please escape_html get_the_author_meta( 'description' ) and the_archive_description() in archive.php line 22 & 24.
  7. Please escape_url the header_image() in /inc/custom-header.php line 111

Recommended:

  1. You can add custom-colors tag to your style.css

Thank you.

#12 @automattic
2 years ago

Thank you for your review! We should have an updated version of the theme uploaded next week.

#13 @themetracbot
2 years ago

  • Summary changed from THEME: Libre – 1.0.1 to THEME: Libre – 1.0.3

Libre - 1.0.3

A stylish, classic look for your personal blog or long-form writing site. The main navigation bar stays fixed to the top while your visitors read, keeping your most important content at hand, while three footer widget areas give your secondary content a comfortable home.

Theme URL - https://wordpress.com/themes/libre/
Author URL - http://wordpress.com/themes/

SVN - https://themes.svn.wordpress.org/libre/1.0.3
ZIP - https://wordpress.org/themes/download/libre.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=libre/1.0.1&new_path=libre/1.0.3

History:

Ticket Summary Status Resolution Owner
#25732 THEME: Libre – 1.0.1 closed live psdtohtmlguru

(this ticket)

#26134 THEME: Libretto – 1.0.1 closed live utsavsinghrathour
#28232 THEME: Libretto – 1.0.2 closed live jcastaneda
#30696 THEME: Libre Poppyz – 1.1.2 closed not-approved trkr
#34354 THEME: Libretto – 1.0.3 closed live themetracbot
#35071 THEME: Libretto – 1.0.4 closed live themetracbot
#44231 THEME: Libretto – 1.0.5 closed live themetracbot
#45965 THEME: Libretto – 1.0.6 closed live themetracbot
#46887 THEME: Libretto – 1.0.8 closed live themetracbot


https://themes.svn.wordpress.org/libre/1.0.3/screenshot.png

#14 @sixhours
2 years ago

  • Summary changed from THEME: Libre – 1.0.3 to THEME: Libre – 1.0.1

Howdy! Thanks again for the review.

We've fixed the word wrapping issue in this release!

  • As we understand it, sticky posts are not *Required* to look different as per https://make.wordpress.org/themes/handbook/review/required/
  • For escaping, we wouldn't want to escape HTML in author/archive descriptions, in case users put valid HTML there.
  • header_image() does not need escaping in the template files as it's escaped in core in wp-includes/theme.php

#15 @ktokopnik
2 years ago

How do I transition from 1.0.1 to 1.0.3? I attempted to simply download the .zip and install from there, but that resulted in:

Unpacking the package…

Installing the theme…

Destination folder already exists. /home/ktokopni/public_html/shadesbetween.com/wp-content/themes/libre/

Theme install failed.

#16 @Otto42
2 years ago

@ktokopnik : this trac is for theme reviews, it is not a support forum. Please use the support forums on WordPress.org if you are having problems.

#17 @psdtohtmlguru
2 years ago

  • Status changed from reviewing to approved

Regarding header_image() escape, it's always better to escape them twice.

Thank you.

#18 @jcastaneda
2 years ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations! The theme is live!

Note: See TracTickets for help on using tickets.