WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#25864 closed theme (live)

THEME: Topcat Lite – 1.0.10

Reported by: dejanmarkovic Owned by: rabmalin
Priority: new theme Keywords: theme-topcat-lite
Cc: dejan@…

Description

Topcat Lite - 1.0.4

Topcat Lite is a responsive, clean and beautiful business and blog style theme featuring custom menu and custom background, custom header and easy to read typography that scales to fit all screens.

Theme URL - http://nytogroup.com/products/wordpress-themes/topcat-lite/
Author URL - http://dejanmarkovic.com/

SVN - https://themes.svn.wordpress.org/topcat-lite/1.0.4
ZIP - https://wordpress.org/themes/download/topcat-lite.1.0.4.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#25864 THEME: Topcat Lite – 1.0.10 closed live rabmalin

(this ticket)

#26890 THEME: Topcat Lite – 1.0.13 closed live jcastaneda
#27210 THEME: Topcat Lite – 1.0.14 closed live jcastaneda
#27673 THEME: Topcat Lite – 1.0.15 closed live emiluzelac
#27981 THEME: Topcat Lite – 1.0.16 closed live karmatosed
#30560 THEME: Topcat Lite – 1.0.17 closed live jcastaneda
#30847 THEME: Topcat Lite – 1.0.18 closed live Otto42


https://themes.svn.wordpress.org/topcat-lite/1.0.4/screenshot.png

Change History (24)

#1 @rabmalin
2 years ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#2 @rabmalin
2 years ago

Continuing review from this ticket. https://themes.trac.wordpress.org/ticket/25450

#3 @rabmalin
2 years ago

Issues:

  • REQUIRED: Background image used is GPL compatible but you should write like this. Image is licensed under Creative Commons Zero.
  • REQUIRED: As your theme name is changed now, your Text Domain should be topcat-lite. Please fix it in all files.
  • REQUIRED: POT file should be topcat-lite.pot.
  • REQUIRED: Are you using layouts folder?
  • REQUIRED: Your new theme slug is topcat_lite. Please prefix all functions, classes, etc accordingly.
  • REQUIRED: Remove html5.js inclusion from header.php and implement it using hook.
  • REQUIRED: Move topcat_render_title stuff from header.php file and put it in functions.php.
  • REQUIRED: In footer.php, you have commented out implementation of footer_menu. If not needed please remove it.
  • REQUIRED: Image handle large-thumbnail should be prefixed with theme slug. Eg topcat-lite-large-thumbnail
  • REQUIRED: Mention license attribute for Google fonts in readme.txt file.
  • REQUIRED: I could not find the implementation of function topcat_custom_header_fonts.
  • REQUIRED: Strings not translatable; functions.php line 245, 273, 274,... Please check in other places also.
  • REQUIRED: Remove rtl.css.
  • REQUIRED: Please remove demo XML file. You should not include it in the theme. May be you could host that file in your own server and put link in readme.txt file.
  • REQUIRED: Logo should be disabled by default. Please fix it.

Note:

  • TGM Recommendation: There is no strict guideline about plugin recommendation but we have unwritten convention is that we should only allow relevant plugin. If you find uncomfortable with my view, you can consult with admin in Slack. If admin confirms about your plugin then I would be happy to approve with those plugin recommendations.

#4 @themetracbot
2 years ago

  • Summary changed from THEME: Topcat Lite – 1.0.4 to THEME: Topcat Lite – 1.0.5

Topcat Lite - 1.0.5

Topcat Lite is a responsive, clean and beautiful business and blog style theme featuring custom menu and custom background, custom header and easy to read typography that scales to fit all screens.

Theme URL - http://nytogroup.com/products/wordpress-themes/topcat-lite-lite/
Author URL - http://dejanmarkovic.com/

SVN - https://themes.svn.wordpress.org/topcat-lite/1.0.5
ZIP - https://wordpress.org/themes/download/topcat-lite.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=topcat-lite/1.0.4&new_path=topcat-lite/1.0.5

History:

Ticket Summary Status Resolution Owner
#25864 THEME: Topcat Lite – 1.0.10 closed live rabmalin

(this ticket)

#26890 THEME: Topcat Lite – 1.0.13 closed live jcastaneda
#27210 THEME: Topcat Lite – 1.0.14 closed live jcastaneda
#27673 THEME: Topcat Lite – 1.0.15 closed live emiluzelac
#27981 THEME: Topcat Lite – 1.0.16 closed live karmatosed
#30560 THEME: Topcat Lite – 1.0.17 closed live jcastaneda
#30847 THEME: Topcat Lite – 1.0.18 closed live Otto42


https://themes.svn.wordpress.org/topcat-lite/1.0.5/screenshot.png

#5 @dejanmarkovic
2 years ago

Hi here is my response:

REQUIRED: Background image used is GPL compatible but you should write like this. Image is licensed under Creative Commons Zero.

DONE


REQUIRED: As your theme name is changed now, your Text Domain should be topcat-lite. Please fix it in all files.
DONE


REQUIRED: POT file should be topcat-lite.pot.

DONE


REQUIRED: Are you using layouts folder?

Yes on line 158 in functions.php. wp_enqueue_style( 'topcat-lite-layout-css', get_template_directory_uri() . '/layouts/content-sidebar.css' );


REQUIRED: Your new theme slug is topcat_lite. Please prefix all functions, classes, etc accordingly.
DONE


REQUIRED: Remove html5.js inclusion from header.php and implement it using hook.

Done


REQUIRED: Move topcat_render_title stuff from header.php file and put it in functions.php.
DONE


REQUIRED: In footer.php, you have commented out implementation of footer_menu. If not needed please remove it.

DONE


REQUIRED: Image handle large-thumbnail should be prefixed with theme slug. Eg topcat-lite-large-thumbnail

DONE although again I found it not used like that in multiple themes :).


REQUIRED: Mention license attribute for Google fonts in readme.txt file.

DONE

REQUIRED: I could not find the implementation of function topcat_custom_header_fonts.
DONE


REQUIRED: Strings not translatable; functions.php line 245, 273, 274,... Please check in other places also.

Thanks for pointing that out but that code actually "belongs" to TGM and I don't think it should be translatable. For example on line 245 is the name of Contact Form 7 plugin and that should not be translatable. I think the same for the strings on lines 273, 274. Please correct me if I am worng

REQUIRED: Remove rtl.css.
DONE


REQUIRED: Please remove demo XML file. You should not include it in the theme. May be you could host that file in your own server and put link in readme.txt file.

Done


REQUIRED: Logo should be disabled by default. Please fix it.
Done

#6 @rabmalin
2 years ago

Issues:

  • REQUIRED: In style.css, Text Domain should be topcat-lite. Currently it is topcat_lite.
  • REQUIRED: Theme URI is not working.
  • REQUIRED: Any string in your theme should have text domain of your theme. Please replace tgmpa with your text domain.
  • RECOMMENDED: If logo is not uploaded, you could display site title and tagline.

#7 @themetracbot
2 years ago

  • Summary changed from THEME: Topcat Lite – 1.0.5 to THEME: Topcat Lite – 1.0.6

Topcat Lite - 1.0.6

Topcat Lite is a responsive, clean and beautiful business and blog style theme featuring custom menu and custom background, custom header and easy to read typography that scales to fit all screens.

Theme URL - http://nytogroup.com/products/wordpress-themes/topcat-lite/
Author URL - http://dejanmarkovic.com/

SVN - https://themes.svn.wordpress.org/topcat-lite/1.0.6
ZIP - https://wordpress.org/themes/download/topcat-lite.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=topcat-lite/1.0.5&new_path=topcat-lite/1.0.6

History:

Ticket Summary Status Resolution Owner
#25864 THEME: Topcat Lite – 1.0.10 closed live rabmalin

(this ticket)

#26890 THEME: Topcat Lite – 1.0.13 closed live jcastaneda
#27210 THEME: Topcat Lite – 1.0.14 closed live jcastaneda
#27673 THEME: Topcat Lite – 1.0.15 closed live emiluzelac
#27981 THEME: Topcat Lite – 1.0.16 closed live karmatosed
#30560 THEME: Topcat Lite – 1.0.17 closed live jcastaneda
#30847 THEME: Topcat Lite – 1.0.18 closed live Otto42


https://themes.svn.wordpress.org/topcat-lite/1.0.6/screenshot.png

#8 @dejanmarkovic
2 years ago

REQUIRED: In style.css, Text Domain should be topcat-lite. Currently it is topcat_lite.

DONE


REQUIRED: Theme URI is not working.
DONE

Hi, here is my update:


REQUIRED: Any string in your theme should have text domain of your theme. Please replace tgmpa with your text domain.
DONE


RECOMMENDED: If logo is not uploaded, you could display site title and tagline.
DONE


+

added code for social menu icon for wordpress.org
added instructions how to open social menu items in new window

#9 @rabmalin
2 years ago

Issues:

  • REQUIRED: Language issue: functions.php line 114, 250;
  • REQUIRED: Text domain missing for _n_noop function. Please check it thoroughly.

#10 @themetracbot
2 years ago

  • Summary changed from THEME: Topcat Lite – 1.0.6 to THEME: Topcat Lite – 1.0.7

Topcat Lite - 1.0.7

Topcat Lite is a responsive, clean and beautiful business and blog style theme featuring custom menu and custom background, custom header and easy to read typography that scales to fit all screens.

Theme URL - http://nytogroup.com/products/wordpress-themes/topcat-lite/
Author URL - http://dejanmarkovic.com/

SVN - https://themes.svn.wordpress.org/topcat-lite/1.0.7
ZIP - https://wordpress.org/themes/download/topcat-lite.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=topcat-lite/1.0.6&new_path=topcat-lite/1.0.7

History:

Ticket Summary Status Resolution Owner
#25864 THEME: Topcat Lite – 1.0.10 closed live rabmalin

(this ticket)

#26890 THEME: Topcat Lite – 1.0.13 closed live jcastaneda
#27210 THEME: Topcat Lite – 1.0.14 closed live jcastaneda
#27673 THEME: Topcat Lite – 1.0.15 closed live emiluzelac
#27981 THEME: Topcat Lite – 1.0.16 closed live karmatosed
#30560 THEME: Topcat Lite – 1.0.17 closed live jcastaneda
#30847 THEME: Topcat Lite – 1.0.18 closed live Otto42


https://themes.svn.wordpress.org/topcat-lite/1.0.7/screenshot.png

#11 @dejanmarkovic
2 years ago

Hi,

REQUIRED: Language issue: functions.php line 114, 250;

DONE

REQUIRED: Text domain missing for _n_noop function. Please check it thoroughly.

DONE Again that was the part of TGM implementation meaning Tom McFarlin wrote that part and he is not using text domain there. I have also checked multiple examples online and I have not found one that is using text domain with _n_noop(). I have fixed the code anyway.
Thank you very much. I appreciate your help!

#12 @themetracbot
2 years ago

  • Summary changed from THEME: Topcat Lite – 1.0.7 to THEME: Topcat Lite – 1.0.8

Topcat Lite - 1.0.8

Topcat Lite is a responsive, clean and beautiful business and blog style theme featuring custom menu and custom background, custom header and easy to read typography that scales to fit all screens.

Theme URL - http://nytogroup.com/products/wordpress-themes/topcat-lite/
Author URL - http://dejanmarkovic.com/

SVN - https://themes.svn.wordpress.org/topcat-lite/1.0.8
ZIP - https://wordpress.org/themes/download/topcat-lite.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=topcat-lite/1.0.7&new_path=topcat-lite/1.0.8

History:

Ticket Summary Status Resolution Owner
#25864 THEME: Topcat Lite – 1.0.10 closed live rabmalin

(this ticket)

#26890 THEME: Topcat Lite – 1.0.13 closed live jcastaneda
#27210 THEME: Topcat Lite – 1.0.14 closed live jcastaneda
#27673 THEME: Topcat Lite – 1.0.15 closed live emiluzelac
#27981 THEME: Topcat Lite – 1.0.16 closed live karmatosed
#30560 THEME: Topcat Lite – 1.0.17 closed live jcastaneda
#30847 THEME: Topcat Lite – 1.0.18 closed live Otto42


https://themes.svn.wordpress.org/topcat-lite/1.0.8/screenshot.png

#13 @dejanmarkovic
2 years ago

In previous version I forgot to rebuild the .pot file. I did it for this one 1.0.8. Thank you and sorry for the inconvenience.


#14 @rabmalin
2 years ago

Hello,

Your theme is almost ready to be approved. Function _n_noop takes only three parameters but you have passed four parameters. Please fix it and theme is ready to be approved.
https://codex.wordpress.org/Function_Reference/_n_noop

#15 @themetracbot
2 years ago

  • Summary changed from THEME: Topcat Lite – 1.0.8 to THEME: Topcat Lite – 1.0.9

Topcat Lite - 1.0.9

Topcat Lite is a responsive, clean and beautiful business and blog style theme featuring custom menu and custom background, custom header and easy to read typography that scales to fit all screens.

Theme URL - http://nytogroup.com/products/wordpress-themes/topcat-lite/
Author URL - http://dejanmarkovic.com/

SVN - https://themes.svn.wordpress.org/topcat-lite/1.0.9
ZIP - https://wordpress.org/themes/download/topcat-lite.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=topcat-lite/1.0.8&new_path=topcat-lite/1.0.9

History:

Ticket Summary Status Resolution Owner
#25864 THEME: Topcat Lite – 1.0.10 closed live rabmalin

(this ticket)

#26890 THEME: Topcat Lite – 1.0.13 closed live jcastaneda
#27210 THEME: Topcat Lite – 1.0.14 closed live jcastaneda
#27673 THEME: Topcat Lite – 1.0.15 closed live emiluzelac
#27981 THEME: Topcat Lite – 1.0.16 closed live karmatosed
#30560 THEME: Topcat Lite – 1.0.17 closed live jcastaneda
#30847 THEME: Topcat Lite – 1.0.18 closed live Otto42


https://themes.svn.wordpress.org/topcat-lite/1.0.9/screenshot.png

#16 @dejanmarkovic
2 years ago

deleted the 4th parameter on _n_noop
Thank you.

#17 @rabmalin
2 years ago

  • Status changed from reviewing to approved

Marking as approved. Good luck. Please be patient. After approval of theme, admin will once again review your theme. Only after admin approval your theme will be live. To know about when your theme will be live, please check queue Report 24 in https://themes.trac.wordpress.org/report

Important: Do not comment in this ticket. If you comment in this ticket, your theme will go to bottom in the queue.

#18 @karmatosed
2 years ago

  • Status changed from approved to reopened

All minified files should have an un-minified file included. Please correct this.

#19 @themetracbot
2 years ago

  • Summary changed from THEME: Topcat Lite – 1.0.9 to THEME: Topcat Lite – 1.0.10

Topcat Lite - 1.0.10

Topcat Lite is a responsive, clean and beautiful business and blog style theme featuring custom menu and custom background, custom header and easy to read typography that scales to fit all screens.

Theme URL - http://nytogroup.com/products/wordpress-themes/topcat-lite/
Author URL - http://dejanmarkovic.com/

SVN - https://themes.svn.wordpress.org/topcat-lite/1.0.10
ZIP - https://wordpress.org/themes/download/topcat-lite.1.0.10.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=topcat-lite/1.0.9&new_path=topcat-lite/1.0.10

History:

Ticket Summary Status Resolution Owner
#25864 THEME: Topcat Lite – 1.0.10 closed live rabmalin

(this ticket)

#26890 THEME: Topcat Lite – 1.0.13 closed live jcastaneda
#27210 THEME: Topcat Lite – 1.0.14 closed live jcastaneda
#27673 THEME: Topcat Lite – 1.0.15 closed live emiluzelac
#27981 THEME: Topcat Lite – 1.0.16 closed live karmatosed
#30560 THEME: Topcat Lite – 1.0.17 closed live jcastaneda
#30847 THEME: Topcat Lite – 1.0.18 closed live Otto42


https://themes.svn.wordpress.org/topcat-lite/1.0.10/screenshot.png

#20 @dejanmarkovic
2 years ago

Hi Tammie @karmatosed,
Thank you so much for the feedback.
I have updated the project files per your request.

Thanks.

Last edited 2 years ago by dejanmarkovic (previous) (diff)

#21 @rabmalin
2 years ago

  • Status changed from reopened to approved

Unminified scripts are added.

#22 @dejanmarkovic
2 years ago

Thank you Nilambar!

#23 @djrmom
2 years ago

  • Resolution set to live
  • Status changed from approved to closed

Congrats, this theme is now live.

On update, please remove the backwards compatible code for wp_title, this is no longer allowed now that title-tag support was added 2 versions ago.

Thanks,
Jenny

#24 @dejanmarkovic
2 years ago

OK, thank you so much Jenny!

Note: See TracTickets for help on using tickets.