WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 22 months ago

#25969 closed theme (not-approved)

THEME: Nanu One Page – 1.4

Reported by: ckthemes Owned by: saurav.rox
Priority: previously reviewed Keywords: theme-nanu-one-page
Cc: weblogixindia@…

Description

Attachments (2)

rt_myriad_wp-1.0.zip (2.8 MB) - added by jarrod99 2 years ago.
rt_myriad_wp-1.0-plugins.zip (4.9 MB) - added by jarrod99 2 years ago.

Change History (21)

#1 @themetracbot
2 years ago

  • Owner set to jarrod99
  • Status changed from new to reviewing

#2 @karmatosed
2 years ago

Please do not upload if you are a reviewer.

#3 @karmatosed
2 years ago

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the urgent review queue. This may mean it still takes time, but should be of more priority. Thanks for your patience.

#4 @Otto42
2 years ago

  • Owner jarrod99 deleted

#5 @tajim
2 years ago

I will continue this review.

#6 @themetracbot
2 years ago

  • Owner set to dhurbag

#7 @dhurbag
2 years ago

Required:
( ! ) Fatal error: Call to undefined function rwmb_meta() in C:\wamp\www\wordpress\wp-content\themes\nanu-one-page\header.php on line 29

While activating theme I got this issue. Please fix it.

#8 @themetracbot
2 years ago

  • Summary changed from THEME: Nanu One Page – 1.3 to THEME: Nanu One Page – 1.4

#9 @saurav.rox
23 months ago

I'll continue with the review. Please assign this ticket to me.
Thanks!

#10 @Otto42
23 months ago

  • Owner changed from dhurbag to saurav.rox

#11 @WEN Solutions
23 months ago

This is not the actual review. Unable to download the zip file of the theme, resulting to 404 file not found. Please re-upload the theme again. Thanks!

Last edited 23 months ago by WEN Solutions (previous) (diff)

#12 @Otto42
23 months ago

This theme failed to properly upload. Do not close the ticket. Instead, email me the ZIP file of the theme directly for investigation.

My email address is otto at wordpress.org.

#13 @ckthemes
23 months ago

We have mail you nanu-one-page theme hopefully you will review it as soon as possible and informe us about review thanks

#14 @Otto42
23 months ago

I have received the ZIP file and will investigate the problem as soon as I can.

#15 @Otto42
23 months ago

I apologize for the delay. The theme has been properly uploaded to the SVN systems.

@saurav.rox please continue with the review.

#16 @saurav.rox
23 months ago

Hello @ckthemes,
I am reviewing your theme. Please fix the below issue and resubmit your theme again.

[REQUIRED]

Theme Check

Theme check generated lot of errors mainly concerned with the improper use of Translation funciton as well as missing text-domain scenario. Please verify all the files taking the highlights listed below:

  • Possible variable $theme_text_domain found in translation function in class-tgm-plugin-activation.php. Translation function calls must NOT contain PHP variables.

Line 1001: 'plugin_activated' => ( 'Plugin activated successfully.', $theme_text_domain ),

  • Found a translation function that is missing a text-domain. Function , with the arguments 'Something went wrong with the plugin API.' line 989 of 'class-tgm-plugin-activation.php'.
  • More than one text-domain is being used in this theme. This means the theme will not be compatible with WordPress.org language packs. The domains found are elegant, ppt, rwmb

You can use this plugin to verify the above issues: https://wordpress.org/plugins/theme-check/

Recommended Plugin

  • Recommended plugin 'Nanu core' not found in WordPress plugin directory. Please verify.

changelog.txt

  • Changelog file is missing. Maintain changelog properly. You can include changelog on readme.txt file.

https://github.com/Otto42/theme-check/blob/master/readme.txt

style.css

  • Author URI: No valid url on it. Please correct it.
  • Text Domain: Text domain is invalid. Text Domain should be in small letters with dash as separators & must match with Theme name. Your text domain should be nanu-one-page.Please correct your theme text domain.

https://make.wordpress.org/themes/handbook/review/required/#language

style/scripts

https://make.wordpress.org/themes/handbook/review/required/#stylesheets-and-scripts

files and folders

  • Please name your files properly. File name should be in small letters with hyphen(-) as text separator.
  • Please remove plugin files from theme. Instead plugins should be recommended by the theme.
  • Please remove 'mail.out' file. If not required.

code

  • Please remove 'echo' while using the_permalink(). It is not required. Check your line line 13 of contentSingle.php, line 11 of contentSearch.php. CHeck other files as well.
  • Please remove protocol such as 'http://' while enqueuing google fonts. Check line 113, 114 of functions.php. https://gist.github.com/jennimckinnon/a65d307e9a3fcf8faa5e#file-functions-php
  • Please prefix theme functions, classes, global variables, image size name, script and style handles, etc with theme slug. Some Functions name missing prefix. Check on functions.php.

http://themereview.co/prefix-all-the-things/

  • Please remove commented/unwanted codes from the theme. Check your functions.php, line 187, line 67. Please check other files as well.


Validation and Sanitization

readme.txt

Language

Reference Link: https://codex.wordpress.org/I18n_for_WordPress_Developers

License

https://make.wordpress.org/themes/handbook/review/required/#licensing
https://make.wordpress.org/themes/handbook/review/resources/#licenses-bundled-resources

Screenshot

RECOMMENDED

  • Recommended to check functions with if ( function_exists( 'your_function' ) ) condition in order make them pluggable thus can be overridden from child theme and maintain backward compatibility. http://www.wpbeginner.com/wp-themes/best-practice-check-if-function-exists-when-adding-in-wordpress-theme/
  • Code indentation is necessary for making readable format.
  • Please check the html files inside /img/perfect-scrollbar-0.4.11. Remove them if not required in the theme.It only increases the theme size. If they are essential to the theme, then please ignore this issue.


NOTE

Best regards,
saurav.rox :)

Last edited 23 months ago by saurav.rox (previous) (diff)

#17 @Otto42
23 months ago

Correction, this is not my theme. Reviews should be directed to @ckthemes.

#18 @jrf
23 months ago

Also: please upgrade the included version of the TGM plugin activation class to the latest version (2.5.2). You are currently using version v2.3.6 which is *extremely* old, out-of-date and has a - albeit minor - security issue.
http://tgmpluginactivation.com/download/

#19 @saurav.rox
22 months ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

No response from the theme-author for 7 days after the latest review. So marking this ticket as not-approved.
Thanks!

Note: See TracTickets for help on using tickets.