WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 12 months ago

Last modified 12 months ago

#26159 closed theme (live)

THEME: Company – 1.0.24

Reported by: Huge-IT Owned by: swetashrestha
Priority: new theme Keywords: theme-company
Cc: hugeitpayplug@…, djrmom

Description

Company - 1.0

Very good solution for your company website.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/company/1.0
ZIP - https://wordpress.org/themes/download/company.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0/screenshot.png

Attachments (2)

Screenshot from 2016-09-28 16-24-25.jpg (396.7 KB) - added by swetashrestha 14 months ago.
screenshot_company.png (145.0 KB) - added by swetashrestha 13 months ago.

Download all attachments as: .zip

Change History (161)

#1 @Huge-IT
2 years ago

Dear Team, any news with the review?

#2 @themetracbot
2 years ago

  • Owner set to rkleinert
  • Status changed from new to reviewing

#3 @Huge-IT
2 years ago

Dear @rkleinert any news ?

Last edited 2 years ago by Huge-IT (previous) (diff)

#4 @Huge-IT
2 years ago

Dear WordPress team please pay attention to this ticket as it already hasen't reviewed for 2 months

#5 @karmatosed
2 years ago

This ticket has been added to the queue to get a more urgent review, please be patient as we are trying to do our best. I'm sorry it has taken so long.

#6 @Huge-IT
2 years ago

Dear @karmatosed thanks for attention. Yes we are patient but please not that already 3rd month passed.

#7 @Huge-IT
2 years ago

Somebody please review the theme

This ticket was mentioned in Slack in #themereview by huge-it. View the logs.


2 years ago

#9 @Otto42
2 years ago

  • Owner rkleinert deleted

@rkleinert If you're not going to perform a review of the theme, do not accept it in the first place.

This ticket was mentioned in Slack in #themereview by utsavsinghrathour. View the logs.


2 years ago

#11 @jcastaneda
2 years ago

  • Owner set to utsavsinghrathour

#12 @utsavsinghrathour
2 years ago

Hi @Huge-IT

Sorry that it tok so long to get reviewed. It can happen at times, since this is a voluntary process. However I shall now review the theme. Please find below issues that I discovered, that needs to be fixed before getting approved.

Required:
Please add a text-domain for the theme on style.css

  • You have used "huge_it_company" as text-domain and texts, but your text-domain needs to be "company"
  • Functions need to start with your text-domain which needs to be "company" again and not "huge_it_company"
  • You can use only one text-domain. For example you have used "label" on searchform.php
  • Screenshot should maintain 4:3 ratio and must not be less than 880 by 660 and not more than 1200 by 900
  • You have added ajax.php but the file is blank. Please remove that if it is not being used.
  • Please mention the license of the scripts and images attached as well.

#13 @utsavsinghrathour
2 years ago

Also the theme on activation gives me this fatal error

Fatal error: Can't use function return value in write context in /home/www/public_html/themecheck/wp-content/themes/company/extras/front_end_options.php on line 16

#14 @themetracbot
2 years ago

  • Summary changed from THEME: Company – 1.0 to THEME: Company – 1.0.1

Company - 1.0.1

Very good solution for your company website.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/company/1.0.1
ZIP - https://wordpress.org/themes/download/company.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0&new_path=company/1.0.1

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.1/screenshot.png

#15 @Otto42
2 years ago

Not a review, just a note: The WordPress logo and name in the header of the screenshot should be removed. Using the name of the theme there is preferable.

#16 @themetracbot
2 years ago

  • Summary changed from THEME: Company – 1.0.1 to THEME: Company – 1.0.2

Company - 1.0.2

Very good solution for your company website.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/company/1.0.2
ZIP - https://wordpress.org/themes/download/company.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.1&new_path=company/1.0.2

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.2/screenshot.png

#17 @Huge-IT
2 years ago

Dear @Otto42 and @utsavsinghrathour thank you for your replies. We have fixed the issues that you have mentioned, please check it again.

#18 @utsavsinghrathour
2 years ago

The theme upon activation, still gives me this error:
Fatal error: Can't use function return value in write context in /home/www/public_html/themecheck/wp-content/themes/company/extras/front_end_options.php on line 16

Please fix this, before I continue..

#19 @themetracbot
2 years ago

  • Summary changed from THEME: Company – 1.0.2 to THEME: Company – 1.0.3

Company - 1.0.3

Very good solution for your company website.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/company/1.0.3
ZIP - https://wordpress.org/themes/download/company.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.2&new_path=company/1.0.3

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.3/screenshot.png

#20 @utsavsinghrathour
2 years ago

The theme still gives me error on activation:
"Notice: Undefined variable: filename in /home/www/public_html/themecheck/wp-content/themes/company/extras/default_content.php on line 265

Warning: strpos() expects parameter 1 to be string, object given in /home/www/public_html/themecheck/wp-content/themes/company/extras/default_content.php on line 307

Catchable fatal error: Object of class WP_Error could not be converted to string in /home/www/public_html/themecheck/wp-content/themes/company/extras/default_content.php on line 310"

Please fix these as I cannot further check with this issue.

#21 @Huge-IT
2 years ago

Dear @utsavsinghrathour, we are currently fixing the issues you have mentioned. But we are unable to see those errors as with our version of PHP the theme gives no error. Could you please tell us what PHP and WordPress version are you using.

#22 @utsavsinghrathour
2 years ago

My Apache version is 2.4.6
and PHP version is 5.4.16

#23 @themetracbot
2 years ago

  • Summary changed from THEME: Company – 1.0.3 to THEME: Company – 1.0.4

Company - 1.0.4

Very good solution for your company website.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/company/1.0.4
ZIP - https://wordpress.org/themes/download/company.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.3&new_path=company/1.0.4

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.4/screenshot.png

#24 @Huge-IT
2 years ago

Dear @utsavsinghrathour please check.

#25 @themetracbot
2 years ago

  • Summary changed from THEME: Company – 1.0.4 to THEME: Company – 1.0.5

Company - 1.0.5

Very good solution for your company website.

Theme URL -
Author URL -

SVN - https://themes.svn.wordpress.org/company/1.0.5
ZIP - https://wordpress.org/themes/download/company.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.4&new_path=company/1.0.5

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.5/screenshot.png

#26 @Huge-IT
2 years ago

Dear friends we have found some more bugs and have fixed so please ignore the previews version and review this one.

#27 @utsavsinghrathour
2 years ago

  • The theme shows blank page when Front page is set as Latest post from customizer.
  • Theme Should not have theme options and should manage everything from customizer.

#28 @Huge-IT
2 years ago

Is there in codex mentioned that we shouldn't use Theme Options.
And In this case how does one of the most popular theme in WordPress (Vantage) has Theme Settings page?

#29 @utsavsinghrathour
23 months ago

As per the recent discussion, we are not supposed to use theme options and the old theme's have theme options but they have a deadline, until which they need to remove those and add customizer only.

https://make.wordpress.org/themes/handbook/review/required/#options-and-settings

Use the Customizer for implementing theme options.

#30 @Huge-IT
23 months ago

Ok, understand. But is it possible to send you the update in 2-3 weeks? As is's big modification and now our team on Christmas vocation.

#31 @utsavsinghrathour
23 months ago

Sure. I will keep this ticket open for 3 weeks from now then.

Happy Holidays! :)

#32 @Huge-IT
22 months ago

Dear @utsavsinghrathour, we found some more bugs on out theme so have to ask you to prolong the waiting time for one more week.
Thanks.

#33 @utsavsinghrathour
22 months ago

No Problem, but please understand that I cannot have a ticket long open.

Regards

#34 @themetracbot
22 months ago

  • Summary changed from THEME: Company – 1.0.5 to THEME: Company – 1.0.6

Company - 1.0.6

Very good solution for your company website.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.6
ZIP - https://wordpress.org/themes/download/company.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.5&new_path=company/1.0.6

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.6/screenshot.png

#35 @Huge-IT
22 months ago

Finally, no general options, all in customizer, hope we did it correctly, please check again, and thanks for understanding.

#36 @Huge-IT
22 months ago

Dear @utsavsinghrathour any news ?

#37 @utsavsinghrathour
22 months ago

Will review today.

#38 @Huge-IT
21 months ago

Dear @utsavsinghrathour it took too long please check it as soon as possible.
We want to start the development of next theme but need to be sure that the first one on which will rely the second is absolutely correct one.

#39 @utsavsinghrathour
21 months ago

Sorry been very very busy. Will review and get back to you tomorrow.
Sorry for the delay

#40 @utsavsinghrathour
21 months ago

I still get this error when activatingand cant process further. Please fix this first and I can go ahead and check others.
Fatal error: Can't use function return value in write context in /home/www/public_html/themecheck/wp-content/themes/company/extras/front_end_blocks.php on line 1093

#41 @themetracbot
21 months ago

  • Summary changed from THEME: Company – 1.0.6 to THEME: Company – 1.0.7

Company - 1.0.7

Very good solution for your company website.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.7
ZIP - https://wordpress.org/themes/download/company.1.0.7.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.6&new_path=company/1.0.7

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.7/screenshot.png

#42 @Huge-IT
21 months ago

Dear @utsavsinghrathour we are very sorry for previous version. Please check it again.
Thank you

#43 @karmatosed
21 months ago

  • Owner utsavsinghrathour deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview.

#44 @grapplerulrich
21 months ago

  • Owner set to psdtohtmlguru

#45 @grapplerulrich
21 months ago

  • Owner psdtohtmlguru deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview.

#46 @themetracbot
21 months ago

  • Owner set to testeim

#47 @Huge-IT
20 months ago

Dear @grapplerulrich it seems @themetracbot is new created account and no reply for week. Could you please change the reviewer.
And sorry but we are new in theme development we are unable to review a theme.

#48 @Otto42
20 months ago

  • Owner testeim deleted

#49 @themetracbot
20 months ago

  • Owner set to ptasker

#50 @ptasker
20 months ago

Hi there, I'm going to take a look and get back to you hopefully this week.

#51 @ptasker
20 months ago

Ok I took a quick look, after initial activation, front end throws a PHP warning:

Warning: Invalid argument supplied for foreach() in /var/www/wpbase.dev/wp-content/themes/company/functions.php on line 127

https://i.gyazo.com/f55183c5f8694cc0873ca1f9968ad0c9.png

The code in question is:

<?php
$fonts = get_theme_mod("company_google_fonts_list");

        foreach($fonts as $font){
...
        }

It looks like $fonts may not come back as an array, which you are then iterating over. I would check that the $fonts array is populated before looping over it.

Please fix this error and I will continue the review.

Peter

#52 @themetracbot
20 months ago

  • Summary changed from THEME: Company – 1.0.7 to THEME: Company – 1.0.8

Company - 1.0.8

Very good solution for your company website.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.8
ZIP - https://wordpress.org/themes/download/company.1.0.8.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.7&new_path=company/1.0.8

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.8/screenshot.png

#53 @Huge-IT
20 months ago

Dear @ptasker we could not exactly find out why that theme_mod did not take a array value but we have added some code to avoid that kind of errors, please check the new version.
Thank you

#54 @ptasker
20 months ago

Hi there,

I have completed my review. Below are my findings.

Required

<?php
$email_from=$_POST['email'];
$name_from=$_POST['name'];
//Instead use
$email_from = sanitize_text_field($_POST['email']);
$name_from = sanitize_text_field($_POST['name']);
  • Harcoded scripts are not allowed, use wp_enqueue_scripts hook (header.php):

<!--[if lt IE 9]> <script src="<?php echo esc_url( get_template_directory_uri() ); ?>/js/html5.js"></script> <![endif]-->

  • Please do not inline styles and scripts. All styles and scripts must be enqueued (front_end_options.php, editor.php, front_end_blocks.php).
  • companyparseFromXML() function needs to be correctly pre-fixed (http://themereview.co/prefix-all-the-things/)
  • Plugins - Change header text to 'Install recommended plugins' not 'Install Required plugins'
  • In extras/default_content.php - please do not require wp-admin files:
<?php
require_once(ABSPATH.'/wp-admin/includes/media.php');
require_once(ABSPATH.'/wp-admin/includes/file.php');
require_once(ABSPATH.'/wp-admin/includes/image.php');

Recommendations

In header.php, the incorrect @package name is used:

@package WordPress @subpackage Twenty_Thirteen @since Twenty Thirteen 1.0

  • Fix some layout issues by using the Theme Unit test data (https://gyazo.com/e5bf76701690cee78349bf0e70b94cd8)
  • Use the database API (WP_Query) when possible, and avoid querying the WordPress DB directly if there are wrapper methods available (default_content.php)
    <?php
    function _get_image_id_by_url($image_url){
            global $wpdb;
            $attachment = $wpdb->get_col($wpdb->prepare("SELECT ID FROM $wpdb->posts WHERE guid='%s';", $image_url ));
        return $attachment[0];
    }
    
    
  • Remove unused, commented out code
  • Include reference to add_editor_style() so the editor styling matched matches output.
Last edited 20 months ago by ptasker (previous) (diff)

This ticket was mentioned in Slack in #themereview by petetasker. View the logs.


20 months ago

#56 @ptasker
20 months ago

Required

  • All scripts need to be prefixed as well
  • Site Icon function must be used
  • Be sure that all copyrights and licenses are included in style.css

#57 @emiluzelac
20 months ago

In addition to that, here's a quick visual scan as requested by @ptasker on Slack:

  • Going over the functions.php, there's more that needs to be prefixed.
  • Theme needs to properly load files.

There are several functions available for getting the path:

  • get_template_directory(); Returns the absolute template directory path.
  • get_template_directory_uri(); Returns the template directory URI.
  • get_stylesheet_directory(); Returns the absolute stylesheet directory path.
  • get_stylesheet_directory_uri(); Returns the stylesheet directory URI.

http://justintadlock.com/archives/2010/11/17/how-to-load-files-within-wordpress-themes

  • Theme still reads Twenty Thirteen, please rename and credit in readme or wherever you prefer.

Good luck!

#58 @jrf
20 months ago

Quick heads-up: If you download a fresh copy of TGMPA using the Custom TGMPA Generator, it will serve you with a customized download of TGMPA which will pass the Theme Check rules.
Also - be aware of some minor changes to the TGMPA configuration options. See the changelog for more information or the Configuration page for more detail on the current options.

#59 @emiluzelac
20 months ago

Thanks @jrf!

#60 @themetracbot
20 months ago

  • Summary changed from THEME: Company – 1.0.8 to THEME: Company – 1.0.9

Company - 1.0.9

Very good solution for your company website.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.9
ZIP - https://wordpress.org/themes/download/company.1.0.9.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.8&new_path=company/1.0.9

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.9/screenshot.png

#61 @Huge-IT
20 months ago

Dear @ptasker @emiluzelac @jrf thank you for fast reply, we have fixed the issues you have mentioned above, but in theme review handbook we could not find any information about that writing inline css in wp_head hook is not allowed(front_end_options.php) ( https://make.wordpress.org/themes/handbook/review/required/explanations-and-examples/#stylesheets-and-scripts , https://codex.wordpress.org/Plugin_API/Action_Reference/wp_head#Examples ).
Thank You.

#62 @ptasker
20 months ago

Hi there, the rule about not inlining scripts and styles is in the handbook here:

https://make.wordpress.org/themes/handbook/review/required/#stylesheets-and-scripts

"No hard coding of scripts and styles unless a browser workaround script. Everything should be enqueued."

In hindsight, my comment about not inlining a browser workaround script is actually allowed, so that is my mistake. Otherwise, all other scripts and styles need to be enqueued.

#63 @Huge-IT
20 months ago

So @ptasker if i understand you right we can keep front_end_options.php like that?(but we will search for better way of implementing dynamic css in front end).
Yeah and we forgot to mention that while making changes in our theme we found out that using get_theme_mods() function returns wrong values if you are in customizer preview mod while get_theme_mod() returns correct values( looks like the problem is in filters which is being used in customizer ).
we made a small workaround for that problem in default_content.php

<?php
function company_get_theme_mods(){
	$mods = get_theme_mods();
	$defaults = company_get_option_defaults();
	/* get_theme_mods() returns wrong value if in customizer so we loop through theme mods and asign correct values 
	 * @see https://core.trac.wordpress.org/ticket/24844
	 */
	$theme_mods = array();
	foreach($defaults as $name=>$val){
		if ( isset( $mods[$name] ) )
			$theme_mods[$name] = apply_filters( "theme_mod_{$name}", $mods[$name] );
		else
			$theme_mods[$name] = apply_filters( "theme_mod_{$name}", $val );
		
		
	}
	
	return wp_parse_args(
        $theme_mods,
        company_get_option_defaults() 
    );
}

I hope we made it correctly.
Thank You

Last edited 20 months ago by Huge-IT (previous) (diff)

#64 @ptasker
20 months ago

Hi there,

There's a couple options for how to setup styles and scripts. wp_add_inline_style is one (for CSS).

Really great example:

https://themes.trac.wordpress.org/browser/patus/1.0.6/functions.php#L118

For scripts, you could use wp_localize_script, which allows you to pass PHP variables to a script:
https://codex.wordpress.org/Function_Reference/wp_localize_script

Further, if you were to clean up the CSS/JS a bit it would be passable to use a wp_head filter as has been done is previous themes:

https://themes.svn.wordpress.org/latte/0.3/inc/customizer/custom-css.php

In general I would just clean it up a bunch, reduce the repetitiveness of the styles, and use the wp_add_inline_style function.

Last edited 20 months ago by ptasker (previous) (diff)

#65 @Huge-IT
20 months ago

Dear @ptasker we understand that this is not the most optimized way but at list it's not wrong so cant we go forward with it fix other problems if they exist post the plugin finally after 9 months and then with development of second theme we will optimized and update this problem too.

#66 @ptasker
20 months ago

I would move ahead with the other fixes yes, we'll leave the styling updates as 'recommended' updates.

Also, I'm not in charge of whether the theme is finally approved, that lies with an admin. But yes, I would keep moving with the other fixes mentioned.

#67 @Huge-IT
20 months ago

Thank you,once being approved we will start development of second theme and definitely will fix and update it.

#68 @ptasker
20 months ago

Hi there, I would treat this review as the primary review for now. It takes a while to get themes through the review process. You should come back to the styling updates once the other fixes you are working on are in place.

From a theme review admin @emiluzelac:

All scripts and styles (including comment reply) should be added from functions file and hooked with wp_enqueue_*, don't hardcode them or include them directly, like in header.php or footer.php

Further example:
https://github.com/Automattic/_s/blob/master/functions.php#L113-L127

#69 @Huge-IT
20 months ago

Hi @ptasker, sorry but your last message was not clear for me. So you continue checking our theme now or we should fix the styles problem to move forward ?

#70 @ptasker
20 months ago

Hi there, if you have the other updates in place I can review them, as many of them were more pressing.

The main issue with front_end_options.php is that it is hard to read/understand what's going on. Keep in mind this theme will be used by many different users, so the code should be easy to understand and update for an end user. If it were cleaned up a bit it would be easier/quicker to review.

Please keep in mind that the PHP Coding Standards should still apply:

https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/

#71 @Huge-IT
20 months ago

In the last version we have fixed all required problems and updated 6 days ago. If there is any other required problems we will fix them ASAP but please lets move forward with this code style, we will make our code much more readable step by step in future updates.

#72 @ptasker
20 months ago

Hi there, I checked out the latest version from SVN and I'm getting PHP notices. They are being output in JS so it's resulting in a JS error as well:

Notice: Undefined index: company_header_bg_position in /var/www/wpbase.dev/wp-content/themes/company/extras/front_end_options.php on line <i>168</i>

https://i.gyazo.com/b92f2ba2e4ae9a43792c29891354f7c9.png

Could you please fix.

Thanks

#73 @themetracbot
20 months ago

  • Summary changed from THEME: Company – 1.0.9 to THEME: Company – 1.0.10

Company - 1.0.10

Very good solution for your company website.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.10
ZIP - https://wordpress.org/themes/download/company.1.0.10.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.9&new_path=company/1.0.10

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.10/screenshot.png

#74 @Huge-IT
20 months ago

Dear @ptasker sorry for late reply. I have fixed issues you have maintoned above. Please check.
Thank You

#75 @ptasker
20 months ago

Hi there,

Something I noticed on this round through is that the front page doesn't display any posts. And isn't following this rule:

Display the correct content according to the front page setting.

When I set the WordPress setting in Reading Settings to show 'Latest Posts' no posts are displayed.

Theme incorporates a custom template for the blog posts index, it must be implemented as the home.php template file, and not as a template-blog.php custom page template

https://make.wordpress.org/themes/2014/06/28/correct-handling-of-static-front-page-and-custom-blog-posts-index-template/

Still some strings that need to be translatable:

Ex:
<div class="load_more_button button-primary">Load More</div>

and

<?php
        if(!empty($footer_attribution)){
                                echo $footer_attribution;
                        }else{
                                echo 'Copyright &#169; 2016 Designed by <a href="http://huge-it.com">Huge-IT</a>  | Powered by <a href="http://wordpress.org/">WordPress</a>';
                        }

In functions.php:

Still some functions that need prefixing. Please check the entire theme for functions that need prefixing.

<?php
function thumbnail_placeholder($width="",$height=""){
        $result="<img class='thumbnail_placeholder' src='".esc_url( get_template_directory_uri()."/images/thumb_ph.png")."' ";
        $result=$result."alt='No image available' />";
        return $result;
}

template-blog.php throw's PHP errors:

https://i.gyazo.com/319bc4a08e84f31d0ca9f190126d171b.png

In the /js folder, why is there a file called not_used.js?

  • js/ResponsiveSlides.js is minified, please include the non-minified version

readme.txt

  • More documentation on the theme options and settings needs to be added the readme.txt. See the twentysixteen readme.txt
Last edited 20 months ago by ptasker (previous) (diff)

#76 @themetracbot
19 months ago

  • Summary changed from THEME: Company – 1.0.10 to THEME: Company – 1.0.11

Company - 1.0.11

Very good solution for your company website.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.11
ZIP - https://wordpress.org/themes/download/company.1.0.11.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.10&new_path=company/1.0.11

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.11/screenshot.png

#77 @ptasker
19 months ago

Hi there, I will take a look at this latest revision next week.

#78 @ptasker
19 months ago

Hi there, I am still taking a look at the theme, but it seems like many of the earlier issues are not fixed. For example, there are many strings that are not wrapped in the () or _e() functions and template-blog.php also still throws a PHP error.

#79 @themetracbot
19 months ago

  • Summary changed from THEME: Company – 1.0.11 to THEME: Company – 1.0.12

Company - 1.0.12

Very good solution for your company website.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.12
ZIP - https://wordpress.org/themes/download/company.1.0.12.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.11&new_path=company/1.0.12

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.12/screenshot.png

#80 @ptasker
19 months ago

Hi there,

I'm just finalizing some notes and will post them either tomorrow or Wednesday.

#81 follow-up: @ptasker
19 months ago

General


  • Theme description in style.css should match the theme functionality. The theme has many options and features in the customizer, these should be generally called out in the description and readme file
  • patch.diff should be removed, no need for users to have this file

functions.php

  • empty function company_header_style should be removed
  • referencing js/pro.js - file does not exist, causes Javascript error
  • attempting to load template file pro_front_end_blocks - template does not exist
  • Also note that I see that pro.js seems to be needed in the customizer, and it looks to be hiding some customizer features behind a pay wall. Note that 'No pay wall restricting any WordPress feature.' https://make.wordpress.org/themes/handbook/review/required/#core-functionality-and-features. Right now I don't think any requirements are being broken, but it's best to not restrict functionality behind a paywall. The general consensus amongst theme reviewers is that only 1 'upgrade to pro' link should be allowed. This is still in flux, but keep it in mind going forward as it looks like this was a recent change to the theme. This may come up during admin review.

https://make.wordpress.org/themes/handbook/review/required/#stylesheets-and-scripts


extras/front_end_blocks.php

Line 13 front_end_blocks.php

  • text string not wrapped in translation function

Lines 311-316

  • Remove commented out code

extras/front_end_options.php

if(response.success){
          ...
        }else{
          alert("no");
        }

Consider removing this alert, as it serves no purpose


extras/front_end_blocks.php

  • Line 281 What is the purpose of only allow the post author to edit the post? Edit post link already handles the permissions check and will not display if a user does not have edit_post permissions.
    <?php
    
      global $post,$current_user;
      get_currentuserinfo();
      if ($post->post_author == $current_user->ID){
        ?>
        <span class="edit">
          <?php edit_post_link('Edit');?>
        </span>
        <?php
      }
    
  • line 1079 text not wrapped in translation function.
<?php
  echo '<p>No content found</p>';
  • empty function company_footer_form should be removed

templates/template-blog.php

  • If I use this template for a page, itstill throw's PHP errors:

Notice: front_end_blocks.php

https://i.gyazo.com/80f12ce85e2cdc46b447a6baa19bd78d.png

And

Notice: Undefined index: front_end_blocks.php on line 37


/extras/editor.php

  • Not escaping $_REQUEST['ID'] and $_REQUEST['blog_category']. Passing an unescaped value is bad practice and could produce PHP errors/corrupt values in the database. These need to be sanitized.
  • Meta box label text still needs to be wrapped in translation functions.
  • Empty style tag line 108

extras/default_content.php

  • Text not wrapped in translation function through out entire file

extras/ajax_callback.php

  • unescaped $_POST variables throughout the file need to be sanitized before being passed to WP_Query

style/hugefont_style.css

  • Close comment */ at end of file
  • Is there a need for the commented out styles? Those should be removed if not used.

extras/customizer/customizer-custom-controls.php

  • Multiple instances of empty render_content() functions. Since they are not being used, they should be removed.
  • Line 727, hotlinking external resources are not allowed. All styles and scripts need to be bundled.

extras/customizer/customizer.php

  • The Top Posts Customizer sections 'company_top_posts_...' are in plugin territory, storing non-trivial, non-design related info in the database. Customizer options can't be used as post types or post meta. Please revise. Maybe use a post selector instead?

See: https://make.wordpress.org/themes/handbook/review/required/#presentation-vs-functionality

https://i.gyazo.com/f4d3c6884b1b09deee846733693bf78c.png

  • There are a few empty functions and style blocks in this file. Consider removing.

js/customize.js


js/javascript.js

  • Remove commented out code as it's not needed. Makes code cleaner and easier to read.
  • Empty function, if not required, please remove.
      jQuery(window).scroll(function() {
      });
    
    

#82 follow-up: @Huge-IT
19 months ago

Dear @ptasker we are sorry for making a lot of mistakes and making this review so hard for you, we are currently working on issues you have mentioned above, but I have few questions about some features.

  1. The 'pay wall'. I agree that the theme must not restrict any of WordPress features. But the theme Company has not done anything that leads to restricting them, we have added some design related features (like colors and Google fonts) and made them available only for 'pro' users. We have not blocked any of WordPress core features, we have just added our own additional features which we have considered for ‘pro’ users. I think this is not breaking any rules.
  1. The Top Posts. We havea section in homepage called 'Top Posts' (the name might have caused misunderstandings). It is not a post type or any functionality related thing.You either choose a category and 3 of the latest posts are being shown or you put 3 custom links as top posts. Isn't that allowed in WordPress themes?
  1. You have mentioned about empty render_content() instances in customizer-custom-controls.php, but in Theme Options api is said that we have to override that function with an empty function in our subclass

https://developer.wordpress.org/themes/advanced-topics/customizer-api/#jsunderscore-templating

  1. I could not find a patch.diff file in Company files.

Thank You.

Last edited 19 months ago by Huge-IT (previous) (diff)

#83 in reply to: ↑ 82 @ptasker
19 months ago

Replying to Huge-IT:

Dear @ptasker we are sorry for making a lot of mistakes and making this review so hard for you, we are currently working on issues you have mentioned above, but I have few questions about some features.

  1. The 'pay wall'. I agree that the theme must not restrict any of WordPress features. But the theme Company has not done anything that leads to restricting them, we have added some design related features (like colors and Google fonts) and made them available only for 'pro' users. We have not blocked any of WordPress core features, we have just added our own additional features which we have considered for ‘pro’ users. I think this is not breaking any rules.

While you are correct, it is not specifically breaking any rules, we theme reviewers recently had a meeting about this and generally decided that blocking customizer options behind a pay wall is a bad practice.

You can see the general consensus here:

https://make.wordpress.org/themes/2016/05/03/may-3rd-meeting-notes/ - "No options or panels/sections behind a paywall. +11"

While I won't say this is blocking my review, it will most definitely come up in the admin review.

  1. The Top Posts. We havea section in homepage called 'Top Posts' (the name might have caused misunderstandings). It is not a post type or any functionality related thing.You either choose a category and 3 of the latest posts are being shown or you put 3 custom links as top posts. Isn't that allowed in WordPress themes?

For this, I would say that since those options are not design related, i.e. fonts, colors, settings, that this section is in plugin territory. These are more like meta-boxes and not allowed in the customizer.

See:
https://make.wordpress.org/themes/handbook/review/required/explanations-and-examples/#plugin-territory

"Non-design related meta boxes"

  1. You have mentioned about empty render_content() instances in customizer-custom-controls.php, but in Theme Options api is said that we have to override that function with an empty function in our subclass

https://developer.wordpress.org/themes/advanced-topics/customizer-api/#jsunderscore-templating

If it serves a purpose, as you mention, I'm fine with it.

  1. I could not find a patch.diff file in Company files.

Ok. Must be a on my end only.

Thank You.

#84 @themetracbot
19 months ago

  • Summary changed from THEME: Company – 1.0.12 to THEME: Company – 1.0.13

Company - 1.0.13

Company theme is a minimalistic, modern theme, which suggests perfect layouts to build your brand-new website/blog. Company Theme owns slider on the homepage, custom background, own resizable content on homepage section, customizable colors and fonts, various navigation types, customizable footer, it is integrated with Google Map, Social Media share possibility, SEO optimized and responsive design.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.13
ZIP - https://wordpress.org/themes/download/company.1.0.13.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.12&new_path=company/1.0.13

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.13/screenshot.png

#85 @Huge-IT
18 months ago

Dear @ptasker please check this version. We have tried our best to fix our mistakes. But we have not deleted the top posts section as it plays great role in homepage design(maybe admins would help us solve this misunderstanding)

#86 in reply to: ↑ 81 @ptasker
18 months ago

  • /extras/font-awesome/css/font-awesome.min.css
  • extras/customizer/customizer-custom-controls.php

Need to bundle non-minified version of Font Awesome

extras/customizer/customizer.php

The Top Posts Customizer sections 'company_top_posts_...' are in plugin territory, storing non-trivial, non-design related > > info in the database. Customizer options can't be used as post types or post meta. Please revise. Maybe use a post >selector instead?

I checked with an admin and their suggestion is to use a post selector. Using the customizer as a sudo post editor is not allowed.

Further, restricting customizer options behind a paywall, as mentioned earlier, is not a great user experience and likely not going to make users happy. I would recommend revising this as well.

https://i.gyazo.com/fe67810eba2c3c7530b6aa2c720b6712.png

#87 @Huge-IT
18 months ago

Dear @ptasker , please do not close the ticket, within a week it will be fixed and updated.

#88 @themetracbot
18 months ago

  • Summary changed from THEME: Company – 1.0.13 to THEME: Company – 1.0.14

Company - 1.0.14

Company theme is a minimalistic, modern theme, which suggests perfect layouts to build your brand-new website/blog. Company Theme owns slider on the homepage, custom background, own resizable content on homepage section, customizable colors and fonts, various navigation types, customizable footer, it is integrated with Google Map, Social Media share possibility, SEO optimized and responsive design.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.14
ZIP - https://wordpress.org/themes/download/company.1.0.14.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.13&new_path=company/1.0.14

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.14/screenshot.png

#89 @jrf
18 months ago

FYI: in the mean time TGMPA v2.6.1 has been released. Upgrading is recommended.
You can download the new version via the Custom TGMPA Generator.

#90 @Huge-IT
18 months ago

Dear @ptasker we have optimized the cusmomizer more user friendly, please check it.
Dear @jrf thank you for a sugestion, will do it in next version.
Thank you.

#91 @ptasker
18 months ago

Thanks, I will take a look in the next day or 2.

#92 @ptasker
18 months ago

Hi there,

I see that you have made a bunch of changes to the customizer. Great.

I am getting a PHP error there now, however:

https://i.gyazo.com/6eaa5fac2e14a852fe727cb52d214696.png

You may want to adjust your local PHP error reporting settings and enable WP_DEBUG in your wp-config.php file during development.

#93 @Huge-IT
18 months ago

I am very sorry for that will fix and upload today.

#94 @themetracbot
18 months ago

  • Summary changed from THEME: Company – 1.0.14 to THEME: Company – 1.0.15

Company - 1.0.15

Company theme is a minimalistic, modern theme, which suggests perfect layouts to build your brand-new website/blog. Company Theme owns slider on the homepage, custom background, own resizable content on homepage section, customizable colors and fonts, various navigation types, customizable footer, it is integrated with Google Map, Social Media share possibility, SEO optimized and responsive design.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.15
ZIP - https://wordpress.org/themes/download/company.1.0.15.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.14&new_path=company/1.0.15

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.15/screenshot.png

#95 @jrf
18 months ago

Looks like TGMPA has not yet been updated to the latest version.

#96 @Huge-IT
17 months ago

Dear @ptasker, any news?

#97 @ptasker
17 months ago

Hi there, I'll take a look shortly. Did you see @jrf not above? TGMPA needs to be updated to the latest version.

#98 @Huge-IT
17 months ago

Hi dear @ptasker . Yes We are greatful for advice but it is not required to have all latest versions of libraries, I think it is better to concentrate on bugs/errors and then update libraries

#99 @ptasker
17 months ago

The following theme check errors are being reported:

WARNING: The tag white has been deprecated, please remove it from your style.css header.
WARNING: The tag responsive-layout has been deprecated, please remove it from your style.css header.
WARNING: The tag black has been deprecated, please remove it from your style.css header.

in js/javascript.js

function rand(min, max) {
    return Math.floor(Math.random() * (max - min + 1)) + min;
}

The function name needs to be namespaced or moved in to the jQuery(document).ready(function()... block so that it's not a global function.

In extras install_plugins.php

<?php
array(
                        'name'      => 'Portfolio Gallery',
                        'slug'      => 'portfolio-gallery',
                        'required'  => false,
                ),
                

The 'name' key needs to be wrapped in the translation function still

Ex.

<?php

array(
                        'name'      => __('Portfolio Gallery'),
                        'slug'      => 'portfolio-gallery',
                        'required'  => false,
                ),

#100 @themetracbot
17 months ago

  • Summary changed from THEME: Company – 1.0.15 to THEME: Company – 1.0.16

Company - 1.0.16

Company theme is a minimalistic, modern theme, which suggests perfect layouts to build your brand-new website/blog. Company Theme owns slider on the homepage, custom background, own resizable content on homepage section, customizable colors and fonts, various navigation types, customizable footer, it is integrated with Google Map, Social Media share possibility, SEO optimized and responsive design.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.16
ZIP - https://wordpress.org/themes/download/company.1.0.16.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.15&new_path=company/1.0.16

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.16/screenshot.png

#101 @Huge-IT
17 months ago

Dear @ptasker please check, dear @jrf the TGMPA's latest version fails theme-check.
Thank You.

#102 @jrf
17 months ago

the TGMPA's latest version fails theme-check.

@Huge-IT As I actually pointed out before: If you download a fresh copy of TGMPA using the Custom TGMPA Generator, it will serve you with a customized download of TGMPA which will pass the Theme Check rules (text-domain and such).

The Custom Generator was specifically created to make it easier to upgrade TGMPA while still complying with the Theme Check rules.

Let me know if you have question or are still running into issues.

#103 @Huge-IT
17 months ago

Dear @jrf we have used the custom generator, but TGMPA uses add_submenu_page() instead of add_theme_page(), that's why it fails theme-check

#104 @Otto42
17 months ago

If you use the generator and tell it that the theme is intended to be distributed via WordPress.org, then it will not have the add_submenu_page call in it.

#105 @jrf
17 months ago

Thanks @Otto42, your answer is spot on ;-)

#106 @Huge-IT
17 months ago

Ok thank you for help dear @Otto42 and @jrf

#107 @ptasker
17 months ago

I'll take a look in the next day or so.

#108 @Huge-IT
17 months ago

Cool beans, thanks mate!
We will wait for that

#109 @ptasker
17 months ago

  • Status changed from reviewing to approved

Looks good from my perspective. The next step is admin review. There will likely be some updates required during that phase.

Peter

#110 @jrf
17 months ago

The TGMPA library still hasn't been updated to v2.6.1 in the latest version of this theme..

#111 @Huge-IT
17 months ago

Thanks for your help @Otto42 , @ptasker , @jrf , @ptasker, we appreciate your help and surely will wait the notes on admin. We will gladly make further changes and fixes. Let us mention kindly that 2 weeks ago, we have mentioned the fact about library updates with the following line, but did not receive any feedback on that. It stated the following: "Hi dear @ptasker. Yes We are grateful for advice, but it is not required to have all latest versions of libraries, I think it is better to concentrate on bugs/errors and then update libraries". At this point we still agree with the previous comment, yet would like to know what admin will say in this regards.
Thank you!

This ticket was mentioned in Slack in #themereview by mattdevelop. View the logs.


16 months ago

#113 @djrmom
15 months ago

  • Cc djrmom added
  • Status changed from approved to reopened

#114 @djrmom
15 months ago

Hi @Huge-IT, I am doing the admin review and will have results for you tomorrow. Thanks, Jenny

#115 @djrmom
15 months ago

  • Status changed from reopened to reviewing

Hi @Huge-IT,

Sorry I took so long, yesterday was a busy day. This is your final review before going live, you won't need to wait in the queue again after re-approval. Please let me know if you have any questions.

Front Page Settings

Template Heirarchy

  • remove template-blog.php, category output is already handled by category.php

Content Creation

Core Functions and Features

  • do not use query_posts

Options/Theme Mods/Customizer

  • Since your theme has been in the queue since before custom logo was added to core, you can wait until the next update to fix, however, I recommend you go ahead and do so now to avoid dealing with migrating to the core settings once you are live
  • company_activation function - you cannot set theme mods on activation
  • Do not remove core controls, you should not enable those that you don't need, however, if you are using custom backgrounds, you must use the core control and not create your own
    $wp_customize->remove_control('header_textcolor');
    $wp_customize->remove_control('display_header_text');
    $wp_customize->remove_control('background_color');
    $wp_customize->remove_section('header_image');
    $wp_customize->remove_section('background_image');
    
  • title and description should not be hidden regardless of logo setting, these are not just visual settings
  • This does not sanitize, please replace with appropriate functions per type of data - company_sanitize_cb
  • please remove unused code instead of commenting out
  • You need to use core customizer controls rather than create your own such as WP_Customize_Company_Text_Control, it appears these may be related to pro controls, if so, they should be removed not hidden

Demo Content/Defaults - https://make.wordpress.org/themes/2016/03/31/what-is-demo-content/

  • Remove the default logo
  • Defaults should never be promoting your theme or theme shop
  • Remove or disable by default demo content such as social links, welcome, slider, top posts
  • The wording in the footer needs to be changed so that it does not imply the user's site is copyright to you "Copyright © 2016 Designed by Huge-IT"

Scripts/Styles

  • custom scripts and styles should be prefixed, but third party assets should use an unprefixed handle following core naming convention (script name in all lowercase, dash - instead of dots .)
    • company_fa -> font-awesome
    • company_lb_min_js -> jquery-colorbox
    • company_lb_css -> colorbox-3
  • google fonts need to be enqueued with https or protocol relative 'fonts.googleapis.com'

Plugin Territory, please remove

  • google maps
  • recaptcha

Security

  • company_responsive_slider, company_head_styles needs output escaping
  • you have set $permalink to get_permalink() in many places, $permalink needs esc_url where used like this, generally usage of get_*link need esc_url
  • logo url output in header.php needs esc_url
  • please check thoroughly for proper output escaping

Upsell

  • You may have one top level link in the customizer but you need to remove the additional text (you can move this into a section/panel). The link should not be covering the standard UI as it is now.

Other

  • Please update TGMPA to latest version

Licensing

  • readme.txt needs to also include author, copyright (if available), and source link for all third-party resources
  • font awesome needs to state both font and css license
  • missing - jscolor, colorbox, simple-slider

Anywhere you need to remove something, such as google maps, recaptcha, and pro only customizer options, all associated code no longer used, needs to be removed, not just hidden or unused.

@ptasker, please continue the review and re-approve when the above issues (and others you find) are fixed. Please let me know if you will be able to continue and if you have any questions.

Thanks,
Jenny

#116 @djrmom
15 months ago

Hi @Huge-IT, please upload or comment on your progress in order to keep this ticket open. Please let me know if you have any questions.

Thanks

#117 @Huge-IT
15 months ago

Thank you very much for the follow-up @djrmom . We very much appreciate that. Could we ask kindly if there is a chance to change the status of this ticket on a pending position somehow or extend the review time period for us? We will be able to make the suggested changes after 10 days. We really don't want to bring this rather unprofessional excuse, but the only developer who is working on this theme is on a vacation :disappointed: Really sorry about that and thanks again for your fast help.

#118 @djrmom
15 months ago

@Huge-IT,

No problem. Please let me know your status around every 7 days so I know it is still in progress.

Thanks

#119 @Huge-IT
15 months ago

Thank you very much for your kindness @djrmom . We appreciate that. We surely will follow and notify you about the progress. Thanks!

#120 @Huge-IT
15 months ago

Our theme developer is back from today and has already reviewing all the mentioned points. We will submit the modifications and edits during the next 5-7 days.

#121 @djrmom
15 months ago

Thanks for the update. Please let me know if you have any questions.

#122 @djrmom
14 months ago

Hi @Huge-IT, please let me know how you are coming on the fixes in order to keep this ticket open.

#123 @Huge-IT
14 months ago

Dear @djrmom , we are making the last minute changes and tests, hopefully, we will upload the finished version in couple of hours.

#124 @djrmom
14 months ago

Thanks @Huge-IT

#125 @themetracbot
14 months ago

  • Summary changed from THEME: Company – 1.0.16 to THEME: Company – 1.0.17

Company - 1.0.17

Company theme is a minimalistic, modern theme, which suggests perfect layouts to build your brand-new website/blog. Company Theme owns slider on the homepage, custom background, own resizable content on homepage section, customizable colors and fonts, various navigation types, customizable footer, it is integrated with Google Map, Social Media share possibility, SEO optimized and responsive design.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.17
ZIP - https://wordpress.org/themes/download/company.1.0.17.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.16&new_path=company/1.0.17

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.17/screenshot.png

#126 @Huge-IT
14 months ago

Dear @ptasker we have made the changes mentioned by @djrmom. We appreciate your help and time spent on this theme. We were trying to bring the best of it, but obviously we will need your further help and assistance. Thank you again!

#127 @themetracbot
14 months ago

  • Summary changed from THEME: Company – 1.0.17 to THEME: Company – 1.0.18

Company - 1.0.18

Company theme is a minimalistic, modern theme, which suggests perfect layouts to build your brand-new website/blog. Company Theme owns slider on the homepage, custom background, own resizable content on homepage section, customizable colors and fonts, various navigation types, customizable footer, it is integrated with Google Map, Social Media share possibility, SEO optimized and responsive design.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.18
ZIP - https://wordpress.org/themes/download/company.1.0.18.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.17&new_path=company/1.0.18

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.18/screenshot.png

#128 @ptasker
14 months ago

  • Still seeing commented out code in some places
  • Hardcoding 2016 in the footer should be switched to dynamic year date('Y')
  • Customizer - header text color does nothing
  • There is still a bunch of instances throughout that are not safely escaped (front_end_options.php in particular).

Scripts/Styles
custom scripts and styles should be prefixed, but third party assets should use an unprefixed handle following core naming convention (script name in all lowercase, dash - instead of dots .)
company_lb_min_js -> jquery-colorbox

Not done

google fonts need to be enqueued with https or protocol relative 'fonts.googleapis.com'

Not done

  • Still references in CSS to recaptcha and Google maps, reference to company_footer_map in footer.php
  • No need to run esc_url() on get_template_directory_uri()

Anywhere you need to remove something, such as google maps, recaptcha, and pro only customizer options, all associated code no longer used, needs to be removed, not just hidden or unused.

Not done

#129 @themetracbot
14 months ago

  • Summary changed from THEME: Company – 1.0.18 to THEME: Company – 1.0.19

Company - 1.0.19

Company theme is a minimalistic, modern theme, which suggests perfect layouts to build your brand-new website/blog. Company Theme owns slider on the homepage, custom background, own resizable content on homepage section, customizable colors and fonts, various navigation types, customizable footer, Social Media share possibility, SEO optimized and responsive design.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.19
ZIP - https://wordpress.org/themes/download/company.1.0.19.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.18&new_path=company/1.0.19

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.19/screenshot.png

#130 @Huge-IT
14 months ago

We have fixed all the mentioned points of yours. Thank you very much for your help. We appreciate that. The only concern we have is connected with the safe escapes. We fixed most of them we found, but surely you may go through one more time if you don't mind and point out to the ones we could have missed. Thank you !

#131 @grapplerulrich
14 months ago

  • Owner ptasker deleted

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the new queue again as a priority. This may mean it still takes time, but will prevent this ticket being held for so long by a reviewer that isn't able to carry on. Thanks for your patience.

If you are the reviewer and able to do this review, please carry on and request you get added back in Slack #themereview or you can take on another review when you have time again.

#132 @themetracbot
14 months ago

  • Owner set to swetashrestha

#133 @swetashrestha
14 months ago

Hello @Huge-IT,

Thanks for uploading theme, here is my review:

REQUIRED:

  • Remove Upgrade to Company Pro button from top of the customizer as you have already added option inside cutomizer
  • Add direct link of images used in screenshot in readme file
  • Add dual license of FontAwesome like this:
    FontAwesome 4.2.0
    Copyright 2012 Dave Gandy
    Font License: SIL OFL 1.1
    Code License: MIT License
    http://fontawesome.io/license/
    
  • Globalize $content_width
    • Please go to this link for more details
  • No need to enqueue jquery, add it in dependency whenever it is requiered
  • Escape missing in:
    • extras/front_end_blocks.php lines 645 to 692 (all the social links)
  • Please remove Statement showing more options in Pro Version, this looks like advertisement
  • I have a query: what does Lightbox option do?
  • There is a design issue in theme please check the screenshot below
    • I cannot click on submenu it disappears when i tried clicking on it.

Note: Please communicate within 7days otherwise theme will be resolved as not-approved

Last edited 14 months ago by swetashrestha (previous) (diff)

#134 @Huge-IT
14 months ago

Thank you very much for your help and concerns @grapplerulrich , we appreciate that. And we are more than happy to cooperate with @swetashrestha. Thanks a lot. We are going to review all the mentioned points and make the changes. We will keep you updated about the progress for sure. Thank you!

#135 @themetracbot
14 months ago

  • Summary changed from THEME: Company – 1.0.19 to THEME: Company – 1.0.20

Company - 1.0.20

Company theme is a minimalistic, modern theme, which suggests perfect layouts to build your brand-new website/blog. Company Theme owns slider on the homepage, custom background, own resizable content on homepage section, customizable colors and fonts, various navigation types, customizable footer, Social Media share possibility, SEO optimized and responsive design.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.20
ZIP - https://wordpress.org/themes/download/company.1.0.20.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.19&new_path=company/1.0.20

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.20/screenshot.png

#136 follow-up: @Huge-IT
14 months ago

Dear @swetashrestha we have made all the required changes. Let us know if we missed something. Thank you!

#137 in reply to: ↑ 136 @swetashrestha
14 months ago

Replying to Huge-IT:

Dear @swetashrestha we have made all the required changes. Let us know if we missed something. Thank you!

Thanks for update i will recheck and post if any issues are left

#138 @swetashrestha
14 months ago

Hello @Huge-IT,

Here are further issues:

  • Theme Check Issue:
    WARNING: Found a translation function that is missing a text-domain. Function __, with the arguments 'By enabling this option you may add a media in post/pages under <a> tag and showcase the media in lightobx'
    
  • When i tried to add Social media button i does not shows up in theme, please check it.
  • Lightbox option does not works

Other issues fixed.

Last edited 14 months ago by swetashrestha (previous) (diff)

#139 @themetracbot
13 months ago

  • Summary changed from THEME: Company – 1.0.20 to THEME: Company – 1.0.21

Company - 1.0.21

Company theme is a minimalistic, modern theme, which suggests perfect layouts to build your brand-new website/blog. Company Theme owns slider on the homepage, custom background, own resizable content on homepage section, customizable colors and fonts, various navigation types, customizable footer, Social Media share possibility, SEO optimized and responsive design.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.21
ZIP - https://wordpress.org/themes/download/company.1.0.21.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.20&new_path=company/1.0.21

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.21/screenshot.png

#140 follow-up: @grapplerulrich
13 months ago

@swetashrestha Have you seen the update?

#141 in reply to: ↑ 140 @swetashrestha
13 months ago

Replying to grapplerulrich:

@swetashrestha Have you seen the update?

Yes, I will recheck and post today.

#142 @swetashrestha
13 months ago

Hello @Huge-IT,

Sorry for my late response i was on leave. All Previous mentioned issues fixed. Just a small mistake on Author URL you have added two Author URL in style.css, please make the change and i will approve the theme.

#143 @themetracbot
13 months ago

  • Summary changed from THEME: Company – 1.0.21 to THEME: Company – 1.0.22

Company - 1.0.22

Company theme is a minimalistic, modern theme, which suggests perfect layouts to build your brand-new website/blog. Company Theme owns slider on the homepage, custom background, own resizable content on homepage section, customizable colors and fonts, various navigation types, customizable footer, Social Media share possibility, SEO optimized and responsive design.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http:huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.22
ZIP - https://wordpress.org/themes/download/company.1.0.22.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.21&new_path=company/1.0.22

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.22/screenshot.png

#144 follow-up: @Huge-IT
13 months ago

Dear @swetashrestha we have made the changes. Please, have a look and let us know if there is still something we need to fix. Thank you for your help and the assistance of the community. We appreciate. Hope to be approved this time.

#145 in reply to: ↑ 144 @swetashrestha
13 months ago

Replying to Huge-IT:

Dear @swetashrestha we have made the changes. Please, have a look and let us know if there is still something we need to fix. Thank you for your help and the assistance of the community. We appreciate. Hope to be approved this time.

Hi @Huge-IT,

Thanks for update, there is problem in Author URL in the ticket page please check the screenshot below

Regards,
Sweta

#146 @themetracbot
13 months ago

  • Summary changed from THEME: Company – 1.0.22 to THEME: Company – 1.0.23

Company - 1.0.23

Company theme is a minimalistic, modern theme, which suggests perfect layouts to build your brand-new website/blog. Company Theme owns slider on the homepage, custom background, own resizable content on homepage section, customizable colors and fonts, various navigation types, customizable footer, Social Media share possibility, SEO optimized and responsive design.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http://huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.23
ZIP - https://wordpress.org/themes/download/company.1.0.23.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.22&new_path=company/1.0.23

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.23/screenshot.png

#147 @swetashrestha
13 months ago

Thanks for the update, I am marking theme as Approved

Admin will perform a final review and make theme live if they did not find any issue. You can check status of you theme in admin's queue

All the best!!!

#148 @swetashrestha
13 months ago

  • Status changed from reviewing to approved

Thanks for the update, I am marking theme as Approved

Admin will perform a final review and make theme live if they did not find any issue. You can check status of you theme in admin's queue

All the best!!!

#149 @Huge-IT
13 months ago

All the best to you as well. And thanks one more time

#150 @djrmom
13 months ago

Hi @Huge-IT, sorry I have been busy with work but should be able to check on this in the next couple of days.

#151 @Huge-IT
13 months ago

Dear @djrmom , hope everything is well at your end and we'd have a chance to draw your attention to our theme. We know that you are super-busy and we honestly appreciate your assistance in this regards. Thank you very much.

#152 @djrmom
13 months ago

Hi @Huge-IT, I am working on it today.

#153 @djrmom
13 months ago

  • Status changed from approved to reopened

Hi @Huge-IT,

Sorry, there is an error output on clean install and a few security issues that need to be fixed. Almost there :)

  • Error on clean install
    Warning: Invalid argument supplied for foreach() in /srv/www/wordpress-themereview-vvv/htdocs/wp-content/themes/company/extras/default_content.php on line 25
    
  • missing esc_url in searchform.php
  • company_ajax_actions_callback_function needs to include nonce check for security
  • hardcoded urls don't need escaping, ex. 'company_facebook_url' => esc_url("https://www.facebook.com"),
  • links are needed to verify images from pexels in readme.txt
  • get_template_part is for loading template files, include or require should be used for functionality files, ex. get_template_part('extras/install_plugins');
  • sanitize_text_field, sanitize_hex_color are for input, use esc_html for output, ex. background-color:<?php echo esc_html($theme_mods["company_sidebar_bg_color"]); ?>;

Thanks,
Jenny

#154 @swetashrestha
13 months ago

  • Status changed from reopened to reviewing

#155 @themetracbot
13 months ago

  • Summary changed from THEME: Company – 1.0.23 to THEME: Company – 1.0.24

Company - 1.0.24

Company theme is a minimalistic, modern theme, which suggests perfect layouts to build your brand-new website/blog. Company Theme owns slider on the homepage, custom background, own resizable content on homepage section, customizable colors and fonts, various navigation types, customizable footer, Social Media share possibility, SEO optimized and responsive design.

Theme URL - http://huge-it.com/wordpress-theme-company
Author URL - http://huge-it.com/

SVN - https://themes.svn.wordpress.org/company/1.0.24
ZIP - https://wordpress.org/themes/download/company.1.0.24.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=company/1.0.23&new_path=company/1.0.24

History:

Ticket Summary Status Resolution Owner
#26159 THEME: Company – 1.0.24 closed live swetashrestha

(this ticket)

#37852 THEME: Company – 1.0.25 closed live themetracbot
#42036 THEME: Company Elite – 1.0.2 closed live juhise
#43361 THEME: Company Elite – 1.0.3 closed live themetracbot
#45052 THEME: Company Elite – 1.0.4 closed live themetracbot
#45637 THEME: Company Elite – 1.0.5 closed live themetracbot


https://themes.svn.wordpress.org/company/1.0.24/screenshot.png

#156 @Huge-IT
13 months ago

Dear @djrmom and @swetashrestha tha respectfully. We have made the mentioned changes as well. Please, review kindly the updated version and let us know if we need to work on it any further. Thank you.

#157 @swetashrestha
12 months ago

  • Status changed from reviewing to approved

Hello @Huge-IT,

Thanks for update, i have rechecked the theme, previous issues are solve and i did not find any further issues. So i am marking theme as approved.


Hello @djrmom,
All issues have been fixed. Please check it.

Regards,
Sweta.

#158 @djrmom
12 months ago

  • Resolution set to live
  • Status changed from approved to closed

Thanks @swetashrestha

Congrats @Huge-IT your theme is now live.

On update please fix:

include/require should use the full file path - ex require_once('extras/editor.php'); -> require_once trailingslashit( get_template_directory() ) . 'extras/editor.php';

Thanks

#159 @Huge-IT
12 months ago

Dear @djrmom and @swetashrestha thank you very much for helping us to bring this theme live. We appreciate your hard work and help a lot. :slightly_smiling_face: P.S. We will surely include mentioned point in the upcoming update.

Note: See TracTickets for help on using tickets.