WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

#26233 closed theme (not-approved)

THEME: Lemonade – 1.0

Reported by: hb81 Owned by: TimothyBlynJacobs
Priority: new theme Keywords: theme-lemonade
Cc: hannahjewkes@…

Description

Attachments (1)

lemonade.zip (2.5 MB) - added by hb81 2 years ago.
New version of theme

Change History (7)

@hb81
2 years ago

New version of theme

#1 @karmatosed
2 years ago

Please can you ensure you upload new versions via wordpress.org, rather than attaching a zip. Reviewers will only review that way.

#2 @themetracbot
2 years ago

  • Owner set to TimothyBlynJacobs
  • Status changed from new to reviewing

#3 @TimothyBlynJacobs
2 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Hi hb81,

My name is Timothy. I'm going to be reviewing your theme.

At this time your theme isn't ready for inclusion in the WordPress themes directory. I've outlined a number of things that you must fix, and recommendations that you should fix. If something isn't clear let me know. This is a fairly comprehensive review, but it might not be all the issues.

Required

  • How are the social media icons licensed?
  • .screen-reader-text css class is needed in your theme css. See: the Codex for an example implementation.
  • There are a number of translation calls that are missing a text domain. These are required. You can run the Theme Check plugin to see a list of all of them. You should also only use one text domain, lemonade. You are using lemthemethemecustomizer in the customizer.
  • You should load your theme on after_setup_theme. This is where you would add theme support, or register menus.
  • Remove reference to favicon.ico in your header.php file. WordPress provides this functionality by default since 4.3
  • Escape your output using esc_url in header.php and escape the output in the footer as well.
  • In home.php ( and elsewhere ) you are hardcoding by and on in the byline. This should be translatable using sprintf to do the replacements for the links.

Recommended

  • Add support for custom background images
  • Consider making the footer settings a widget area, instead of options in the customizer. This will make your theme more flexible for your users.
  • Shorten “link to your social media pages” to Social Media Links or something similar.
  • Specify in the social media customizer whether usernames, or full links should be used.
  • Not all of the default images in the customizer appear to be linked correctly
  • Remove empty print.css file
  • Remove sass comments in your css files.
  • The <code> tag is not the same as the <pre> tag. The <code> tag should not break and start a new line. It should be stylized inline with the text. Same for <kbd>
  • When a sticky post is appearing in its usual position, i.e. not at the first position in the blog, it should not have a “sticky” tag.
  • Pingbacks and trackbacks are not displayed.
  • Don’t rename the core Site Identity customizer panel. While it might make sense when isolated with your theme, it is confusing for WordPress users who are looking for Site Identity from their experience with previous themes.
  • Consider the case when there is no custom logo defined. Perhaps move the header text up to align with the social media icons.

Notes

  • Consider adding styling for an input with a type of submit
  • The white on yellow for twitter and instagram is difficult to read. Consider a different contrasting color

After all of the required issues are fixed, you can upload a new version of your theme and I will take another look at your theme.

#4 @jcastaneda
2 years ago

  • Resolution not-approved deleted
  • Status changed from closed to reopened

#5 @jcastaneda
2 years ago

  • Status changed from reopened to reviewing

#6 @karmatosed
2 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

I am closing this ticket as you've not responded to the review. In future please respond, even to say you need more time within 7 days.

Note: See TracTickets for help on using tickets.