WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

#26430 closed theme (live)

THEME: Smart Magazine – 1.0.6

Reported by: kais99 Owned by: rabmalin
Priority: new theme Keywords: theme-smart-magazine
Cc: qaiser.bashir@…

Description

Smart Magazine - 1.0.0

Smart Magazine is a modern responsive WordPress theme that lets you write articles and blog posts with ease. The Smart magazine theme is excellent for a news, newspaper, magazine, publishing or other editorial websites. Smart Magazine is a easily customizable using WordPress theme customizer. Demo – http://demo.mag-themes.com/smartmagazine

Theme URL - http://mag-themes.com/smart-magazine/
Author URL - http://mag-themes.com/

SVN - https://themes.svn.wordpress.org/smart-magazine/1.0.0
ZIP - https://wordpress.org/themes/download/smart-magazine.1.0.0.zip?nostats=1

History:


https://themes.svn.wordpress.org/smart-magazine/1.0.0/screenshot.png

Change History (24)

#1 @themetracbot
2 years ago

  • Summary changed from THEME: Smart Magazine – 1.0.0 to THEME: Smart Magazine – 1.0.1

Smart Magazine - 1.0.1

Smart Magazine is a modern responsive WordPress theme that lets you write articles and blog posts with ease. The Smart magazine theme is excellent for a news, newspaper, magazine, publishing or other editorial websites. Smart Magazine is a easily customizable using WordPress theme customizer. Demo – http://demo.mag-themes.com/smartmagazine

Theme URL - http://mag-themes.com/smart-magazine/
Author URL - http://mag-themes.com/

SVN - https://themes.svn.wordpress.org/smart-magazine/1.0.1
ZIP - https://wordpress.org/themes/download/smart-magazine.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smart-magazine/1.0.0&new_path=smart-magazine/1.0.1

History:


https://themes.svn.wordpress.org/smart-magazine/1.0.1/screenshot.png

#2 @rabmalin
2 years ago

  • Owner set to rabmalin
  • Status changed from new to reviewing

#3 @rabmalin
2 years ago

Hello @kais99,

Thanks for uploading theme. Please fix following issues and reupload your theme again.

REQUIRED

rtl.css

  • rtl.css is not necessary if all code inside are commented out or blank. So remove it.

readme.txt

  • correct the spelling of reponsive in line 3.
  • Can you mention the sources for screenshots? Also mention the license they are licensed under.

Language

  • All strings are not translatable. Please fix it. For your reference find line number 15 on content-single.php on line 28, 29 of customizer.php etc.. Check on other files too. Use this plugin to check. https://wordpress.org/plugins/piglatin/

Reference Link: https://codex.wordpress.org/I18n_for_WordPress_Developers

js

code

  • Please prefix theme functions, classes, global variables, image size name, script and style handles, etc with theme slug. Some Functions name missing prefix. For your reference it is missing on functions.php line 85, 90 etc. Check on all files too.

http://themereview.co/prefix-all-the-things/

  • extras.php. You can now remove backward compatibility code for title tag as we are already at WP 4.3.
  • Please remove commented codes for your reference script.js line 12. Please check other files too.
  • Please enqueue styles such as inline style block written in 'footer.php' in functions by making custom file.

Validation and Sanitization

RECOMMENDED

Theme Check

  • Screenshot size should be 880x660, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.

NOTE

  • REQUIRED points should be resolved to make theme approved on wordpress.org. RECOMMENDED points includes best practices on theme development but theme will not be rejected on the base of RECOMMENDED points.
  • Please fix issues and reupload your theme. Update your theme version and changelog. https://wordpress.org/themes/upload/
  • Please respond within 7 days. If there is no response for 7 days, ticket will be closed as not-approved.

#4 @kais99
2 years ago

Many Thanks. I would fix the issue ASAP.

Best Regards,
Qaiser

#5 @themetracbot
2 years ago

  • Summary changed from THEME: Smart Magazine – 1.0.1 to THEME: Smart Magazine – 1.0.2

Smart Magazine - 1.0.2

Smart Magazine is a modern responsive WordPress theme that lets you write articles and blog posts with ease. The Smart magazine theme is excellent for a news, newspaper, magazine, publishing or other editorial websites. Smart Magazine is a easily customizable using WordPress theme customizer. Demo – http://demo.mag-themes.com/smartmagazine

Theme URL - http://mag-themes.com/smart-magazine/
Author URL - http://mag-themes.com/

SVN - https://themes.svn.wordpress.org/smart-magazine/1.0.2
ZIP - https://wordpress.org/themes/download/smart-magazine.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smart-magazine/1.0.1&new_path=smart-magazine/1.0.2

History:


https://themes.svn.wordpress.org/smart-magazine/1.0.2/screenshot.png

#6 @themetracbot
2 years ago

  • Summary changed from THEME: Smart Magazine – 1.0.2 to THEME: Smart Magazine – 1.0.3

Smart Magazine - 1.0.3

Smart Magazine is a modern responsive WordPress theme that lets you write articles and blog posts with ease. The Smart magazine theme is excellent for a news, newspaper, magazine, publishing or other editorial websites. Smart Magazine is a easily customizable using WordPress theme customizer. Demo – http://demo.mag-themes.com/smartmagazine

Theme URL - http://mag-themes.com/smart-magazine/
Author URL - http://mag-themes.com/

SVN - https://themes.svn.wordpress.org/smart-magazine/1.0.3
ZIP - https://wordpress.org/themes/download/smart-magazine.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smart-magazine/1.0.2&new_path=smart-magazine/1.0.3

History:


https://themes.svn.wordpress.org/smart-magazine/1.0.3/screenshot.png

#7 @kais99
2 years ago

Hi
I have fixed everything apart from 2 points:
JS: The original file of respond.min.js is missing : File is in the folder assets/js
extras.php. You can now remove backward compatibility code for title tag as we are already at WP 4.3. : The code first checks if WordPress version is less than 4.1. I think we should leave it for the people who hasn't updated their WordPress yet.

Apart from above 2, I have worked on all recommended and required issues. Thanks for the mentioning "piglatin" plugin. It is very useful.

Please let me know if I have missed anything.

Many Thanks,
Qaiser

#8 @rabmalin
2 years ago

Hello,

Please fix following issues and re-upload your theme.

Issues

  • REQUIRED: Remove following from header.php.
    	/usr/bin/php -q http://demo.mag-themes.com/wp-cron.php?_nonce=d5d0c2b6&backwpup_run=runext&jobid=1
    
  • REQUIRED: Use esc_url to escape image url or similar. header.php line 74.
  • REQUIRED: Spelling - Fotter Menu.
  • REQUIRED: Remove commented out unnecessary codes.
  • RECOMMENDED: You could use paginate_links to implement pagination rather than creating yourself.
  • REQUIRED: Remove commented out unnecessary codes.
  • REQUIRED: respond.min.js is minified script. You need to provide unminified script also. Also for font-awesome.min.css, jquery.easing.js and other.
  • REQUIRED: Remove _s and Automattic from POT file and put your own.
  • REQUIRED: Do we need layouts folder?
  • REQUIRED: Can you confirm that all images used in the screenshot are your personal creation?
  • REQUIRED: Escaping missing - customizer.php line 217, 218. Please check in other places also.
  • REQUIRED: You have removed Custom Header section from customizer. If we do not include custom-header.php file then we need not remove from the customizer manually.
  • REQUIRED: Translation issues - gum_ad.php line 58. Please check in other places also.
  • REQUIRED: Invalid prefix in function register_smart_magazine_posts_grid_1_widgets. Please check in other places also.

#9 @kais99
2 years ago

Thanks. I am working on it.
Just one question, re: REQUIRED: respond.min.js is minified script. You need to provide unminified script also. Also for font-awesome.min.css, jquery.easing.js and other.

Should the unminified scripts be in a folder or do I need to call or register them in the theme instead of minified versions?

Many Thanks,
Qaiser

#10 @rabmalin
2 years ago

You can freely use minified scripts and styles. Only requirement is that unminified scripts also should be available in the theme in case user want to modify that. It is not possible to modify minified scripts.

#11 @themetracbot
2 years ago

  • Summary changed from THEME: Smart Magazine – 1.0.3 to THEME: Smart Magazine – 1.0.4

Smart Magazine - 1.0.4

Smart Magazine is a modern responsive WordPress theme that lets you write articles and blog posts with ease. The Smart magazine theme is excellent for a news, newspaper, magazine, publishing or other editorial websites. Smart Magazine is a easily customizable using WordPress theme customizer. Demo – http://demo.mag-themes.com/smartmagazine

Theme URL - http://mag-themes.com/smart-magazine/
Author URL - http://mag-themes.com/

SVN - https://themes.svn.wordpress.org/smart-magazine/1.0.4
ZIP - https://wordpress.org/themes/download/smart-magazine.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smart-magazine/1.0.3&new_path=smart-magazine/1.0.4

History:


https://themes.svn.wordpress.org/smart-magazine/1.0.4/screenshot.png

#12 @kais99
2 years ago

Hi rabmalin

I have fixed all the issues. Please check.

Thanks,
Qaiser

#13 @rabmalin
2 years ago


Hello,

Please fix following issues and re-upload your theme.

Issues

#14 @kais99
2 years ago

Thanks. I would fix the new issues today. Just one thing
REQUIRED: gum_ad.php line 13 - gum_ad is registered as widget id. Can you please explain? Similar in other widgets.

What do you want me to explain? What is wrong with gum_ad as ID?

#15 @rabmalin
2 years ago

It should be prefixed with theme slug.

#16 @kais99
2 years ago

Ah ok. sorry. I would fix it later today.

Thanks,
Qaiser

#17 @themetracbot
2 years ago

  • Summary changed from THEME: Smart Magazine – 1.0.4 to THEME: Smart Magazine – 1.0.5

Smart Magazine - 1.0.5

Smart Magazine is a modern responsive WordPress theme that lets you write articles and blog posts with ease. The Smart magazine theme is excellent for a news, newspaper, magazine, publishing or other editorial websites. Smart Magazine is a easily customizable using WordPress theme customizer. Demo – http://demo.mag-themes.com/smartmagazine

Theme URL - http://mag-themes.com/smart-magazine/
Author URL - http://mag-themes.com/

SVN - https://themes.svn.wordpress.org/smart-magazine/1.0.5
ZIP - https://wordpress.org/themes/download/smart-magazine.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smart-magazine/1.0.4&new_path=smart-magazine/1.0.5

History:


https://themes.svn.wordpress.org/smart-magazine/1.0.5/screenshot.png

#18 @kais99
2 years ago

I have fixed all the issues. Please check.

Thanks,
Qaiser

#19 @rabmalin
2 years ago

Issues

  • REQUIRED: Incorrect text domain search.php line 36, 37, 38.
  • REQUIRED: readme.txt - Please mention license information and FULL image URL of each images used in theme and screenshot.
  • REQUIRED: License info missing for jquery.hoverIntent.js, jquery.easing.js, jquery.mousewheel-3.0.6.pack.js. Please check other resources also.

#20 @themetracbot
2 years ago

  • Summary changed from THEME: Smart Magazine – 1.0.5 to THEME: Smart Magazine – 1.0.6

Smart Magazine - 1.0.6

Smart Magazine is a modern responsive WordPress theme that lets you write articles and blog posts with ease. The Smart magazine theme is excellent for a news, newspaper, magazine, publishing or other editorial websites. Smart Magazine is a easily customizable using WordPress theme customizer. Demo – http://demo.mag-themes.com/smartmagazine

Theme URL - http://mag-themes.com/smart-magazine/
Author URL - http://mag-themes.com/

SVN - https://themes.svn.wordpress.org/smart-magazine/1.0.6
ZIP - https://wordpress.org/themes/download/smart-magazine.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=smart-magazine/1.0.5&new_path=smart-magazine/1.0.6

History:


https://themes.svn.wordpress.org/smart-magazine/1.0.6/screenshot.png

#21 @kais99
2 years ago

Hi
I have fixed all issues. Please check.

Thanks,
Qaiser

#22 @rabmalin
2 years ago

  • Status changed from reviewing to approved

Marking as approved. Please be patient. After approval of theme, admin will once again review your theme. Only after admin approval your theme will be live.

#23 @kais99
2 years ago

Thank you. you were really helpful. Learnt many new things. Should have done an open source theme long time ago.

Q

Last edited 2 years ago by kais99 (previous) (diff)

#24 @karmatosed
2 years ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations, this theme is now live!

Note: See TracTickets for help on using tickets.