WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

Last modified 21 months ago

#26492 closed theme (live)

THEME: Shamrock – 1.0.6

Reported by: mekshq Owned by: swetashrestha
Priority: new theme Keywords: theme-shamrock
Cc: office@…

Description

Shamrock - 1.0

Shamrock is a clean and beautifully designed WordPress theme which will make your articles shine. Modern typography will make your visitors very easy to read while its responsive design will ensure it looks good an all devices. It’s highly flexible so you can use powerful yet simple options in the customizer to style it depending on your taste.

Theme URL - http://mekshq.com/themes/shamrock
Author URL - http://mekshq.com

SVN - https://themes.svn.wordpress.org/shamrock/1.0
ZIP - https://wordpress.org/themes/download/shamrock.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#26492 THEME: Shamrock – 1.0.6 closed live swetashrestha

(this ticket)

#29044 THEME: Shamrock – 1.0.7 closed live Otto42


https://themes.svn.wordpress.org/shamrock/1.0/screenshot.png

Attachments (1)

shamrock-fixed.zip (1.2 MB) - added by mekshq 2 years ago.
Theme package with the fixes required by a reviewer

Download all attachments as: .zip

Change History (28)

#1 @themetracbot
2 years ago

  • Owner set to swetashrestha
  • Status changed from new to reviewing

#2 follow-up: @swetashrestha
2 years ago

REQUIRED:

  • Got these issues on activation of theme:
    Notice: The called constructor method for WP_Widget is deprecated since version 4.3.0! Use instead. in .../functions.php on line 3457
    
  • Remove starting message section:
    Thank you for choosing Shamrock!
    We really appreciate your trust and support.
    
  • Proper Copyright/Licensing and attribution required for the resources used by theme (like fonts, images, javascripts etc ). Go through this link for more details
  • Include a text-domain in style.css
  • Change function prefix smr to shamrock
  • Include shamrock.pot file inside language folder. Go through this link for more details
  • No minification of scripts or files unless provide original files. Provide unmified version of bootstrap.min.css, font-awesome.min.css, jquery.magnific-popup.min.js and jquery.owl.carousel.min.js
  • Text-domain missing in translation function. For example:

Change

__smr( 'continue_reading' ) 

to

__('continue_reading', shamrock) 
  • Make all the public facing text string translation ready. Go through this link
  • Theme URI shows Page Not Found, Theme URI must contain information related to theme
  • screen-reader-text css class is needed in your theme css. See See: the Codex for an example implementation.
  • Remove style.less file as theme has style.css file
  • From footer.php remove all the direct links to your social accounts (facebook, twitter, googleplus)

Please feel free to ask if you have any questions.

Note:

  • Please communicate in the ticket within 7days, otherwise ticket will be resolve as not-approved
  • Theme might need a few more review iteration before final approval
Last edited 2 years ago by swetashrestha (previous) (diff)

#3 in reply to: ↑ 2 ; follow-up: @mekshq
2 years ago

Replying to swetashrestha:

Hi First of all, we had problems to commit the changes to repository:
Commit failed (details follow):
POST of '/!svn/me': 403 Forbidden (https://themes.svn.wordpress.org)

As this is our first theme on WordPress.org I'm not sure if there are some different way to do this. However, I'm sending you updated theme package as an attachment.

Here is a list of changes:

  • Got these issues on activation of theme:
    Notice: The called constructor method for WP_Widget is deprecated since version 4.3.0! Use instead. in .../functions.php on line 3457
    

Fixed

  • Remove starting message section:
    Thank you for choosing Shamrock!
    We really appreciate your trust and support.
    

Removed. I'm just curious, why we are not allowed to provide introduction panel for our users so they can easily understand where to start?

  • Proper Copyright/Licensing and attribution required for the resources used by theme (like fonts, images, javascripts etc ). Go through this link for more details

Added in readme.txt file of the theme.

  • Include a text-domain in style.css

Included.

  • Change function prefix smr to shamrock

Changed.

  • Include shamrock.pot file inside language folder.

Included.

  • Text-domain missing in translation function. For example:

Change

__smr( 'continue_reading' ) 

to

__('continue_reading', shamrock) 

Sorry, but I think you haven't understood the code. smr() function actually calls native wp function () which has all translated string included. You can find all the text in includes/translate.php which will work with translations.

  • Make all the public facing text string translation ready.

Done.

  • Remove style.less file as theme has style.css file

Removed.

  • From footer.php remove all the direct links to your social accounts (facebook, twitter, googleplus)

Removed.

@mekshq
2 years ago

Theme package with the fixes required by a reviewer

#4 follow-up: @swetashrestha
2 years ago

Hi mekshq,
Increase version of theme and upload via uploader.
Make sure that you have logged in from same account.

#5 @themetracbot
2 years ago

  • Summary changed from THEME: Shamrock – 1.0 to THEME: Shamrock – 1.0.1

Shamrock - 1.0.1

Shamrock is a clean and beautifully designed WordPress theme which will make your articles shine. Modern typography will make your visitors very easy to read while its responsive design will ensure it looks good an all devices. It’s highly flexible so you can use powerful yet simple options in the customizer to style it depending on your taste.

Theme URL -
Author URL - http://mekshq.com

SVN - https://themes.svn.wordpress.org/shamrock/1.0.1
ZIP - https://wordpress.org/themes/download/shamrock.1.0.1.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shamrock/1.0&new_path=shamrock/1.0.1

History:

Ticket Summary Status Resolution Owner
#26492 THEME: Shamrock – 1.0.6 closed live swetashrestha

(this ticket)

#29044 THEME: Shamrock – 1.0.7 closed live Otto42


https://themes.svn.wordpress.org/shamrock/1.0.1/screenshot.png

#6 in reply to: ↑ 4 @mekshq
2 years ago

Replying to swetashrestha:

Hi swetashrestha,

Thank you, we have increased the version to 1.0.1 and uploaded.

Please check

Hi mekshq,
Increase version of theme and upload via uploader.
Make sure that you have logged in from same account.

#7 in reply to: ↑ 3 @swetashrestha
2 years ago

Replying to mekshq:

Replying to swetashrestha:

Hi First of all, we had problems to commit the changes to repository:
Commit failed (details follow):
POST of '/!svn/me': 403 Forbidden (https://themes.svn.wordpress.org)

As this is our first theme on WordPress.org I'm not sure if there are some different way to do this. However, I'm sending you updated theme package as an attachment.

Here is a list of changes:

  • Got these issues on activation of theme:
    Notice: The called constructor method for WP_Widget is deprecated since version 4.3.0! Use instead. in .../functions.php on line 3457
    

Fixed

  • Remove starting message section:
    Thank you for choosing Shamrock!
    We really appreciate your trust and support.
    

Removed. I'm just curious, why we are not allowed to provide introduction panel for our users so they can easily understand where to start?

This is because other themes have misused the message for advertisement. Hence this has been disallowed for all themes in WordPress repo.

  • Proper Copyright/Licensing and attribution required for the resources used by theme (like fonts, images, javascripts etc ). Go through this link for more details

Added in readme.txt file of the theme.

  • Include a text-domain in style.css

Included.

  • Change function prefix smr to shamrock

Changed.

  • Include shamrock.pot file inside language folder.

Included.

  • Text-domain missing in translation function. For example:

Change

__smr( 'continue_reading' ) 

to

__('continue_reading', shamrock) 

Sorry, but I think you haven't understood the code. smr() function actually calls native wp function () which has all translated string included. You can find all the text in includes/translate.php which will work with translations.

  • Make all the public facing text string translation ready.

Done.

  • Remove style.less file as theme has style.css file

Removed.

  • From footer.php remove all the direct links to your social accounts (facebook, twitter, googleplus)

Removed.

#8 follow-up: @swetashrestha
2 years ago

Further Issues:

For Translation:

  • Go through this link here
  • The way you done translation, this will nor work with Automated WordPress translation. Translation is handled by WordPress using polygots. You do not need to provide any additional feature for translation. Please remove this feature.
  • Please go through these links:
  • All functions must be properly prefixed with theme_slug(shamrock)
  • Update kirki to latest version
  • Provide license details of images used in screenshot, serialize.js in readme file
  • The way you are including google fonts is not proper. Use : method for proper google font enqueue/ enqueue
  • Proper validation and sanitization not found. Go /here for more info
    • Escape link and image source using esc_url()
    • Escape missing in css/dynamic-css.php line 3 to 8

RECOMMENDED:


Note: Will do detail review of framework after your next update.

Last edited 2 years ago by swetashrestha (previous) (diff)

#9 @themetracbot
2 years ago

  • Summary changed from THEME: Shamrock – 1.0.1 to THEME: Shamrock – 1.0.2

Shamrock - 1.0.2

Shamrock is a clean and beautifully designed WordPress theme which will make your articles shine. Modern typography will make your visitors very easy to read while its responsive design will ensure it looks good an all devices. It’s highly flexible so you can use powerful yet simple options in the customizer to style it depending on your taste.

Theme URL -
Author URL - http://mekshq.com

SVN - https://themes.svn.wordpress.org/shamrock/1.0.2
ZIP - https://wordpress.org/themes/download/shamrock.1.0.2.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shamrock/1.0.1&new_path=shamrock/1.0.2

History:

Ticket Summary Status Resolution Owner
#26492 THEME: Shamrock – 1.0.6 closed live swetashrestha

(this ticket)

#29044 THEME: Shamrock – 1.0.7 closed live Otto42


https://themes.svn.wordpress.org/shamrock/1.0.2/screenshot.png

#10 in reply to: ↑ 8 @mekshq
2 years ago

Replying to swetashrestha:

Hi,

I have fixed the remaining issues and uploaded new version 1.0.2.

Thanks

Further Issues:

For Translation:

  • Go through this link here
  • The way you done translation, this will nor work with Automated WordPress translation. Translation is handled by WordPress using polygots. You do not need to provide any additional feature for translation. Please remove this feature.
  • Please go through these links:
  • All functions must be properly prefixed with theme_slug(shamrock)
  • Update kirki to latest version
  • Provide license details of images used in screenshot, serialize.js in readme file
  • The way you are including google fonts is not proper. Use : method for proper google font enqueue/ enqueue
  • Proper validation and sanitization not found. Go /here for more info
    • Escape link and image source using esc_url()
    • Escape missing in css/dynamic-css.php line 3 to 8

RECOMMENDED:


Note: Will do detail review of framework after your next update.

#11 follow-up: @swetashrestha
2 years ago

Previous issue NOT-FIXED:

  • The way you are making your text string translatable is not correct. For example:
    <p><?php _e('The page that you are looking for doesn&rsquo;t exist on this website. You may have accidentally mistype the page address, or followed an expired link. Anyway, we will help you get back on track. Why don&rsquo;t you try searching for an article?', THEME_SLUG); ?></p>
    

Replace THEME_SLUG with theme's actual text-domain, that is, shamrock. Make sure that you change this in all the places.

#12 @themetracbot
2 years ago

  • Summary changed from THEME: Shamrock – 1.0.2 to THEME: Shamrock – 1.0.3

Shamrock - 1.0.3

Shamrock is a clean and beautifully designed WordPress theme which will make your articles shine. Modern typography will make your visitors very easy to read while its responsive design will ensure it looks good an all devices. It&#8217;s highly flexible so you can use powerful yet simple options in the customizer to style it depending on your taste.

Theme URL -
Author URL - http://mekshq.com

SVN - https://themes.svn.wordpress.org/shamrock/1.0.3
ZIP - https://wordpress.org/themes/download/shamrock.1.0.3.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shamrock/1.0.2&new_path=shamrock/1.0.3

History:

Ticket Summary Status Resolution Owner
#26492 THEME: Shamrock – 1.0.6 closed live swetashrestha

(this ticket)

#29044 THEME: Shamrock – 1.0.7 closed live Otto42


https://themes.svn.wordpress.org/shamrock/1.0.3/screenshot.png

#13 @themetracbot
2 years ago

  • Summary changed from THEME: Shamrock – 1.0.3 to THEME: Shamrock – 1.0.4

Shamrock - 1.0.4

Shamrock is a clean and beautifully designed WordPress theme which will make your articles shine. Modern typography will make your visitors very easy to read while its responsive design will ensure it looks good an all devices. It&#8217;s highly flexible so you can use powerful yet simple options in the customizer to style it depending on your taste.

Theme URL -
Author URL - http://mekshq.com

SVN - https://themes.svn.wordpress.org/shamrock/1.0.4
ZIP - https://wordpress.org/themes/download/shamrock.1.0.4.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shamrock/1.0.3&new_path=shamrock/1.0.4

History:

Ticket Summary Status Resolution Owner
#26492 THEME: Shamrock – 1.0.6 closed live swetashrestha

(this ticket)

#29044 THEME: Shamrock – 1.0.7 closed live Otto42


https://themes.svn.wordpress.org/shamrock/1.0.4/screenshot.png

#14 @themetracbot
2 years ago

  • Summary changed from THEME: Shamrock – 1.0.4 to THEME: Shamrock – 1.0.5

Shamrock - 1.0.5

Shamrock is a clean and beautifully designed WordPress theme which will make your articles shine. Modern typography will make your visitors very easy to read while its responsive design will ensure it looks good an all devices. It&#8217;s highly flexible so you can use powerful yet simple options in the customizer to style it depending on your taste.

Theme URL -
Author URL - http://mekshq.com

SVN - https://themes.svn.wordpress.org/shamrock/1.0.5
ZIP - https://wordpress.org/themes/download/shamrock.1.0.5.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shamrock/1.0.4&new_path=shamrock/1.0.5

History:

Ticket Summary Status Resolution Owner
#26492 THEME: Shamrock – 1.0.6 closed live swetashrestha

(this ticket)

#29044 THEME: Shamrock – 1.0.7 closed live Otto42


https://themes.svn.wordpress.org/shamrock/1.0.5/screenshot.png

#15 in reply to: ↑ 11 @mekshq
2 years ago

Replying to swetashrestha:
Hi,

Really sorry for multiple uploads, please review version 1.0.5, I think we have added 'shamrock' instead of THEME_SLUG to all the strings. If I may ask, is that a new requirement?

Best regards

Previous issue NOT-FIXED:

  • The way you are making your text string translatable is not correct. For example:
    <p><?php _e('The page that you are looking for doesn&rsquo;t exist on this website. You may have accidentally mistype the page address, or followed an expired link. Anyway, we will help you get back on track. Why don&rsquo;t you try searching for an article?', THEME_SLUG); ?></p>
    

Replace THEME_SLUG with theme's actual text-domain, that is, shamrock. Make sure that you change this in all the places.

#16 follow-up: @swetashrestha
2 years ago

Just few issues left:

  • Provide unminified version of select2.full.min.js
  • Add attribution to serialize.js in readme.txt
  • When registering and enqueueing scripts in functions.php, you don't need to call wp_register_style() and wp_enqueue_style(). Just call wp_enqueue_style().
    wp_register_style( 'smr-bootstrap', CSS_URI . 'bootstrap/bootstrap.min.css', false, THEME_VERSION, 'screen, print' );
    wp_enqueue_style( 'smr-bootstrap' );
    
    simply be:
    wp_enqueue_style ( 'smr-bootstrap', CSS_URI . 'bootstrap/bootstrap.min.css', false, THEME_VERSION, 'screen, print');
    
  • Check function shamrock_load_admin_scripts() also

RECOMMENDED:

  • Provide direct links for images used in screenshot

#17 @themetracbot
2 years ago

  • Summary changed from THEME: Shamrock – 1.0.5 to THEME: Shamrock – 1.0.6

Shamrock - 1.0.6

Shamrock is a clean and beautifully designed WordPress theme which will make your articles shine. Modern typography will make your visitors very easy to read while its responsive design will ensure it looks good an all devices. It&#8217;s highly flexible so you can use powerful yet simple options in the customizer to style it depending on your taste.

Theme URL -
Author URL - http://mekshq.com

SVN - https://themes.svn.wordpress.org/shamrock/1.0.6
ZIP - https://wordpress.org/themes/download/shamrock.1.0.6.zip?nostats=1

Diff with previous version: https://themes.trac.wordpress.org/changeset?old_path=shamrock/1.0.5&new_path=shamrock/1.0.6

History:

Ticket Summary Status Resolution Owner
#26492 THEME: Shamrock – 1.0.6 closed live swetashrestha

(this ticket)

#29044 THEME: Shamrock – 1.0.7 closed live Otto42


https://themes.svn.wordpress.org/shamrock/1.0.6/screenshot.png

#18 in reply to: ↑ 16 @mekshq
2 years ago

Replying to swetashrestha:

Hi,

Thanks for your feedback. We have provided what you have asked in the latest review. The version is 1.0.6.

Cheers

Just few issues left:

  • Provide unminified version of select2.full.min.js
  • Add attribution to serialize.js in readme.txt
  • When registering and enqueueing scripts in functions.php, you don't need to call wp_register_style() and wp_enqueue_style(). Just call wp_enqueue_style().
    wp_register_style( 'smr-bootstrap', CSS_URI . 'bootstrap/bootstrap.min.css', false, THEME_VERSION, 'screen, print' );
    wp_enqueue_style( 'smr-bootstrap' );
    
    simply be:
    wp_enqueue_style ( 'smr-bootstrap', CSS_URI . 'bootstrap/bootstrap.min.css', false, THEME_VERSION, 'screen, print');
    
  • Check function shamrock_load_admin_scripts() also

RECOMMENDED:

  • Provide direct links for images used in screenshot

#19 follow-up: @swetashrestha
2 years ago

  • Status changed from reviewing to approved

Previous issues Fixed, Marking Theme as Approved.

#20 @swetashrestha
2 years ago

Last edited 2 years ago by swetashrestha (previous) (diff)

#21 in reply to: ↑ 19 ; follow-up: @mekshq
2 years ago

Replying to swetashrestha:

Good news! Thanks!

Can you please let us know what are the further steps?

Previous issues Fixed, Marking Theme as Approved.

#22 in reply to: ↑ 21 @swetashrestha
2 years ago

Replying to mekshq:

Replying to swetashrestha:

Good news! Thanks!

Can you please let us know what are the further steps?

Previous issues Fixed, Marking Theme as Approved.

Hi mekshq,
There are no further steps, you just have to wait until admin makes your theme live. Admin will do the final check and if they do not found any issues your theme will be live .You theme is in the queue

#23 follow-up: @karmatosed
2 years ago

  • Resolution set to live
  • Status changed from approved to closed

Congratulations, this theme is now live!

#24 in reply to: ↑ 23 @mekshq
2 years ago

Replying to karmatosed:

Congratulations, this theme is now live!

Hi,

Thanks that's great news!

Since this is our first theme, can you please guide me through the process of further theme updates. Where we should submit it?

Cheers

#25 @goasiacode
22 months ago

hello miss

i am upload my first themes in wordpress theme directory 3 weeks ago but not reply from wordpress theme team

you ask me how many time to approve

#26 @rabmalin
21 months ago

@mekshq @goasiacode You should re-upload your theme from here. https://wordpress.org/themes/getting-started/

#27 @rechargehippo
21 months ago

Hello sir,

I am reupload theme via https://wordpress.org/themes/getting-started/ but not any reply from wordpress team

See My Theme : http://themes.rechargehippo.com/shygo/

My Tracks

https://themes.trac.wordpress.org/ticket/29814
https://themes.trac.wordpress.org/ticket/29226

Please help again

Thanks

Wakil
West Bengal

Please Send your Mail Id i need a some help

Note: See TracTickets for help on using tickets.