WordPress.org

Make WordPress Themes

Opened 2 years ago

Closed 2 years ago

#26513 closed theme (not-approved)

THEME: Material Pak WP – 1.0

Reported by: tahirtaous Owned by: kevinhaig
Priority: new theme Keywords: theme-material-pak-wp
Cc: tahirtaous@…

Description

Material Pak WP - 1.0

The Material WordPress theme for WordPress takes us back to the blog, featuring a full range of post formats, each displayed beautifully in their own unique way. Design details abound, starting with a vibrant color scheme and matching header images, beautiful typography and icons, and a flexible layout that looks great on any device, big or small.

Theme URL - http://www.tahirtaous.com/download-free-material-design-wordpress-theme/
Author URL - http://tahirtaous.com/newsletter

SVN - https://themes.svn.wordpress.org/material-pak-wp/1.0
ZIP - https://wordpress.org/themes/download/material-pak-wp.1.0.zip?nostats=1

History:

Ticket Summary Status Resolution Owner
#26513 THEME: Material Pak WP – 1.0 closed not-approved kevinhaig

(this ticket)


https://themes.svn.wordpress.org/material-pak-wp/1.0/screenshot.png

Change History (9)

#1 @themetracbot
2 years ago

  • Owner set to massimodefi
  • Status changed from new to reviewing

#2 @karmatosed
2 years ago

I am sorry this review is taking so long. Sometimes people are unable to carry on the review, this may have happened this time. As a result, I am going to add this to the urgent review queue. This may mean it still takes time, but should be of more priority. Thanks for your patience.

#3 @Otto42
2 years ago

  • Owner massimodefi deleted

#4 @jcastaneda
2 years ago

  • Owner set to kevinhaig

#5 @kevinhaig
2 years ago

Material Pak WP 1.0
Theme Review
==================
Hi @tahirtaous, I am @kevinhaig and I picked up the review of your theme.

The review process follows requirements in this reference : https://make.wordpress.org/themes/handbook/review/required/. If you do not understand a requirement or anything else in the review, or if you do not agree with anything, please comment in the ticket. I can then help you, or if I am not sure of something I will certainly seek a second opinion from an admin.

Outcome
Theme left as reviewing for 7 days, and it may be closed after that if there is no response. Note that if you need more time, please make a comment in the ticket.

Required
Required items must be resolved before the theme is approved.

Code

  • No PHP or JS errors.
    • PHP Notice: Constant WP_POST_REVISIONS already defined in C:\xampp\htdocs\wptestb\wp-content\themes\material-pak-wp\functions.php on line 208
    • NOTICE: C:\xampp\htdocs\wptestb\wp-content\themes\material-pak-wp\index.php:51 - Use of undefined constant sidebar - assumed 'sidebar'require('C:\xampp\htdocs\wptestb\wp-blog-header.php'), require_once('C:\xampp\htdocs\wptestb\wp-includes\template-loader.php'), include('C:\xampp\htdocs\wptestb\wp-content\themes\material-pak-wp\index.php')
    • Notice: Undefined variable: link in C:\xampp\htdocs\wptestb\wp-content\themes\material-pak-wp\page-fullwidth.php on line 22
  • @charset utf8 is not needed in style.css, why do you have it?
  • What is headerOld.php for? If not being used, it should be deleted.
  • Provide a unique prefix for everything the Theme defines in the public namespace, including options, functions, global variables, constants, post meta, etc.
    • Use only one prefix, normally we would recommend the text domain, but you could use an abbreviated version. The important thing is for it to be unique. Also make sure your hook handles use it as well.
  • No removing or modifying non-presentational hooks.
    • remove_action('wp_head', 'wp_generator');
  • remove commented out code in functions.php


Core Functionality and Features

  • Please remove the upsell panel in the admin area, it is not allowed.
  • Please remove the custom footer from the admin area, it is not allowed.
  • why are you filtering out comment-author from the comment classes?
  • Why are you trying to post a feature image in functions.php Please remove the_post_thumbnail().
  • clean up the comments and add_theme_support() area in functions.php.
    • You have add_theme_support('title-tags') twice.

Plugins

  • Don’t do things in a theme considered plugin territory.
    • add_filter('login_errors',create_function('$a', "return null;")); is not allowed, it is considered plugin territory
    • add_filter( 'login_errors', 'wpfme_login_obscure' ); is not allowed, it is considered plugin territory

Language

  • You are using more than one text domain in the theme, twentyfifteen,materialwordpress. Neither of these is correct. The correct text domain for your theme is the WordPress approved themeslug which is material-pak-wp. Please change to this text domain, including the one listed in style.css.
  • There are text strings in footer.php that need to be translated, Developed by for example.
  • Line 41 and 43 in page.php is not translated properly, check page-fullwidth.php as well.
  • text domain in comments.php is wrong
  • When you translate a text string you need to include the text domain
    • line 44 in index.php <?php _e("Sorry, but you are looking for something that isn't here."); ?> should be `<?php _e('Sorry, but you are looking for something that isn't here.','material-pak-wp'); ?>
  • Please go through your theme and correct the translations, and add translations you missed.

Licensing

  • Declare copyright and license explicitly. Use the license and license uri header slugs to style.css.
    • You have not done this correctly. Add the following to either readme.txt or style.css.
      theme name WordPress Theme, Copyright (C) 2015, theme author
      theme name is distributed under the terms of the GNU GPL
      
  • All code and design should be your own or legally yours.
    • I am seeing twenty-fifteen everywhere, readme.txt, as a second text domain. and in other comments. If you have used any code from twentyfifteen then appropriate credits are required, see Derivative Themes and Incorporated Code Copyright Attribution in the reference below.
    • for example comments.php is from twentyfifteen. Remove all reference to twentyfifteen but acknowledge that you have used code from that theme. Change the text domain as well.
  • ref: https://make.wordpress.org/themes/2014/07/08/proper-copyrightlicense-attribution-for-themes/

Screenshot

  • The screenshot should be no bigger than 1200 x 900px, and be a 1.33 aspect ratio.

Selling, credits and links

  • If the theme adds a footer credit link, there should only be one (link to WordPress does not count)
    • Only one credit link is allowed in footer.php, you have 2.

Stylesheets and Scripts

  • No hard coding of scripts, styles and Favicons unless a browser workaround script. Everything should be enqueued.
    • You are not allowed to hard code a google font in header.php. Please enqueue the font in a setup file in functions.php.
  • where is material.css or material.min.css being loaded?
  • wp_register_script( 'material-design-script', '/wp-content/themes/MDLWP/js/material.js', '1.0', true ); should be wp_register_script( 'material-design-script', '/wp-content/themes/material-pak-wp/js/material.js', '1.0', true ); because material-pak-wp is your theme slug.
  • use wp_enqueue_scripts instead of wp_print_styles as the hook to load styles and scripts
  • No minification of scripts or files unless provide original files.
    • style.css can be minified but you must also supply an unminified version

Templates

  • page-fullwidth-noMenu.php is not set up correctly, and if you test it it does not work. Set up a separate header for this page that excludes your menu.
  • Do not use page- as a prefix for page templates, as WordPress will interpret the file as a specialized template, meant to apply to only one page on your site.

Recommended

  • Recommended items are not required for theme approval, however if you decide to add them they are Required to function properly.
  • I will go the theme in more detail for the next submission. I have done a quick check with the Theme Unit Test data and have noticed some problems.
    • why is there two scroll bars in the theme. There must be a css problem.
    • Markup: HTML Tags and Formatting, css breaks

Notes to Author

Theme is open for 7 days, if you need additional time to address the review make sure you make a comment to that effect in the ticket, or the theme may be closed.

Reminders

  • Make sure you thoroughly test your changes functionally and visually.
  • Download Debug Bar by wordpressdotorg, and get it running properly, it will help you debug your theme.
  • Use the Theme Unit Test data as the basis for your testing.
  • Always test your theme in a brand new test bed to see that it loads into the admin section and displays for the first time without errors.

#6 @kevinhaig
2 years ago

I missed something regarding licensing:

MDL Apache 2 license is not compatible with GPL V2 or later.
Please license your theme as GPLV3.

#7 follow-up: @kevinhaig
2 years ago

@tahirtaous
Are you planning to update this theme or should I close it.

#8 in reply to: ↑ 7 @tahirtaous
2 years ago

Replying to kevinhaig:

@tahirtaous
Are you planning to update this theme or should I close it.

Yes I am planning to update this theme but I need some more time.

Last edited 2 years ago by tahirtaous (previous) (diff)

#9 @kevinhaig
2 years ago

  • Resolution set to not-approved
  • Status changed from reviewing to closed

Theme closed, no author response.

@tahirtaous You will still be able to upload your theme when you are ready, but for now I am closing this one. Its been 3 weeks without a response from the initial review.

Note: See TracTickets for help on using tickets.